Re: [Xen-devel] [PATCH] xen/arm: Allow cleaning the directory even when CONFIG_EARLY_PRINTK is set

[Julien Grall <julien.grall@arm.com>]

Hi Jan,

Thank you for the feedback.

On 5/23/19 9:27 AM, Jan Beulich wrote:
>>>> On 24.04.19 at 12:47, <julien.grall@arm.com> wrote:
>> On 24/04/2019 01:20, Stefano Stabellini wrote:
>>> On Mon, 22 Apr 2019, Julien Grall wrote:
>>>> This code is pretty nasty, but I haven't found a better way for avoiding
>>>> to check if CONFIG_DEBUG is enabled when the target clean is called.
>>>>
>>>> Ideally we will want to move CONFIG_EARLY_PRINTK in Kconfig. I haven't
>>>> had time yet to look at it properly so far.
> 
> This, to me, would seem to be the much better approach, as it would
> avoid replacing one nasty construct by another. Are there any
> complications?

Last time I looked at moving earlyprintk to Kconfig I was struggling to 
find a good way describing them.

I guess I can have another look if I can manage to do it in a couple of 
hours.

This patch is more a way to paper the problem before causing more 
trouble when building using Yocto.

Cheers,

>>> Can we include .config in the clean target?
>> I did only mention the clean target in the commit message but the issue is the
>> same for any target not include .config. For instance, a distclean results to
>> the same error.
>>
>> It also feels quite wrong to expect the .config to be in place for any target
>> other than build.
> 
> I agree.
> 
> Jan
> 
> 

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel