xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Julien Grall <julien.grall@arm.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen/arm: Allow cleaning the directory even when CONFIG_EARLY_PRINTK is set
Date: Thu, 23 May 2019 02:27:41 -0600	[thread overview]
Message-ID: <5CE6597D0200007800231998@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <d664ac40-a4aa-9967-8534-ea722f8e0724@arm.com>

>>> On 24.04.19 at 12:47, <julien.grall@arm.com> wrote:
> On 24/04/2019 01:20, Stefano Stabellini wrote:
>> On Mon, 22 Apr 2019, Julien Grall wrote:
>>> This code is pretty nasty, but I haven't found a better way for avoiding
>>> to check if CONFIG_DEBUG is enabled when the target clean is called.
>>>
>>> Ideally we will want to move CONFIG_EARLY_PRINTK in Kconfig. I haven't
>>> had time yet to look at it properly so far.

This, to me, would seem to be the much better approach, as it would
avoid replacing one nasty construct by another. Are there any
complications?

>> Can we include .config in the clean target?
> I did only mention the clean target in the commit message but the issue is the 
> same for any target not include .config. For instance, a distclean results to 
> the same error.
> 
> It also feels quite wrong to expect the .config to be in place for any target 
> other than build.

I agree.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Jan Beulich" <JBeulich@suse.com>
To: "Julien Grall" <julien.grall@arm.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH] xen/arm: Allow cleaning the directory even when CONFIG_EARLY_PRINTK is set
Date: Thu, 23 May 2019 02:27:41 -0600	[thread overview]
Message-ID: <5CE6597D0200007800231998@prv1-mh.provo.novell.com> (raw)
Message-ID: <20190523082741.ztNe_ekDhTK9Y-nou12CsaI6-F6D3kIIgaMTbRG3pQQ@z> (raw)
In-Reply-To: <d664ac40-a4aa-9967-8534-ea722f8e0724@arm.com>

>>> On 24.04.19 at 12:47, <julien.grall@arm.com> wrote:
> On 24/04/2019 01:20, Stefano Stabellini wrote:
>> On Mon, 22 Apr 2019, Julien Grall wrote:
>>> This code is pretty nasty, but I haven't found a better way for avoiding
>>> to check if CONFIG_DEBUG is enabled when the target clean is called.
>>>
>>> Ideally we will want to move CONFIG_EARLY_PRINTK in Kconfig. I haven't
>>> had time yet to look at it properly so far.

This, to me, would seem to be the much better approach, as it would
avoid replacing one nasty construct by another. Are there any
complications?

>> Can we include .config in the clean target?
> I did only mention the clean target in the commit message but the issue is the 
> same for any target not include .config. For instance, a distclean results to 
> the same error.
> 
> It also feels quite wrong to expect the .config to be in place for any target 
> other than build.

I agree.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2019-05-23  8:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-22 16:41 [PATCH] xen/arm: Allow cleaning the directory even when CONFIG_EARLY_PRINTK is set Julien Grall
2019-04-22 16:41 ` [Xen-devel] " Julien Grall
2019-04-24  0:20 ` Stefano Stabellini
2019-04-24  0:20   ` [Xen-devel] " Stefano Stabellini
2019-04-24 10:47   ` Julien Grall
2019-04-24 10:47     ` [Xen-devel] " Julien Grall
2019-05-23  8:27     ` Jan Beulich [this message]
2019-05-23  8:27       ` Jan Beulich
2019-05-23  9:10       ` Julien Grall
2019-05-23  9:10         ` [Xen-devel] " Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5CE6597D0200007800231998@prv1-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=julien.grall@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).