Re: [PATCH] xen/arm: Allow cleaning the directory even when CONFIG_EARLY_PRINTK is set

[Julien Grall <julien.grall@arm.com>]

Hi,

On 24/04/2019 01:20, Stefano Stabellini wrote:
> On Mon, 22 Apr 2019, Julien Grall wrote:
>> CONFIG_EARLY_PRINTK can only be set when CONFIG_DEBUG is enabled. It can
>> be quite convenient to only modify the target.
>>
>> However, the target clean will not include the .config.
>>
>> This means CONFIG_DEBUG is not enabled and therefore make will throw
>> an error preventing clean to continue.
>>
>> The check is not moved at linking time.
>                 ^ now ?
> 
> 
>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>>
>> ---
>>
>> This code is pretty nasty, but I haven't found a better way for avoiding
>> to check if CONFIG_DEBUG is enabled when the target clean is called.
>>
>> Ideally we will want to move CONFIG_EARLY_PRINTK in Kconfig. I haven't
>> had time yet to look at it properly so far.
> 
> Can we include .config in the clean target?
I did only mention the clean target in the commit message but the issue is the 
same for any target not include .config. For instance, a distclean results to 
the same error.

It also feels quite wrong to expect the .config to be in place for any target 
other than build.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel