From: Julien Grall <julien.grall@arm.com>
To: "Xu, Quan" <quan.xu@intel.com>, xen-devel@lists.xen.org
Cc: Kevin Tian <kevin.tian@intel.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Feng Wu <feng.wu@intel.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
dario.faggioli@citrix.com, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v7 04/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU mapping (top level ones)
Date: Thu, 9 Jun 2016 11:30:37 +0100 [thread overview]
Message-ID: <5759454D.6010807@arm.com> (raw)
In-Reply-To: <1465376344-28290-5-git-send-email-quan.xu@intel.com>
Hello,
On 08/06/16 09:58, Xu, Quan wrote:
> From: Quan Xu <quan.xu@intel.com>
>
> Signed-off-by: Quan Xu <quan.xu@intel.com>
> Acked-by: Kevin Tian <kevin.tian@intel.com>
>
> CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien.grall@arm.com>
> CC: Kevin Tian <kevin.tian@intel.com>
> CC: Feng Wu <feng.wu@intel.com>
> CC: Jan Beulich <jbeulich@suse.com>
>
> v7: drop the amd_iommu_hwdom_init() fix, which has been added in
> patch 2 in this v7.
> ---
> xen/drivers/passthrough/arm/smmu.c | 4 ++--
> xen/drivers/passthrough/vtd/iommu.c | 7 ++++---
> xen/include/asm-x86/hvm/svm/amd-iommu-proto.h | 4 ++--
> xen/include/xen/iommu.h | 4 ++--
> 4 files changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c
> index 1ce4ddf..ee5c89d 100644
> --- a/xen/drivers/passthrough/arm/smmu.c
> +++ b/xen/drivers/passthrough/arm/smmu.c
> @@ -2745,8 +2745,8 @@ static void arm_smmu_iommu_domain_teardown(struct domain *d)
> xfree(xen_domain);
> }
>
> -static int arm_smmu_map_page(struct domain *d, unsigned long gfn,
> - unsigned long mfn, unsigned int flags)
> +static int __must_check arm_smmu_map_page(struct domain *d, unsigned long gfn,
> + unsigned long mfn, unsigned int flags)
This file is using the Linux coding style. So you should use hard tab here.
> {
> p2m_type_t t;
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-09 10:30 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 8:58 [PATCH v7 00/11] Check VT-d Device-TLB flush error Xu, Quan
2016-06-08 8:58 ` [PATCH v7 01/11] IOMMU: handle IOMMU mapping and unmapping failures Xu, Quan
2016-06-08 8:58 ` [PATCH v7 02/11] IOMMU/MMU: enhance the call trees of IOMMU unmapping and mapping Xu, Quan
2016-06-08 14:40 ` Jan Beulich
[not found] ` <57584D8602000078000F32D0@prv-mh.provo.novell.com>
[not found] ` <421857ad-4f6b-e99c-1e81-034b19effdfb@amd.com>
2016-06-10 6:56 ` Jan Beulich
2016-06-12 6:41 ` Tian, Kevin
2016-06-08 8:58 ` [PATCH v7 03/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU unmapping (top level ones) Xu, Quan
2016-06-08 14:42 ` Jan Beulich
2016-06-08 14:54 ` Jan Beulich
2016-06-09 19:30 ` Suravee Suthikulanit
2016-06-09 10:28 ` Julien Grall
2016-06-08 8:58 ` [PATCH v7 04/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU mapping " Xu, Quan
2016-06-08 14:43 ` Jan Beulich
2016-06-09 18:45 ` Suravee Suthikulanit
2016-06-09 10:30 ` Julien Grall [this message]
2016-06-08 8:58 ` [PATCH v7 05/11] IOMMU/MMU: propagate IOMMU Device-TLB flush error up to iommu_iotlb_flush{, _all} " Xu, Quan
2016-06-09 11:12 ` Julien Grall
2016-06-09 11:45 ` Jan Beulich
2016-06-09 12:03 ` Julien Grall
2016-06-09 12:08 ` Julien Grall
2016-06-09 12:15 ` Jan Beulich
2016-06-09 12:24 ` Julien Grall
2016-06-09 12:32 ` Jan Beulich
2016-06-09 12:39 ` Julien Grall
2016-06-12 6:55 ` Tian, Kevin
2016-06-12 7:02 ` Xu, Quan
2016-06-12 15:35 ` Julien Grall
2016-06-09 12:14 ` Jan Beulich
2016-06-12 6:46 ` Tian, Kevin
2016-06-08 8:58 ` [PATCH v7 06/11] propagate IOMMU Device-TLB flush error up to EPT update " Xu, Quan
2016-06-08 8:59 ` [PATCH v7 07/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU suspending " Xu, Quan
2016-06-08 14:51 ` Jan Beulich
2016-06-12 7:42 ` Xu, Quan
2016-06-13 9:25 ` Jan Beulich
2016-06-09 18:58 ` Suravee Suthikulanit
2016-06-12 6:58 ` Tian, Kevin
2016-06-08 8:59 ` [PATCH v7 08/11] IOMMU: propagate IOMMU Device-TLB flush error (leaf ones) Xu, Quan
2016-06-08 8:59 ` [PATCH v7 09/11] vt-d: fix the IOMMU flush issue Xu, Quan
2016-06-12 7:32 ` Tian, Kevin
2016-06-12 9:27 ` Xu, Quan
2016-06-13 8:50 ` Xu, Quan
2016-06-08 8:59 ` [PATCH v7 10/11] vt-d: propagate the IOMMU Device-TLB flush error up to ME phantom functions Xu, Quan
2016-06-12 7:34 ` Tian, Kevin
2016-06-08 8:59 ` [PATCH v7 11/11] vt-d: add __must_check annotation to IOMMU flush pointers and handlers Xu, Quan
2016-06-12 7:35 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5759454D.6010807@arm.com \
--to=julien.grall@arm.com \
--cc=dario.faggioli@citrix.com \
--cc=feng.wu@intel.com \
--cc=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=quan.xu@intel.com \
--cc=sstabellini@kernel.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).