From: Juergen Gross <jgross@suse.com>
To: Paul Durrant <Paul.Durrant@citrix.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: Anthony Perard <anthony.perard@citrix.com>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"kraxel@redhat.com" <kraxel@redhat.com>
Subject: Re: [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix
Date: Thu, 16 Jun 2016 14:18:44 +0200 [thread overview]
Message-ID: <57629924.105@suse.com> (raw)
In-Reply-To: <481f9b77db71494d81ea43dada59abf0@AMSPEX02CL03.citrite.net>
On 16/06/16 13:24, Paul Durrant wrote:
>> -----Original Message-----
>> From: Xen-devel [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of
>> Juergen Gross
>> Sent: 16 June 2016 11:02
>> To: qemu-devel@nongnu.org; xen-devel@lists.xensource.com
>> Cc: Anthony Perard; Juergen Gross; sstabellini@kernel.org;
>> kraxel@redhat.com
>> Subject: [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64
>> word size mix
>>
>> In case the word size of the domU and qemu running the qdisk backend
>> differ BLKIF_OP_DISCARD will not work reliably, as the request
>> structure in the ring have different layouts for different word size.
>>
>> Correct this by copying the request structure in case of different
>> word size element by element in the BLKIF_OP_DISCARD case, too.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Would it not be better to re-import the canonical blkif header as a whole rather than cherry-picking like this? You'd need to post-process to maintain style and possibly change some names for compatibility etc. but probably nothing beyond what indent and a simple [s]ed script can do.
> I did broadly the same thing to re-import the netif header into Linux recently.
It's a little bit more than indent/sed, but nothing really scary.
I'll do it.
Juergen
next prev parent reply other threads:[~2016-06-16 12:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 10:02 [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix Juergen Gross
2016-06-16 10:54 ` Jan Beulich
[not found] ` <5762A17B02000078000F59F3@suse.com>
2016-06-16 11:04 ` Juergen Gross
2016-06-16 11:17 ` Jan Beulich
2016-06-16 13:07 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.10.1606161407240.18449@sstabellini-ThinkPad-X260>
2016-06-16 13:49 ` Juergen Gross
[not found] ` <5762AE7B.4030402@suse.com>
2016-06-17 16:07 ` Stefano Stabellini
2016-06-16 11:24 ` [Xen-devel] " Paul Durrant
2016-06-16 12:18 ` Juergen Gross [this message]
2016-06-16 12:23 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57629924.105@suse.com \
--to=jgross@suse.com \
--cc=Paul.Durrant@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).