From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/2] hvmloader: don't hard-code IO-APIC parameters
Date: Fri, 17 Jun 2016 11:05:33 +0100 [thread overview]
Message-ID: <59f231ae-60a2-3e0f-cec2-b0b515ff50ce@citrix.com> (raw)
In-Reply-To: <5762903B02000078000F597E@prv-mh.provo.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 711 bytes --]
On 16/06/16 10:40, Jan Beulich wrote:
> The IO-APIC address has variable bits determined by the PCI-to-ISA
> bridge, and the IO-APIC version should be read from the IO-APIC. (Note
> that there's still implicit rather than explicit agreement on the
> IO-APIC base address between qemu and the hypervisor.)
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
The status quo is not great, and I can see why you want to improve it.
However, I think that this is not the way to do that. It ties HVMLoader
to the PIIX4 board in Qemu, and will break attempts to use Q35 or
something else. (In Q35, the IO-APIC decode address comes from Chipset
Configuration Register, rather than ISA device config space).
~Andrew
[-- Attachment #1.2: Type: text/html, Size: 1206 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-17 10:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 9:33 [PATCH 0/2] x86: hvmloader improvements Jan Beulich
2016-06-16 9:40 ` [PATCH 1/2] hvmloader: limit CPUs exposed to guests Jan Beulich
2016-06-16 15:09 ` Boris Ostrovsky
2016-06-16 15:25 ` Jan Beulich
2016-06-16 15:37 ` Boris Ostrovsky
2016-06-16 16:04 ` Jan Beulich
2016-06-16 16:38 ` Boris Ostrovsky
2016-06-17 9:40 ` Andrew Cooper
2016-06-16 9:40 ` [PATCH 2/2] hvmloader: don't hard-code IO-APIC parameters Jan Beulich
2016-06-16 16:49 ` Boris Ostrovsky
2016-06-17 6:00 ` Jan Beulich
2016-06-17 11:51 ` Boris Ostrovsky
2016-06-17 14:26 ` Jan Beulich
2016-06-17 10:05 ` Andrew Cooper [this message]
2016-06-17 10:23 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59f231ae-60a2-3e0f-cec2-b0b515ff50ce@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).