xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Paul Durrant <Paul.Durrant@citrix.com>
To: 'Jan Beulich' <JBeulich@suse.com>
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>,
	"Julien Grall (julien.grall@arm.com)" <julien.grall@arm.com>,
	'Boris Ostrovsky' <boris.ostrovsky@oracle.com>,
	"xen-devel (xen-devel@lists.xenproject.org)"
	<xen-devel@lists.xenproject.org>
Subject: Re: debian stretch dom0 + xen 4.9 fails to boot
Date: Wed, 7 Jun 2017 12:26:48 +0000	[thread overview]
Message-ID: <677c97e5726f4a56ae84cbe5a96fcbba@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <59380B710200007800160553@prv-mh.provo.novell.com>

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 07 June 2017 13:19
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: Julien Grall (julien.grall@arm.com) <julien.grall@arm.com>; Andrew
> Cooper <Andrew.Cooper3@citrix.com>; xen-devel (xen-
> devel@lists.xenproject.org) <xen-devel@lists.xenproject.org>; 'Boris
> Ostrovsky' <boris.ostrovsky@oracle.com>; Juergen Gross
> <jgross@suse.com>
> Subject: RE: [Xen-devel] debian stretch dom0 + xen 4.9 fails to boot
> 
> >>> On 07.06.17 at 14:02, <Paul.Durrant@citrix.com> wrote:
> >> From: Juergen Gross [mailto:jgross@suse.com]
> >> Sent: 07 June 2017 12:57
> >>
> >> On 07/06/17 13:06, Paul Durrant wrote:
> >> > It appears that it is just the code that needs to go at the end. The
> following
> >> patch is sufficient to avoid the problem. This may be preferable to a full
> >> reversion...
> >>
> >> I believe this is wrong. You risk the wakeup_stack extending into wakeup
> >> code and the main reason of the patch is gone, as now the permanent
> >> trampoline no longer is on a single page.
> >>
> >
> > I must be misunderstanding something then. The stack grows down from
> > wakeup_stack towards wakeup_stack_start doesn't it? So why would
> there be an
> > issue with the stack overwriting wakeup code?
> 
> I think this is a pointless discussion: Once we know memory is being
> corrupted, it doesn't help shuffling things around. By putting the
> wakeup code at the end, it'll be that which gets corrupted, and
> hence S3 wakeup would not work. We can really only try to figure
> out what parts of memory we need to avoid touching _at all_.
> 

Yes, fair enough. I'm currently trying to figure out what the code in head.S just ahead of trampoline_setup is trying to do.

  Paul

> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-06-07 12:26 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 14:32 debian stretch dom0 + xen 4.9 fails to boot Paul Durrant
2017-06-06 15:11 ` Jan Beulich
2017-06-06 15:51   ` Paul Durrant
2017-06-06 16:28     ` Paul Durrant
2017-06-06 17:00       ` Boris Ostrovsky
2017-06-07  8:07         ` Jan Beulich
2017-06-07  8:09           ` Paul Durrant
2017-06-07  8:19             ` Paul Durrant
2017-06-07 14:05           ` Boris Ostrovsky
2017-06-07  8:07         ` Paul Durrant
2017-06-07  8:27           ` Jan Beulich
     [not found]           ` <5937D4FF02000078001602F6@suse.com>
2017-06-07  9:03             ` Juergen Gross
2017-06-07  9:05               ` Paul Durrant
2017-06-07  9:09                 ` Andrew Cooper
2017-06-07 10:36                   ` Paul Durrant
2017-06-07 11:06                     ` Paul Durrant
2017-06-07 11:57                       ` Juergen Gross
2017-06-07 12:02                         ` Paul Durrant
2017-06-07 12:13                           ` Juergen Gross
2017-06-07 12:19                           ` Jan Beulich
2017-06-07 12:26                             ` Paul Durrant [this message]
2017-06-07 12:34                               ` Jan Beulich
2017-06-07 11:50                     ` Jan Beulich
2017-06-07 11:55                       ` Paul Durrant
2017-06-07 12:00                         ` Jan Beulich
2017-06-07 12:46                           ` Paul Durrant
2017-06-07 12:55                             ` Jan Beulich
2017-06-07 15:06                               ` Paul Durrant
2017-06-07 15:33                                 ` Jan Beulich
2017-06-07 15:40                                   ` Paul Durrant
2017-06-07 15:52                                     ` Jan Beulich
2017-06-08 12:42                                       ` Paul Durrant
2017-06-08 12:46                                         ` Juergen Gross
2017-06-08 13:18                                         ` Jan Beulich
2017-06-08 13:24                                           ` Paul Durrant
2017-06-09 12:19                                           ` Paul Durrant
2017-06-09 13:05                                             ` Jan Beulich
2017-06-09 13:52                                               ` Boris Ostrovsky
2017-06-09 15:14                                                 ` Paul Durrant
2017-06-09 15:41                                                   ` Jan Beulich
2017-06-09 15:47                                                     ` Paul Durrant
2017-06-09 15:58                                                       ` Jan Beulich
2017-06-12  8:14                                                       ` Paul Durrant
2017-06-12 10:40                                                         ` Jan Beulich
2017-06-12 10:44                                                           ` Paul Durrant
2017-06-12 10:53                                                             ` Paul Durrant
2017-06-12 11:12                                                               ` Jan Beulich
2017-06-12 12:05                                                                 ` Paul Durrant
2017-06-12 12:25                                                                   ` Paul Durrant
2017-06-12 13:54                                                                   ` Jan Beulich
2017-06-12 14:28                                                                     ` Paul Durrant
2017-06-12 14:43                                                                       ` Paul Durrant
2017-06-12 15:03                                                                         ` Paul Durrant
2017-06-12 15:07                                                                         ` Jan Beulich
2017-06-12 15:21                                                                           ` Paul Durrant
2017-06-06 17:40     ` Julien Grall
2017-06-07  8:05       ` Paul Durrant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=677c97e5726f4a56ae84cbe5a96fcbba@AMSPEX02CL03.citrite.net \
    --to=paul.durrant@citrix.com \
    --cc=Andrew.Cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=julien.grall@arm.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).