From: Juergen Gross <jgross@suse.com>
To: Paul Durrant <Paul.Durrant@citrix.com>,
'Jan Beulich' <JBeulich@suse.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
"Julien Grall (julien.grall@arm.com)" <julien.grall@arm.com>,
'BorisOstrovsky' <boris.ostrovsky@oracle.com>,
"xen-devel(xen-devel@lists.xenproject.org)"
<xen-devel@lists.xenproject.org>
Subject: Re: debian stretch dom0 + xen 4.9 fails to boot
Date: Thu, 8 Jun 2017 14:46:27 +0200 [thread overview]
Message-ID: <f6507096-6764-8f53-c09f-d11ea0ff8ab0@suse.com> (raw)
In-Reply-To: <94bf1caf8b95436fa7b3aed74a172ce1@AMSPEX02CL03.citrite.net>
On 08/06/17 14:42, Paul Durrant wrote:
> For those following this...
>
> By poking characters at the screen and bisecting where they stopped, I have narrowed the problem to the code in edd.S. I can successfully boot by setting opt_edd=off on the Xen cmd line and I can also boot with the following patch applied:
>
> diff --git a/xen/arch/x86/boot/edd.S b/xen/arch/x86/boot/edd.S
> index 73371f98b5..5409f1d9a1 100644
> --- a/xen/arch/x86/boot/edd.S
> +++ b/xen/arch/x86/boot/edd.S
> @@ -148,5 +148,6 @@ GLOBAL(boot_mbr_signature_nr)
> .byte 0
> GLOBAL(boot_mbr_signature)
> .fill EDD_MBR_SIG_MAX*8,1,0
> + .align 4096
> GLOBAL(boot_edd_info)
> - .fill 512,1,0 # big enough for a disc sector
> + .fill 4096,1,0 # big enough for a disc sector
>
> (based on a hunch that the BIOS defaults to a 4K sector for my NVMe drive)
>
> I need to investigate some more but I do wonder whether the EDD info should be read first to determine the appropriate size of memory buffer to use when issuing the read of the MBR. Hardcoding a 4k reservation seems like the wrong thing to do, even if it is sufficient for this BIOS
Thanks for rehabilitation of my patch. :-)
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-08 12:46 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 14:32 debian stretch dom0 + xen 4.9 fails to boot Paul Durrant
2017-06-06 15:11 ` Jan Beulich
2017-06-06 15:51 ` Paul Durrant
2017-06-06 16:28 ` Paul Durrant
2017-06-06 17:00 ` Boris Ostrovsky
2017-06-07 8:07 ` Jan Beulich
2017-06-07 8:09 ` Paul Durrant
2017-06-07 8:19 ` Paul Durrant
2017-06-07 14:05 ` Boris Ostrovsky
2017-06-07 8:07 ` Paul Durrant
2017-06-07 8:27 ` Jan Beulich
[not found] ` <5937D4FF02000078001602F6@suse.com>
2017-06-07 9:03 ` Juergen Gross
2017-06-07 9:05 ` Paul Durrant
2017-06-07 9:09 ` Andrew Cooper
2017-06-07 10:36 ` Paul Durrant
2017-06-07 11:06 ` Paul Durrant
2017-06-07 11:57 ` Juergen Gross
2017-06-07 12:02 ` Paul Durrant
2017-06-07 12:13 ` Juergen Gross
2017-06-07 12:19 ` Jan Beulich
2017-06-07 12:26 ` Paul Durrant
2017-06-07 12:34 ` Jan Beulich
2017-06-07 11:50 ` Jan Beulich
2017-06-07 11:55 ` Paul Durrant
2017-06-07 12:00 ` Jan Beulich
2017-06-07 12:46 ` Paul Durrant
2017-06-07 12:55 ` Jan Beulich
2017-06-07 15:06 ` Paul Durrant
2017-06-07 15:33 ` Jan Beulich
2017-06-07 15:40 ` Paul Durrant
2017-06-07 15:52 ` Jan Beulich
2017-06-08 12:42 ` Paul Durrant
2017-06-08 12:46 ` Juergen Gross [this message]
2017-06-08 13:18 ` Jan Beulich
2017-06-08 13:24 ` Paul Durrant
2017-06-09 12:19 ` Paul Durrant
2017-06-09 13:05 ` Jan Beulich
2017-06-09 13:52 ` Boris Ostrovsky
2017-06-09 15:14 ` Paul Durrant
2017-06-09 15:41 ` Jan Beulich
2017-06-09 15:47 ` Paul Durrant
2017-06-09 15:58 ` Jan Beulich
2017-06-12 8:14 ` Paul Durrant
2017-06-12 10:40 ` Jan Beulich
2017-06-12 10:44 ` Paul Durrant
2017-06-12 10:53 ` Paul Durrant
2017-06-12 11:12 ` Jan Beulich
2017-06-12 12:05 ` Paul Durrant
2017-06-12 12:25 ` Paul Durrant
2017-06-12 13:54 ` Jan Beulich
2017-06-12 14:28 ` Paul Durrant
2017-06-12 14:43 ` Paul Durrant
2017-06-12 15:03 ` Paul Durrant
2017-06-12 15:07 ` Jan Beulich
2017-06-12 15:21 ` Paul Durrant
2017-06-06 17:40 ` Julien Grall
2017-06-07 8:05 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6507096-6764-8f53-c09f-d11ea0ff8ab0@suse.com \
--to=jgross@suse.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=Paul.Durrant@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=julien.grall@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).