* Re: [Patch v11 3/3] vt-d: fix vt-d Device-TLB flush timeout issue (+ crash logic )
@ 2016-06-17 8:51 Xu, Quan
2016-06-17 13:34 ` Julien Grall
0 siblings, 1 reply; 4+ messages in thread
From: Xu, Quan @ 2016-06-17 8:51 UTC (permalink / raw)
To: xen-devel, Julien Grall, Suravee Suthikulpanit, jbeulich, Tian, Kevin
Cc: dario.faggioli, Wu, Feng
+ arm/amd maintainers..
On June 01, 2016 5:05 PM, Xu, Quan <quan.xu@intel.com> wrote:
> If Device-TLB flush timed out, we hide the target ATS device immediately and
> crash the domain owning this ATS device. If impacted domain is hardware
> domain, just throw out a warning.
>
> By hiding the device, we make sure it can't be assigned to any domain any
> longer (see device_assigned).
DomU (other than Dom0) gets crashed when a device IOTLB flush times out. I suppose that's what you will want on ARM/AMD then too.
We need to move up the crash logic , as similar as iommu_map_page() / iommu_unmap_page().
- add the crash logic to iommu_iotlb_flush() / iommu_iotlb_flush_all().
- when IOMMU/MMU share page tables, we need to fix it one by one.
-- on amd, we need to add the crash logic to amd_iommu_flush_pages().
-- on intel, we need to add the crash logic to iommu_pte_flush().
-- on arm, we benefit that we add the crash logic to iommu_iotlb_flush().
Taken together, we need to add crash logic to
iommu_iotlb_flush() / iommu_iotlb_flush_all() / iommu_pte_flush() / amd_iommu_flush_pages().
Thoughts?
Quan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch v11 3/3] vt-d: fix vt-d Device-TLB flush timeout issue (+ crash logic )
2016-06-17 8:51 [Patch v11 3/3] vt-d: fix vt-d Device-TLB flush timeout issue (+ crash logic ) Xu, Quan
@ 2016-06-17 13:34 ` Julien Grall
2016-06-18 9:54 ` Xu, Quan
0 siblings, 1 reply; 4+ messages in thread
From: Julien Grall @ 2016-06-17 13:34 UTC (permalink / raw)
To: Xu, Quan, xen-devel, Suravee Suthikulpanit, jbeulich, Tian, Kevin
Cc: dario.faggioli, Wu, Feng
Hi Quan,
On 17/06/16 09:51, Xu, Quan wrote:
> + arm/amd maintainers..
>
> On June 01, 2016 5:05 PM, Xu, Quan <quan.xu@intel.com> wrote:
>> If Device-TLB flush timed out, we hide the target ATS device immediately and
>> crash the domain owning this ATS device. If impacted domain is hardware
>> domain, just throw out a warning.
>>
>> By hiding the device, we make sure it can't be assigned to any domain any
>> longer (see device_assigned).
>
> DomU (other than Dom0) gets crashed when a device IOTLB flush times out. I suppose that's what you will want on ARM/AMD then too.
Correct it is what we want for ARM :).
> We need to move up the crash logic , as similar as iommu_map_page() / iommu_unmap_page().
>
> - add the crash logic to iommu_iotlb_flush() / iommu_iotlb_flush_all().
>
> - when IOMMU/MMU share page tables, we need to fix it one by one.
> -- on amd, we need to add the crash logic to amd_iommu_flush_pages().
> -- on intel, we need to add the crash logic to iommu_pte_flush().
> -- on arm, we benefit that we add the crash logic to iommu_iotlb_flush().
Right.
>
>
> Taken together, we need to add crash logic to
> iommu_iotlb_flush() / iommu_iotlb_flush_all() / iommu_pte_flush() / amd_iommu_flush_pages().
For iommu_iotlb_* yes as it is common code. I don't know for the others.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch v11 3/3] vt-d: fix vt-d Device-TLB flush timeout issue (+ crash logic )
2016-06-17 13:34 ` Julien Grall
@ 2016-06-18 9:54 ` Xu, Quan
2016-06-20 6:53 ` Xu, Quan
0 siblings, 1 reply; 4+ messages in thread
From: Xu, Quan @ 2016-06-18 9:54 UTC (permalink / raw)
To: Julien Grall, xen-devel
Cc: Tian, Kevin, dario.faggioli, Wu, Feng, jbeulich, Suravee Suthikulpanit
On June 17, 2016 9:35 PM, Julien Grall <julien.grall@arm.com> wrote:
> On 17/06/16 09:51, Xu, Quan wrote:
> > + arm/amd maintainers..
> >
> > On June 01, 2016 5:05 PM, Xu, Quan <quan.xu@intel.com> wrote:
> >> If Device-TLB flush timed out, we hide the target ATS device
> >> immediately and crash the domain owning this ATS device. If impacted
> >> domain is hardware domain, just throw out a warning.
> >>
> >> By hiding the device, we make sure it can't be assigned to any domain
> >> any longer (see device_assigned).
> >
> > DomU (other than Dom0) gets crashed when a device IOTLB flush times out.
> I suppose that's what you will want on ARM/AMD then too.
>
> Correct it is what we want for ARM :).
>
That's good :):)..
Julien, thanks.
> > We need to move up the crash logic , as similar as iommu_map_page() /
> iommu_unmap_page().
> >
> > - add the crash logic to iommu_iotlb_flush() / iommu_iotlb_flush_all().
> >
> > - when IOMMU/MMU share page tables, we need to fix it one by one.
> > -- on amd, we need to add the crash logic to
> amd_iommu_flush_pages().
> > -- on intel, we need to add the crash logic to iommu_pte_flush().
> > -- on arm, we benefit that we add the crash logic to
> iommu_iotlb_flush().
>
> Right.
>
:):)
> >
> >
> > Taken together, we need to add crash logic to
> > iommu_iotlb_flush() / iommu_iotlb_flush_all() /
> iommu_pte_flush() / amd_iommu_flush_pages().
>
> For iommu_iotlb_* yes as it is common code. I don't know for the others.
>
IMO, that's is enough. I hope the other maintainers can give some comments. Thanks!!
Quan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch v11 3/3] vt-d: fix vt-d Device-TLB flush timeout issue (+ crash logic )
2016-06-18 9:54 ` Xu, Quan
@ 2016-06-20 6:53 ` Xu, Quan
0 siblings, 0 replies; 4+ messages in thread
From: Xu, Quan @ 2016-06-20 6:53 UTC (permalink / raw)
To: xen-devel, jbeulich, Suravee Suthikulpanit
Cc: Tian, Kevin, Julien Grall, Wu, Feng, dario.faggioli
On June 18, 2016 5:54 PM, Xu, Quan <quan.xu@intel.com> wrote:
> On June 17, 2016 9:35 PM, Julien Grall <julien.grall@arm.com> wrote:
> > On 17/06/16 09:51, Xu, Quan wrote:
> > > + arm/amd maintainers..
> > >
> > > On June 01, 2016 5:05 PM, Xu, Quan <quan.xu@intel.com> wrote:
> > >> If Device-TLB flush timed out, we hide the target ATS device
> > >> immediately and crash the domain owning this ATS device. If
> > >> impacted domain is hardware domain, just throw out a warning.
> > >>
> > >> By hiding the device, we make sure it can't be assigned to any
> > >> domain any longer (see device_assigned).
> > >
> > > DomU (other than Dom0) gets crashed when a device IOTLB flush times
> out.
> > I suppose that's what you will want on ARM/AMD then too.
> >
> > Correct it is what we want for ARM :).
> >
>
>
> That's good :):)..
> Julien, thanks.
>
> > > We need to move up the crash logic , as similar as iommu_map_page()
> > > /
> > iommu_unmap_page().
> > >
> > > - add the crash logic to iommu_iotlb_flush() / iommu_iotlb_flush_all().
> > >
> > > - when IOMMU/MMU share page tables, we need to fix it one by one.
> > > -- on amd, we need to add the crash logic to
> > amd_iommu_flush_pages().
> > > -- on intel, we need to add the crash logic to iommu_pte_flush().
> > > -- on arm, we benefit that we add the crash logic to
> > iommu_iotlb_flush().
> >
> > Right.
> >
>
> :):)
>
> > >
> > >
> > > Taken together, we need to add crash logic to
> > > iommu_iotlb_flush() /
> > > iommu_iotlb_flush_all() /
> > iommu_pte_flush() / amd_iommu_flush_pages().
> >
Think twice, now I am inclined to leave amd_iommu_flush_pages() as is,
As the IOTLB flush error has not been yet bubbled up on AMD platform, it is pointless to add
domain crash logic there.
Quan
> > For iommu_iotlb_* yes as it is common code. I don't know for the others.
> >
> IMO, that's is enough. I hope the other maintainers can give some comments.
> Thanks!!
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-20 6:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-17 8:51 [Patch v11 3/3] vt-d: fix vt-d Device-TLB flush timeout issue (+ crash logic ) Xu, Quan
2016-06-17 13:34 ` Julien Grall
2016-06-18 9:54 ` Xu, Quan
2016-06-20 6:53 ` Xu, Quan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).