From: Hongyan Xia <hx242@xen.org>
To: Julien Grall <julien.grall.oss@gmail.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 02/16] acpi: vmap pages in acpi_os_alloc_memory
Date: Mon, 04 May 2020 09:27:39 +0100 [thread overview]
Message-ID: <c3edd42c66ded0c1f129e1de2a4b8f54cef4c136.camel@xen.org> (raw)
In-Reply-To: <CAJ=z9a0S0rOYbJVPGK6mTKN0OgJtiTU7YN-APLF4Dvr4CaKfJg@mail.gmail.com>
On Fri, 2020-05-01 at 22:35 +0100, Julien Grall wrote:
> Hi,
>
> On Thu, 30 Apr 2020 at 21:44, Hongyan Xia <hx242@xen.org> wrote:
> >
> > From: Hongyan Xia <hongyxia@amazon.com>
> >
> > Also, introduce a wrapper around vmap that maps a contiguous range
> > for
> > boot allocations.
> >
> > Signed-off-by: Hongyan Xia <hongyxia@amazon.com>
> > ---
> > xen/drivers/acpi/osl.c | 9 ++++++++-
> > xen/include/xen/vmap.h | 5 +++++
> > 2 files changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/xen/drivers/acpi/osl.c b/xen/drivers/acpi/osl.c
> > index 4c8bb7839e..d0762dad4e 100644
> > --- a/xen/drivers/acpi/osl.c
> > +++ b/xen/drivers/acpi/osl.c
> > @@ -219,7 +219,11 @@ void *__init acpi_os_alloc_memory(size_t sz)
> > void *ptr;
> >
> > if (system_state == SYS_STATE_early_boot)
> > - return
> > mfn_to_virt(mfn_x(alloc_boot_pages(PFN_UP(sz), 1)));
> > + {
> > + mfn_t mfn = alloc_boot_pages(PFN_UP(sz), 1);
> > +
> > + return vmap_boot_pages(mfn, PFN_UP(sz));
> > + }
> >
> > ptr = xmalloc_bytes(sz);
> > ASSERT(!ptr || is_xmalloc_memory(ptr));
> > @@ -244,5 +248,8 @@ void __init acpi_os_free_memory(void *ptr)
> > if (is_xmalloc_memory(ptr))
> > xfree(ptr);
> > else if (ptr && system_state == SYS_STATE_early_boot)
> > + {
> > + vunmap(ptr);
> > init_boot_pages(__pa(ptr), __pa(ptr) + PAGE_SIZE);
>
> __pa(ptr) can only work on the direct map. Even worth, on Arm it will
> fault because there is no mapping.
> I think you will want to use vmap_to_mfn() before calling vunmap().
Thanks for spotting this. This is definitely wrong. Will revise.
Hongyan
next prev parent reply other threads:[~2020-05-04 8:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 20:44 [PATCH 00/16] Remove the direct map Hongyan Xia
2020-04-30 20:44 ` [PATCH 01/16] x86/setup: move vm_init() before acpi calls Hongyan Xia
2020-04-30 20:44 ` [PATCH 02/16] acpi: vmap pages in acpi_os_alloc_memory Hongyan Xia
2020-05-01 12:02 ` Wei Liu
2020-05-01 12:46 ` Hongyan Xia
2020-05-01 21:35 ` Julien Grall
2020-05-04 8:27 ` Hongyan Xia [this message]
2020-04-30 20:44 ` [PATCH 03/16] x86/numa: vmap the pages for memnodemap Hongyan Xia
2020-04-30 20:44 ` [PATCH 04/16] x86/srat: vmap the pages for acpi_slit Hongyan Xia
2020-11-30 10:16 ` Jan Beulich
2020-11-30 18:11 ` Hongyan Xia
2020-12-01 7:37 ` Jan Beulich
2020-04-30 20:44 ` [PATCH 05/16] x86: map/unmap pages in restore_all_guests Hongyan Xia
2020-04-30 20:44 ` [PATCH 06/16] x86/pv: domheap pages should be mapped while relocating initrd Hongyan Xia
2020-04-30 20:44 ` [PATCH 07/16] x86/pv: rewrite how building PV dom0 handles domheap mappings Hongyan Xia
2020-04-30 20:44 ` [PATCH 08/16] x86: add Persistent Map (PMAP) infrastructure Hongyan Xia
2020-04-30 20:44 ` [PATCH 09/16] x86: lift mapcache variable to the arch level Hongyan Xia
2020-04-30 20:44 ` [PATCH 10/16] x86/mapcache: initialise the mapcache for the idle domain Hongyan Xia
2020-04-30 20:44 ` [PATCH 11/16] x86: add a boot option to enable and disable the direct map Hongyan Xia
2020-05-01 8:43 ` Julien Grall
2020-05-01 12:11 ` Wei Liu
2020-05-01 12:59 ` Hongyan Xia
2020-05-01 13:11 ` Wei Liu
2020-05-01 15:59 ` Julien Grall
2020-04-30 20:44 ` [PATCH 12/16] x86/domain_page: remove the fast paths when mfn is not in the directmap Hongyan Xia
2020-04-30 20:44 ` [PATCH 13/16] xen/page_alloc: add a path for xenheap when there is no direct map Hongyan Xia
2020-05-01 8:50 ` Julien Grall
2021-04-22 12:31 ` Jan Beulich
2021-04-28 11:04 ` Hongyan Xia
2021-04-28 11:51 ` Jan Beulich
2021-04-28 13:22 ` Hongyan Xia
2021-04-28 13:55 ` Jan Beulich
2020-04-30 20:44 ` [PATCH 14/16] x86/setup: leave early boot slightly earlier Hongyan Xia
2020-04-30 20:44 ` [PATCH 15/16] x86/setup: vmap heap nodes when they are outside the direct map Hongyan Xia
2020-04-30 20:44 ` [PATCH 16/16] x86/setup: do not create valid mappings when directmap=no Hongyan Xia
2020-05-01 12:07 ` [PATCH 00/16] Remove the direct map Wei Liu
2020-05-01 13:53 ` Hongyan Xia
2020-06-02 9:08 ` Wei Liu
2021-04-28 10:14 ` Hongyan Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3edd42c66ded0c1f129e1de2a4b8f54cef4c136.camel@xen.org \
--to=hx242@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall.oss@gmail.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).