[PATCH] meta-arm-toolchain: Convert to new override syntax

[PATCH] meta-arm-toolchain: Convert to new override syntax

[Khem Raj]

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-arm-toolchain/conf/layer.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-arm-toolchain/conf/layer.conf b/meta-arm-toolchain/conf/layer.conf
index 04486d4..41305ee 100644
--- a/meta-arm-toolchain/conf/layer.conf
+++ b/meta-arm-toolchain/conf/layer.conf
@@ -18,4 +18,4 @@ LAYERSERIES_COMPAT_arm-toolchain = "hardknott"
 BB_DANGLINGAPPENDS_WARNONLY = "true"
 
 # These variables are used for armcompiler license
-BB_HASHBASE_WHITELIST_append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
+BB_HASHBASE_WHITELIST:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
-- 
2.32.0

Re: [meta-arm] [PATCH] meta-arm-toolchain: Convert to new override syntax

[Sumit Garg]

Hi Khem,

On Mon, 2 Aug 2021 at 22:05, Khem Raj <raj.khem@gmail.com> wrote:
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta-arm-toolchain/conf/layer.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-arm-toolchain/conf/layer.conf b/meta-arm-toolchain/conf/layer.conf
> index 04486d4..41305ee 100644
> --- a/meta-arm-toolchain/conf/layer.conf
> +++ b/meta-arm-toolchain/conf/layer.conf
> @@ -18,4 +18,4 @@ LAYERSERIES_COMPAT_arm-toolchain = "hardknott"
>  BB_DANGLINGAPPENDS_WARNONLY = "true"
>
>  # These variables are used for armcompiler license
> -BB_HASHBASE_WHITELIST_append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
> +BB_HASHBASE_WHITELIST:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"

This only looks like change for one instance of override and there are
many other instances in meta-arm-toolchain. I think the new override
syntax brings more clarity. So I would suggest converting all other
instances of overrides to new syntax as well.

-Sumit

> --
> 2.32.0
>
>
> 
>

Re: [meta-arm] [PATCH] meta-arm-toolchain: Convert to new override syntax

[Khem Raj]

yeah ignore this. I have more changes after this

On Mon, Aug 2, 2021 at 10:25 PM Sumit Garg <sumit.garg@linaro.org> wrote:
>
> Hi Khem,
>
> On Mon, 2 Aug 2021 at 22:05, Khem Raj <raj.khem@gmail.com> wrote:
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta-arm-toolchain/conf/layer.conf | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta-arm-toolchain/conf/layer.conf b/meta-arm-toolchain/conf/layer.conf
> > index 04486d4..41305ee 100644
> > --- a/meta-arm-toolchain/conf/layer.conf
> > +++ b/meta-arm-toolchain/conf/layer.conf
> > @@ -18,4 +18,4 @@ LAYERSERIES_COMPAT_arm-toolchain = "hardknott"
> >  BB_DANGLINGAPPENDS_WARNONLY = "true"
> >
> >  # These variables are used for armcompiler license
> > -BB_HASHBASE_WHITELIST_append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
> > +BB_HASHBASE_WHITELIST:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
>
> This only looks like change for one instance of override and there are
> many other instances in meta-arm-toolchain. I think the new override
> syntax brings more clarity. So I would suggest converting all other
> instances of overrides to new syntax as well.
>
> -Sumit
>
> > --
> > 2.32.0
> >
> >
> > 
> >