From: Johannes Berg <johannes@sipsolutions.net>
To: Wen Gong <wgong@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 8/8] mac80211: save transmit power envelope element and power constraint
Date: Fri, 27 Aug 2021 08:55:06 +0200 [thread overview]
Message-ID: <0680b508a7864e02f55d763851f7460baa73b53f.camel@sipsolutions.net> (raw)
In-Reply-To: <db22a4cb9a07e3845a50f436c7052feb@codeaurora.org>
On Fri, 2021-08-27 at 14:53 +0800, Wen Gong wrote:
> >
> > Well, there's an existing place in this function that uses
> > cfg80211_find_ext_ie(), and various uses of ieee80211_bss_get_ie(), so
> > it feels like if we're going to do the full parsing, we should switch
> > all the existing "look up an element" to also use the parsed data
> > instead.
> ok.
> so it ha 2 way to change, right?
> 1.
> change ieee802_11_parse_elems() to ieee80211_bss_get_ie()
No why?
I think we should make a first patch (that doesn't add TPE yet) that
changes the function to ieee80211_parse_elems() and removes all the
ieee80211_bss_get_ie() / cfg80211_find_ext_ie() calls in favour of just
parsing once, and then looking at the elements there.
Then your TPE patch becomes trivial since the elems are already there?
>
> 2.
> still use ieee802_11_parse_elems(), and change others
> ieee80211_bss_get_ie()/cfg80211_find_ext_ie()
> to use the result of ieee802_11_parse_elems()
>
Right!
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Wen Gong <wgong@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 8/8] mac80211: save transmit power envelope element and power constraint
Date: Fri, 27 Aug 2021 08:55:06 +0200 [thread overview]
Message-ID: <0680b508a7864e02f55d763851f7460baa73b53f.camel@sipsolutions.net> (raw)
In-Reply-To: <db22a4cb9a07e3845a50f436c7052feb@codeaurora.org>
On Fri, 2021-08-27 at 14:53 +0800, Wen Gong wrote:
> >
> > Well, there's an existing place in this function that uses
> > cfg80211_find_ext_ie(), and various uses of ieee80211_bss_get_ie(), so
> > it feels like if we're going to do the full parsing, we should switch
> > all the existing "look up an element" to also use the parsed data
> > instead.
> ok.
> so it ha 2 way to change, right?
> 1.
> change ieee802_11_parse_elems() to ieee80211_bss_get_ie()
No why?
I think we should make a first patch (that doesn't add TPE yet) that
changes the function to ieee80211_parse_elems() and removes all the
ieee80211_bss_get_ie() / cfg80211_find_ext_ie() calls in favour of just
parsing once, and then looking at the elements there.
Then your TPE patch becomes trivial since the elems are already there?
>
> 2.
> still use ieee802_11_parse_elems(), and change others
> ieee80211_bss_get_ie()/cfg80211_find_ext_ie()
> to use the result of ieee802_11_parse_elems()
>
Right!
johannes
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2021-08-27 6:55 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 12:20 [PATCH v2 0/8] cfg80211/mac80211: Add support for 6GHZ STA for various modes : LPI, SP and VLP Wen Gong
2021-08-20 12:20 ` Wen Gong
2021-08-20 12:20 ` [PATCH v2 1/8] cfg80211: add power type definition for 6 GHz Wen Gong
2021-08-20 12:20 ` Wen Gong
2021-08-26 8:20 ` Johannes Berg
2021-08-26 8:20 ` Johannes Berg
2021-08-26 8:22 ` Johannes Berg
2021-08-26 8:22 ` Johannes Berg
2021-08-26 11:02 ` Wen Gong
2021-08-26 11:02 ` Wen Gong
2021-08-26 11:11 ` Johannes Berg
2021-08-26 11:11 ` Johannes Berg
2021-08-26 10:57 ` Wen Gong
2021-08-26 10:57 ` Wen Gong
2021-08-26 10:59 ` Johannes Berg
2021-08-26 10:59 ` Johannes Berg
2021-08-26 11:01 ` Wen Gong
2021-08-26 11:01 ` Wen Gong
2021-08-20 12:20 ` [PATCH v2 2/8] mac80211: add definition of regulatory info in 6 GHz operation information Wen Gong
2021-08-20 12:20 ` Wen Gong
2021-08-26 8:20 ` Johannes Berg
2021-08-26 8:20 ` Johannes Berg
2021-08-20 12:20 ` [PATCH v2 3/8] mac80211: add parse " Wen Gong
2021-08-20 12:20 ` Wen Gong
2021-08-26 8:21 ` Johannes Berg
2021-08-26 8:21 ` Johannes Berg
2021-08-20 12:20 ` [PATCH v2 4/8] cfg80211: add definition for 6 GHz power spectral density(psd) Wen Gong
2021-08-20 12:20 ` Wen Gong
2021-08-20 12:20 ` [PATCH v2 5/8] cfg80211: save power spectral density(psd) of regulatory rule Wen Gong
2021-08-20 12:20 ` Wen Gong
2021-08-26 8:25 ` Johannes Berg
2021-08-26 8:25 ` Johannes Berg
2021-08-26 10:43 ` Wen Gong
2021-08-26 10:43 ` Wen Gong
2021-08-26 10:56 ` Johannes Berg
2021-08-26 10:56 ` Johannes Berg
2021-08-26 10:58 ` Wen Gong
2021-08-26 10:58 ` Wen Gong
2021-08-20 12:20 ` [PATCH v2 6/8] mac80211: add definition for transmit power envelope element Wen Gong
2021-08-20 12:20 ` Wen Gong
2021-08-26 8:30 ` Johannes Berg
2021-08-26 8:30 ` Johannes Berg
2021-08-20 12:20 ` [PATCH v2 7/8] mac80211: add parse " Wen Gong
2021-08-20 12:20 ` Wen Gong
2021-08-26 8:20 ` Johannes Berg
2021-08-26 8:20 ` Johannes Berg
2021-08-20 12:20 ` [PATCH v2 8/8] mac80211: save transmit power envelope element and power constraint Wen Gong
2021-08-20 12:20 ` Wen Gong
2021-08-26 8:29 ` Johannes Berg
2021-08-26 8:29 ` Johannes Berg
2021-08-26 10:50 ` Wen Gong
2021-08-26 10:50 ` Wen Gong
2021-08-26 10:57 ` Johannes Berg
2021-08-26 10:57 ` Johannes Berg
2021-08-26 11:00 ` Wen Gong
2021-08-26 11:00 ` Wen Gong
2021-08-26 11:10 ` Johannes Berg
2021-08-26 11:10 ` Johannes Berg
2021-08-27 2:01 ` Wen Gong
2021-08-27 2:01 ` Wen Gong
2023-07-19 3:29 ` Wen Gong
2023-07-19 3:29 ` Wen Gong
2021-08-27 2:11 ` Wen Gong
2021-08-27 2:11 ` Wen Gong
2021-08-27 6:46 ` Johannes Berg
2021-08-27 6:46 ` Johannes Berg
2021-08-27 6:53 ` Wen Gong
2021-08-27 6:53 ` Wen Gong
2021-08-27 6:55 ` Johannes Berg [this message]
2021-08-27 6:55 ` Johannes Berg
2021-08-27 7:12 ` Wen Gong
2021-08-27 7:12 ` Wen Gong
2021-08-27 7:38 ` Johannes Berg
2021-08-27 7:38 ` Johannes Berg
2021-08-27 8:18 ` Wen Gong
2021-08-27 8:18 ` Wen Gong
2021-08-27 8:20 ` Johannes Berg
2021-08-27 8:20 ` Johannes Berg
2021-08-27 8:28 ` Wen Gong
2021-08-27 8:28 ` Wen Gong
2021-08-27 8:30 ` Johannes Berg
2021-08-27 8:30 ` Johannes Berg
2021-08-27 8:47 ` Wen Gong
2021-08-27 8:47 ` Wen Gong
2021-08-25 2:18 ` [PATCH v2 0/8] cfg80211/mac80211: Add support for 6GHZ STA for various modes : LPI, SP and VLP Wen Gong
2021-08-25 2:18 ` Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0680b508a7864e02f55d763851f7460baa73b53f.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.