From: Johannes Berg <johannes@sipsolutions.net>
To: Wen Gong <wgong@codeaurora.org>, ath11k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 3/8] mac80211: add parse regulatory info in 6 GHz operation information
Date: Thu, 26 Aug 2021 10:21:41 +0200 [thread overview]
Message-ID: <57012b81620f7c176c405262f2caf8d497393cae.camel@sipsolutions.net> (raw)
In-Reply-To: <20210820122041.12157-4-wgong@codeaurora.org>
On Fri, 2021-08-20 at 08:20 -0400, Wen Gong wrote:
> This patch is to convert the regulatory info subfield in HE operation
> element to power type and save in struct cfg80211_chan_def.
>
> Signed-off-by: Wen Gong <wgong@codeaurora.org>
> ---
> net/mac80211/util.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/net/mac80211/util.c b/net/mac80211/util.c
> index 93d96a4f9c3e..cb1c35d8ef48 100644
> --- a/net/mac80211/util.c
> +++ b/net/mac80211/util.c
> @@ -3395,6 +3395,16 @@ bool ieee80211_chandef_he_6ghz_oper(struct ieee80211_sub_if_data *sdata,
> NL80211_BAND_6GHZ);
> he_chandef.chan = ieee80211_get_channel(sdata->local->hw.wiphy, freq);
>
>
> + switch (u8_get_bits(he_6ghz_oper->control,
> + IEEE80211_HE_6GHZ_OPER_CTRL_REG_INFO)) {
> + case IEEE80211_6GHZ_CTRL_REG_LPI_AP:
> + he_chandef.power_type = NL80211_REG_LPI_AP;
> + break;
> + case IEEE80211_6GHZ_CTRL_REG_SP_AP:
> + he_chandef.power_type = NL80211_REG_SP_AP;
> + break;
> + }
Now here you put it in the chandef, but don't propagate it anywhere if
channels are merged, etc. I don't think this can work correctly in all
but the most trivial use cases.
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Wen Gong <wgong@codeaurora.org>, ath11k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 3/8] mac80211: add parse regulatory info in 6 GHz operation information
Date: Thu, 26 Aug 2021 10:21:41 +0200 [thread overview]
Message-ID: <57012b81620f7c176c405262f2caf8d497393cae.camel@sipsolutions.net> (raw)
In-Reply-To: <20210820122041.12157-4-wgong@codeaurora.org>
On Fri, 2021-08-20 at 08:20 -0400, Wen Gong wrote:
> This patch is to convert the regulatory info subfield in HE operation
> element to power type and save in struct cfg80211_chan_def.
>
> Signed-off-by: Wen Gong <wgong@codeaurora.org>
> ---
> net/mac80211/util.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/net/mac80211/util.c b/net/mac80211/util.c
> index 93d96a4f9c3e..cb1c35d8ef48 100644
> --- a/net/mac80211/util.c
> +++ b/net/mac80211/util.c
> @@ -3395,6 +3395,16 @@ bool ieee80211_chandef_he_6ghz_oper(struct ieee80211_sub_if_data *sdata,
> NL80211_BAND_6GHZ);
> he_chandef.chan = ieee80211_get_channel(sdata->local->hw.wiphy, freq);
>
>
> + switch (u8_get_bits(he_6ghz_oper->control,
> + IEEE80211_HE_6GHZ_OPER_CTRL_REG_INFO)) {
> + case IEEE80211_6GHZ_CTRL_REG_LPI_AP:
> + he_chandef.power_type = NL80211_REG_LPI_AP;
> + break;
> + case IEEE80211_6GHZ_CTRL_REG_SP_AP:
> + he_chandef.power_type = NL80211_REG_SP_AP;
> + break;
> + }
Now here you put it in the chandef, but don't propagate it anywhere if
channels are merged, etc. I don't think this can work correctly in all
but the most trivial use cases.
johannes
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2021-08-26 8:21 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 12:20 [PATCH v2 0/8] cfg80211/mac80211: Add support for 6GHZ STA for various modes : LPI, SP and VLP Wen Gong
2021-08-20 12:20 ` Wen Gong
2021-08-20 12:20 ` [PATCH v2 1/8] cfg80211: add power type definition for 6 GHz Wen Gong
2021-08-20 12:20 ` Wen Gong
2021-08-26 8:20 ` Johannes Berg
2021-08-26 8:20 ` Johannes Berg
2021-08-26 8:22 ` Johannes Berg
2021-08-26 8:22 ` Johannes Berg
2021-08-26 11:02 ` Wen Gong
2021-08-26 11:02 ` Wen Gong
2021-08-26 11:11 ` Johannes Berg
2021-08-26 11:11 ` Johannes Berg
2021-08-26 10:57 ` Wen Gong
2021-08-26 10:57 ` Wen Gong
2021-08-26 10:59 ` Johannes Berg
2021-08-26 10:59 ` Johannes Berg
2021-08-26 11:01 ` Wen Gong
2021-08-26 11:01 ` Wen Gong
2021-08-20 12:20 ` [PATCH v2 2/8] mac80211: add definition of regulatory info in 6 GHz operation information Wen Gong
2021-08-20 12:20 ` Wen Gong
2021-08-26 8:20 ` Johannes Berg
2021-08-26 8:20 ` Johannes Berg
2021-08-20 12:20 ` [PATCH v2 3/8] mac80211: add parse " Wen Gong
2021-08-20 12:20 ` Wen Gong
2021-08-26 8:21 ` Johannes Berg [this message]
2021-08-26 8:21 ` Johannes Berg
2021-08-20 12:20 ` [PATCH v2 4/8] cfg80211: add definition for 6 GHz power spectral density(psd) Wen Gong
2021-08-20 12:20 ` Wen Gong
2021-08-20 12:20 ` [PATCH v2 5/8] cfg80211: save power spectral density(psd) of regulatory rule Wen Gong
2021-08-20 12:20 ` Wen Gong
2021-08-26 8:25 ` Johannes Berg
2021-08-26 8:25 ` Johannes Berg
2021-08-26 10:43 ` Wen Gong
2021-08-26 10:43 ` Wen Gong
2021-08-26 10:56 ` Johannes Berg
2021-08-26 10:56 ` Johannes Berg
2021-08-26 10:58 ` Wen Gong
2021-08-26 10:58 ` Wen Gong
2021-08-20 12:20 ` [PATCH v2 6/8] mac80211: add definition for transmit power envelope element Wen Gong
2021-08-20 12:20 ` Wen Gong
2021-08-26 8:30 ` Johannes Berg
2021-08-26 8:30 ` Johannes Berg
2021-08-20 12:20 ` [PATCH v2 7/8] mac80211: add parse " Wen Gong
2021-08-20 12:20 ` Wen Gong
2021-08-26 8:20 ` Johannes Berg
2021-08-26 8:20 ` Johannes Berg
2021-08-20 12:20 ` [PATCH v2 8/8] mac80211: save transmit power envelope element and power constraint Wen Gong
2021-08-20 12:20 ` Wen Gong
2021-08-26 8:29 ` Johannes Berg
2021-08-26 8:29 ` Johannes Berg
2021-08-26 10:50 ` Wen Gong
2021-08-26 10:50 ` Wen Gong
2021-08-26 10:57 ` Johannes Berg
2021-08-26 10:57 ` Johannes Berg
2021-08-26 11:00 ` Wen Gong
2021-08-26 11:00 ` Wen Gong
2021-08-26 11:10 ` Johannes Berg
2021-08-26 11:10 ` Johannes Berg
2021-08-27 2:01 ` Wen Gong
2021-08-27 2:01 ` Wen Gong
2023-07-19 3:29 ` Wen Gong
2023-07-19 3:29 ` Wen Gong
2021-08-27 2:11 ` Wen Gong
2021-08-27 2:11 ` Wen Gong
2021-08-27 6:46 ` Johannes Berg
2021-08-27 6:46 ` Johannes Berg
2021-08-27 6:53 ` Wen Gong
2021-08-27 6:53 ` Wen Gong
2021-08-27 6:55 ` Johannes Berg
2021-08-27 6:55 ` Johannes Berg
2021-08-27 7:12 ` Wen Gong
2021-08-27 7:12 ` Wen Gong
2021-08-27 7:38 ` Johannes Berg
2021-08-27 7:38 ` Johannes Berg
2021-08-27 8:18 ` Wen Gong
2021-08-27 8:18 ` Wen Gong
2021-08-27 8:20 ` Johannes Berg
2021-08-27 8:20 ` Johannes Berg
2021-08-27 8:28 ` Wen Gong
2021-08-27 8:28 ` Wen Gong
2021-08-27 8:30 ` Johannes Berg
2021-08-27 8:30 ` Johannes Berg
2021-08-27 8:47 ` Wen Gong
2021-08-27 8:47 ` Wen Gong
2021-08-25 2:18 ` [PATCH v2 0/8] cfg80211/mac80211: Add support for 6GHZ STA for various modes : LPI, SP and VLP Wen Gong
2021-08-25 2:18 ` Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57012b81620f7c176c405262f2caf8d497393cae.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.