From: Johannes Berg <johannes@sipsolutions.net> To: Wen Gong <wgong@codeaurora.org> Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v2 1/8] cfg80211: add power type definition for 6 GHz Date: Thu, 26 Aug 2021 12:59:09 +0200 [thread overview] Message-ID: <7e07a64f33bc1a1ca09e36d6152628478a622b69.camel@sipsolutions.net> (raw) In-Reply-To: <e6006814059d085a1f57af24b9561dde@codeaurora.org> On Thu, 2021-08-26 at 18:57 +0800, Wen Gong wrote: > On 2021-08-26 16:20, Johannes Berg wrote: > > > struct cfg80211_chan_def { > > > struct ieee80211_channel *chan; > > > @@ -684,6 +685,7 @@ struct cfg80211_chan_def { > > > u32 center_freq2; > > > struct ieee80211_edmg edmg; > > > u16 freq1_offset; > > > + enum nl80211_ap_reg_power power_type; > > > > I'm not sure why this should be in the chandef, there's no way that > > anything in cfg80211 is ever using it there, at least in your patches. > > > It is used in mac80211 of [PATCH v2 3/8] mac80211: add parse regulatory > info in 6 GHz operation information. > should i move it to mac80211's .h file? > > > +/** > > > + * enum nl80211_ap_reg_power - regulatory power for a Access Point [...] > > > It is used in mac80211 of [PATCH v2 3/8] mac80211: add parse regulatory > info in 6 GHz operation information. > should i move it to mac80211's .h file? Yeah I saw both of them are used, but why are they defined as nl80211 API? Do you have any intention to set them through nl80211? And like I said, I'm not really convinced this belongs into struct cfg80211_chan_def either. Maybe it should be in bss_conf too? johannes >
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net> To: Wen Gong <wgong@codeaurora.org> Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v2 1/8] cfg80211: add power type definition for 6 GHz Date: Thu, 26 Aug 2021 12:59:09 +0200 [thread overview] Message-ID: <7e07a64f33bc1a1ca09e36d6152628478a622b69.camel@sipsolutions.net> (raw) In-Reply-To: <e6006814059d085a1f57af24b9561dde@codeaurora.org> On Thu, 2021-08-26 at 18:57 +0800, Wen Gong wrote: > On 2021-08-26 16:20, Johannes Berg wrote: > > > struct cfg80211_chan_def { > > > struct ieee80211_channel *chan; > > > @@ -684,6 +685,7 @@ struct cfg80211_chan_def { > > > u32 center_freq2; > > > struct ieee80211_edmg edmg; > > > u16 freq1_offset; > > > + enum nl80211_ap_reg_power power_type; > > > > I'm not sure why this should be in the chandef, there's no way that > > anything in cfg80211 is ever using it there, at least in your patches. > > > It is used in mac80211 of [PATCH v2 3/8] mac80211: add parse regulatory > info in 6 GHz operation information. > should i move it to mac80211's .h file? > > > +/** > > > + * enum nl80211_ap_reg_power - regulatory power for a Access Point [...] > > > It is used in mac80211 of [PATCH v2 3/8] mac80211: add parse regulatory > info in 6 GHz operation information. > should i move it to mac80211's .h file? Yeah I saw both of them are used, but why are they defined as nl80211 API? Do you have any intention to set them through nl80211? And like I said, I'm not really convinced this belongs into struct cfg80211_chan_def either. Maybe it should be in bss_conf too? johannes > -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2021-08-26 10:59 UTC|newest] Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-20 12:20 [PATCH v2 0/8] cfg80211/mac80211: Add support for 6GHZ STA for various modes : LPI, SP and VLP Wen Gong 2021-08-20 12:20 ` Wen Gong 2021-08-20 12:20 ` [PATCH v2 1/8] cfg80211: add power type definition for 6 GHz Wen Gong 2021-08-20 12:20 ` Wen Gong 2021-08-26 8:20 ` Johannes Berg 2021-08-26 8:20 ` Johannes Berg 2021-08-26 8:22 ` Johannes Berg 2021-08-26 8:22 ` Johannes Berg 2021-08-26 11:02 ` Wen Gong 2021-08-26 11:02 ` Wen Gong 2021-08-26 11:11 ` Johannes Berg 2021-08-26 11:11 ` Johannes Berg 2021-08-26 10:57 ` Wen Gong 2021-08-26 10:57 ` Wen Gong 2021-08-26 10:59 ` Johannes Berg [this message] 2021-08-26 10:59 ` Johannes Berg 2021-08-26 11:01 ` Wen Gong 2021-08-26 11:01 ` Wen Gong 2021-08-20 12:20 ` [PATCH v2 2/8] mac80211: add definition of regulatory info in 6 GHz operation information Wen Gong 2021-08-20 12:20 ` Wen Gong 2021-08-26 8:20 ` Johannes Berg 2021-08-26 8:20 ` Johannes Berg 2021-08-20 12:20 ` [PATCH v2 3/8] mac80211: add parse " Wen Gong 2021-08-20 12:20 ` Wen Gong 2021-08-26 8:21 ` Johannes Berg 2021-08-26 8:21 ` Johannes Berg 2021-08-20 12:20 ` [PATCH v2 4/8] cfg80211: add definition for 6 GHz power spectral density(psd) Wen Gong 2021-08-20 12:20 ` Wen Gong 2021-08-20 12:20 ` [PATCH v2 5/8] cfg80211: save power spectral density(psd) of regulatory rule Wen Gong 2021-08-20 12:20 ` Wen Gong 2021-08-26 8:25 ` Johannes Berg 2021-08-26 8:25 ` Johannes Berg 2021-08-26 10:43 ` Wen Gong 2021-08-26 10:43 ` Wen Gong 2021-08-26 10:56 ` Johannes Berg 2021-08-26 10:56 ` Johannes Berg 2021-08-26 10:58 ` Wen Gong 2021-08-26 10:58 ` Wen Gong 2021-08-20 12:20 ` [PATCH v2 6/8] mac80211: add definition for transmit power envelope element Wen Gong 2021-08-20 12:20 ` Wen Gong 2021-08-26 8:30 ` Johannes Berg 2021-08-26 8:30 ` Johannes Berg 2021-08-20 12:20 ` [PATCH v2 7/8] mac80211: add parse " Wen Gong 2021-08-20 12:20 ` Wen Gong 2021-08-26 8:20 ` Johannes Berg 2021-08-26 8:20 ` Johannes Berg 2021-08-20 12:20 ` [PATCH v2 8/8] mac80211: save transmit power envelope element and power constraint Wen Gong 2021-08-20 12:20 ` Wen Gong 2021-08-26 8:29 ` Johannes Berg 2021-08-26 8:29 ` Johannes Berg 2021-08-26 10:50 ` Wen Gong 2021-08-26 10:50 ` Wen Gong 2021-08-26 10:57 ` Johannes Berg 2021-08-26 10:57 ` Johannes Berg 2021-08-26 11:00 ` Wen Gong 2021-08-26 11:00 ` Wen Gong 2021-08-26 11:10 ` Johannes Berg 2021-08-26 11:10 ` Johannes Berg 2021-08-27 2:01 ` Wen Gong 2021-08-27 2:01 ` Wen Gong 2023-07-19 3:29 ` Wen Gong 2023-07-19 3:29 ` Wen Gong 2021-08-27 2:11 ` Wen Gong 2021-08-27 2:11 ` Wen Gong 2021-08-27 6:46 ` Johannes Berg 2021-08-27 6:46 ` Johannes Berg 2021-08-27 6:53 ` Wen Gong 2021-08-27 6:53 ` Wen Gong 2021-08-27 6:55 ` Johannes Berg 2021-08-27 6:55 ` Johannes Berg 2021-08-27 7:12 ` Wen Gong 2021-08-27 7:12 ` Wen Gong 2021-08-27 7:38 ` Johannes Berg 2021-08-27 7:38 ` Johannes Berg 2021-08-27 8:18 ` Wen Gong 2021-08-27 8:18 ` Wen Gong 2021-08-27 8:20 ` Johannes Berg 2021-08-27 8:20 ` Johannes Berg 2021-08-27 8:28 ` Wen Gong 2021-08-27 8:28 ` Wen Gong 2021-08-27 8:30 ` Johannes Berg 2021-08-27 8:30 ` Johannes Berg 2021-08-27 8:47 ` Wen Gong 2021-08-27 8:47 ` Wen Gong 2021-08-25 2:18 ` [PATCH v2 0/8] cfg80211/mac80211: Add support for 6GHZ STA for various modes : LPI, SP and VLP Wen Gong 2021-08-25 2:18 ` Wen Gong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7e07a64f33bc1a1ca09e36d6152628478a622b69.camel@sipsolutions.net \ --to=johannes@sipsolutions.net \ --cc=ath11k@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ --cc=wgong@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.