From: Vinod Koul <vinod.koul@linux.intel.com> To: Boojin Kim <boojin.kim@samsung.com> Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Kukjin Kim <kgene.kim@samsung.com>, Russell King <linux@arm.linux.org.uk>, Linus Walleij <linus.walleij@linaro.org>, Jassi Brar <jassisinghbrar@gmail.com>, Grant Likely <grant.likely@secretlab.ca>, Mark Brown <broonie@opensource.wolfsonmicro.com>, Dan Williams <dan.j.williams@intel.com> Subject: Re: [PATCH v7 02/15] DMA: PL330: Update PL330 DMA API driver Date: Mon, 29 Aug 2011 19:25:41 +0530 [thread overview] Message-ID: <1314626141.1606.139.camel@vkoul-udesk3> (raw) In-Reply-To: <1314238425-6480-3-git-send-email-boojin.kim@samsung.com> On Thu, 2011-08-25 at 11:13 +0900, Boojin Kim wrote: > This patch updates following 3 items. > @@ -69,6 +70,10 @@ struct dma_pl330_chan { > * NULL if the channel is available to be acquired. > */ > void *pl330_chid; > + > + /* For D-to-M and M-to-D channels */ > + int burst_sz; /* the peripheral fifo width */ > + dma_addr_t fifo_addr; > }; Why should you store peripheral address and burst size in channel structure. You should take these from the API and dma_slave_structure > > struct dma_pl330_dmac { > @@ -456,7 +461,7 @@ static struct dma_pl330_desc *pl330_get_desc(struct dma_pl330_chan *pch) > > if (peri) { > desc->req.rqtype = peri->rqtype; > - desc->req.peri = peri->peri_id; > + desc->req.peri = pch->chan.chan_id; > } else { > desc->req.rqtype = MEMTOMEM; > desc->req.peri = 0; > @@ -582,7 +587,7 @@ pl330_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl, > struct dma_pl330_peri *peri = chan->private; > struct scatterlist *sg; > unsigned long flags; > - int i, burst_size; > + int i; > dma_addr_t addr; > > if (unlikely(!pch || !sgl || !sg_len || !peri)) > @@ -598,8 +603,7 @@ pl330_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl, > return NULL; > } > > - addr = peri->fifo_addr; > - burst_size = peri->burst_sz; > + addr = pch->fifo_addr; what you removed is the correct way to do... -- ~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@linux.intel.com (Vinod Koul) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v7 02/15] DMA: PL330: Update PL330 DMA API driver Date: Mon, 29 Aug 2011 19:25:41 +0530 [thread overview] Message-ID: <1314626141.1606.139.camel@vkoul-udesk3> (raw) In-Reply-To: <1314238425-6480-3-git-send-email-boojin.kim@samsung.com> On Thu, 2011-08-25 at 11:13 +0900, Boojin Kim wrote: > This patch updates following 3 items. > @@ -69,6 +70,10 @@ struct dma_pl330_chan { > * NULL if the channel is available to be acquired. > */ > void *pl330_chid; > + > + /* For D-to-M and M-to-D channels */ > + int burst_sz; /* the peripheral fifo width */ > + dma_addr_t fifo_addr; > }; Why should you store peripheral address and burst size in channel structure. You should take these from the API and dma_slave_structure > > struct dma_pl330_dmac { > @@ -456,7 +461,7 @@ static struct dma_pl330_desc *pl330_get_desc(struct dma_pl330_chan *pch) > > if (peri) { > desc->req.rqtype = peri->rqtype; > - desc->req.peri = peri->peri_id; > + desc->req.peri = pch->chan.chan_id; > } else { > desc->req.rqtype = MEMTOMEM; > desc->req.peri = 0; > @@ -582,7 +587,7 @@ pl330_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl, > struct dma_pl330_peri *peri = chan->private; > struct scatterlist *sg; > unsigned long flags; > - int i, burst_size; > + int i; > dma_addr_t addr; > > if (unlikely(!pch || !sgl || !sg_len || !peri)) > @@ -598,8 +603,7 @@ pl330_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl, > return NULL; > } > > - addr = peri->fifo_addr; > - burst_size = peri->burst_sz; > + addr = pch->fifo_addr; what you removed is the correct way to do... -- ~Vinod
next prev parent reply other threads:[~2011-08-29 13:56 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-08-25 2:13 To use DMA generic APIs for Samsung DMA Boojin Kim 2011-08-25 2:13 ` Boojin Kim 2011-08-25 2:13 ` [PATCH v7 01/15] DMA: PL330: Add support runtime PM for PL330 DMAC Boojin Kim 2011-08-25 2:13 ` Boojin Kim 2011-08-25 2:13 ` [PATCH v7 02/15] DMA: PL330: Update PL330 DMA API driver Boojin Kim 2011-08-25 2:13 ` Boojin Kim 2011-08-26 14:48 ` Jassi Brar 2011-08-26 14:48 ` Jassi Brar 2011-08-29 13:55 ` Vinod Koul [this message] 2011-08-29 13:55 ` Vinod Koul 2011-08-29 14:22 ` Vinod Koul 2011-08-29 14:22 ` Vinod Koul 2011-08-29 14:25 ` Vinod Koul 2011-08-29 14:25 ` Vinod Koul 2011-08-25 2:13 ` [PATCH v7 03/15] DMA: PL330: Modify device_control() Boojin Kim 2011-08-25 2:13 ` Boojin Kim 2011-08-26 15:19 ` Jassi Brar 2011-08-26 15:19 ` Jassi Brar 2011-08-25 2:13 ` [PATCH v7 04/15] DMA: PL330: Add DMA_CYCLIC capability Boojin Kim 2011-08-25 2:13 ` Boojin Kim 2011-08-26 15:25 ` Jassi Brar 2011-08-26 15:25 ` Jassi Brar 2011-08-25 2:13 ` [PATCH v7 05/15] ARM: SAMSUNG: Update to use PL330-DMA driver Boojin Kim 2011-08-25 2:13 ` Boojin Kim 2011-08-25 2:13 ` [PATCH v7 06/15] ARM: SAMSUNG: Add common DMA operations Boojin Kim 2011-08-25 2:13 ` Boojin Kim 2011-08-25 2:13 ` [PATCH v7 07/15] ARM: EXYNOS4: Use generic DMA PL330 driver Boojin Kim 2011-08-25 2:13 ` Boojin Kim 2011-08-25 2:13 ` [PATCH v7 08/15] ARM: S5PV210: " Boojin Kim 2011-08-25 2:13 ` Boojin Kim 2011-08-25 2:13 ` [PATCH v7 09/15] ARM: S5PC100: " Boojin Kim 2011-08-25 2:13 ` Boojin Kim 2011-08-25 2:13 ` [PATCH v7 10/15] ARM: S5P64X0: " Boojin Kim 2011-08-25 2:13 ` Boojin Kim 2011-08-25 2:13 ` [PATCH v7 11/15] ARM: SAMSUNG: Remove S3C-PL330-DMA driver Boojin Kim 2011-08-25 2:13 ` Boojin Kim 2011-08-25 2:13 ` [PATCH v7 12/15] spi/s3c64xx: Add support DMA engine API Boojin Kim 2011-08-25 2:13 ` Boojin Kim 2011-08-25 2:13 ` [PATCH v7 13/15] spi/s3c64xx: Merge dma control code Boojin Kim 2011-08-25 2:13 ` Boojin Kim 2011-08-25 2:13 ` [PATCH v7 14/15] ASoC: Samsung: Update DMA interface Boojin Kim 2011-08-25 2:13 ` Boojin Kim 2011-08-25 2:13 ` [PATCH v7 15/15] ARM: SAMSUNG: Remove Samsung specific enum type for dma direction Boojin Kim 2011-08-25 2:13 ` Boojin Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1314626141.1606.139.camel@vkoul-udesk3 \ --to=vinod.koul@linux.intel.com \ --cc=boojin.kim@samsung.com \ --cc=broonie@opensource.wolfsonmicro.com \ --cc=dan.j.williams@intel.com \ --cc=grant.likely@secretlab.ca \ --cc=jassisinghbrar@gmail.com \ --cc=kgene.kim@samsung.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.