All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jassi Brar <jassisinghbrar@gmail.com>
To: Boojin Kim <boojin.kim@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	Vinod Koul <vinod.koul@intel.com>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	Russell King <linux@arm.linux.org.uk>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v7 03/15] DMA: PL330: Modify device_control()
Date: Fri, 26 Aug 2011 20:49:05 +0530	[thread overview]
Message-ID: <CABb+yY3s6g3HrfHa9n-WOzhfzi26g46WxzNDCHzEaRg95zSC5w@mail.gmail.com> (raw)
In-Reply-To: <1314238425-6480-4-git-send-email-boojin.kim@samsung.com>

On Thu, Aug 25, 2011 at 7:43 AM, Boojin Kim <boojin.kim@samsung.com> wrote:
> This patch modifies device_control() to support both DMA_TERMINATE_ALL
> and DMA_SLAVE_CONFIG command.
> First, modify the flush control for DMA_TERMINATE_ALL command.
> Second, add the slave configuration control for DMA_SLAVE_CONFIG command.

I repeat what I said for v6.
*********
Apart from the alleged purpose "Support DMA_SLAVE_CONFIG command"
this patch also modifies the behavior of DMA_TERMINATE_ALL.
If the change is intended, please split it into two patches and
explain the reason.
Otherwise, restore the behavior.
*********

WARNING: multiple messages have this Message-ID (diff)
From: jassisinghbrar@gmail.com (Jassi Brar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 03/15] DMA: PL330: Modify device_control()
Date: Fri, 26 Aug 2011 20:49:05 +0530	[thread overview]
Message-ID: <CABb+yY3s6g3HrfHa9n-WOzhfzi26g46WxzNDCHzEaRg95zSC5w@mail.gmail.com> (raw)
In-Reply-To: <1314238425-6480-4-git-send-email-boojin.kim@samsung.com>

On Thu, Aug 25, 2011 at 7:43 AM, Boojin Kim <boojin.kim@samsung.com> wrote:
> This patch modifies device_control() to support both DMA_TERMINATE_ALL
> and DMA_SLAVE_CONFIG command.
> First, modify the flush control for DMA_TERMINATE_ALL command.
> Second, add the slave configuration control for DMA_SLAVE_CONFIG command.

I repeat what I said for v6.
*********
Apart from the alleged purpose "Support DMA_SLAVE_CONFIG command"
this patch also modifies the behavior of DMA_TERMINATE_ALL.
If the change is intended, please split it into two patches and
explain the reason.
Otherwise, restore the behavior.
*********

  reply	other threads:[~2011-08-26 15:19 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-25  2:13 To use DMA generic APIs for Samsung DMA Boojin Kim
2011-08-25  2:13 ` Boojin Kim
2011-08-25  2:13 ` [PATCH v7 01/15] DMA: PL330: Add support runtime PM for PL330 DMAC Boojin Kim
2011-08-25  2:13   ` Boojin Kim
2011-08-25  2:13 ` [PATCH v7 02/15] DMA: PL330: Update PL330 DMA API driver Boojin Kim
2011-08-25  2:13   ` Boojin Kim
2011-08-26 14:48   ` Jassi Brar
2011-08-26 14:48     ` Jassi Brar
2011-08-29 13:55   ` Vinod Koul
2011-08-29 13:55     ` Vinod Koul
2011-08-29 14:22     ` Vinod Koul
2011-08-29 14:22       ` Vinod Koul
2011-08-29 14:25       ` Vinod Koul
2011-08-29 14:25         ` Vinod Koul
2011-08-25  2:13 ` [PATCH v7 03/15] DMA: PL330: Modify device_control() Boojin Kim
2011-08-25  2:13   ` Boojin Kim
2011-08-26 15:19   ` Jassi Brar [this message]
2011-08-26 15:19     ` Jassi Brar
2011-08-25  2:13 ` [PATCH v7 04/15] DMA: PL330: Add DMA_CYCLIC capability Boojin Kim
2011-08-25  2:13   ` Boojin Kim
2011-08-26 15:25   ` Jassi Brar
2011-08-26 15:25     ` Jassi Brar
2011-08-25  2:13 ` [PATCH v7 05/15] ARM: SAMSUNG: Update to use PL330-DMA driver Boojin Kim
2011-08-25  2:13   ` Boojin Kim
2011-08-25  2:13 ` [PATCH v7 06/15] ARM: SAMSUNG: Add common DMA operations Boojin Kim
2011-08-25  2:13   ` Boojin Kim
2011-08-25  2:13 ` [PATCH v7 07/15] ARM: EXYNOS4: Use generic DMA PL330 driver Boojin Kim
2011-08-25  2:13   ` Boojin Kim
2011-08-25  2:13 ` [PATCH v7 08/15] ARM: S5PV210: " Boojin Kim
2011-08-25  2:13   ` Boojin Kim
2011-08-25  2:13 ` [PATCH v7 09/15] ARM: S5PC100: " Boojin Kim
2011-08-25  2:13   ` Boojin Kim
2011-08-25  2:13 ` [PATCH v7 10/15] ARM: S5P64X0: " Boojin Kim
2011-08-25  2:13   ` Boojin Kim
2011-08-25  2:13 ` [PATCH v7 11/15] ARM: SAMSUNG: Remove S3C-PL330-DMA driver Boojin Kim
2011-08-25  2:13   ` Boojin Kim
2011-08-25  2:13 ` [PATCH v7 12/15] spi/s3c64xx: Add support DMA engine API Boojin Kim
2011-08-25  2:13   ` Boojin Kim
2011-08-25  2:13 ` [PATCH v7 13/15] spi/s3c64xx: Merge dma control code Boojin Kim
2011-08-25  2:13   ` Boojin Kim
2011-08-25  2:13 ` [PATCH v7 14/15] ASoC: Samsung: Update DMA interface Boojin Kim
2011-08-25  2:13   ` Boojin Kim
2011-08-25  2:13 ` [PATCH v7 15/15] ARM: SAMSUNG: Remove Samsung specific enum type for dma direction Boojin Kim
2011-08-25  2:13   ` Boojin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABb+yY3s6g3HrfHa9n-WOzhfzi26g46WxzNDCHzEaRg95zSC5w@mail.gmail.com \
    --to=jassisinghbrar@gmail.com \
    --cc=boojin.kim@samsung.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dan.j.williams@intel.com \
    --cc=grant.likely@secretlab.ca \
    --cc=kgene.kim@samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.