[RFC v2 1/6] tee: optee: allow kernel pages to register as shm

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Sumit Garg <sumit.garg@linaro.org>
To: keyrings@vger.kernel.org, linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org
Cc: tee-dev@lists.linaro.org, daniel.thompson@linaro.org,
	Sumit Garg <sumit.garg@linaro.org>,
	corbet@lwn.net, jejb@linux.ibm.com, ard.biesheuvel@linaro.org,
	linux-doc@vger.kernel.org, jmorris@namei.org,
	zohar@linux.ibm.com, linux-kernel@vger.kernel.org,
	dhowells@redhat.com, jarkko.sakkinen@linux.intel.com,
	casey@schaufler-ca.com, jens.wiklander@linaro.org,
	linux-arm-kernel@lists.infradead.org, serge@hallyn.com
Subject: [RFC v2 1/6] tee: optee: allow kernel pages to register as shm
Date: Tue, 30 Jul 2019 12:35:35 +0000	[thread overview]
Message-ID: <1564489420-677-2-git-send-email-sumit.garg@linaro.org> (raw)
In-Reply-To: <1564489420-677-1-git-send-email-sumit.garg@linaro.org>

Kernel pages are marked as normal type memory only so allow kernel pages
to be registered as shared memory with OP-TEE.

Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
---
 drivers/tee/optee/call.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/tee/optee/call.c b/drivers/tee/optee/call.c
index aa94270..bce45b1 100644
--- a/drivers/tee/optee/call.c
+++ b/drivers/tee/optee/call.c
@@ -553,6 +553,13 @@ static int check_mem_type(unsigned long start, size_t num_pages)
 	struct mm_struct *mm = current->mm;
 	int rc;
 
+	/*
+	 * Allow kernel address to register with OP-TEE as kernel
+	 * pages are configured as normal memory only.
+	 */
+	if (virt_addr_valid(start))
+		return 0;
+
 	down_read(&mm->mmap_sem);
 	rc = __check_mem_type(find_vma(mm, start),
 			      start + num_pages * PAGE_SIZE);
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)

From: Sumit Garg <sumit.garg@linaro.org>
To: keyrings@vger.kernel.org, linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org
Cc: jens.wiklander@linaro.org, corbet@lwn.net, dhowells@redhat.com,
	jejb@linux.ibm.com, jarkko.sakkinen@linux.intel.com,
	zohar@linux.ibm.com, jmorris@namei.org, serge@hallyn.com,
	casey@schaufler-ca.com, ard.biesheuvel@linaro.org,
	daniel.thompson@linaro.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, tee-dev@lists.linaro.org,
	Sumit Garg <sumit.garg@linaro.org>
Subject: [RFC v2 1/6] tee: optee: allow kernel pages to register as shm
Date: Tue, 30 Jul 2019 17:53:35 +0530	[thread overview]
Message-ID: <1564489420-677-2-git-send-email-sumit.garg@linaro.org> (raw)
In-Reply-To: <1564489420-677-1-git-send-email-sumit.garg@linaro.org>

Kernel pages are marked as normal type memory only so allow kernel pages
to be registered as shared memory with OP-TEE.

Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
---
 drivers/tee/optee/call.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/tee/optee/call.c b/drivers/tee/optee/call.c
index aa94270..bce45b1 100644
--- a/drivers/tee/optee/call.c
+++ b/drivers/tee/optee/call.c
@@ -553,6 +553,13 @@ static int check_mem_type(unsigned long start, size_t num_pages)
 	struct mm_struct *mm = current->mm;
 	int rc;
 
+	/*
+	 * Allow kernel address to register with OP-TEE as kernel
+	 * pages are configured as normal memory only.
+	 */
+	if (virt_addr_valid(start))
+		return 0;
+
 	down_read(&mm->mmap_sem);
 	rc = __check_mem_type(find_vma(mm, start),
 			      start + num_pages * PAGE_SIZE);
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)

From: Sumit Garg <sumit.garg@linaro.org>
To: keyrings@vger.kernel.org, linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org
Cc: tee-dev@lists.linaro.org, daniel.thompson@linaro.org,
	Sumit Garg <sumit.garg@linaro.org>,
	corbet@lwn.net, jejb@linux.ibm.com, ard.biesheuvel@linaro.org,
	linux-doc@vger.kernel.org, jmorris@namei.org,
	zohar@linux.ibm.com, linux-kernel@vger.kernel.org,
	dhowells@redhat.com, jarkko.sakkinen@linux.intel.com,
	casey@schaufler-ca.com, jens.wiklander@linaro.org,
	linux-arm-kernel@lists.infradead.org, serge@hallyn.com
Subject: [RFC v2 1/6] tee: optee: allow kernel pages to register as shm
Date: Tue, 30 Jul 2019 17:53:35 +0530	[thread overview]
Message-ID: <1564489420-677-2-git-send-email-sumit.garg@linaro.org> (raw)
In-Reply-To: <1564489420-677-1-git-send-email-sumit.garg@linaro.org>

Kernel pages are marked as normal type memory only so allow kernel pages
to be registered as shared memory with OP-TEE.

Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
---
 drivers/tee/optee/call.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/tee/optee/call.c b/drivers/tee/optee/call.c
index aa94270..bce45b1 100644
--- a/drivers/tee/optee/call.c
+++ b/drivers/tee/optee/call.c
@@ -553,6 +553,13 @@ static int check_mem_type(unsigned long start, size_t num_pages)
 	struct mm_struct *mm = current->mm;
 	int rc;
 
+	/*
+	 * Allow kernel address to register with OP-TEE as kernel
+	 * pages are configured as normal memory only.
+	 */
+	if (virt_addr_valid(start))
+		return 0;
+
 	down_read(&mm->mmap_sem);
 	rc = __check_mem_type(find_vma(mm, start),
 			      start + num_pages * PAGE_SIZE);
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

next prev parent reply	other threads:[~2019-07-30 12:35 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 12:23 [RFC v2 0/6] Introduce TEE based Trusted Keys support Sumit Garg
2019-07-30 12:35 ` Sumit Garg
2019-07-30 12:23 ` Sumit Garg
2019-07-30 12:23 ` Sumit Garg [this message]
2019-07-30 12:35   ` [RFC v2 1/6] tee: optee: allow kernel pages to register as shm Sumit Garg
2019-07-30 12:23   ` Sumit Garg
2019-07-30 12:23 ` [RFC v2 2/6] tee: enable support to register kernel memory Sumit Garg
2019-07-30 12:35   ` Sumit Garg
2019-07-30 12:23   ` Sumit Garg
2019-08-08 22:26   ` [Tee-dev] " Stuart Yoder
2019-08-08 22:26     ` Stuart Yoder
2019-08-08 22:26     ` Stuart Yoder
2019-08-09  5:36     ` Sumit Garg
2019-08-09  5:48       ` Sumit Garg
2019-08-09  5:36       ` Sumit Garg
2019-07-30 12:23 ` [RFC v2 3/6] tee: add private login method for kernel clients Sumit Garg
2019-07-30 12:35   ` Sumit Garg
2019-07-30 12:23   ` Sumit Garg
2019-07-30 12:23 ` [RFC v2 4/6] KEYS: trusted: Introduce TEE based Trusted Keys Sumit Garg
2019-07-30 12:35   ` Sumit Garg
2019-07-30 12:23   ` Sumit Garg
2019-07-30 12:23 ` [RFC v2 5/6] doc: keys: Document usage of " Sumit Garg
2019-07-30 12:35   ` Sumit Garg
2019-07-30 12:23   ` Sumit Garg
2019-07-30 12:23 ` [RFC v2 6/6] MAINTAINERS: Add entry for " Sumit Garg
2019-07-30 12:35   ` Sumit Garg
2019-07-30 12:23   ` Sumit Garg
2019-07-31  7:11 ` [RFC v2 0/6] Introduce TEE based Trusted Keys support Janne Karhunen
2019-07-31  7:11   ` Janne Karhunen
2019-07-31  7:11   ` Janne Karhunen
2019-07-31 10:21   ` Janne Karhunen
2019-07-31 10:21     ` Janne Karhunen
2019-07-31 10:21     ` Janne Karhunen
2019-07-31 13:58     ` Sumit Garg
2019-07-31 13:59       ` Sumit Garg
2019-07-31 13:58       ` Sumit Garg
2019-08-01  6:21       ` Janne Karhunen
2019-08-01  6:21         ` Janne Karhunen
2019-08-01  6:21         ` Janne Karhunen
2019-08-01  7:40         ` Sumit Garg
2019-08-01  7:52           ` Sumit Garg
2019-08-01  7:40           ` Sumit Garg
2019-08-01  7:59           ` Janne Karhunen
2019-08-01  7:59             ` Janne Karhunen
2019-08-01  7:59             ` Janne Karhunen
2019-08-01 10:00             ` Sumit Garg
2019-08-01 10:12               ` Sumit Garg
2019-08-01 10:00               ` Sumit Garg
2019-08-01 10:40               ` Janne Karhunen
2019-08-01 10:40                 ` Janne Karhunen
2019-08-01 10:40                 ` Janne Karhunen
2019-07-31 10:26   ` Sumit Garg
2019-07-31 10:38     ` Sumit Garg
2019-07-31 10:26     ` Sumit Garg
2019-07-31 11:02     ` Janne Karhunen
2019-07-31 11:02       ` Janne Karhunen
2019-07-31 11:02       ` Janne Karhunen
2019-07-31 14:23       ` Sumit Garg
2019-07-31 14:35         ` Sumit Garg
2019-07-31 14:23         ` Sumit Garg
2019-08-01  6:36         ` Janne Karhunen
2019-08-01  6:36           ` Janne Karhunen
2019-08-01  6:36           ` Janne Karhunen
2019-08-01  6:50           ` [Tee-dev] " Rouven Czerwinski
2019-08-01  6:50             ` Rouven Czerwinski
2019-08-01  6:50             ` Rouven Czerwinski
2019-08-01  7:30             ` Janne Karhunen
2019-08-01  7:30               ` Janne Karhunen
2019-08-01  7:30               ` Janne Karhunen
2019-08-01  7:58               ` Sumit Garg
2019-08-01  7:58                 ` Sumit Garg
2019-08-01  7:58                 ` Sumit Garg
2019-08-01  8:30                 ` Janne Karhunen
2019-08-01  8:30                   ` Janne Karhunen
2019-08-01  8:30                   ` Janne Karhunen
2019-08-01 10:27                   ` Sumit Garg
2019-08-01 10:39                     ` Sumit Garg
2019-08-01 10:27                     ` Sumit Garg
2019-08-04 20:48 ` Jarkko Sakkinen
2019-08-04 20:48   ` Jarkko Sakkinen
2019-08-04 20:48   ` Jarkko Sakkinen

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:aa94270 dfblob:aa94270 dfblob:aa94270 dfblob:bce45b1
dfblob:bce45b1 dfblob:bce45b1
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1564489420-677-2-git-send-email-sumit.garg@linaro.org \
    --to=sumit.garg@linaro.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=casey@schaufler-ca.com \
    --cc=corbet@lwn.net \
    --cc=daniel.thompson@linaro.org \
    --cc=dhowells@redhat.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jejb@linux.ibm.com \
    --cc=jens.wiklander@linaro.org \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=serge@hallyn.com \
    --cc=tee-dev@lists.linaro.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.