From: pradeepc@codeaurora.org
To: Johannes Berg <johannes@sipsolutions.net>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] nl80211: add support to configure FTM responder functionality
Date: Wed, 15 Aug 2018 18:48:18 -0700 [thread overview]
Message-ID: <15c381ce743aedca37f3eea67975f841@codeaurora.org> (raw)
In-Reply-To: <1534334948.3547.39.camel@sipsolutions.net>
On 2018-08-15 05:09, Johannes Berg wrote:
> On Tue, 2018-08-14 at 17:30 -0700, Pradeep Kumar Chitrapu wrote:
>>
>> + int ftm_responder;
>
> bool
>
>> + * @NL80211_ATTR_FTM_RESPONDER: attribute which user-space can
>> include in
>> + * %NL80211_CMD_START_AP to enable(1) or disable(0) fine timing
>> measurement
>> + * (FTM) responder functionality. If not set, it means don't care
>> and
>> + * the device will decide what to use.
>
> Why 0/1 instead of a flag attribute?
Using FLAG attribute may create uncertainty to userspace especially when
flag attribute
is not set and the driver supports capability, instead of
assuming/relying on the default
behavior of driver/firmware.
>
> Also, I think you need the attributes (LCI/Civic location)?
>
> johannes
WARNING: multiple messages have this Message-ID (diff)
From: pradeepc@codeaurora.org
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 1/3] nl80211: add support to configure FTM responder functionality
Date: Wed, 15 Aug 2018 18:48:18 -0700 [thread overview]
Message-ID: <15c381ce743aedca37f3eea67975f841@codeaurora.org> (raw)
In-Reply-To: <1534334948.3547.39.camel@sipsolutions.net>
On 2018-08-15 05:09, Johannes Berg wrote:
> On Tue, 2018-08-14 at 17:30 -0700, Pradeep Kumar Chitrapu wrote:
>>
>> + int ftm_responder;
>
> bool
>
>> + * @NL80211_ATTR_FTM_RESPONDER: attribute which user-space can
>> include in
>> + * %NL80211_CMD_START_AP to enable(1) or disable(0) fine timing
>> measurement
>> + * (FTM) responder functionality. If not set, it means don't care
>> and
>> + * the device will decide what to use.
>
> Why 0/1 instead of a flag attribute?
Using FLAG attribute may create uncertainty to userspace especially when
flag attribute
is not set and the driver supports capability, instead of
assuming/relying on the default
behavior of driver/firmware.
>
> Also, I think you need the attributes (LCI/Civic location)?
>
> johannes
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2018-08-16 4:43 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 0:30 [PATCH 0/3] Add support for ftm responder configuration Pradeep Kumar Chitrapu
2018-08-15 0:30 ` Pradeep Kumar Chitrapu
2018-08-15 0:30 ` [PATCH 1/3] nl80211: add support to configure FTM responder functionality Pradeep Kumar Chitrapu
2018-08-15 0:30 ` Pradeep Kumar Chitrapu
2018-08-15 12:09 ` Johannes Berg
2018-08-15 12:09 ` Johannes Berg
2018-08-16 1:48 ` pradeepc [this message]
2018-08-16 1:48 ` pradeepc
2018-08-16 8:09 ` Johannes Berg
2018-08-16 8:09 ` Johannes Berg
2018-08-31 1:10 ` [PATCH 1/3] cfg80211: support FTM responder configuration/statistics Pradeep Kumar Chitrapu
2018-08-31 1:10 ` Pradeep Kumar Chitrapu
2018-08-15 0:30 ` [PATCH 2/3] mac80211: Add support to notify ftm responder configuration to the driver Pradeep Kumar Chitrapu
2018-08-15 0:30 ` Pradeep Kumar Chitrapu
2018-08-15 12:09 ` Johannes Berg
2018-08-15 12:09 ` Johannes Berg
2018-08-31 1:11 ` [PATCH 2/3] mac80211: support FTM responder configuration/statistics Pradeep Kumar Chitrapu
2018-08-31 1:11 ` Pradeep Kumar Chitrapu
2018-08-15 0:30 ` [PATCH 3/3] ath10k: Add support to configure ftm responder role Pradeep Kumar Chitrapu
2018-08-15 0:30 ` Pradeep Kumar Chitrapu
2018-08-15 10:03 ` Sebastian Gottschall
2018-08-15 10:03 ` Sebastian Gottschall
2018-08-15 10:16 ` Sebastian Gottschall
2018-08-15 10:16 ` Sebastian Gottschall
2018-10-01 13:32 ` Kalle Valo
2018-10-01 13:32 ` Kalle Valo
2018-11-16 12:17 ` Kalle Valo
2018-11-16 12:17 ` Kalle Valo
2018-08-31 1:11 ` Pradeep Kumar Chitrapu
2018-08-31 1:11 ` Pradeep Kumar Chitrapu
2018-08-15 9:04 ` [PATCH 0/3] Add support for ftm responder configuration Johannes Berg
2018-08-15 9:04 ` Johannes Berg
2018-08-16 1:50 ` pradeepc
2018-08-16 1:50 ` pradeepc
2018-08-16 8:12 ` Johannes Berg
2018-08-16 8:12 ` Johannes Berg
2018-08-18 7:50 ` Pradeep Kumar Chitrapu
2018-08-18 7:50 ` Pradeep Kumar Chitrapu
2018-08-20 9:33 ` Johannes Berg
2018-08-20 9:33 ` Johannes Berg
2018-08-21 18:32 ` Pradeep Kumar Chitrapu
2018-08-21 18:32 ` Pradeep Kumar Chitrapu
2018-08-21 19:24 ` Johannes Berg
2018-08-21 19:24 ` Johannes Berg
2018-08-16 9:21 ` Kalle Valo
2018-08-16 9:21 ` Kalle Valo
2018-08-31 1:10 ` [PATCH 0/3] support ftm responder configuration/statistics Pradeep Kumar Chitrapu
2018-08-31 1:10 ` Pradeep Kumar Chitrapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15c381ce743aedca37f3eea67975f841@codeaurora.org \
--to=pradeepc@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.