From: pradeepc@codeaurora.org To: Johannes Berg <johannes@sipsolutions.net> Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH 0/3] Add support for ftm responder configuration Date: Wed, 15 Aug 2018 18:50:52 -0700 [thread overview] Message-ID: <4aaa3a6185dbd116ba5c1a2ce76b691f@codeaurora.org> (raw) In-Reply-To: <1534323867.3547.30.camel@sipsolutions.net> On 2018-08-15 02:04, Johannes Berg wrote: > On Tue, 2018-08-14 at 17:30 -0700, Pradeep Kumar Chitrapu wrote: >> Currently ftm_responder parameter in hostapd.conf is only used for >> fine >> timing measurement (FTM) capability advertisement and actual control >> of >> the functionality is with low-level device/driver. This leads to >> confusion >> to the user when the capability advertisement is different from actual >> FTM >> responder functionality. >> >> For example, FTM responder capability advertisement is set to >> 'disabled', >> which would imply that AP must not respond to FTM requests, but user >> sees >> AP still responding to FTM requests, as the functionality is enabled >> in >> the driver. > Hi Johannes, Thanks for the review.. > All you describe above is really a driver bug - it shouldn't have > enabled it to start with? Sure.. But isn't it justifiable for drivers/firmware choosing to enable ftm responder by default when there is no way for userspace to specify this parameter? > >> The patch set allows userspace to configure FTM responder >> functionality >> with the addition of new Netlink attribute NL80211_ATTR_FTM_RESPONDER >> and also adds extended feature flag for the drivers to advertise the >> support. Sending '0' to disable FTM responder would imply AP does not >> respond to FTM requests and sending '1' to enable FTM responder would >> imply that AP responds to all FTM requests. > > This makes sense anyway. Funny you should post this within hours of me > doing the same, basically. Sorry, I missed your patches before posting mine :) > > I have no objection to your approach, though I guess it'd be nice if > you > could take a look at the statistics I have exposed and see if those > makes sense or if additional ones are desirable for you, and then we > can > combine the work that way, i.e. have your configuration and our stats? I looked at the patch you posted and this makes sense. I will try to align ath10k driver changes with your approach. Thanks Pradeep > > johannes
WARNING: multiple messages have this Message-ID (diff)
From: pradeepc@codeaurora.org To: Johannes Berg <johannes@sipsolutions.net> Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: Re: [PATCH 0/3] Add support for ftm responder configuration Date: Wed, 15 Aug 2018 18:50:52 -0700 [thread overview] Message-ID: <4aaa3a6185dbd116ba5c1a2ce76b691f@codeaurora.org> (raw) In-Reply-To: <1534323867.3547.30.camel@sipsolutions.net> On 2018-08-15 02:04, Johannes Berg wrote: > On Tue, 2018-08-14 at 17:30 -0700, Pradeep Kumar Chitrapu wrote: >> Currently ftm_responder parameter in hostapd.conf is only used for >> fine >> timing measurement (FTM) capability advertisement and actual control >> of >> the functionality is with low-level device/driver. This leads to >> confusion >> to the user when the capability advertisement is different from actual >> FTM >> responder functionality. >> >> For example, FTM responder capability advertisement is set to >> 'disabled', >> which would imply that AP must not respond to FTM requests, but user >> sees >> AP still responding to FTM requests, as the functionality is enabled >> in >> the driver. > Hi Johannes, Thanks for the review.. > All you describe above is really a driver bug - it shouldn't have > enabled it to start with? Sure.. But isn't it justifiable for drivers/firmware choosing to enable ftm responder by default when there is no way for userspace to specify this parameter? > >> The patch set allows userspace to configure FTM responder >> functionality >> with the addition of new Netlink attribute NL80211_ATTR_FTM_RESPONDER >> and also adds extended feature flag for the drivers to advertise the >> support. Sending '0' to disable FTM responder would imply AP does not >> respond to FTM requests and sending '1' to enable FTM responder would >> imply that AP responds to all FTM requests. > > This makes sense anyway. Funny you should post this within hours of me > doing the same, basically. Sorry, I missed your patches before posting mine :) > > I have no objection to your approach, though I guess it'd be nice if > you > could take a look at the statistics I have exposed and see if those > makes sense or if additional ones are desirable for you, and then we > can > combine the work that way, i.e. have your configuration and our stats? I looked at the patch you posted and this makes sense. I will try to align ath10k driver changes with your approach. Thanks Pradeep > > johannes _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2018-08-16 4:45 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-15 0:30 [PATCH 0/3] Add support for ftm responder configuration Pradeep Kumar Chitrapu 2018-08-15 0:30 ` Pradeep Kumar Chitrapu 2018-08-15 0:30 ` [PATCH 1/3] nl80211: add support to configure FTM responder functionality Pradeep Kumar Chitrapu 2018-08-15 0:30 ` Pradeep Kumar Chitrapu 2018-08-15 12:09 ` Johannes Berg 2018-08-15 12:09 ` Johannes Berg 2018-08-16 1:48 ` pradeepc 2018-08-16 1:48 ` pradeepc 2018-08-16 8:09 ` Johannes Berg 2018-08-16 8:09 ` Johannes Berg 2018-08-31 1:10 ` [PATCH 1/3] cfg80211: support FTM responder configuration/statistics Pradeep Kumar Chitrapu 2018-08-31 1:10 ` Pradeep Kumar Chitrapu 2018-08-15 0:30 ` [PATCH 2/3] mac80211: Add support to notify ftm responder configuration to the driver Pradeep Kumar Chitrapu 2018-08-15 0:30 ` Pradeep Kumar Chitrapu 2018-08-15 12:09 ` Johannes Berg 2018-08-15 12:09 ` Johannes Berg 2018-08-31 1:11 ` [PATCH 2/3] mac80211: support FTM responder configuration/statistics Pradeep Kumar Chitrapu 2018-08-31 1:11 ` Pradeep Kumar Chitrapu 2018-08-15 0:30 ` [PATCH 3/3] ath10k: Add support to configure ftm responder role Pradeep Kumar Chitrapu 2018-08-15 0:30 ` Pradeep Kumar Chitrapu 2018-08-15 10:03 ` Sebastian Gottschall 2018-08-15 10:03 ` Sebastian Gottschall 2018-08-15 10:16 ` Sebastian Gottschall 2018-08-15 10:16 ` Sebastian Gottschall 2018-10-01 13:32 ` Kalle Valo 2018-10-01 13:32 ` Kalle Valo 2018-11-16 12:17 ` Kalle Valo 2018-11-16 12:17 ` Kalle Valo 2018-08-31 1:11 ` Pradeep Kumar Chitrapu 2018-08-31 1:11 ` Pradeep Kumar Chitrapu 2018-08-15 9:04 ` [PATCH 0/3] Add support for ftm responder configuration Johannes Berg 2018-08-15 9:04 ` Johannes Berg 2018-08-16 1:50 ` pradeepc [this message] 2018-08-16 1:50 ` pradeepc 2018-08-16 8:12 ` Johannes Berg 2018-08-16 8:12 ` Johannes Berg 2018-08-18 7:50 ` Pradeep Kumar Chitrapu 2018-08-18 7:50 ` Pradeep Kumar Chitrapu 2018-08-20 9:33 ` Johannes Berg 2018-08-20 9:33 ` Johannes Berg 2018-08-21 18:32 ` Pradeep Kumar Chitrapu 2018-08-21 18:32 ` Pradeep Kumar Chitrapu 2018-08-21 19:24 ` Johannes Berg 2018-08-21 19:24 ` Johannes Berg 2018-08-16 9:21 ` Kalle Valo 2018-08-16 9:21 ` Kalle Valo 2018-08-31 1:10 ` [PATCH 0/3] support ftm responder configuration/statistics Pradeep Kumar Chitrapu 2018-08-31 1:10 ` Pradeep Kumar Chitrapu 2018-08-21 22:08 [PATCH 0/3] Add support for ftm responder configuration Pradeep Kumar Chitrapu 2018-08-21 22:08 ` Pradeep Kumar Chitrapu 2018-08-22 7:27 ` Johannes Berg 2018-08-22 7:27 ` Johannes Berg 2018-08-22 18:22 ` Pradeep Kumar Chitrapu 2018-08-22 18:22 ` Pradeep Kumar Chitrapu 2018-08-28 8:43 ` Johannes Berg 2018-08-28 8:43 ` Johannes Berg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4aaa3a6185dbd116ba5c1a2ce76b691f@codeaurora.org \ --to=pradeepc@codeaurora.org \ --cc=ath10k@lists.infradead.org \ --cc=johannes@sipsolutions.net \ --cc=linux-wireless@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.