From: Kalle Valo <kvalo@codeaurora.org>
To: Sebastian Gottschall <s.gottschall@dd-wrt.com>
Cc: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
johannes@sipsolutions.net, ath10k@lists.infradead.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/3] ath10k: Add support to configure ftm responder role
Date: Mon, 01 Oct 2018 16:32:44 +0300 [thread overview]
Message-ID: <871s99lrlv.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <36962f12-84ff-d1a9-8273-a8e3444db108@dd-wrt.com> (Sebastian Gottschall's message of "Wed, 15 Aug 2018 12:16:50 +0200")
Sebastian Gottschall <s.gottschall@dd-wrt.com> writes:
> Am 15.08.2018 um 02:30 schrieb Pradeep Kumar Chitrapu:
>> + if (test_bit(WMI_SERVICE_RTT, ar->wmi.svc_map))
>> + wiphy_ext_feature_set(ar->hw->wiphy,
>> + NL80211_EXT_FEATURE_SET_FTM_RESPONDER);
>> +
>
> not sure if this is accurate. even if WMI_SERVICE_RTT is set, the
> firmware may not support this feature. this feature doesnt seem to be
> implemented in current firmware releases
> i checked the firmware sourcecode i have from 3.4 series and it doesnt
> support this feature
Pradeep, did you check this? It's really bad if ath10k enables the
feature even if the firmware doesn't support this.
--
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Sebastian Gottschall <s.gottschall@dd-wrt.com>
Cc: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
ath10k@lists.infradead.org
Subject: Re: [PATCH 3/3] ath10k: Add support to configure ftm responder role
Date: Mon, 01 Oct 2018 16:32:44 +0300 [thread overview]
Message-ID: <871s99lrlv.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <36962f12-84ff-d1a9-8273-a8e3444db108@dd-wrt.com> (Sebastian Gottschall's message of "Wed, 15 Aug 2018 12:16:50 +0200")
Sebastian Gottschall <s.gottschall@dd-wrt.com> writes:
> Am 15.08.2018 um 02:30 schrieb Pradeep Kumar Chitrapu:
>> + if (test_bit(WMI_SERVICE_RTT, ar->wmi.svc_map))
>> + wiphy_ext_feature_set(ar->hw->wiphy,
>> + NL80211_EXT_FEATURE_SET_FTM_RESPONDER);
>> +
>
> not sure if this is accurate. even if WMI_SERVICE_RTT is set, the
> firmware may not support this feature. this feature doesnt seem to be
> implemented in current firmware releases
> i checked the firmware sourcecode i have from 3.4 series and it doesnt
> support this feature
Pradeep, did you check this? It's really bad if ath10k enables the
feature even if the firmware doesn't support this.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2018-10-01 13:32 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 0:30 [PATCH 0/3] Add support for ftm responder configuration Pradeep Kumar Chitrapu
2018-08-15 0:30 ` Pradeep Kumar Chitrapu
2018-08-15 0:30 ` [PATCH 1/3] nl80211: add support to configure FTM responder functionality Pradeep Kumar Chitrapu
2018-08-15 0:30 ` Pradeep Kumar Chitrapu
2018-08-15 12:09 ` Johannes Berg
2018-08-15 12:09 ` Johannes Berg
2018-08-16 1:48 ` pradeepc
2018-08-16 1:48 ` pradeepc
2018-08-16 8:09 ` Johannes Berg
2018-08-16 8:09 ` Johannes Berg
2018-08-31 1:10 ` [PATCH 1/3] cfg80211: support FTM responder configuration/statistics Pradeep Kumar Chitrapu
2018-08-31 1:10 ` Pradeep Kumar Chitrapu
2018-08-15 0:30 ` [PATCH 2/3] mac80211: Add support to notify ftm responder configuration to the driver Pradeep Kumar Chitrapu
2018-08-15 0:30 ` Pradeep Kumar Chitrapu
2018-08-15 12:09 ` Johannes Berg
2018-08-15 12:09 ` Johannes Berg
2018-08-31 1:11 ` [PATCH 2/3] mac80211: support FTM responder configuration/statistics Pradeep Kumar Chitrapu
2018-08-31 1:11 ` Pradeep Kumar Chitrapu
2018-08-15 0:30 ` [PATCH 3/3] ath10k: Add support to configure ftm responder role Pradeep Kumar Chitrapu
2018-08-15 0:30 ` Pradeep Kumar Chitrapu
2018-08-15 10:03 ` Sebastian Gottschall
2018-08-15 10:03 ` Sebastian Gottschall
2018-08-15 10:16 ` Sebastian Gottschall
2018-08-15 10:16 ` Sebastian Gottschall
2018-10-01 13:32 ` Kalle Valo [this message]
2018-10-01 13:32 ` Kalle Valo
2018-11-16 12:17 ` Kalle Valo
2018-11-16 12:17 ` Kalle Valo
2018-08-31 1:11 ` Pradeep Kumar Chitrapu
2018-08-31 1:11 ` Pradeep Kumar Chitrapu
2018-08-15 9:04 ` [PATCH 0/3] Add support for ftm responder configuration Johannes Berg
2018-08-15 9:04 ` Johannes Berg
2018-08-16 1:50 ` pradeepc
2018-08-16 1:50 ` pradeepc
2018-08-16 8:12 ` Johannes Berg
2018-08-16 8:12 ` Johannes Berg
2018-08-18 7:50 ` Pradeep Kumar Chitrapu
2018-08-18 7:50 ` Pradeep Kumar Chitrapu
2018-08-20 9:33 ` Johannes Berg
2018-08-20 9:33 ` Johannes Berg
2018-08-21 18:32 ` Pradeep Kumar Chitrapu
2018-08-21 18:32 ` Pradeep Kumar Chitrapu
2018-08-21 19:24 ` Johannes Berg
2018-08-21 19:24 ` Johannes Berg
2018-08-16 9:21 ` Kalle Valo
2018-08-16 9:21 ` Kalle Valo
2018-08-31 1:10 ` [PATCH 0/3] support ftm responder configuration/statistics Pradeep Kumar Chitrapu
2018-08-31 1:10 ` Pradeep Kumar Chitrapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s99lrlv.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pradeepc@codeaurora.org \
--cc=s.gottschall@dd-wrt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.