From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Steffen Trumtrar <s.trumtrar@pengutronix.de> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, linux-fbdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org Subject: Re: [PATCH 2/2 v6] of: add generic videomode description Date: Mon, 08 Oct 2012 14:19:49 +0200 [thread overview] Message-ID: <1811676.DhpfCA3vWz@avalon> (raw) In-Reply-To: <20121008075741.GC20800@pengutronix.de> Hi Steffen, On Monday 08 October 2012 09:57:41 Steffen Trumtrar wrote: > On Mon, Oct 08, 2012 at 10:21:53AM +0300, Tomi Valkeinen wrote: > > On Thu, 2012-10-04 at 19:59 +0200, Steffen Trumtrar wrote: [snip] > > > diff --git a/include/linux/of_videomode.h b/include/linux/of_videomode.h > > > new file mode 100644 > > > index 0000000..96efe01 > > > --- /dev/null > > > +++ b/include/linux/of_videomode.h > > > @@ -0,0 +1,41 @@ > > > +/* > > > + * Copyright 2012 Steffen Trumtrar <s.trumtrar@pengutronix.de> > > > + * > > > + * generic videomode description > > > + * > > > + * This file is released under the GPLv2 > > > + */ > > > + > > > +#ifndef __LINUX_VIDEOMODE_H > > > +#define __LINUX_VIDEOMODE_H > > > + > > > +#include <drm/drmP.h> > > > > You don't need to include this. > > That is a fix to my liking. Easily done ;-) > > > > +struct videomode { > > > + u32 pixelclock; > > > + u32 refreshrate; > > > + > > > + u32 hactive; > > > + u32 hfront_porch; > > > + u32 hback_porch; > > > + u32 hsync_len; > > > + > > > + u32 vactive; > > > + u32 vfront_porch; > > > + u32 vback_porch; > > > + u32 vsync_len; > > > + > > > + bool hah; > > > + bool vah; > > > + bool interlaced; > > > + bool doublescan; > > > + > > > +}; > > > > This is not really of related. And actually, neither is the struct > > signal_timing in the previous patch. It would be nice to have these in a > > common header that fb, drm, and others could use instead of each having > > their own timing structs. > > > > But that's probably out of scope for this series =). Did you check the > > timing structs from the video related frameworks in the kernel to see if > > your structs contain all the info the others have, so that, at least in > > theory, everybody could use these common structs? > > > > Tomi > > Yes. Stephen and Laurent already suggested to split it up. > No, all info is not contained. That starts with drm, which has width-mm,.. > If time permits, I will go over that. Just to make sure we won't forget it, the V4L2 version of the timings structure is struct v4l2_bt_timings in include/linux/videodev2.h. -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Steffen Trumtrar <s.trumtrar@pengutronix.de> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, linux-fbdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org Subject: Re: [PATCH 2/2 v6] of: add generic videomode description Date: Mon, 08 Oct 2012 12:19:49 +0000 [thread overview] Message-ID: <1811676.DhpfCA3vWz@avalon> (raw) In-Reply-To: <20121008075741.GC20800@pengutronix.de> Hi Steffen, On Monday 08 October 2012 09:57:41 Steffen Trumtrar wrote: > On Mon, Oct 08, 2012 at 10:21:53AM +0300, Tomi Valkeinen wrote: > > On Thu, 2012-10-04 at 19:59 +0200, Steffen Trumtrar wrote: [snip] > > > diff --git a/include/linux/of_videomode.h b/include/linux/of_videomode.h > > > new file mode 100644 > > > index 0000000..96efe01 > > > --- /dev/null > > > +++ b/include/linux/of_videomode.h > > > @@ -0,0 +1,41 @@ > > > +/* > > > + * Copyright 2012 Steffen Trumtrar <s.trumtrar@pengutronix.de> > > > + * > > > + * generic videomode description > > > + * > > > + * This file is released under the GPLv2 > > > + */ > > > + > > > +#ifndef __LINUX_VIDEOMODE_H > > > +#define __LINUX_VIDEOMODE_H > > > + > > > +#include <drm/drmP.h> > > > > You don't need to include this. > > That is a fix to my liking. Easily done ;-) > > > > +struct videomode { > > > + u32 pixelclock; > > > + u32 refreshrate; > > > + > > > + u32 hactive; > > > + u32 hfront_porch; > > > + u32 hback_porch; > > > + u32 hsync_len; > > > + > > > + u32 vactive; > > > + u32 vfront_porch; > > > + u32 vback_porch; > > > + u32 vsync_len; > > > + > > > + bool hah; > > > + bool vah; > > > + bool interlaced; > > > + bool doublescan; > > > + > > > +}; > > > > This is not really of related. And actually, neither is the struct > > signal_timing in the previous patch. It would be nice to have these in a > > common header that fb, drm, and others could use instead of each having > > their own timing structs. > > > > But that's probably out of scope for this series =). Did you check the > > timing structs from the video related frameworks in the kernel to see if > > your structs contain all the info the others have, so that, at least in > > theory, everybody could use these common structs? > > > > Tomi > > Yes. Stephen and Laurent already suggested to split it up. > No, all info is not contained. That starts with drm, which has width-mm,.. > If time permits, I will go over that. Just to make sure we won't forget it, the V4L2 version of the timings structure is struct v4l2_bt_timings in include/linux/videodev2.h. -- Regards, Laurent Pinchart
next prev parent reply other threads:[~2012-10-08 12:19 UTC|newest] Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-10-04 17:59 [PATCH 0/2 v6] of: add display helper Steffen Trumtrar 2012-10-04 17:59 ` Steffen Trumtrar 2012-10-04 17:59 ` Steffen Trumtrar 2012-10-04 17:59 ` [PATCH 1/2 v6] of: add helper to parse display timings Steffen Trumtrar 2012-10-04 17:59 ` Steffen Trumtrar 2012-10-04 17:59 ` Steffen Trumtrar 2012-10-04 18:47 ` Stephen Warren 2012-10-04 18:47 ` Stephen Warren [not found] ` <506DD9B4.40409-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2012-10-05 16:16 ` Steffen Trumtrar 2012-10-05 16:16 ` Steffen Trumtrar 2012-10-05 16:16 ` Steffen Trumtrar 2012-10-05 16:21 ` Stephen Warren 2012-10-05 16:21 ` Stephen Warren 2012-10-05 16:38 ` Steffen Trumtrar 2012-10-05 16:38 ` Steffen Trumtrar 2012-10-07 13:38 ` Laurent Pinchart 2012-10-07 13:38 ` Laurent Pinchart 2012-10-08 7:34 ` Steffen Trumtrar 2012-10-08 7:34 ` Steffen Trumtrar [not found] ` <1349373560-11128-2-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2012-10-04 21:35 ` Guennadi Liakhovetski 2012-10-04 21:35 ` Guennadi Liakhovetski 2012-10-04 21:35 ` Guennadi Liakhovetski 2012-10-05 7:17 ` Robert Schwebel 2012-10-05 7:17 ` Robert Schwebel 2012-10-05 16:17 ` Stephen Warren 2012-10-05 16:17 ` Stephen Warren 2012-10-08 8:25 ` Guennadi Liakhovetski 2012-10-08 8:25 ` Guennadi Liakhovetski 2012-10-08 9:01 ` Tomi Valkeinen 2012-10-08 9:01 ` Tomi Valkeinen 2012-10-08 12:04 ` Laurent Pinchart 2012-10-08 12:04 ` Laurent Pinchart 2012-10-08 12:20 ` Tomi Valkeinen 2012-10-08 12:20 ` Tomi Valkeinen 2012-10-08 16:12 ` Stephen Warren 2012-10-08 16:12 ` Stephen Warren 2012-10-08 16:12 ` Stephen Warren 2012-10-08 16:34 ` Mitch Bradley 2012-10-08 16:34 ` Mitch Bradley 2012-10-08 16:34 ` Mitch Bradley 2012-10-08 16:10 ` Stephen Warren 2012-10-08 16:10 ` Stephen Warren 2012-10-08 17:33 ` Laurent Pinchart 2012-10-08 17:33 ` Laurent Pinchart [not found] ` <Pine.LNX.4.64.1210042307300.3744-0199iw4Nj15frtckUFj5Ag@public.gmane.org> 2012-10-05 16:28 ` Steffen Trumtrar 2012-10-05 16:28 ` Steffen Trumtrar 2012-10-05 16:28 ` Steffen Trumtrar 2012-10-08 7:07 ` Tomi Valkeinen 2012-10-08 7:07 ` Tomi Valkeinen 2012-10-08 7:12 ` Tomi Valkeinen 2012-10-08 7:12 ` Tomi Valkeinen 2012-10-08 7:49 ` Steffen Trumtrar 2012-10-08 7:49 ` Steffen Trumtrar [not found] ` <20121008074921.GB20800-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2012-10-11 19:31 ` Thierry Reding 2012-10-11 19:31 ` Thierry Reding 2012-10-11 19:31 ` Thierry Reding 2012-10-12 7:21 ` Steffen Trumtrar 2012-10-12 7:21 ` Steffen Trumtrar 2012-10-20 10:58 ` Thierry Reding 2012-10-20 10:58 ` Thierry Reding 2012-10-20 19:59 ` Thierry Reding 2012-10-20 19:59 ` Thierry Reding 2012-10-22 7:40 ` Steffen Trumtrar 2012-10-22 7:40 ` Steffen Trumtrar 2012-10-04 17:59 ` [PATCH 2/2 v6] of: add generic videomode description Steffen Trumtrar 2012-10-04 17:59 ` Steffen Trumtrar 2012-10-04 17:59 ` Steffen Trumtrar 2012-10-04 18:51 ` Stephen Warren 2012-10-04 18:51 ` Stephen Warren 2012-10-05 15:51 ` Steffen Trumtrar 2012-10-05 15:51 ` Steffen Trumtrar 2012-10-07 13:38 ` Laurent Pinchart 2012-10-07 13:38 ` Laurent Pinchart 2012-10-20 10:45 ` Thierry Reding 2012-10-20 10:45 ` Thierry Reding 2012-10-08 7:21 ` Tomi Valkeinen 2012-10-08 7:21 ` Tomi Valkeinen 2012-10-08 7:57 ` Steffen Trumtrar 2012-10-08 7:57 ` Steffen Trumtrar 2012-10-08 12:19 ` Laurent Pinchart [this message] 2012-10-08 12:19 ` Laurent Pinchart 2012-10-08 12:13 ` Laurent Pinchart 2012-10-08 12:13 ` Laurent Pinchart 2012-10-08 12:48 ` Steffen Trumtrar 2012-10-08 12:48 ` Steffen Trumtrar 2012-10-08 20:52 ` Laurent Pinchart 2012-10-08 20:52 ` Laurent Pinchart 2012-10-09 7:26 ` Steffen Trumtrar 2012-10-09 7:26 ` Steffen Trumtrar [not found] ` <20121009072608.GA2519-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2012-10-20 10:54 ` Thierry Reding 2012-10-20 10:54 ` Thierry Reding 2012-10-20 10:54 ` Thierry Reding 2012-10-20 11:04 ` Thierry Reding 2012-10-20 11:04 ` Thierry Reding 2012-10-22 7:35 ` Steffen Trumtrar 2012-10-22 7:35 ` Steffen Trumtrar [not found] ` <1349373560-11128-1-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2012-10-15 10:54 ` [PATCH 0/2 v6] of: add display helper Leela Krishna Amudala 2012-10-15 10:55 ` Leela Krishna Amudala 2012-10-15 10:54 ` Leela Krishna Amudala 2012-10-15 14:17 ` Steffen Trumtrar 2012-10-15 14:17 ` Steffen Trumtrar 2012-10-20 11:35 ` Thierry Reding 2012-10-20 11:35 ` Thierry Reding
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1811676.DhpfCA3vWz@avalon \ --to=laurent.pinchart@ideasonboard.com \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=s.trumtrar@pengutronix.de \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.