From: Stephen Warren <swarren@wwwdotorg.org>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: devicetree-discuss@lists.ozlabs.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2 v6] of: add generic videomode description
Date: Thu, 04 Oct 2012 12:51:00 -0600 [thread overview]
Message-ID: <506DDA94.1090702@wwwdotorg.org> (raw)
In-Reply-To: <1349373560-11128-3-git-send-email-s.trumtrar@pengutronix.de>
On 10/04/2012 11:59 AM, Steffen Trumtrar wrote:
> Get videomode from devicetree in a format appropriate for the
> backend. drm_display_mode and fb_videomode are supported atm.
> Uses the display signal timings from of_display_timings
> +++ b/drivers/of/of_videomode.c
> +int videomode_from_timing(struct display_timings *disp, struct videomode *vm,
> + st = display_timings_get(disp, index);
> +
> + if (!st) {
It's a little odd to leave a blank line between those two lines.
Only half of the code in this file seems OF-related; the routines to
convert a timing to a videomode or drm display mode seem like they'd be
useful outside device tree, so I wonder if putting them into
of_videomode.c is the correct thing to do. Still, it's probably not a
big deal.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: devicetree-discuss@lists.ozlabs.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2 v6] of: add generic videomode description
Date: Thu, 04 Oct 2012 18:51:00 +0000 [thread overview]
Message-ID: <506DDA94.1090702@wwwdotorg.org> (raw)
In-Reply-To: <1349373560-11128-3-git-send-email-s.trumtrar@pengutronix.de>
On 10/04/2012 11:59 AM, Steffen Trumtrar wrote:
> Get videomode from devicetree in a format appropriate for the
> backend. drm_display_mode and fb_videomode are supported atm.
> Uses the display signal timings from of_display_timings
> +++ b/drivers/of/of_videomode.c
> +int videomode_from_timing(struct display_timings *disp, struct videomode *vm,
> + st = display_timings_get(disp, index);
> +
> + if (!st) {
It's a little odd to leave a blank line between those two lines.
Only half of the code in this file seems OF-related; the routines to
convert a timing to a videomode or drm display mode seem like they'd be
useful outside device tree, so I wonder if putting them into
of_videomode.c is the correct thing to do. Still, it's probably not a
big deal.
next prev parent reply other threads:[~2012-10-04 18:51 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 17:59 [PATCH 0/2 v6] of: add display helper Steffen Trumtrar
2012-10-04 17:59 ` Steffen Trumtrar
2012-10-04 17:59 ` Steffen Trumtrar
2012-10-04 17:59 ` [PATCH 1/2 v6] of: add helper to parse display timings Steffen Trumtrar
2012-10-04 17:59 ` Steffen Trumtrar
2012-10-04 17:59 ` Steffen Trumtrar
2012-10-04 18:47 ` Stephen Warren
2012-10-04 18:47 ` Stephen Warren
[not found] ` <506DD9B4.40409-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-05 16:16 ` Steffen Trumtrar
2012-10-05 16:16 ` Steffen Trumtrar
2012-10-05 16:16 ` Steffen Trumtrar
2012-10-05 16:21 ` Stephen Warren
2012-10-05 16:21 ` Stephen Warren
2012-10-05 16:38 ` Steffen Trumtrar
2012-10-05 16:38 ` Steffen Trumtrar
2012-10-07 13:38 ` Laurent Pinchart
2012-10-07 13:38 ` Laurent Pinchart
2012-10-08 7:34 ` Steffen Trumtrar
2012-10-08 7:34 ` Steffen Trumtrar
[not found] ` <1349373560-11128-2-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-10-04 21:35 ` Guennadi Liakhovetski
2012-10-04 21:35 ` Guennadi Liakhovetski
2012-10-04 21:35 ` Guennadi Liakhovetski
2012-10-05 7:17 ` Robert Schwebel
2012-10-05 7:17 ` Robert Schwebel
2012-10-05 16:17 ` Stephen Warren
2012-10-05 16:17 ` Stephen Warren
2012-10-08 8:25 ` Guennadi Liakhovetski
2012-10-08 8:25 ` Guennadi Liakhovetski
2012-10-08 9:01 ` Tomi Valkeinen
2012-10-08 9:01 ` Tomi Valkeinen
2012-10-08 12:04 ` Laurent Pinchart
2012-10-08 12:04 ` Laurent Pinchart
2012-10-08 12:20 ` Tomi Valkeinen
2012-10-08 12:20 ` Tomi Valkeinen
2012-10-08 16:12 ` Stephen Warren
2012-10-08 16:12 ` Stephen Warren
2012-10-08 16:12 ` Stephen Warren
2012-10-08 16:34 ` Mitch Bradley
2012-10-08 16:34 ` Mitch Bradley
2012-10-08 16:34 ` Mitch Bradley
2012-10-08 16:10 ` Stephen Warren
2012-10-08 16:10 ` Stephen Warren
2012-10-08 17:33 ` Laurent Pinchart
2012-10-08 17:33 ` Laurent Pinchart
[not found] ` <Pine.LNX.4.64.1210042307300.3744-0199iw4Nj15frtckUFj5Ag@public.gmane.org>
2012-10-05 16:28 ` Steffen Trumtrar
2012-10-05 16:28 ` Steffen Trumtrar
2012-10-05 16:28 ` Steffen Trumtrar
2012-10-08 7:07 ` Tomi Valkeinen
2012-10-08 7:07 ` Tomi Valkeinen
2012-10-08 7:12 ` Tomi Valkeinen
2012-10-08 7:12 ` Tomi Valkeinen
2012-10-08 7:49 ` Steffen Trumtrar
2012-10-08 7:49 ` Steffen Trumtrar
[not found] ` <20121008074921.GB20800-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-10-11 19:31 ` Thierry Reding
2012-10-11 19:31 ` Thierry Reding
2012-10-11 19:31 ` Thierry Reding
2012-10-12 7:21 ` Steffen Trumtrar
2012-10-12 7:21 ` Steffen Trumtrar
2012-10-20 10:58 ` Thierry Reding
2012-10-20 10:58 ` Thierry Reding
2012-10-20 19:59 ` Thierry Reding
2012-10-20 19:59 ` Thierry Reding
2012-10-22 7:40 ` Steffen Trumtrar
2012-10-22 7:40 ` Steffen Trumtrar
2012-10-04 17:59 ` [PATCH 2/2 v6] of: add generic videomode description Steffen Trumtrar
2012-10-04 17:59 ` Steffen Trumtrar
2012-10-04 17:59 ` Steffen Trumtrar
2012-10-04 18:51 ` Stephen Warren [this message]
2012-10-04 18:51 ` Stephen Warren
2012-10-05 15:51 ` Steffen Trumtrar
2012-10-05 15:51 ` Steffen Trumtrar
2012-10-07 13:38 ` Laurent Pinchart
2012-10-07 13:38 ` Laurent Pinchart
2012-10-20 10:45 ` Thierry Reding
2012-10-20 10:45 ` Thierry Reding
2012-10-08 7:21 ` Tomi Valkeinen
2012-10-08 7:21 ` Tomi Valkeinen
2012-10-08 7:57 ` Steffen Trumtrar
2012-10-08 7:57 ` Steffen Trumtrar
2012-10-08 12:19 ` Laurent Pinchart
2012-10-08 12:19 ` Laurent Pinchart
2012-10-08 12:13 ` Laurent Pinchart
2012-10-08 12:13 ` Laurent Pinchart
2012-10-08 12:48 ` Steffen Trumtrar
2012-10-08 12:48 ` Steffen Trumtrar
2012-10-08 20:52 ` Laurent Pinchart
2012-10-08 20:52 ` Laurent Pinchart
2012-10-09 7:26 ` Steffen Trumtrar
2012-10-09 7:26 ` Steffen Trumtrar
[not found] ` <20121009072608.GA2519-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-10-20 10:54 ` Thierry Reding
2012-10-20 10:54 ` Thierry Reding
2012-10-20 10:54 ` Thierry Reding
2012-10-20 11:04 ` Thierry Reding
2012-10-20 11:04 ` Thierry Reding
2012-10-22 7:35 ` Steffen Trumtrar
2012-10-22 7:35 ` Steffen Trumtrar
[not found] ` <1349373560-11128-1-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-10-15 10:54 ` [PATCH 0/2 v6] of: add display helper Leela Krishna Amudala
2012-10-15 10:55 ` Leela Krishna Amudala
2012-10-15 10:54 ` Leela Krishna Amudala
2012-10-15 14:17 ` Steffen Trumtrar
2012-10-15 14:17 ` Steffen Trumtrar
2012-10-20 11:35 ` Thierry Reding
2012-10-20 11:35 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506DDA94.1090702@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=s.trumtrar@pengutronix.de \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.