From: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
To: Tomi Valkeinen <tomi.valkeinen-l0cyMroinI0@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2 v6] of: add helper to parse display timings
Date: Thu, 11 Oct 2012 21:31:18 +0200 [thread overview]
Message-ID: <20121011193118.GA27599@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <20121008074921.GB20800-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 454 bytes --]
On Mon, Oct 08, 2012 at 09:49:21AM +0200, Steffen Trumtrar wrote:
> On Mon, Oct 08, 2012 at 10:07:45AM +0300, Tomi Valkeinen wrote:
> > On Thu, 2012-10-04 at 19:59 +0200, Steffen Trumtrar wrote:
[...]
> > > +
> > > + disp->num_timings = 0;
> > > +
> > > + for_each_child_of_node(timings_np, entry) {
> > > + disp->num_timings++;
> > > + }
> >
> > No need for { }
> >
>
> Okay.
Or you could just use of_get_child_count().
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 192 bytes --]
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@avionic-design.de>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>,
devicetree-discuss@lists.ozlabs.org,
Rob Herring <robherring2@gmail.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/2 v6] of: add helper to parse display timings
Date: Thu, 11 Oct 2012 21:31:18 +0200 [thread overview]
Message-ID: <20121011193118.GA27599@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <20121008074921.GB20800@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 454 bytes --]
On Mon, Oct 08, 2012 at 09:49:21AM +0200, Steffen Trumtrar wrote:
> On Mon, Oct 08, 2012 at 10:07:45AM +0300, Tomi Valkeinen wrote:
> > On Thu, 2012-10-04 at 19:59 +0200, Steffen Trumtrar wrote:
[...]
> > > +
> > > + disp->num_timings = 0;
> > > +
> > > + for_each_child_of_node(timings_np, entry) {
> > > + disp->num_timings++;
> > > + }
> >
> > No need for { }
> >
>
> Okay.
Or you could just use of_get_child_count().
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@avionic-design.de>
To: Tomi Valkeinen <tomi.valkeinen-l0cyMroinI0@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2 v6] of: add helper to parse display timings
Date: Thu, 11 Oct 2012 19:31:18 +0000 [thread overview]
Message-ID: <20121011193118.GA27599@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <20121008074921.GB20800-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 454 bytes --]
On Mon, Oct 08, 2012 at 09:49:21AM +0200, Steffen Trumtrar wrote:
> On Mon, Oct 08, 2012 at 10:07:45AM +0300, Tomi Valkeinen wrote:
> > On Thu, 2012-10-04 at 19:59 +0200, Steffen Trumtrar wrote:
[...]
> > > +
> > > + disp->num_timings = 0;
> > > +
> > > + for_each_child_of_node(timings_np, entry) {
> > > + disp->num_timings++;
> > > + }
> >
> > No need for { }
> >
>
> Okay.
Or you could just use of_get_child_count().
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-10-11 19:31 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 17:59 [PATCH 0/2 v6] of: add display helper Steffen Trumtrar
2012-10-04 17:59 ` Steffen Trumtrar
2012-10-04 17:59 ` Steffen Trumtrar
2012-10-04 17:59 ` [PATCH 1/2 v6] of: add helper to parse display timings Steffen Trumtrar
2012-10-04 17:59 ` Steffen Trumtrar
2012-10-04 17:59 ` Steffen Trumtrar
2012-10-04 18:47 ` Stephen Warren
2012-10-04 18:47 ` Stephen Warren
[not found] ` <506DD9B4.40409-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-05 16:16 ` Steffen Trumtrar
2012-10-05 16:16 ` Steffen Trumtrar
2012-10-05 16:16 ` Steffen Trumtrar
2012-10-05 16:21 ` Stephen Warren
2012-10-05 16:21 ` Stephen Warren
2012-10-05 16:38 ` Steffen Trumtrar
2012-10-05 16:38 ` Steffen Trumtrar
2012-10-07 13:38 ` Laurent Pinchart
2012-10-07 13:38 ` Laurent Pinchart
2012-10-08 7:34 ` Steffen Trumtrar
2012-10-08 7:34 ` Steffen Trumtrar
[not found] ` <1349373560-11128-2-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-10-04 21:35 ` Guennadi Liakhovetski
2012-10-04 21:35 ` Guennadi Liakhovetski
2012-10-04 21:35 ` Guennadi Liakhovetski
2012-10-05 7:17 ` Robert Schwebel
2012-10-05 7:17 ` Robert Schwebel
2012-10-05 16:17 ` Stephen Warren
2012-10-05 16:17 ` Stephen Warren
2012-10-08 8:25 ` Guennadi Liakhovetski
2012-10-08 8:25 ` Guennadi Liakhovetski
2012-10-08 9:01 ` Tomi Valkeinen
2012-10-08 9:01 ` Tomi Valkeinen
2012-10-08 12:04 ` Laurent Pinchart
2012-10-08 12:04 ` Laurent Pinchart
2012-10-08 12:20 ` Tomi Valkeinen
2012-10-08 12:20 ` Tomi Valkeinen
2012-10-08 16:12 ` Stephen Warren
2012-10-08 16:12 ` Stephen Warren
2012-10-08 16:12 ` Stephen Warren
2012-10-08 16:34 ` Mitch Bradley
2012-10-08 16:34 ` Mitch Bradley
2012-10-08 16:34 ` Mitch Bradley
2012-10-08 16:10 ` Stephen Warren
2012-10-08 16:10 ` Stephen Warren
2012-10-08 17:33 ` Laurent Pinchart
2012-10-08 17:33 ` Laurent Pinchart
[not found] ` <Pine.LNX.4.64.1210042307300.3744-0199iw4Nj15frtckUFj5Ag@public.gmane.org>
2012-10-05 16:28 ` Steffen Trumtrar
2012-10-05 16:28 ` Steffen Trumtrar
2012-10-05 16:28 ` Steffen Trumtrar
2012-10-08 7:07 ` Tomi Valkeinen
2012-10-08 7:07 ` Tomi Valkeinen
2012-10-08 7:12 ` Tomi Valkeinen
2012-10-08 7:12 ` Tomi Valkeinen
2012-10-08 7:49 ` Steffen Trumtrar
2012-10-08 7:49 ` Steffen Trumtrar
[not found] ` <20121008074921.GB20800-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-10-11 19:31 ` Thierry Reding [this message]
2012-10-11 19:31 ` Thierry Reding
2012-10-11 19:31 ` Thierry Reding
2012-10-12 7:21 ` Steffen Trumtrar
2012-10-12 7:21 ` Steffen Trumtrar
2012-10-20 10:58 ` Thierry Reding
2012-10-20 10:58 ` Thierry Reding
2012-10-20 19:59 ` Thierry Reding
2012-10-20 19:59 ` Thierry Reding
2012-10-22 7:40 ` Steffen Trumtrar
2012-10-22 7:40 ` Steffen Trumtrar
2012-10-04 17:59 ` [PATCH 2/2 v6] of: add generic videomode description Steffen Trumtrar
2012-10-04 17:59 ` Steffen Trumtrar
2012-10-04 17:59 ` Steffen Trumtrar
2012-10-04 18:51 ` Stephen Warren
2012-10-04 18:51 ` Stephen Warren
2012-10-05 15:51 ` Steffen Trumtrar
2012-10-05 15:51 ` Steffen Trumtrar
2012-10-07 13:38 ` Laurent Pinchart
2012-10-07 13:38 ` Laurent Pinchart
2012-10-20 10:45 ` Thierry Reding
2012-10-20 10:45 ` Thierry Reding
2012-10-08 7:21 ` Tomi Valkeinen
2012-10-08 7:21 ` Tomi Valkeinen
2012-10-08 7:57 ` Steffen Trumtrar
2012-10-08 7:57 ` Steffen Trumtrar
2012-10-08 12:19 ` Laurent Pinchart
2012-10-08 12:19 ` Laurent Pinchart
2012-10-08 12:13 ` Laurent Pinchart
2012-10-08 12:13 ` Laurent Pinchart
2012-10-08 12:48 ` Steffen Trumtrar
2012-10-08 12:48 ` Steffen Trumtrar
2012-10-08 20:52 ` Laurent Pinchart
2012-10-08 20:52 ` Laurent Pinchart
2012-10-09 7:26 ` Steffen Trumtrar
2012-10-09 7:26 ` Steffen Trumtrar
[not found] ` <20121009072608.GA2519-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-10-20 10:54 ` Thierry Reding
2012-10-20 10:54 ` Thierry Reding
2012-10-20 10:54 ` Thierry Reding
2012-10-20 11:04 ` Thierry Reding
2012-10-20 11:04 ` Thierry Reding
2012-10-22 7:35 ` Steffen Trumtrar
2012-10-22 7:35 ` Steffen Trumtrar
[not found] ` <1349373560-11128-1-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-10-15 10:54 ` [PATCH 0/2 v6] of: add display helper Leela Krishna Amudala
2012-10-15 10:55 ` Leela Krishna Amudala
2012-10-15 10:54 ` Leela Krishna Amudala
2012-10-15 14:17 ` Steffen Trumtrar
2012-10-15 14:17 ` Steffen Trumtrar
2012-10-20 11:35 ` Thierry Reding
2012-10-20 11:35 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121011193118.GA27599@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding-rm9k5ik7kjkj5m59nbduvrnah6klmebb@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tomi.valkeinen-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.