From: Stephen Warren <swarren@wwwdotorg.org> To: devicetree-discuss@lists.ozlabs.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Tomi Valkeinen <tomi.valkeinen@ti.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, linux-media@vger.kernel.org Subject: Re: [PATCH 1/2 v6] of: add helper to parse display timings Date: Fri, 05 Oct 2012 10:21:37 -0600 [thread overview] Message-ID: <506F0911.1050808@wwwdotorg.org> (raw) In-Reply-To: <20121005161620.GB2053@pengutronix.de> On 10/05/2012 10:16 AM, Steffen Trumtrar wrote: > On Thu, Oct 04, 2012 at 12:47:16PM -0600, Stephen Warren wrote: >> On 10/04/2012 11:59 AM, Steffen Trumtrar wrote: ... >>> + for_each_child_of_node(timings_np, entry) { >>> + struct signal_timing *st; >>> + >>> + st = of_get_display_timing(entry); >>> + >>> + if (!st) >>> + continue; >> >> I wonder if that shouldn't be an error? > > In the sense of a pr_err not a -EINVAL I presume?! It is a little bit quiet in > case of a faulty spec, that is right. I did mean return an error; if we try to parse something and can't, shouldn't we return an error? I suppose it may be possible to limp on and use whatever subset of modes could be parsed and drop the others, which is what this code does, but the code after the loop would definitely return an error if zero timings were parseable.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org> To: devicetree-discuss@lists.ozlabs.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Tomi Valkeinen <tomi.valkeinen@ti.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, linux-media@vger.kernel.org Subject: Re: [PATCH 1/2 v6] of: add helper to parse display timings Date: Fri, 05 Oct 2012 16:21:37 +0000 [thread overview] Message-ID: <506F0911.1050808@wwwdotorg.org> (raw) In-Reply-To: <20121005161620.GB2053@pengutronix.de> On 10/05/2012 10:16 AM, Steffen Trumtrar wrote: > On Thu, Oct 04, 2012 at 12:47:16PM -0600, Stephen Warren wrote: >> On 10/04/2012 11:59 AM, Steffen Trumtrar wrote: ... >>> + for_each_child_of_node(timings_np, entry) { >>> + struct signal_timing *st; >>> + >>> + st = of_get_display_timing(entry); >>> + >>> + if (!st) >>> + continue; >> >> I wonder if that shouldn't be an error? > > In the sense of a pr_err not a -EINVAL I presume?! It is a little bit quiet in > case of a faulty spec, that is right. I did mean return an error; if we try to parse something and can't, shouldn't we return an error? I suppose it may be possible to limp on and use whatever subset of modes could be parsed and drop the others, which is what this code does, but the code after the loop would definitely return an error if zero timings were parseable.
next prev parent reply other threads:[~2012-10-05 16:21 UTC|newest] Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-10-04 17:59 [PATCH 0/2 v6] of: add display helper Steffen Trumtrar 2012-10-04 17:59 ` Steffen Trumtrar 2012-10-04 17:59 ` Steffen Trumtrar 2012-10-04 17:59 ` [PATCH 1/2 v6] of: add helper to parse display timings Steffen Trumtrar 2012-10-04 17:59 ` Steffen Trumtrar 2012-10-04 17:59 ` Steffen Trumtrar 2012-10-04 18:47 ` Stephen Warren 2012-10-04 18:47 ` Stephen Warren [not found] ` <506DD9B4.40409-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2012-10-05 16:16 ` Steffen Trumtrar 2012-10-05 16:16 ` Steffen Trumtrar 2012-10-05 16:16 ` Steffen Trumtrar 2012-10-05 16:21 ` Stephen Warren [this message] 2012-10-05 16:21 ` Stephen Warren 2012-10-05 16:38 ` Steffen Trumtrar 2012-10-05 16:38 ` Steffen Trumtrar 2012-10-07 13:38 ` Laurent Pinchart 2012-10-07 13:38 ` Laurent Pinchart 2012-10-08 7:34 ` Steffen Trumtrar 2012-10-08 7:34 ` Steffen Trumtrar [not found] ` <1349373560-11128-2-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2012-10-04 21:35 ` Guennadi Liakhovetski 2012-10-04 21:35 ` Guennadi Liakhovetski 2012-10-04 21:35 ` Guennadi Liakhovetski 2012-10-05 7:17 ` Robert Schwebel 2012-10-05 7:17 ` Robert Schwebel 2012-10-05 16:17 ` Stephen Warren 2012-10-05 16:17 ` Stephen Warren 2012-10-08 8:25 ` Guennadi Liakhovetski 2012-10-08 8:25 ` Guennadi Liakhovetski 2012-10-08 9:01 ` Tomi Valkeinen 2012-10-08 9:01 ` Tomi Valkeinen 2012-10-08 12:04 ` Laurent Pinchart 2012-10-08 12:04 ` Laurent Pinchart 2012-10-08 12:20 ` Tomi Valkeinen 2012-10-08 12:20 ` Tomi Valkeinen 2012-10-08 16:12 ` Stephen Warren 2012-10-08 16:12 ` Stephen Warren 2012-10-08 16:12 ` Stephen Warren 2012-10-08 16:34 ` Mitch Bradley 2012-10-08 16:34 ` Mitch Bradley 2012-10-08 16:34 ` Mitch Bradley 2012-10-08 16:10 ` Stephen Warren 2012-10-08 16:10 ` Stephen Warren 2012-10-08 17:33 ` Laurent Pinchart 2012-10-08 17:33 ` Laurent Pinchart [not found] ` <Pine.LNX.4.64.1210042307300.3744-0199iw4Nj15frtckUFj5Ag@public.gmane.org> 2012-10-05 16:28 ` Steffen Trumtrar 2012-10-05 16:28 ` Steffen Trumtrar 2012-10-05 16:28 ` Steffen Trumtrar 2012-10-08 7:07 ` Tomi Valkeinen 2012-10-08 7:07 ` Tomi Valkeinen 2012-10-08 7:12 ` Tomi Valkeinen 2012-10-08 7:12 ` Tomi Valkeinen 2012-10-08 7:49 ` Steffen Trumtrar 2012-10-08 7:49 ` Steffen Trumtrar [not found] ` <20121008074921.GB20800-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2012-10-11 19:31 ` Thierry Reding 2012-10-11 19:31 ` Thierry Reding 2012-10-11 19:31 ` Thierry Reding 2012-10-12 7:21 ` Steffen Trumtrar 2012-10-12 7:21 ` Steffen Trumtrar 2012-10-20 10:58 ` Thierry Reding 2012-10-20 10:58 ` Thierry Reding 2012-10-20 19:59 ` Thierry Reding 2012-10-20 19:59 ` Thierry Reding 2012-10-22 7:40 ` Steffen Trumtrar 2012-10-22 7:40 ` Steffen Trumtrar 2012-10-04 17:59 ` [PATCH 2/2 v6] of: add generic videomode description Steffen Trumtrar 2012-10-04 17:59 ` Steffen Trumtrar 2012-10-04 17:59 ` Steffen Trumtrar 2012-10-04 18:51 ` Stephen Warren 2012-10-04 18:51 ` Stephen Warren 2012-10-05 15:51 ` Steffen Trumtrar 2012-10-05 15:51 ` Steffen Trumtrar 2012-10-07 13:38 ` Laurent Pinchart 2012-10-07 13:38 ` Laurent Pinchart 2012-10-20 10:45 ` Thierry Reding 2012-10-20 10:45 ` Thierry Reding 2012-10-08 7:21 ` Tomi Valkeinen 2012-10-08 7:21 ` Tomi Valkeinen 2012-10-08 7:57 ` Steffen Trumtrar 2012-10-08 7:57 ` Steffen Trumtrar 2012-10-08 12:19 ` Laurent Pinchart 2012-10-08 12:19 ` Laurent Pinchart 2012-10-08 12:13 ` Laurent Pinchart 2012-10-08 12:13 ` Laurent Pinchart 2012-10-08 12:48 ` Steffen Trumtrar 2012-10-08 12:48 ` Steffen Trumtrar 2012-10-08 20:52 ` Laurent Pinchart 2012-10-08 20:52 ` Laurent Pinchart 2012-10-09 7:26 ` Steffen Trumtrar 2012-10-09 7:26 ` Steffen Trumtrar [not found] ` <20121009072608.GA2519-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2012-10-20 10:54 ` Thierry Reding 2012-10-20 10:54 ` Thierry Reding 2012-10-20 10:54 ` Thierry Reding 2012-10-20 11:04 ` Thierry Reding 2012-10-20 11:04 ` Thierry Reding 2012-10-22 7:35 ` Steffen Trumtrar 2012-10-22 7:35 ` Steffen Trumtrar [not found] ` <1349373560-11128-1-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2012-10-15 10:54 ` [PATCH 0/2 v6] of: add display helper Leela Krishna Amudala 2012-10-15 10:55 ` Leela Krishna Amudala 2012-10-15 10:54 ` Leela Krishna Amudala 2012-10-15 14:17 ` Steffen Trumtrar 2012-10-15 14:17 ` Steffen Trumtrar 2012-10-20 11:35 ` Thierry Reding 2012-10-20 11:35 ` Thierry Reding
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=506F0911.1050808@wwwdotorg.org \ --to=swarren@wwwdotorg.org \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.