From: Jan Kara <jack@suse.cz> To: Dan Williams <dan.j.williams@intel.com> Cc: Jan Kara <jack@suse.cz>, Matthew Wilcox <mawilcox@microsoft.com>, x86@kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de> Subject: Re: [PATCH v4 13/14] libnvdimm, pmem: gate cache management on QUEUE_FLAG_WC in pmem_dax_flush() Date: Thu, 15 Jun 2017 10:09:11 +0200 [thread overview] Message-ID: <20170615080911.GC1764@quack2.suse.cz> (raw) In-Reply-To: <149748185051.10107.3746460181917620940.stgit@dwillia2-desk3.amr.corp.intel.com> On Wed 14-06-17 16:11:26, Dan Williams wrote: > Some platforms arrange for cpu caches to be flushed on power-fail. On > those platforms there is no requirement that the kernel track and flush > potentially dirty cache lines. Given that we still insert entries into > the radix for locking purposes this patch only disables the cache flush > loop, not the dirty tracking. > > Userspace can override the default cache setting via the block device > queue "write_cache" attribute in sysfs. > > Cc: Jeff Moyer <jmoyer@redhat.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Matthew Wilcox <mawilcox@microsoft.com> > Cc: Ross Zwisler <ross.zwisler@linux.intel.com> > Suggested-by: Jan Kara <jack@suse.cz> > Signed-off-by: Dan Williams <dan.j.williams@intel.com> Looks good. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > Changes since v3: > * move the check of QUEUE_FLAG_WC into the pmem driver directly (Jan) > > drivers/nvdimm/pmem.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c > index 06f6c27ec1e9..49938b246a7b 100644 > --- a/drivers/nvdimm/pmem.c > +++ b/drivers/nvdimm/pmem.c > @@ -244,7 +244,16 @@ static size_t pmem_copy_from_iter(struct dax_device *dax_dev, pgoff_t pgoff, > static void pmem_dax_flush(struct dax_device *dax_dev, pgoff_t pgoff, > void *addr, size_t size) > { > - arch_wb_cache_pmem(addr, size); > + struct pmem_device *pmem = dax_get_private(dax_dev); > + struct gendisk *disk = pmem->disk; > + struct request_queue *q = disk->queue; > + > + /* > + * Only perform cache management when the queue has caching > + * enabled. > + */ > + if (test_bit(QUEUE_FLAG_WC, &q->queue_flags)) > + arch_wb_cache_pmem(addr, size); > } > > static const struct dax_operations pmem_dax_ops = { > -- Jan Kara <jack@suse.com> SUSE Labs, CR _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz> To: Dan Williams <dan.j.williams@intel.com> Cc: linux-nvdimm@lists.01.org, Jan Kara <jack@suse.cz>, Matthew Wilcox <mawilcox@microsoft.com>, x86@kernel.org, linux-kernel@vger.kernel.org, Jeff Moyer <jmoyer@redhat.com>, linux-fsdevel@vger.kernel.org, Ross Zwisler <ross.zwisler@linux.intel.com>, Christoph Hellwig <hch@lst.de> Subject: Re: [PATCH v4 13/14] libnvdimm, pmem: gate cache management on QUEUE_FLAG_WC in pmem_dax_flush() Date: Thu, 15 Jun 2017 10:09:11 +0200 [thread overview] Message-ID: <20170615080911.GC1764@quack2.suse.cz> (raw) In-Reply-To: <149748185051.10107.3746460181917620940.stgit@dwillia2-desk3.amr.corp.intel.com> On Wed 14-06-17 16:11:26, Dan Williams wrote: > Some platforms arrange for cpu caches to be flushed on power-fail. On > those platforms there is no requirement that the kernel track and flush > potentially dirty cache lines. Given that we still insert entries into > the radix for locking purposes this patch only disables the cache flush > loop, not the dirty tracking. > > Userspace can override the default cache setting via the block device > queue "write_cache" attribute in sysfs. > > Cc: Jeff Moyer <jmoyer@redhat.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Matthew Wilcox <mawilcox@microsoft.com> > Cc: Ross Zwisler <ross.zwisler@linux.intel.com> > Suggested-by: Jan Kara <jack@suse.cz> > Signed-off-by: Dan Williams <dan.j.williams@intel.com> Looks good. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > Changes since v3: > * move the check of QUEUE_FLAG_WC into the pmem driver directly (Jan) > > drivers/nvdimm/pmem.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c > index 06f6c27ec1e9..49938b246a7b 100644 > --- a/drivers/nvdimm/pmem.c > +++ b/drivers/nvdimm/pmem.c > @@ -244,7 +244,16 @@ static size_t pmem_copy_from_iter(struct dax_device *dax_dev, pgoff_t pgoff, > static void pmem_dax_flush(struct dax_device *dax_dev, pgoff_t pgoff, > void *addr, size_t size) > { > - arch_wb_cache_pmem(addr, size); > + struct pmem_device *pmem = dax_get_private(dax_dev); > + struct gendisk *disk = pmem->disk; > + struct request_queue *q = disk->queue; > + > + /* > + * Only perform cache management when the queue has caching > + * enabled. > + */ > + if (test_bit(QUEUE_FLAG_WC, &q->queue_flags)) > + arch_wb_cache_pmem(addr, size); > } > > static const struct dax_operations pmem_dax_ops = { > -- Jan Kara <jack@suse.com> SUSE Labs, CR
next prev parent reply other threads:[~2017-06-15 8:07 UTC|newest] Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-09 20:23 [PATCH v3 00/14] pmem: stop abusing __copy_user_nocache(), and other reworks Dan Williams 2017-06-09 20:23 ` Dan Williams 2017-06-09 20:23 ` Dan Williams 2017-06-09 20:23 ` [PATCH v3 01/14] x86, uaccess: introduce copy_from_iter_flushcache for pmem / cache-bypass operations Dan Williams 2017-06-09 20:23 ` Dan Williams 2017-06-09 20:23 ` Dan Williams 2017-06-18 8:28 ` Christoph Hellwig 2017-06-18 8:28 ` Christoph Hellwig 2017-06-18 8:28 ` Christoph Hellwig 2017-06-19 2:02 ` Dan Williams 2017-06-19 2:02 ` Dan Williams 2017-06-19 2:02 ` Dan Williams 2017-06-09 20:23 ` [PATCH v3 02/14] dm: add ->copy_from_iter() dax operation support Dan Williams 2017-06-09 20:23 ` Dan Williams 2017-06-09 20:23 ` Dan Williams 2017-06-15 0:46 ` Kani, Toshimitsu 2017-06-15 0:46 ` Kani, Toshimitsu 2017-06-15 0:46 ` Kani, Toshimitsu 2017-06-15 1:21 ` Kani, Toshimitsu 2017-06-15 1:21 ` Kani, Toshimitsu 2017-06-18 8:37 ` Christoph Hellwig 2017-06-18 8:37 ` Christoph Hellwig 2017-06-18 8:37 ` Christoph Hellwig 2017-06-19 2:04 ` Dan Williams 2017-06-19 2:04 ` Dan Williams 2017-06-19 2:04 ` Dan Williams 2017-06-09 20:24 ` [PATCH v3 03/14] filesystem-dax: convert to dax_copy_from_iter() Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-14 10:58 ` Jan Kara 2017-06-14 10:58 ` Jan Kara 2017-06-14 10:58 ` Jan Kara 2017-06-09 20:24 ` [PATCH v3 04/14] dax, pmem: introduce an optional 'flush' dax_operation Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-14 10:57 ` Jan Kara 2017-06-14 10:57 ` Jan Kara 2017-06-14 10:57 ` Jan Kara 2017-06-09 20:24 ` [PATCH v3 05/14] dm: add ->flush() dax operation support Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-15 1:44 ` Kani, Toshimitsu 2017-06-15 1:44 ` Kani, Toshimitsu 2017-06-15 1:44 ` Kani, Toshimitsu 2017-06-09 20:24 ` [PATCH v3 06/14] filesystem-dax: convert to dax_flush() Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-14 10:56 ` Jan Kara 2017-06-14 10:56 ` Jan Kara 2017-06-14 10:56 ` Jan Kara 2017-06-09 20:24 ` [PATCH v3 07/14] x86, dax: replace clear_pmem() with open coded memset + dax_ops->flush Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-14 10:55 ` Jan Kara 2017-06-14 10:55 ` Jan Kara 2017-06-14 10:55 ` Jan Kara 2017-06-09 20:24 ` [PATCH v3 08/14] x86, dax, libnvdimm: move wb_cache_pmem() to libnvdimm Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-12 0:29 ` [PATCH v4 " Dan Williams 2017-06-12 0:29 ` Dan Williams 2017-06-14 10:54 ` [PATCH v3 " Jan Kara 2017-06-14 10:54 ` Jan Kara 2017-06-14 16:49 ` Dan Williams 2017-06-14 16:49 ` Dan Williams 2017-06-14 16:49 ` Dan Williams 2017-06-15 8:11 ` Jan Kara 2017-06-15 8:11 ` Jan Kara 2017-06-15 8:11 ` Jan Kara 2017-06-18 8:40 ` Christoph Hellwig 2017-06-18 8:40 ` Christoph Hellwig 2017-06-18 8:40 ` Christoph Hellwig 2017-06-19 2:06 ` Dan Williams 2017-06-19 2:06 ` Dan Williams 2017-06-19 2:06 ` Dan Williams 2017-06-09 20:24 ` [PATCH v3 09/14] x86, libnvdimm, pmem: move arch_invalidate_pmem() " Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-14 10:49 ` Jan Kara 2017-06-14 10:49 ` Jan Kara 2017-06-09 20:24 ` [PATCH v3 10/14] pmem: remove global pmem api Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-14 10:48 ` Jan Kara 2017-06-14 10:48 ` Jan Kara 2017-06-14 10:48 ` Jan Kara 2017-06-09 20:24 ` [PATCH v3 11/14] libnvdimm, pmem: fix persistence warning Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-09 20:24 ` [PATCH v3 12/14] libnvdimm, nfit: enable support for volatile ranges Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-09 20:24 ` [PATCH v3 13/14] filesystem-dax: gate calls to dax_flush() on QUEUE_FLAG_WC Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-09 20:24 ` Dan Williams 2017-06-14 10:46 ` Jan Kara 2017-06-14 10:46 ` Jan Kara 2017-06-14 16:49 ` Dan Williams 2017-06-14 16:49 ` Dan Williams 2017-06-14 16:49 ` Dan Williams 2017-06-14 23:11 ` [PATCH v4 13/14] libnvdimm, pmem: gate cache management on QUEUE_FLAG_WC in pmem_dax_flush() Dan Williams 2017-06-14 23:11 ` Dan Williams 2017-06-15 8:09 ` Jan Kara [this message] 2017-06-15 8:09 ` Jan Kara 2017-06-18 8:45 ` [PATCH v3 13/14] filesystem-dax: gate calls to dax_flush() on QUEUE_FLAG_WC Christoph Hellwig 2017-06-18 8:45 ` Christoph Hellwig 2017-06-18 8:45 ` Christoph Hellwig 2017-06-19 2:07 ` Dan Williams 2017-06-19 2:07 ` Dan Williams 2017-06-19 2:07 ` Dan Williams 2017-06-09 20:25 ` [PATCH v3 14/14] libnvdimm, pmem: disable dax flushing when pmem is fronting a volatile region Dan Williams 2017-06-09 20:25 ` Dan Williams 2017-06-09 20:25 ` Dan Williams 2017-06-09 23:21 ` Dan Williams 2017-06-09 23:21 ` Dan Williams 2017-06-10 17:54 ` [PATCH v4 " Dan Williams 2017-06-10 17:54 ` Dan Williams
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170615080911.GC1764@quack2.suse.cz \ --to=jack@suse.cz \ --cc=dan.j.williams@intel.com \ --cc=hch@lst.de \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=mawilcox@microsoft.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.