From: Dan Williams <dan.j.williams@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jan Kara <jack@suse.cz>, Matthew Wilcox <mawilcox@microsoft.com>,
X86 ML <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
dm-devel@redhat.com, Ingo Molnar <mingo@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v3 08/14] x86, dax, libnvdimm: move wb_cache_pmem() to libnvdimm
Date: Sun, 18 Jun 2017 19:06:14 -0700 [thread overview]
Message-ID: <CAPcyv4gbzpj3mQeb+Y=QG4dVvau6_1U=aW0e+SjwRkaNn=BmWA@mail.gmail.com> (raw)
In-Reply-To: <20170618084036.GC26456@lst.de>
On Sun, Jun 18, 2017 at 1:40 AM, Christoph Hellwig <hch@lst.de> wrote:
>> +void clean_cache_range(void *addr, size_t size);
>>
>> static inline int
>> __copy_from_user_inatomic_nocache(void *dst, const void __user *src,
>> diff --git a/arch/x86/lib/usercopy_64.c b/arch/x86/lib/usercopy_64.c
>> index f42d2fd86ca3..baa80ff29da8 100644
>> --- a/arch/x86/lib/usercopy_64.c
>> +++ b/arch/x86/lib/usercopy_64.c
>> @@ -85,7 +85,7 @@ copy_user_handle_tail(char *to, char *from, unsigned len)
>> * instruction. Note that @size is internally rounded up to be cache
>> * line size aligned.
>> */
>> -static void clean_cache_range(void *addr, size_t size)
>> +void clean_cache_range(void *addr, size_t size)
>
> Can you keep clean_cache_range private please? Just add
> arch_wb_cache_pmem to usercopy_64.c just behind it so that the
> compiler can tail-call and export that instead.
>
>> --- a/drivers/nvdimm/pmem.h
>> +++ b/drivers/nvdimm/pmem.h
>> @@ -4,6 +4,13 @@
>> #include <linux/types.h>
>> #include <linux/pfn_t.h>
>> #include <linux/fs.h>
>> +#include <asm/pmem.h>
>> +
>> +#ifndef CONFIG_ARCH_HAS_PMEM_API
>> +static inline void arch_wb_cache_pmem(void *addr, size_t size)
>> +{
>> +}
>> +#endif
>
> And our normal Linux style would be to have this linux linux/pmem.h,
> which should always be included for the asm version.
Ok, will do.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
Jan Kara <jack@suse.cz>,
dm-devel@redhat.com, Matthew Wilcox <mawilcox@microsoft.com>,
X86 ML <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jeff Moyer <jmoyer@redhat.com>, Ingo Molnar <mingo@redhat.com>,
"Oliver O'Halloran" <oohall@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ross Zwisler <ross.zwisler@linux.intel.com>
Subject: Re: [PATCH v3 08/14] x86, dax, libnvdimm: move wb_cache_pmem() to libnvdimm
Date: Sun, 18 Jun 2017 19:06:14 -0700 [thread overview]
Message-ID: <CAPcyv4gbzpj3mQeb+Y=QG4dVvau6_1U=aW0e+SjwRkaNn=BmWA@mail.gmail.com> (raw)
In-Reply-To: <20170618084036.GC26456@lst.de>
On Sun, Jun 18, 2017 at 1:40 AM, Christoph Hellwig <hch@lst.de> wrote:
>> +void clean_cache_range(void *addr, size_t size);
>>
>> static inline int
>> __copy_from_user_inatomic_nocache(void *dst, const void __user *src,
>> diff --git a/arch/x86/lib/usercopy_64.c b/arch/x86/lib/usercopy_64.c
>> index f42d2fd86ca3..baa80ff29da8 100644
>> --- a/arch/x86/lib/usercopy_64.c
>> +++ b/arch/x86/lib/usercopy_64.c
>> @@ -85,7 +85,7 @@ copy_user_handle_tail(char *to, char *from, unsigned len)
>> * instruction. Note that @size is internally rounded up to be cache
>> * line size aligned.
>> */
>> -static void clean_cache_range(void *addr, size_t size)
>> +void clean_cache_range(void *addr, size_t size)
>
> Can you keep clean_cache_range private please? Just add
> arch_wb_cache_pmem to usercopy_64.c just behind it so that the
> compiler can tail-call and export that instead.
>
>> --- a/drivers/nvdimm/pmem.h
>> +++ b/drivers/nvdimm/pmem.h
>> @@ -4,6 +4,13 @@
>> #include <linux/types.h>
>> #include <linux/pfn_t.h>
>> #include <linux/fs.h>
>> +#include <asm/pmem.h>
>> +
>> +#ifndef CONFIG_ARCH_HAS_PMEM_API
>> +static inline void arch_wb_cache_pmem(void *addr, size_t size)
>> +{
>> +}
>> +#endif
>
> And our normal Linux style would be to have this linux linux/pmem.h,
> which should always be included for the asm version.
Ok, will do.
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>,
Matthew Wilcox <mawilcox-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>,
X86 ML <x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org"
<linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org>,
dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
"H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
linux-fsdevel
<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Subject: Re: [PATCH v3 08/14] x86, dax, libnvdimm: move wb_cache_pmem() to libnvdimm
Date: Sun, 18 Jun 2017 19:06:14 -0700 [thread overview]
Message-ID: <CAPcyv4gbzpj3mQeb+Y=QG4dVvau6_1U=aW0e+SjwRkaNn=BmWA@mail.gmail.com> (raw)
In-Reply-To: <20170618084036.GC26456-jcswGhMUV9g@public.gmane.org>
On Sun, Jun 18, 2017 at 1:40 AM, Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> wrote:
>> +void clean_cache_range(void *addr, size_t size);
>>
>> static inline int
>> __copy_from_user_inatomic_nocache(void *dst, const void __user *src,
>> diff --git a/arch/x86/lib/usercopy_64.c b/arch/x86/lib/usercopy_64.c
>> index f42d2fd86ca3..baa80ff29da8 100644
>> --- a/arch/x86/lib/usercopy_64.c
>> +++ b/arch/x86/lib/usercopy_64.c
>> @@ -85,7 +85,7 @@ copy_user_handle_tail(char *to, char *from, unsigned len)
>> * instruction. Note that @size is internally rounded up to be cache
>> * line size aligned.
>> */
>> -static void clean_cache_range(void *addr, size_t size)
>> +void clean_cache_range(void *addr, size_t size)
>
> Can you keep clean_cache_range private please? Just add
> arch_wb_cache_pmem to usercopy_64.c just behind it so that the
> compiler can tail-call and export that instead.
>
>> --- a/drivers/nvdimm/pmem.h
>> +++ b/drivers/nvdimm/pmem.h
>> @@ -4,6 +4,13 @@
>> #include <linux/types.h>
>> #include <linux/pfn_t.h>
>> #include <linux/fs.h>
>> +#include <asm/pmem.h>
>> +
>> +#ifndef CONFIG_ARCH_HAS_PMEM_API
>> +static inline void arch_wb_cache_pmem(void *addr, size_t size)
>> +{
>> +}
>> +#endif
>
> And our normal Linux style would be to have this linux linux/pmem.h,
> which should always be included for the asm version.
Ok, will do.
next prev parent reply other threads:[~2017-06-19 2:04 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 20:23 [PATCH v3 00/14] pmem: stop abusing __copy_user_nocache(), and other reworks Dan Williams
2017-06-09 20:23 ` Dan Williams
2017-06-09 20:23 ` Dan Williams
2017-06-09 20:23 ` [PATCH v3 01/14] x86, uaccess: introduce copy_from_iter_flushcache for pmem / cache-bypass operations Dan Williams
2017-06-09 20:23 ` Dan Williams
2017-06-09 20:23 ` Dan Williams
2017-06-18 8:28 ` Christoph Hellwig
2017-06-18 8:28 ` Christoph Hellwig
2017-06-18 8:28 ` Christoph Hellwig
2017-06-19 2:02 ` Dan Williams
2017-06-19 2:02 ` Dan Williams
2017-06-19 2:02 ` Dan Williams
2017-06-09 20:23 ` [PATCH v3 02/14] dm: add ->copy_from_iter() dax operation support Dan Williams
2017-06-09 20:23 ` Dan Williams
2017-06-09 20:23 ` Dan Williams
2017-06-15 0:46 ` Kani, Toshimitsu
2017-06-15 0:46 ` Kani, Toshimitsu
2017-06-15 0:46 ` Kani, Toshimitsu
2017-06-15 1:21 ` Kani, Toshimitsu
2017-06-15 1:21 ` Kani, Toshimitsu
2017-06-18 8:37 ` Christoph Hellwig
2017-06-18 8:37 ` Christoph Hellwig
2017-06-18 8:37 ` Christoph Hellwig
2017-06-19 2:04 ` Dan Williams
2017-06-19 2:04 ` Dan Williams
2017-06-19 2:04 ` Dan Williams
2017-06-09 20:24 ` [PATCH v3 03/14] filesystem-dax: convert to dax_copy_from_iter() Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-14 10:58 ` Jan Kara
2017-06-14 10:58 ` Jan Kara
2017-06-14 10:58 ` Jan Kara
2017-06-09 20:24 ` [PATCH v3 04/14] dax, pmem: introduce an optional 'flush' dax_operation Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-14 10:57 ` Jan Kara
2017-06-14 10:57 ` Jan Kara
2017-06-14 10:57 ` Jan Kara
2017-06-09 20:24 ` [PATCH v3 05/14] dm: add ->flush() dax operation support Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-15 1:44 ` Kani, Toshimitsu
2017-06-15 1:44 ` Kani, Toshimitsu
2017-06-15 1:44 ` Kani, Toshimitsu
2017-06-09 20:24 ` [PATCH v3 06/14] filesystem-dax: convert to dax_flush() Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-14 10:56 ` Jan Kara
2017-06-14 10:56 ` Jan Kara
2017-06-14 10:56 ` Jan Kara
2017-06-09 20:24 ` [PATCH v3 07/14] x86, dax: replace clear_pmem() with open coded memset + dax_ops->flush Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-14 10:55 ` Jan Kara
2017-06-14 10:55 ` Jan Kara
2017-06-14 10:55 ` Jan Kara
2017-06-09 20:24 ` [PATCH v3 08/14] x86, dax, libnvdimm: move wb_cache_pmem() to libnvdimm Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-12 0:29 ` [PATCH v4 " Dan Williams
2017-06-12 0:29 ` Dan Williams
2017-06-14 10:54 ` [PATCH v3 " Jan Kara
2017-06-14 10:54 ` Jan Kara
2017-06-14 16:49 ` Dan Williams
2017-06-14 16:49 ` Dan Williams
2017-06-14 16:49 ` Dan Williams
2017-06-15 8:11 ` Jan Kara
2017-06-15 8:11 ` Jan Kara
2017-06-15 8:11 ` Jan Kara
2017-06-18 8:40 ` Christoph Hellwig
2017-06-18 8:40 ` Christoph Hellwig
2017-06-18 8:40 ` Christoph Hellwig
2017-06-19 2:06 ` Dan Williams [this message]
2017-06-19 2:06 ` Dan Williams
2017-06-19 2:06 ` Dan Williams
2017-06-09 20:24 ` [PATCH v3 09/14] x86, libnvdimm, pmem: move arch_invalidate_pmem() " Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-14 10:49 ` Jan Kara
2017-06-14 10:49 ` Jan Kara
2017-06-09 20:24 ` [PATCH v3 10/14] pmem: remove global pmem api Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-14 10:48 ` Jan Kara
2017-06-14 10:48 ` Jan Kara
2017-06-14 10:48 ` Jan Kara
2017-06-09 20:24 ` [PATCH v3 11/14] libnvdimm, pmem: fix persistence warning Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-09 20:24 ` [PATCH v3 12/14] libnvdimm, nfit: enable support for volatile ranges Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-09 20:24 ` [PATCH v3 13/14] filesystem-dax: gate calls to dax_flush() on QUEUE_FLAG_WC Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-09 20:24 ` Dan Williams
2017-06-14 10:46 ` Jan Kara
2017-06-14 10:46 ` Jan Kara
2017-06-14 16:49 ` Dan Williams
2017-06-14 16:49 ` Dan Williams
2017-06-14 16:49 ` Dan Williams
2017-06-14 23:11 ` [PATCH v4 13/14] libnvdimm, pmem: gate cache management on QUEUE_FLAG_WC in pmem_dax_flush() Dan Williams
2017-06-14 23:11 ` Dan Williams
2017-06-15 8:09 ` Jan Kara
2017-06-15 8:09 ` Jan Kara
2017-06-18 8:45 ` [PATCH v3 13/14] filesystem-dax: gate calls to dax_flush() on QUEUE_FLAG_WC Christoph Hellwig
2017-06-18 8:45 ` Christoph Hellwig
2017-06-18 8:45 ` Christoph Hellwig
2017-06-19 2:07 ` Dan Williams
2017-06-19 2:07 ` Dan Williams
2017-06-19 2:07 ` Dan Williams
2017-06-09 20:25 ` [PATCH v3 14/14] libnvdimm, pmem: disable dax flushing when pmem is fronting a volatile region Dan Williams
2017-06-09 20:25 ` Dan Williams
2017-06-09 20:25 ` Dan Williams
2017-06-09 23:21 ` Dan Williams
2017-06-09 23:21 ` Dan Williams
2017-06-10 17:54 ` [PATCH v4 " Dan Williams
2017-06-10 17:54 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4gbzpj3mQeb+Y=QG4dVvau6_1U=aW0e+SjwRkaNn=BmWA@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mawilcox@microsoft.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.