Re: [PATCH v9] drm/i915/icl: Check for fused-off VDBOX and VEBOX instances

From: kbuild test robot <lkp@intel.com>
To: Oscar Mateo <oscar.mateo@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	kbuild-all@01.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH v9] drm/i915/icl: Check for fused-off VDBOX and VEBOX instances
Date: Fri, 23 Feb 2018 11:03:30 +0800	[thread overview]
Message-ID: <201802231003.Gm9nUZZT%fengguang.wu@intel.com> (raw)
In-Reply-To: <1519256134-653-1-git-send-email-oscar.mateo@intel.com>

[-- Attachment #1: Type: text/plain, Size: 4364 bytes --]

Hi Oscar,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20180222]
[cannot apply to v4.16-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Oscar-Mateo/drm-i915-icl-Check-for-fused-off-VDBOX-and-VEBOX-instances/20180223-095336
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-a1-201807 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/gpu/drm/i915/intel_device_info.c: In function 'intel_device_info_init_mmio':
>> drivers/gpu/drm/i915/intel_device_info.c:619:18: error: 'I915_MAX_VCS' undeclared (first use in this function)
     for (i = 0; i < I915_MAX_VCS; i++) {
                     ^
   drivers/gpu/drm/i915/intel_device_info.c:619:18: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/gpu/drm/i915/intel_device_info.c:631:18: error: 'I915_MAX_VECS' undeclared (first use in this function)
     for (i = 0; i < I915_MAX_VECS; i++) {
                     ^
>> drivers/gpu/drm/i915/intel_device_info.c:632:3: error: implicit declaration of function '_VECS' [-Werror=implicit-function-declaration]
      if (!HAS_ENGINE(dev_priv, _VECS(i)))
      ^
   cc1: some warnings being treated as errors
--
   drivers/gpu/drm/i915/intel_uncore.c: In function 'intel_uncore_prune':
   drivers/gpu/drm/i915/intel_uncore.c:1468:19: error: 'I915_MAX_VCS' undeclared (first use in this function)
      for (i = 0; i < I915_MAX_VCS; i++) {
                      ^
   drivers/gpu/drm/i915/intel_uncore.c:1468:19: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/gpu/drm/i915/intel_uncore.c:1469:16: error: 'FW_DOMAIN_ID_MEDIA_VDBOX0' undeclared (first use in this function)
       domain_id = FW_DOMAIN_ID_MEDIA_VDBOX0 + i;
                   ^
   drivers/gpu/drm/i915/intel_uncore.c:1478:19: error: 'I915_MAX_VECS' undeclared (first use in this function)
      for (i = 0; i < I915_MAX_VECS; i++) {
                      ^
>> drivers/gpu/drm/i915/intel_uncore.c:1479:16: error: 'FW_DOMAIN_ID_MEDIA_VEBOX0' undeclared (first use in this function)
       domain_id = FW_DOMAIN_ID_MEDIA_VEBOX0 + i;
                   ^
   drivers/gpu/drm/i915/intel_uncore.c:1481:4: error: implicit declaration of function '_VECS' [-Werror=implicit-function-declaration]
       if (HAS_ENGINE(dev_priv, _VECS(i)))
       ^
   cc1: some warnings being treated as errors

vim +/I915_MAX_VCS +619 drivers/gpu/drm/i915/intel_device_info.c

   595	
   596	/*
   597	 * Determine which engines are fused off in our particular hardware. Since the
   598	 * fuse register is in the blitter powerwell, we need forcewake to be ready at
   599	 * this point (but later we need to prune the forcewake domains for engines that
   600	 * are indeed fused off).
   601	 */
   602	void intel_device_info_init_mmio(struct drm_i915_private *dev_priv)
   603	{
   604		struct intel_device_info *info = mkwrite_device_info(dev_priv);
   605		u8 vdbox_disable, vebox_disable;
   606		u32 media_fuse;
   607		int i;
   608	
   609		if (INTEL_GEN(dev_priv) < 11)
   610			return;
   611	
   612		media_fuse = I915_READ(GEN11_GT_VEBOX_VDBOX_DISABLE);
   613	
   614		vdbox_disable = media_fuse & GEN11_GT_VDBOX_DISABLE_MASK;
   615		vebox_disable = (media_fuse & GEN11_GT_VEBOX_DISABLE_MASK) >>
   616				GEN11_GT_VEBOX_DISABLE_SHIFT;
   617	
   618		DRM_DEBUG_DRIVER("vdbox disable: %04x\n", vdbox_disable);
 > 619		for (i = 0; i < I915_MAX_VCS; i++) {
   620			if (!HAS_ENGINE(dev_priv, _VCS(i)))
   621				continue;
   622	
   623			if (!(BIT(i) & vdbox_disable))
   624				continue;
   625	
   626			info->ring_mask &= ~ENGINE_MASK(_VCS(i));
   627			DRM_DEBUG_DRIVER("vcs%u fused off\n", i);
   628		}
   629	
   630		DRM_DEBUG_DRIVER("vebox disable: %04x\n", vebox_disable);
 > 631		for (i = 0; i < I915_MAX_VECS; i++) {
 > 632			if (!HAS_ENGINE(dev_priv, _VECS(i)))

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27632 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx