Re: [PATCH 01/20] drm/i915/icl: Add the ICL PCI IDs

From: Anuj Phogat <anuj.phogat@gmail.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	Paulo Zanoni <paulo.r.zanoni@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 01/20] drm/i915/icl: Add the ICL PCI IDs
Date: Tue, 13 Feb 2018 10:48:21 -0800	[thread overview]
Message-ID: <CAP5d04E3VsOKia6co1v2VdqoaZQWJoJ3MkNUam6xjnGhKHDtcg@mail.gmail.com> (raw)
In-Reply-To: <20180213163738.9055-2-mika.kuoppala@linux.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 2656 bytes --]

On Tue, Feb 13, 2018 at 8:37 AM, Mika Kuoppala <
mika.kuoppala@linux.intel.com> wrote:

> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> This is the current PCI ID list in our documentation.
>
> Let's leave the _gt#_ part out for now since our current documentation
> is not 100% clear and we don't need this info now anyway.
>
> v2: Use the new ICL_11 naming (Kelvin Gardiner).
> v3: Latest IDs as per BSpec (Oscar).
> v4: Make it compile (Paulo).
> v5: Remove comments (Lucas).
> v6: Multile rebases (Paulo).
> v7: Rebase (Mika)
>
> Reviewed-by: Anuj Phogat <anuj.phogat@intel.com> (v1)
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_pci.c |  1 +
>  include/drm/i915_pciids.h       | 12 ++++++++++++
>  2 files changed, 13 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c
> b/drivers/gpu/drm/i915/i915_pci.c
> index 4e7a10c89782..c94a76bef763 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -650,6 +650,7 @@ static const struct pci_device_id pciidlist[] = {
>         INTEL_CFL_U_GT2_IDS(&intel_coffeelake_gt2_info),
>         INTEL_CFL_U_GT3_IDS(&intel_coffeelake_gt3_info),
>         INTEL_CNL_IDS(&intel_cannonlake_info),
> +       INTEL_ICL_11_IDS(&intel_icelake_11_info),
>         {0, 0, 0}
>  };
>  MODULE_DEVICE_TABLE(pci, pciidlist);
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index 9e1fe6634424..4afcdb4492f1 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -430,4 +430,16 @@
>         INTEL_VGA_DEVICE(0x5A5C, info), \
>         INTEL_VGA_DEVICE(0x5A44, info)
>
> +/* ICL */
> +#define INTEL_ICL_11_IDS(info) \
> +       INTEL_VGA_DEVICE(0x8A50, info), \
> +       INTEL_VGA_DEVICE(0x8A51, info), \
> +       INTEL_VGA_DEVICE(0x8A5C, info), \
> +       INTEL_VGA_DEVICE(0x8A5D, info), \
> +       INTEL_VGA_DEVICE(0x8A52, info), \
> +       INTEL_VGA_DEVICE(0x8A5A, info), \
> +       INTEL_VGA_DEVICE(0x8A5B, info), \
> +       INTEL_VGA_DEVICE(0x8A71, info), \
> +       INTEL_VGA_DEVICE(0x8A70, info)
>
Why do we need a GT0 pci id in there?


> +
>  #endif /* _I915_PCIIDS_H */
> --
> 2.14.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>

[-- Attachment #1.2: Type: text/html, Size: 4297 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx