From: Vivek Goyal <vgoyal@redhat.com>
To: Liu Bo <bo.liu@linux.alibaba.com>
Cc: Miklos Szeredi <mszeredi@redhat.com>,
Peng Tao <tao.peng@linux.alibaba.com>,
miklos@szeredi.hu, linux-nvdimm@lists.01.org,
linux-kernel@vger.kernel.org, dgilbert@redhat.com,
virtio-fs@redhat.com, stefanha@redhat.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 11/19] fuse, dax: Implement dax read/write operations
Date: Thu, 22 Aug 2019 08:59:27 -0400 [thread overview]
Message-ID: <20190822125927.GA8999@redhat.com> (raw)
In-Reply-To: <20190821194934.rqswgc52juisunl2@US-160370MP2.local>
On Wed, Aug 21, 2019 at 12:49:34PM -0700, Liu Bo wrote:
[..]
> > +static int iomap_begin_upgrade_mapping(struct inode *inode, loff_t pos,
> > + loff_t length, unsigned flags,
> > + struct iomap *iomap)
> > +{
> > + struct fuse_inode *fi = get_fuse_inode(inode);
> > + struct fuse_dax_mapping *dmap;
> > + int ret;
> > +
> > + /*
> > + * Take exclusive lock so that only one caller can try to setup
> > + * mapping and others wait.
> > + */
> > + down_write(&fi->i_dmap_sem);
> > + dmap = fuse_dax_interval_tree_iter_first(&fi->dmap_tree, pos, pos);
> > +
> > + /* We are holding either inode lock or i_mmap_sem, and that should
> > + * ensure that dmap can't reclaimed or truncated and it should still
> > + * be there in tree despite the fact we dropped and re-acquired the
> > + * lock.
> > + */
> > + ret = -EIO;
> > + if (WARN_ON(!dmap))
> > + goto out_err;
> > +
> > + /* Maybe another thread already upgraded mapping while we were not
> > + * holding lock.
> > + */
> > + if (dmap->writable)
> > + goto out_fill_iomap;
>
> @ret needs to be reset here.
>
Good catch. Will fix it.
Vivek
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Liu Bo <bo.liu@linux.alibaba.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvdimm@lists.01.org, virtio-fs@redhat.com,
miklos@szeredi.hu, stefanha@redhat.com, dgilbert@redhat.com,
Miklos Szeredi <mszeredi@redhat.com>,
Peng Tao <tao.peng@linux.alibaba.com>
Subject: Re: [PATCH 11/19] fuse, dax: Implement dax read/write operations
Date: Thu, 22 Aug 2019 08:59:27 -0400 [thread overview]
Message-ID: <20190822125927.GA8999@redhat.com> (raw)
In-Reply-To: <20190821194934.rqswgc52juisunl2@US-160370MP2.local>
On Wed, Aug 21, 2019 at 12:49:34PM -0700, Liu Bo wrote:
[..]
> > +static int iomap_begin_upgrade_mapping(struct inode *inode, loff_t pos,
> > + loff_t length, unsigned flags,
> > + struct iomap *iomap)
> > +{
> > + struct fuse_inode *fi = get_fuse_inode(inode);
> > + struct fuse_dax_mapping *dmap;
> > + int ret;
> > +
> > + /*
> > + * Take exclusive lock so that only one caller can try to setup
> > + * mapping and others wait.
> > + */
> > + down_write(&fi->i_dmap_sem);
> > + dmap = fuse_dax_interval_tree_iter_first(&fi->dmap_tree, pos, pos);
> > +
> > + /* We are holding either inode lock or i_mmap_sem, and that should
> > + * ensure that dmap can't reclaimed or truncated and it should still
> > + * be there in tree despite the fact we dropped and re-acquired the
> > + * lock.
> > + */
> > + ret = -EIO;
> > + if (WARN_ON(!dmap))
> > + goto out_err;
> > +
> > + /* Maybe another thread already upgraded mapping while we were not
> > + * holding lock.
> > + */
> > + if (dmap->writable)
> > + goto out_fill_iomap;
>
> @ret needs to be reset here.
>
Good catch. Will fix it.
Vivek
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Liu Bo <bo.liu@linux.alibaba.com>
Cc: Miklos Szeredi <mszeredi@redhat.com>,
Peng Tao <tao.peng@linux.alibaba.com>,
miklos@szeredi.hu, linux-nvdimm@lists.01.org,
linux-kernel@vger.kernel.org, virtio-fs@redhat.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [Virtio-fs] [PATCH 11/19] fuse, dax: Implement dax read/write operations
Date: Thu, 22 Aug 2019 08:59:27 -0400 [thread overview]
Message-ID: <20190822125927.GA8999@redhat.com> (raw)
In-Reply-To: <20190821194934.rqswgc52juisunl2@US-160370MP2.local>
On Wed, Aug 21, 2019 at 12:49:34PM -0700, Liu Bo wrote:
[..]
> > +static int iomap_begin_upgrade_mapping(struct inode *inode, loff_t pos,
> > + loff_t length, unsigned flags,
> > + struct iomap *iomap)
> > +{
> > + struct fuse_inode *fi = get_fuse_inode(inode);
> > + struct fuse_dax_mapping *dmap;
> > + int ret;
> > +
> > + /*
> > + * Take exclusive lock so that only one caller can try to setup
> > + * mapping and others wait.
> > + */
> > + down_write(&fi->i_dmap_sem);
> > + dmap = fuse_dax_interval_tree_iter_first(&fi->dmap_tree, pos, pos);
> > +
> > + /* We are holding either inode lock or i_mmap_sem, and that should
> > + * ensure that dmap can't reclaimed or truncated and it should still
> > + * be there in tree despite the fact we dropped and re-acquired the
> > + * lock.
> > + */
> > + ret = -EIO;
> > + if (WARN_ON(!dmap))
> > + goto out_err;
> > +
> > + /* Maybe another thread already upgraded mapping while we were not
> > + * holding lock.
> > + */
> > + if (dmap->writable)
> > + goto out_fill_iomap;
>
> @ret needs to be reset here.
>
Good catch. Will fix it.
Vivek
next prev parent reply other threads:[~2019-08-22 13:00 UTC|newest]
Thread overview: 231+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 17:57 [PATCH v3 00/19][RFC] virtio-fs: Enable DAX support Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 01/19] dax: remove block device dependencies Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-26 11:51 ` Christoph Hellwig
2019-08-26 11:51 ` [Virtio-fs] " Christoph Hellwig
2019-08-26 11:51 ` Christoph Hellwig
2019-08-27 16:38 ` Vivek Goyal
2019-08-27 16:38 ` [Virtio-fs] " Vivek Goyal
2019-08-27 16:38 ` Vivek Goyal
2019-08-28 6:58 ` Christoph Hellwig
2019-08-28 6:58 ` [Virtio-fs] " Christoph Hellwig
2019-08-28 6:58 ` Christoph Hellwig
2019-08-28 17:58 ` Vivek Goyal
2019-08-28 17:58 ` [Virtio-fs] " Vivek Goyal
2019-08-28 17:58 ` Vivek Goyal
2019-08-28 22:53 ` Dave Chinner
2019-08-28 22:53 ` [Virtio-fs] " Dave Chinner
2019-08-28 22:53 ` Dave Chinner
2019-08-29 0:04 ` Dan Williams
2019-08-29 0:04 ` [Virtio-fs] " Dan Williams
2019-08-29 0:04 ` Dan Williams
2019-08-29 9:32 ` Christoph Hellwig
2019-08-29 9:32 ` [Virtio-fs] " Christoph Hellwig
2019-08-29 9:32 ` Christoph Hellwig
2019-12-16 18:10 ` Vivek Goyal
2019-12-16 18:10 ` [Virtio-fs] " Vivek Goyal
2019-12-16 18:10 ` Vivek Goyal
2020-01-07 12:51 ` Christoph Hellwig
2020-01-07 12:51 ` [Virtio-fs] " Christoph Hellwig
2020-01-07 12:51 ` Christoph Hellwig
2020-01-07 14:22 ` Dan Williams
2020-01-07 14:22 ` [Virtio-fs] " Dan Williams
2020-01-07 14:22 ` Dan Williams
2020-01-07 17:07 ` Darrick J. Wong
2020-01-07 17:07 ` [Virtio-fs] " Darrick J. Wong
2020-01-07 17:07 ` Darrick J. Wong
2020-01-07 17:29 ` Dan Williams
2020-01-07 17:29 ` [Virtio-fs] " Dan Williams
2020-01-07 17:29 ` Dan Williams
2020-01-07 18:01 ` Vivek Goyal
2020-01-07 18:01 ` [Virtio-fs] " Vivek Goyal
2020-01-07 18:01 ` Vivek Goyal
2020-01-07 18:07 ` Dan Williams
2020-01-07 18:07 ` [Virtio-fs] " Dan Williams
2020-01-07 18:07 ` Dan Williams
2020-01-07 18:33 ` Vivek Goyal
2020-01-07 18:33 ` [Virtio-fs] " Vivek Goyal
2020-01-07 18:33 ` Vivek Goyal
2020-01-07 18:49 ` Dan Williams
2020-01-07 18:49 ` [Virtio-fs] " Dan Williams
2020-01-07 18:49 ` Dan Williams
2020-01-07 19:02 ` Darrick J. Wong
2020-01-07 19:02 ` [Virtio-fs] " Darrick J. Wong
2020-01-07 19:02 ` Darrick J. Wong
2020-01-07 19:46 ` Dan Williams
2020-01-07 19:46 ` [Virtio-fs] " Dan Williams
2020-01-07 19:46 ` Dan Williams
2020-01-07 23:38 ` Dan Williams
2020-01-07 23:38 ` [Virtio-fs] " Dan Williams
2020-01-07 23:38 ` Dan Williams
2020-01-09 11:24 ` Jan Kara
2020-01-09 11:24 ` [Virtio-fs] " Jan Kara
2020-01-09 11:24 ` Jan Kara
2020-01-09 20:03 ` Dan Williams
2020-01-09 20:03 ` [Virtio-fs] " Dan Williams
2020-01-09 20:03 ` Dan Williams
2020-01-10 12:36 ` Christoph Hellwig
2020-01-10 12:36 ` [Virtio-fs] " Christoph Hellwig
2020-01-10 12:36 ` Christoph Hellwig
2020-01-14 20:31 ` Vivek Goyal
2020-01-14 20:31 ` [Virtio-fs] " Vivek Goyal
2020-01-14 20:31 ` Vivek Goyal
2020-01-14 20:39 ` Dan Williams
2020-01-14 20:39 ` [Virtio-fs] " Dan Williams
2020-01-14 20:39 ` Dan Williams
2020-01-14 21:28 ` Vivek Goyal
2020-01-14 21:28 ` [Virtio-fs] " Vivek Goyal
2020-01-14 21:28 ` Vivek Goyal
2020-01-14 22:23 ` Dan Williams
2020-01-14 22:23 ` [Virtio-fs] " Dan Williams
2020-01-14 22:23 ` Dan Williams
2020-01-15 19:56 ` Vivek Goyal
2020-01-15 19:56 ` [Virtio-fs] " Vivek Goyal
2020-01-15 19:56 ` Vivek Goyal
2020-01-15 20:17 ` Dan Williams
2020-01-15 20:17 ` [Virtio-fs] " Dan Williams
2020-01-15 20:17 ` Dan Williams
2020-01-15 21:08 ` Jeff Moyer
2020-01-15 21:08 ` [Virtio-fs] " Jeff Moyer
2020-01-15 21:08 ` Jeff Moyer
2020-01-16 18:09 ` Dan Williams
2020-01-16 18:09 ` [Virtio-fs] " Dan Williams
2020-01-16 18:09 ` Dan Williams
2020-01-16 18:39 ` Vivek Goyal
2020-01-16 18:39 ` [Virtio-fs] " Vivek Goyal
2020-01-16 18:39 ` Vivek Goyal
2020-01-16 19:09 ` Dan Williams
2020-01-16 19:09 ` [Virtio-fs] " Dan Williams
2020-01-16 19:09 ` Dan Williams
2020-01-16 19:23 ` Vivek Goyal
2020-01-16 19:23 ` [Virtio-fs] " Vivek Goyal
2020-01-16 19:23 ` Vivek Goyal
2020-02-11 17:33 ` Vivek Goyal
2020-02-11 17:33 ` [Virtio-fs] " Vivek Goyal
2020-02-11 17:33 ` Vivek Goyal
2020-01-15 9:03 ` Jan Kara
2020-01-15 9:03 ` [Virtio-fs] " Jan Kara
2020-01-15 9:03 ` Jan Kara
2019-08-21 17:57 ` [PATCH 02/19] dax: Pass dax_dev to dax_writeback_mapping_range() Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-26 11:53 ` Christoph Hellwig
2019-08-26 11:53 ` [Virtio-fs] " Christoph Hellwig
2019-08-26 11:53 ` Christoph Hellwig
2019-08-26 20:33 ` Vivek Goyal
2019-08-26 20:33 ` [Virtio-fs] " Vivek Goyal
2019-08-26 20:33 ` Vivek Goyal
2019-08-26 20:58 ` Vivek Goyal
2019-08-26 20:58 ` [Virtio-fs] " Vivek Goyal
2019-08-26 20:58 ` Vivek Goyal
2019-08-26 21:33 ` Dan Williams
2019-08-26 21:33 ` [Virtio-fs] " Dan Williams
2019-08-26 21:33 ` Dan Williams
2019-08-28 6:58 ` Christoph Hellwig
2019-08-28 6:58 ` [Virtio-fs] " Christoph Hellwig
2019-08-28 6:58 ` Christoph Hellwig
2020-01-03 14:12 ` Vivek Goyal
2020-01-03 14:12 ` [Virtio-fs] " Vivek Goyal
2020-01-03 14:12 ` Vivek Goyal
2020-01-03 18:12 ` Dan Williams
2020-01-03 18:12 ` [Virtio-fs] " Dan Williams
2020-01-03 18:12 ` Dan Williams
2020-01-03 18:18 ` Dan Williams
2020-01-03 18:18 ` [Virtio-fs] " Dan Williams
2020-01-03 18:18 ` Dan Williams
2020-01-03 18:33 ` Vivek Goyal
2020-01-03 18:33 ` [Virtio-fs] " Vivek Goyal
2020-01-03 18:33 ` Vivek Goyal
2020-01-03 19:30 ` Dan Williams
2020-01-03 19:30 ` [Virtio-fs] " Dan Williams
2020-01-03 19:30 ` Dan Williams
2020-01-03 18:43 ` Vivek Goyal
2020-01-03 18:43 ` [Virtio-fs] " Vivek Goyal
2020-01-03 18:43 ` Vivek Goyal
2019-08-27 13:45 ` Jan Kara
2019-08-27 13:45 ` [Virtio-fs] " Jan Kara
2019-08-27 13:45 ` Jan Kara
2019-08-21 17:57 ` [PATCH 03/19] virtio: Add get_shm_region method Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 04/19] virtio: Implement get_shm_region for PCI transport Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-26 1:43 ` [Virtio-fs] " piaojun
2019-08-26 1:43 ` piaojun
2019-08-26 1:43 ` piaojun
2019-08-26 13:06 ` Vivek Goyal
2019-08-26 13:06 ` Vivek Goyal
2019-08-26 13:06 ` Vivek Goyal
2019-08-27 9:41 ` piaojun
2019-08-27 9:41 ` piaojun
2019-08-27 9:41 ` piaojun
2019-08-27 8:34 ` Cornelia Huck
2019-08-27 8:34 ` [Virtio-fs] " Cornelia Huck
2019-08-27 8:34 ` Cornelia Huck
2019-08-27 8:46 ` Cornelia Huck
2019-08-27 8:46 ` [Virtio-fs] " Cornelia Huck
2019-08-27 8:46 ` Cornelia Huck
2019-08-27 11:53 ` Vivek Goyal
2019-08-27 11:53 ` [Virtio-fs] " Vivek Goyal
2019-08-27 11:53 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 05/19] virtio: Implement get_shm_region for MMIO transport Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-27 8:39 ` Cornelia Huck
2019-08-27 8:39 ` [Virtio-fs] " Cornelia Huck
2019-08-27 8:39 ` Cornelia Huck
2019-08-27 11:54 ` Vivek Goyal
2019-08-27 11:54 ` [Virtio-fs] " Vivek Goyal
2019-08-27 11:54 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 06/19] fuse, dax: add fuse_conn->dax_dev field Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 07/19] virtio_fs, dax: Set up virtio_fs dax_device Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 08/19] fuse: Keep a list of free dax memory ranges Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 09/19] fuse: implement FUSE_INIT map_alignment field Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 10/19] fuse: Introduce setupmapping/removemapping commands Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 11/19] fuse, dax: Implement dax read/write operations Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-21 19:49 ` Liu Bo
2019-08-21 19:49 ` [Virtio-fs] " Liu Bo
2019-08-21 19:49 ` Liu Bo
2019-08-22 12:59 ` Vivek Goyal [this message]
2019-08-22 12:59 ` [Virtio-fs] " Vivek Goyal
2019-08-22 12:59 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 12/19] fuse, dax: add DAX mmap support Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 13/19] fuse: Define dax address space operations Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 14/19] fuse, dax: Take ->i_mmap_sem lock during dax page fault Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 15/19] fuse: Maintain a list of busy elements Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 16/19] dax: Create a range version of dax_layout_busy_page() Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 17/19] fuse: Add logic to free up a memory range Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 18/19] fuse: Release file in process context Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 19/19] fuse: Take inode lock for dax inode truncation Vivek Goyal
2019-08-21 17:57 ` [Virtio-fs] " Vivek Goyal
2019-08-21 17:57 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822125927.GA8999@redhat.com \
--to=vgoyal@redhat.com \
--cc=bo.liu@linux.alibaba.com \
--cc=dgilbert@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=miklos@szeredi.hu \
--cc=mszeredi@redhat.com \
--cc=stefanha@redhat.com \
--cc=tao.peng@linux.alibaba.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.