From: Manasi Navare <manasi.d.navare@intel.com> To: Animesh Manna <animesh.manna@intel.com> Cc: jani.nikula@intel.com, nidhi1.gupta@intel.com, intel-gfx@lists.freedesktop.org Subject: Re: [RFC 4/7] drm/i915/dp: Notify testapp using uevent and debugfs entry Date: Sun, 17 Nov 2019 20:58:45 -0800 [thread overview] Message-ID: <20191118045845.GC1135@intel.com> (raw) In-Reply-To: <20191115152549.23047-5-animesh.manna@intel.com> On Fri, Nov 15, 2019 at 08:55:46PM +0530, Animesh Manna wrote: > To align with link compliance design existing intel_dp_compliance > tool will be used to get the phy request in userspace through uevent. > > Signed-off-by: Animesh Manna <animesh.manna@intel.com> I would prefer splitting this patch since sending a uevent is more related to the PHY test prep handling and debugfs handling can all be in a separate patch. I prefer this because debugfs nodes might need to change in the future based on more requirements or testing feedback so its better for that to be in separate patch. you could add the hotplug event sending part to the prep patch (3/7) and mention that in the commit message Debugfs part looks good to me. Have you tested the debugfs nodes and validated if this information is being written in the correct form? After the split and validation of debugs nodes: Acked-by: Manasi Navare <manasi.d.navare@intel.com> Manasi > --- > drivers/gpu/drm/i915/display/intel_dp.c | 6 ++++-- > drivers/gpu/drm/i915/i915_debugfs.c | 10 ++++++++++ > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 338d3744c5d5..a2b860cf3b93 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -5288,8 +5288,10 @@ intel_dp_short_pulse(struct intel_dp *intel_dp) > > intel_psr_short_pulse(intel_dp); > > - if (intel_dp->compliance.test_type == DP_TEST_LINK_TRAINING) { > - DRM_DEBUG_KMS("Link Training Compliance Test requested\n"); > + if (intel_dp->compliance.test_type == DP_TEST_LINK_TRAINING || > + intel_dp->compliance.test_type == > + DP_TEST_LINK_PHY_TEST_PATTERN) { > + DRM_DEBUG_KMS("Compliance Test requested\n"); > /* Send a Hotplug Uevent to userspace to start modeset */ > drm_kms_helper_hotplug_event(&dev_priv->drm); > } > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index cab632791f73..e8b1a8c1015a 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -3212,6 +3212,16 @@ static int i915_displayport_test_data_show(struct seq_file *m, void *data) > intel_dp->compliance.test_data.vdisplay); > seq_printf(m, "bpc: %u\n", > intel_dp->compliance.test_data.bpc); > + } else if (intel_dp->compliance.test_type == > + DP_TEST_LINK_PHY_TEST_PATTERN) { > + seq_printf(m, "pattern: %d\n", > + intel_dp->compliance.test_data.phytest.phy_pattern); > + seq_printf(m, "Number of lanes: %d\n", > + intel_dp->compliance.test_data.phytest.num_lanes); > + seq_printf(m, "Link Rate: %d\n", > + intel_dp->compliance.test_data.phytest.link_rate); > + seq_printf(m, "level: %02x\n", > + intel_dp->train_set[0]); > } > } else > seq_puts(m, "0"); > -- > 2.22.0 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Manasi Navare <manasi.d.navare@intel.com> To: Animesh Manna <animesh.manna@intel.com> Cc: jani.nikula@intel.com, nidhi1.gupta@intel.com, intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [RFC 4/7] drm/i915/dp: Notify testapp using uevent and debugfs entry Date: Sun, 17 Nov 2019 20:58:45 -0800 [thread overview] Message-ID: <20191118045845.GC1135@intel.com> (raw) Message-ID: <20191118045845.z2L5C9-qRN_5EdYg4ngAeNEzhoCd7RrW8TEzsyZk0qw@z> (raw) In-Reply-To: <20191115152549.23047-5-animesh.manna@intel.com> On Fri, Nov 15, 2019 at 08:55:46PM +0530, Animesh Manna wrote: > To align with link compliance design existing intel_dp_compliance > tool will be used to get the phy request in userspace through uevent. > > Signed-off-by: Animesh Manna <animesh.manna@intel.com> I would prefer splitting this patch since sending a uevent is more related to the PHY test prep handling and debugfs handling can all be in a separate patch. I prefer this because debugfs nodes might need to change in the future based on more requirements or testing feedback so its better for that to be in separate patch. you could add the hotplug event sending part to the prep patch (3/7) and mention that in the commit message Debugfs part looks good to me. Have you tested the debugfs nodes and validated if this information is being written in the correct form? After the split and validation of debugs nodes: Acked-by: Manasi Navare <manasi.d.navare@intel.com> Manasi > --- > drivers/gpu/drm/i915/display/intel_dp.c | 6 ++++-- > drivers/gpu/drm/i915/i915_debugfs.c | 10 ++++++++++ > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 338d3744c5d5..a2b860cf3b93 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -5288,8 +5288,10 @@ intel_dp_short_pulse(struct intel_dp *intel_dp) > > intel_psr_short_pulse(intel_dp); > > - if (intel_dp->compliance.test_type == DP_TEST_LINK_TRAINING) { > - DRM_DEBUG_KMS("Link Training Compliance Test requested\n"); > + if (intel_dp->compliance.test_type == DP_TEST_LINK_TRAINING || > + intel_dp->compliance.test_type == > + DP_TEST_LINK_PHY_TEST_PATTERN) { > + DRM_DEBUG_KMS("Compliance Test requested\n"); > /* Send a Hotplug Uevent to userspace to start modeset */ > drm_kms_helper_hotplug_event(&dev_priv->drm); > } > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index cab632791f73..e8b1a8c1015a 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -3212,6 +3212,16 @@ static int i915_displayport_test_data_show(struct seq_file *m, void *data) > intel_dp->compliance.test_data.vdisplay); > seq_printf(m, "bpc: %u\n", > intel_dp->compliance.test_data.bpc); > + } else if (intel_dp->compliance.test_type == > + DP_TEST_LINK_PHY_TEST_PATTERN) { > + seq_printf(m, "pattern: %d\n", > + intel_dp->compliance.test_data.phytest.phy_pattern); > + seq_printf(m, "Number of lanes: %d\n", > + intel_dp->compliance.test_data.phytest.num_lanes); > + seq_printf(m, "Link Rate: %d\n", > + intel_dp->compliance.test_data.phytest.link_rate); > + seq_printf(m, "level: %02x\n", > + intel_dp->train_set[0]); > } > } else > seq_puts(m, "0"); > -- > 2.22.0 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-18 4:55 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-15 15:25 [RFC 0/7] DP Phy compliace auto test Animesh Manna 2019-11-15 15:25 ` [Intel-gfx] " Animesh Manna 2019-11-15 15:25 ` [RFC 1/7] drm/dp: get/set phy compliance pattern Animesh Manna 2019-11-15 15:25 ` [Intel-gfx] " Animesh Manna 2019-11-18 4:04 ` Manasi Navare 2019-11-18 4:04 ` [Intel-gfx] " Manasi Navare 2019-11-18 18:39 ` Animesh Manna 2019-11-18 18:39 ` [Intel-gfx] " Animesh Manna 2019-11-15 15:25 ` [RFC 2/7] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation Animesh Manna 2019-11-15 15:25 ` [Intel-gfx] " Animesh Manna 2019-11-15 15:25 ` [RFC 3/7] drm/i915/dp: Preparation for DP phy compliance auto test Animesh Manna 2019-11-15 15:25 ` [Intel-gfx] " Animesh Manna 2019-11-18 4:47 ` Manasi Navare 2019-11-18 4:47 ` [Intel-gfx] " Manasi Navare 2019-11-15 15:25 ` [RFC 4/7] drm/i915/dp: Notify testapp using uevent and debugfs entry Animesh Manna 2019-11-15 15:25 ` [Intel-gfx] " Animesh Manna 2019-11-18 4:58 ` Manasi Navare [this message] 2019-11-18 4:58 ` Manasi Navare 2019-11-18 5:06 ` Manasi Navare 2019-11-18 5:06 ` [Intel-gfx] " Manasi Navare 2019-11-18 18:45 ` Animesh Manna 2019-11-18 18:45 ` [Intel-gfx] " Animesh Manna 2019-11-15 15:25 ` [RFC 5/7] drm/i915/dp: Register definition for DP compliance register Animesh Manna 2019-11-15 15:25 ` [Intel-gfx] " Animesh Manna 2019-11-18 5:00 ` Manasi Navare 2019-11-18 5:00 ` [Intel-gfx] " Manasi Navare 2019-11-15 15:25 ` [RFC 6/7] drm/i915/dp: Update the pattern as per request Animesh Manna 2019-11-15 15:25 ` [Intel-gfx] " Animesh Manna 2019-11-18 6:41 ` Manasi Navare 2019-11-18 6:41 ` [Intel-gfx] " Manasi Navare 2019-11-18 18:47 ` Animesh Manna 2019-11-18 18:47 ` [Intel-gfx] " Animesh Manna 2019-12-11 23:44 ` Manasi Navare 2019-11-15 15:25 ` [RFC 7/7] drm/i915/dp: Program vswing, pre-emphasis, test-pattern Animesh Manna 2019-11-15 15:25 ` [Intel-gfx] " Animesh Manna 2019-11-18 7:53 ` Manasi Navare 2019-11-18 7:53 ` [Intel-gfx] " Manasi Navare 2019-12-11 23:50 ` Manasi Navare 2019-12-13 17:24 ` Animesh Manna 2020-01-14 21:38 ` Manasi Navare 2020-01-20 13:53 ` Manna, Animesh 2020-01-24 0:56 ` Manasi Navare 2019-11-15 19:27 ` ✗ Fi.CI.BUILD: failure for DP Phy compliace auto test Patchwork 2019-11-15 19:27 ` [Intel-gfx] " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191118045845.GC1135@intel.com \ --to=manasi.d.navare@intel.com \ --cc=animesh.manna@intel.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@intel.com \ --cc=nidhi1.gupta@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.