Re: [PATCH 03/12] OPP: Improve required-opps linking

From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 03/12] OPP: Improve required-opps linking
Date: Thu, 21 May 2020 09:10:59 +0800	[thread overview]
Message-ID: <202005210920.HLjIMpN9%lkp@intel.com> (raw)
In-Reply-To: <20200520034307.20435-4-andrew-sh.cheng@mediatek.com>

[-- Attachment #1: Type: text/plain, Size: 5647 bytes --]

Hi "Andrew-sh.Cheng",

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pm/linux-next]
[also build test ERROR on robh/for-next linus/master v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Andrew-sh-Cheng/Add-cpufreq-and-cci-devfreq-for-mt8183-and-SVS-support/20200520-222709
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: parisc-randconfig-r013-20200520 (attached as .config)
compiler: hppa64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>, old ones prefixed by <<):

hppa64-linux-ld: drivers/opp/cpu.o: in function `_of_lazy_link_required_tables':
>> drivers/opp/cpu.c:226: multiple definition of `_of_lazy_link_required_tables'; drivers/opp/core.o:include/linux/refcount.h:206: first defined here
hppa64-linux-ld: drivers/opp/debugfs.o: in function `_of_lazy_link_required_tables':
drivers/opp/debugfs.c:126: multiple definition of `_of_lazy_link_required_tables'; drivers/opp/core.o:include/linux/refcount.h:206: first defined here

vim +226 drivers/opp/cpu.c

6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  194  
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  195  /**
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  196   * dev_pm_opp_get_sharing_cpus() - Get cpumask of CPUs sharing OPPs with @cpu_dev
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  197   * @cpu_dev:	CPU device for which we do this operation
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  198   * @cpumask:	cpumask to update with information of sharing CPUs
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  199   *
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  200   * This updates the @cpumask with CPUs that are sharing OPPs with @cpu_dev.
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  201   *
79ee2e8f730411 drivers/base/power/opp/cpu.c Viresh Kumar  2016-06-16  202   * Returns -ENODEV if OPP table isn't already present and -EINVAL if the OPP
79ee2e8f730411 drivers/base/power/opp/cpu.c Viresh Kumar  2016-06-16  203   * table's status is access-unknown.
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  204   */
ddbb74bc70c0db drivers/base/power/opp/cpu.c Arnd Bergmann 2016-04-30  205  int dev_pm_opp_get_sharing_cpus(struct device *cpu_dev, struct cpumask *cpumask)
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  206  {
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  207  	struct opp_device *opp_dev;
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  208  	struct opp_table *opp_table;
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  209  	int ret = 0;
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  210  
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  211  	opp_table = _find_opp_table(cpu_dev);
5b650b388844f2 drivers/base/power/opp/cpu.c Viresh Kumar  2017-01-23  212  	if (IS_ERR(opp_table))
5b650b388844f2 drivers/base/power/opp/cpu.c Viresh Kumar  2017-01-23  213  		return PTR_ERR(opp_table);
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  214  
79ee2e8f730411 drivers/base/power/opp/cpu.c Viresh Kumar  2016-06-16  215  	if (opp_table->shared_opp == OPP_TABLE_ACCESS_UNKNOWN) {
79ee2e8f730411 drivers/base/power/opp/cpu.c Viresh Kumar  2016-06-16  216  		ret = -EINVAL;
5b650b388844f2 drivers/base/power/opp/cpu.c Viresh Kumar  2017-01-23  217  		goto put_opp_table;
79ee2e8f730411 drivers/base/power/opp/cpu.c Viresh Kumar  2016-06-16  218  	}
79ee2e8f730411 drivers/base/power/opp/cpu.c Viresh Kumar  2016-06-16  219  
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  220  	cpumask_clear(cpumask);
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  221  
79ee2e8f730411 drivers/base/power/opp/cpu.c Viresh Kumar  2016-06-16  222  	if (opp_table->shared_opp == OPP_TABLE_ACCESS_SHARED) {
3d2556992a878a drivers/opp/cpu.c            Viresh Kumar  2018-08-03  223  		mutex_lock(&opp_table->lock);
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  224  		list_for_each_entry(opp_dev, &opp_table->dev_list, node)
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar  2016-04-27  225  			cpumask_set_cpu(opp_dev->dev->id, cpumask);
3d2556992a878a drivers/opp/cpu.c            Viresh Kumar  2018-08-03 @226  		mutex_unlock(&opp_table->lock);

:::::: The code at line 226 was first introduced by commit
:::::: 3d2556992a878a2210d3be498416aee39e0c32aa OPP: Protect dev_list with opp_table lock

:::::: TO: Viresh Kumar <viresh.kumar@linaro.org>
:::::: CC: Viresh Kumar <viresh.kumar@linaro.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26188 bytes --]