From: Andrew-sh.Cheng <andrew-sh.cheng@mediatek.com> To: MyungJoo Ham <myungjoo.ham@samsung.com>, Kyungmin Park <kyungmin.park@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, "Rob Herring" <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, "Matthias Brugger" <matthias.bgg@gmail.com>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Viresh Kumar <viresh.kumar@linaro.org>, Nishanth Menon <nm@ti.com>, "Stephen Boyd" <sboyd@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org> Cc: devicetree@vger.kernel.org, Saravana Kannan <saravanak@google.com>, srv_heupstream@mediatek.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 04/12] PM / devfreq: Cache OPP table reference in devfreq Date: Wed, 20 May 2020 11:42:59 +0800 [thread overview] Message-ID: <20200520034307.20435-5-andrew-sh.cheng@mediatek.com> (raw) In-Reply-To: <20200520034307.20435-1-andrew-sh.cheng@mediatek.com> From: Saravana Kannan <saravanak@google.com> The OPP table can be used often in devfreq. Trying to get it each time can be expensive, so cache it in the devfreq struct. Signed-off-by: Saravana Kannan <saravanak@google.com> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> --- drivers/devfreq/devfreq.c | 6 ++++++ include/linux/devfreq.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 6fecd11dafdd..1103a3ae5586 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -719,6 +719,8 @@ static void devfreq_dev_release(struct device *dev) if (devfreq->profile->exit) devfreq->profile->exit(devfreq->dev.parent); + if (devfreq->opp_table) + dev_pm_opp_put_opp_table(devfreq->opp_table); mutex_destroy(&devfreq->lock); kfree(devfreq); } @@ -797,6 +799,10 @@ struct devfreq *devfreq_add_device(struct device *dev, } devfreq->suspend_freq = dev_pm_opp_get_suspend_opp_freq(dev); + devfreq->opp_table = dev_pm_opp_get_opp_table(dev); + if (IS_ERR(devfreq->opp_table)) + devfreq->opp_table = NULL; + atomic_set(&devfreq->suspend_count, 0); dev_set_name(&devfreq->dev, "%s", dev_name(dev)); diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h index 57e871a559a9..a4b19d593151 100644 --- a/include/linux/devfreq.h +++ b/include/linux/devfreq.h @@ -131,6 +131,7 @@ struct devfreq_stats { * @profile: device-specific devfreq profile * @governor: method how to choose frequency based on the usage. * @governor_name: devfreq governor name for use with this devfreq + * @opp_table: Reference to OPP table of dev.parent, if one exists. * @nb: notifier block used to notify devfreq object that it should * reevaluate operable frequencies. Devfreq users may use * devfreq.nb to the corresponding register notifier call chain. @@ -168,6 +169,7 @@ struct devfreq { struct devfreq_dev_profile *profile; const struct devfreq_governor *governor; char governor_name[DEVFREQ_NAME_LEN]; + struct opp_table *opp_table; struct notifier_block nb; struct delayed_work work; -- 2.12.5 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Andrew-sh.Cheng <andrew-sh.cheng@mediatek.com> To: MyungJoo Ham <myungjoo.ham@samsung.com>, Kyungmin Park <kyungmin.park@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, "Rob Herring" <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, "Matthias Brugger" <matthias.bgg@gmail.com>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Viresh Kumar <viresh.kumar@linaro.org>, Nishanth Menon <nm@ti.com>, "Stephen Boyd" <sboyd@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org> Cc: devicetree@vger.kernel.org, Saravana Kannan <saravanak@google.com>, srv_heupstream@mediatek.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 04/12] PM / devfreq: Cache OPP table reference in devfreq Date: Wed, 20 May 2020 11:42:59 +0800 [thread overview] Message-ID: <20200520034307.20435-5-andrew-sh.cheng@mediatek.com> (raw) In-Reply-To: <20200520034307.20435-1-andrew-sh.cheng@mediatek.com> From: Saravana Kannan <saravanak@google.com> The OPP table can be used often in devfreq. Trying to get it each time can be expensive, so cache it in the devfreq struct. Signed-off-by: Saravana Kannan <saravanak@google.com> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> --- drivers/devfreq/devfreq.c | 6 ++++++ include/linux/devfreq.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 6fecd11dafdd..1103a3ae5586 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -719,6 +719,8 @@ static void devfreq_dev_release(struct device *dev) if (devfreq->profile->exit) devfreq->profile->exit(devfreq->dev.parent); + if (devfreq->opp_table) + dev_pm_opp_put_opp_table(devfreq->opp_table); mutex_destroy(&devfreq->lock); kfree(devfreq); } @@ -797,6 +799,10 @@ struct devfreq *devfreq_add_device(struct device *dev, } devfreq->suspend_freq = dev_pm_opp_get_suspend_opp_freq(dev); + devfreq->opp_table = dev_pm_opp_get_opp_table(dev); + if (IS_ERR(devfreq->opp_table)) + devfreq->opp_table = NULL; + atomic_set(&devfreq->suspend_count, 0); dev_set_name(&devfreq->dev, "%s", dev_name(dev)); diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h index 57e871a559a9..a4b19d593151 100644 --- a/include/linux/devfreq.h +++ b/include/linux/devfreq.h @@ -131,6 +131,7 @@ struct devfreq_stats { * @profile: device-specific devfreq profile * @governor: method how to choose frequency based on the usage. * @governor_name: devfreq governor name for use with this devfreq + * @opp_table: Reference to OPP table of dev.parent, if one exists. * @nb: notifier block used to notify devfreq object that it should * reevaluate operable frequencies. Devfreq users may use * devfreq.nb to the corresponding register notifier call chain. @@ -168,6 +169,7 @@ struct devfreq { struct devfreq_dev_profile *profile; const struct devfreq_governor *governor; char governor_name[DEVFREQ_NAME_LEN]; + struct opp_table *opp_table; struct notifier_block nb; struct delayed_work work; -- 2.12.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-20 3:54 UTC|newest] Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20200520034324epcas1p3affbd24bd1f3fe40d51baade07c1abba@epcas1p3.samsung.com> 2020-05-20 3:42 ` [PATCH 00/12] Add cpufreq and cci devfreq for mt8183, and SVS support Andrew-sh.Cheng 2020-05-20 3:42 ` Andrew-sh.Cheng 2020-05-20 3:42 ` [PATCH 01/12] OPP: Allow required-opps even if the device doesn't have power-domains Andrew-sh.Cheng 2020-05-20 3:42 ` Andrew-sh.Cheng 2020-05-20 14:54 ` Matthias Brugger 2020-05-20 14:54 ` Matthias Brugger 2020-05-20 14:54 ` Matthias Brugger 2020-05-21 1:50 ` andrew-sh.cheng 2020-05-21 1:50 ` andrew-sh.cheng 2020-05-20 3:42 ` [PATCH 02/12] OPP: Add function to look up required OPP's for a given OPP Andrew-sh.Cheng 2020-05-20 3:42 ` Andrew-sh.Cheng 2020-05-20 3:42 ` [PATCH 03/12] OPP: Improve required-opps linking Andrew-sh.Cheng 2020-05-20 3:42 ` Andrew-sh.Cheng 2020-05-20 22:46 ` kbuild test robot 2020-05-21 1:10 ` kbuild test robot 2020-05-20 3:42 ` Andrew-sh.Cheng [this message] 2020-05-20 3:42 ` [PATCH 04/12] PM / devfreq: Cache OPP table reference in devfreq Andrew-sh.Cheng 2020-05-20 3:43 ` [PATCH 05/12] PM / devfreq: Add required OPPs support to passive governor Andrew-sh.Cheng 2020-05-20 3:43 ` Andrew-sh.Cheng 2020-05-20 3:43 ` [PATCH 06/12] PM / devfreq: Add cpu based scaling support to passive_governor Andrew-sh.Cheng 2020-05-20 3:43 ` Andrew-sh.Cheng 2020-05-28 5:03 ` Chanwoo Choi 2020-05-28 5:03 ` Chanwoo Choi 2020-05-28 5:03 ` Chanwoo Choi 2020-05-28 6:14 ` Chanwoo Choi 2020-05-28 6:14 ` Chanwoo Choi 2020-05-28 6:14 ` Chanwoo Choi 2020-05-28 7:17 ` Chanwoo Choi 2020-05-28 7:17 ` Chanwoo Choi 2020-05-28 7:17 ` Chanwoo Choi 2020-06-02 12:23 ` andrew-sh.cheng 2020-06-02 12:23 ` andrew-sh.cheng 2020-06-03 4:12 ` Chanwoo Choi 2020-06-03 4:12 ` Chanwoo Choi 2020-06-03 4:12 ` Chanwoo Choi 2020-06-02 11:43 ` andrew-sh.cheng 2020-06-02 11:43 ` andrew-sh.cheng 2020-06-03 4:07 ` Chanwoo Choi 2020-06-03 4:07 ` Chanwoo Choi 2020-06-03 4:07 ` Chanwoo Choi 2020-06-17 7:59 ` andrew-sh.cheng 2020-06-17 7:59 ` andrew-sh.cheng 2020-05-20 3:43 ` [PATCH 07/12] cpufreq: mediatek: Enable clock and regulator Andrew-sh.Cheng 2020-05-20 3:43 ` Andrew-sh.Cheng 2020-05-20 3:43 ` [PATCH 08/12] dt-bindings: devfreq: add compatible for mt8183 cci devfreq Andrew-sh.Cheng 2020-05-20 3:43 ` Andrew-sh.Cheng 2020-05-28 7:42 ` Chanwoo Choi 2020-05-28 7:42 ` Chanwoo Choi 2020-05-28 7:42 ` Chanwoo Choi 2020-06-17 12:05 ` andrew-sh.cheng 2020-06-17 12:05 ` andrew-sh.cheng 2020-05-20 3:43 ` [PATCH 09/12] devfreq: add mediatek " Andrew-sh.Cheng 2020-05-20 3:43 ` Andrew-sh.Cheng 2020-05-20 12:31 ` Mark Brown 2020-05-20 12:31 ` Mark Brown 2020-05-20 12:31 ` Mark Brown 2020-05-21 8:52 ` andrew-sh.cheng 2020-05-21 8:52 ` andrew-sh.cheng 2020-05-21 8:52 ` andrew-sh.cheng 2020-05-28 7:35 ` Chanwoo Choi 2020-05-28 7:35 ` Chanwoo Choi 2020-05-28 7:35 ` Chanwoo Choi 2020-05-28 8:00 ` Chanwoo Choi 2020-05-28 8:00 ` Chanwoo Choi 2020-05-28 8:00 ` Chanwoo Choi 2020-05-20 3:43 ` [PATCH 10/12] opp: Modify opp API, dev_pm_opp_get_freq(), find freq in opp, even it is disabled Andrew-sh.Cheng 2020-05-20 3:43 ` Andrew-sh.Cheng 2020-05-20 3:43 ` [PATCH 11/12] cpufreq: mediatek: add opp notification for SVS support Andrew-sh.Cheng 2020-05-20 3:43 ` Andrew-sh.Cheng 2020-05-20 3:43 ` [PATCH 12/12] devfreq: mediatek: cci devfreq register " Andrew-sh.Cheng 2020-05-20 3:43 ` Andrew-sh.Cheng 2020-05-20 4:10 ` [PATCH 00/12] Add cpufreq and cci devfreq for mt8183, and " Chanwoo Choi 2020-05-20 4:10 ` Chanwoo Choi 2020-05-20 4:10 ` Chanwoo Choi 2020-05-20 5:36 ` andrew-sh.cheng 2020-05-20 5:36 ` andrew-sh.cheng 2020-05-20 6:24 ` Chanwoo Choi 2020-05-20 6:24 ` Chanwoo Choi 2020-05-20 6:24 ` Chanwoo Choi 2020-05-20 7:10 ` andrew-sh.cheng 2020-05-20 7:10 ` andrew-sh.cheng 2020-05-20 14:53 ` Matthias Brugger 2020-05-20 14:53 ` Matthias Brugger 2020-05-20 14:53 ` Matthias Brugger 2020-06-15 7:31 ` Viresh Kumar 2020-06-15 7:31 ` Viresh Kumar 2020-06-15 7:31 ` Viresh Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200520034307.20435-5-andrew-sh.cheng@mediatek.com \ --to=andrew-sh.cheng@mediatek.com \ --cc=broonie@kernel.org \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=kyungmin.park@samsung.com \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=matthias.bgg@gmail.com \ --cc=myungjoo.ham@samsung.com \ --cc=nm@ti.com \ --cc=rjw@rjwysocki.net \ --cc=robh+dt@kernel.org \ --cc=saravanak@google.com \ --cc=sboyd@kernel.org \ --cc=srv_heupstream@mediatek.com \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.