From: Chanwoo Choi <cw00.choi@samsung.com>
To: "andrew-sh.cheng" <andrew-sh.cheng@mediatek.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Nishanth Menon <nm@ti.com>, Stephen Boyd <sboyd@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
Sibi Sankar <sibis@codeaurora.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 06/12] PM / devfreq: Add cpu based scaling support to passive_governor
Date: Wed, 3 Jun 2020 13:12:54 +0900 [thread overview]
Message-ID: <89ecb940-d613-1b18-c7fc-abab4d4264c2@samsung.com> (raw)
In-Reply-To: <1591100614.1804.1.camel@mtksdaap41>
Hi Andrew-sh.Cheng,
On 6/2/20 9:23 PM, andrew-sh.cheng wrote:
> On Thu, 2020-05-28 at 16:17 +0900, Chanwoo Choi wrote:
>> Hi Andrew-sh.Cheng,
>>
>> The exynos-bus.c used the passive governor.
>> Even if don't make the problem because DEVFREQ_PARENT_DEV is zero,
>> you need to initialize the parent_type with DEVFREQ_PARENT_DEV as following:
>>
>> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
>> index 8fa8eb541373..1c71c47bc2ac 100644
>> --- a/drivers/devfreq/exynos-bus.c
>> +++ b/drivers/devfreq/exynos-bus.c
>> @@ -369,6 +369,7 @@ static int exynos_bus_profile_init_passive(struct exynos_bus *bus,
>> return -ENOMEM;
>>
>> passive_data->parent = parent_devfreq;
>> + passive_data->parent_type = DEVFREQ_PARENT_DEV;
>>
>> /* Add devfreq device for exynos bus with passive governor */
>> bus->devfreq = devm_devfreq_add_device(dev, profile, DEVFREQ_GOV_PASSIVE,
> Hi Chanwoo Choi,
> Do you just remind me to initialize it to DEVFREQ_PARENT_DEV whn use
> this governor?
Yes. This change was not included in this patchset.
> I will do it and thank you for reminding.
Thanks.
(snip)
And, this patchset doesn't include the dt-binding example
and any real example in devicetree. If possible, I recommend
you better to update dt-binding document with example.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: Chanwoo Choi <cw00.choi@samsung.com>
To: "andrew-sh.cheng" <andrew-sh.cheng@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Nishanth Menon <nm@ti.com>,
srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
Stephen Boyd <sboyd@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Mark Brown <broonie@kernel.org>,
linux-pm@vger.kernel.org,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
linux-mediatek@lists.infradead.org,
Sibi Sankar <sibis@codeaurora.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 06/12] PM / devfreq: Add cpu based scaling support to passive_governor
Date: Wed, 3 Jun 2020 13:12:54 +0900 [thread overview]
Message-ID: <89ecb940-d613-1b18-c7fc-abab4d4264c2@samsung.com> (raw)
In-Reply-To: <1591100614.1804.1.camel@mtksdaap41>
Hi Andrew-sh.Cheng,
On 6/2/20 9:23 PM, andrew-sh.cheng wrote:
> On Thu, 2020-05-28 at 16:17 +0900, Chanwoo Choi wrote:
>> Hi Andrew-sh.Cheng,
>>
>> The exynos-bus.c used the passive governor.
>> Even if don't make the problem because DEVFREQ_PARENT_DEV is zero,
>> you need to initialize the parent_type with DEVFREQ_PARENT_DEV as following:
>>
>> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
>> index 8fa8eb541373..1c71c47bc2ac 100644
>> --- a/drivers/devfreq/exynos-bus.c
>> +++ b/drivers/devfreq/exynos-bus.c
>> @@ -369,6 +369,7 @@ static int exynos_bus_profile_init_passive(struct exynos_bus *bus,
>> return -ENOMEM;
>>
>> passive_data->parent = parent_devfreq;
>> + passive_data->parent_type = DEVFREQ_PARENT_DEV;
>>
>> /* Add devfreq device for exynos bus with passive governor */
>> bus->devfreq = devm_devfreq_add_device(dev, profile, DEVFREQ_GOV_PASSIVE,
> Hi Chanwoo Choi,
> Do you just remind me to initialize it to DEVFREQ_PARENT_DEV whn use
> this governor?
Yes. This change was not included in this patchset.
> I will do it and thank you for reminding.
Thanks.
(snip)
And, this patchset doesn't include the dt-binding example
and any real example in devicetree. If possible, I recommend
you better to update dt-binding document with example.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Chanwoo Choi <cw00.choi@samsung.com>
To: "andrew-sh.cheng" <andrew-sh.cheng@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Nishanth Menon <nm@ti.com>,
srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
Stephen Boyd <sboyd@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Mark Brown <broonie@kernel.org>,
linux-pm@vger.kernel.org,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
linux-mediatek@lists.infradead.org,
Sibi Sankar <sibis@codeaurora.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 06/12] PM / devfreq: Add cpu based scaling support to passive_governor
Date: Wed, 3 Jun 2020 13:12:54 +0900 [thread overview]
Message-ID: <89ecb940-d613-1b18-c7fc-abab4d4264c2@samsung.com> (raw)
In-Reply-To: <1591100614.1804.1.camel@mtksdaap41>
Hi Andrew-sh.Cheng,
On 6/2/20 9:23 PM, andrew-sh.cheng wrote:
> On Thu, 2020-05-28 at 16:17 +0900, Chanwoo Choi wrote:
>> Hi Andrew-sh.Cheng,
>>
>> The exynos-bus.c used the passive governor.
>> Even if don't make the problem because DEVFREQ_PARENT_DEV is zero,
>> you need to initialize the parent_type with DEVFREQ_PARENT_DEV as following:
>>
>> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
>> index 8fa8eb541373..1c71c47bc2ac 100644
>> --- a/drivers/devfreq/exynos-bus.c
>> +++ b/drivers/devfreq/exynos-bus.c
>> @@ -369,6 +369,7 @@ static int exynos_bus_profile_init_passive(struct exynos_bus *bus,
>> return -ENOMEM;
>>
>> passive_data->parent = parent_devfreq;
>> + passive_data->parent_type = DEVFREQ_PARENT_DEV;
>>
>> /* Add devfreq device for exynos bus with passive governor */
>> bus->devfreq = devm_devfreq_add_device(dev, profile, DEVFREQ_GOV_PASSIVE,
> Hi Chanwoo Choi,
> Do you just remind me to initialize it to DEVFREQ_PARENT_DEV whn use
> this governor?
Yes. This change was not included in this patchset.
> I will do it and thank you for reminding.
Thanks.
(snip)
And, this patchset doesn't include the dt-binding example
and any real example in devicetree. If possible, I recommend
you better to update dt-binding document with example.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-03 4:02 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200520034324epcas1p3affbd24bd1f3fe40d51baade07c1abba@epcas1p3.samsung.com>
2020-05-20 3:42 ` [PATCH 00/12] Add cpufreq and cci devfreq for mt8183, and SVS support Andrew-sh.Cheng
2020-05-20 3:42 ` Andrew-sh.Cheng
2020-05-20 3:42 ` [PATCH 01/12] OPP: Allow required-opps even if the device doesn't have power-domains Andrew-sh.Cheng
2020-05-20 3:42 ` Andrew-sh.Cheng
2020-05-20 14:54 ` Matthias Brugger
2020-05-20 14:54 ` Matthias Brugger
2020-05-20 14:54 ` Matthias Brugger
2020-05-21 1:50 ` andrew-sh.cheng
2020-05-21 1:50 ` andrew-sh.cheng
2020-05-20 3:42 ` [PATCH 02/12] OPP: Add function to look up required OPP's for a given OPP Andrew-sh.Cheng
2020-05-20 3:42 ` Andrew-sh.Cheng
2020-05-20 3:42 ` [PATCH 03/12] OPP: Improve required-opps linking Andrew-sh.Cheng
2020-05-20 3:42 ` Andrew-sh.Cheng
2020-05-20 22:46 ` kbuild test robot
2020-05-21 1:10 ` kbuild test robot
2020-05-20 3:42 ` [PATCH 04/12] PM / devfreq: Cache OPP table reference in devfreq Andrew-sh.Cheng
2020-05-20 3:42 ` Andrew-sh.Cheng
2020-05-20 3:43 ` [PATCH 05/12] PM / devfreq: Add required OPPs support to passive governor Andrew-sh.Cheng
2020-05-20 3:43 ` Andrew-sh.Cheng
2020-05-20 3:43 ` [PATCH 06/12] PM / devfreq: Add cpu based scaling support to passive_governor Andrew-sh.Cheng
2020-05-20 3:43 ` Andrew-sh.Cheng
2020-05-28 5:03 ` Chanwoo Choi
2020-05-28 5:03 ` Chanwoo Choi
2020-05-28 5:03 ` Chanwoo Choi
2020-05-28 6:14 ` Chanwoo Choi
2020-05-28 6:14 ` Chanwoo Choi
2020-05-28 6:14 ` Chanwoo Choi
2020-05-28 7:17 ` Chanwoo Choi
2020-05-28 7:17 ` Chanwoo Choi
2020-05-28 7:17 ` Chanwoo Choi
2020-06-02 12:23 ` andrew-sh.cheng
2020-06-02 12:23 ` andrew-sh.cheng
2020-06-03 4:12 ` Chanwoo Choi [this message]
2020-06-03 4:12 ` Chanwoo Choi
2020-06-03 4:12 ` Chanwoo Choi
2020-06-02 11:43 ` andrew-sh.cheng
2020-06-02 11:43 ` andrew-sh.cheng
2020-06-03 4:07 ` Chanwoo Choi
2020-06-03 4:07 ` Chanwoo Choi
2020-06-03 4:07 ` Chanwoo Choi
2020-06-17 7:59 ` andrew-sh.cheng
2020-06-17 7:59 ` andrew-sh.cheng
2020-05-20 3:43 ` [PATCH 07/12] cpufreq: mediatek: Enable clock and regulator Andrew-sh.Cheng
2020-05-20 3:43 ` Andrew-sh.Cheng
2020-05-20 3:43 ` [PATCH 08/12] dt-bindings: devfreq: add compatible for mt8183 cci devfreq Andrew-sh.Cheng
2020-05-20 3:43 ` Andrew-sh.Cheng
2020-05-28 7:42 ` Chanwoo Choi
2020-05-28 7:42 ` Chanwoo Choi
2020-05-28 7:42 ` Chanwoo Choi
2020-06-17 12:05 ` andrew-sh.cheng
2020-06-17 12:05 ` andrew-sh.cheng
2020-05-20 3:43 ` [PATCH 09/12] devfreq: add mediatek " Andrew-sh.Cheng
2020-05-20 3:43 ` Andrew-sh.Cheng
2020-05-20 12:31 ` Mark Brown
2020-05-20 12:31 ` Mark Brown
2020-05-20 12:31 ` Mark Brown
2020-05-21 8:52 ` andrew-sh.cheng
2020-05-21 8:52 ` andrew-sh.cheng
2020-05-21 8:52 ` andrew-sh.cheng
2020-05-28 7:35 ` Chanwoo Choi
2020-05-28 7:35 ` Chanwoo Choi
2020-05-28 7:35 ` Chanwoo Choi
2020-05-28 8:00 ` Chanwoo Choi
2020-05-28 8:00 ` Chanwoo Choi
2020-05-28 8:00 ` Chanwoo Choi
2020-05-20 3:43 ` [PATCH 10/12] opp: Modify opp API, dev_pm_opp_get_freq(), find freq in opp, even it is disabled Andrew-sh.Cheng
2020-05-20 3:43 ` Andrew-sh.Cheng
2020-05-20 3:43 ` [PATCH 11/12] cpufreq: mediatek: add opp notification for SVS support Andrew-sh.Cheng
2020-05-20 3:43 ` Andrew-sh.Cheng
2020-05-20 3:43 ` [PATCH 12/12] devfreq: mediatek: cci devfreq register " Andrew-sh.Cheng
2020-05-20 3:43 ` Andrew-sh.Cheng
2020-05-20 4:10 ` [PATCH 00/12] Add cpufreq and cci devfreq for mt8183, and " Chanwoo Choi
2020-05-20 4:10 ` Chanwoo Choi
2020-05-20 4:10 ` Chanwoo Choi
2020-05-20 5:36 ` andrew-sh.cheng
2020-05-20 5:36 ` andrew-sh.cheng
2020-05-20 6:24 ` Chanwoo Choi
2020-05-20 6:24 ` Chanwoo Choi
2020-05-20 6:24 ` Chanwoo Choi
2020-05-20 7:10 ` andrew-sh.cheng
2020-05-20 7:10 ` andrew-sh.cheng
2020-05-20 14:53 ` Matthias Brugger
2020-05-20 14:53 ` Matthias Brugger
2020-05-20 14:53 ` Matthias Brugger
2020-06-15 7:31 ` Viresh Kumar
2020-06-15 7:31 ` Viresh Kumar
2020-06-15 7:31 ` Viresh Kumar
2020-05-21 16:09 [PATCH 06/12] PM / devfreq: Add cpu based scaling support to passive_governor kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89ecb940-d613-1b18-c7fc-abab4d4264c2@samsung.com \
--to=cw00.choi@samsung.com \
--cc=andrew-sh.cheng@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sibis@codeaurora.org \
--cc=srv_heupstream@mediatek.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.