From: andrew-sh.cheng <andrew-sh.cheng@mediatek.com> To: Chanwoo Choi <cw00.choi@samsung.com> Cc: Mark Rutland <mark.rutland@arm.com>, Nishanth Menon <nm@ti.com>, srv_heupstream@mediatek.com, linux-pm@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>, Mark Brown <broonie@kernel.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Liam Girdwood <lgirdwood@gmail.com>, Rob Herring <robh+dt@kernel.org>, linux-kernel@vger.kernel.org, Kyungmin Park <kyungmin.park@samsung.com>, MyungJoo Ham <myungjoo.ham@samsung.com>, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger <matthias.bgg@gmail.com>, devicetree@vger.kernel.org Subject: Re: [PATCH 08/12] dt-bindings: devfreq: add compatible for mt8183 cci devfreq Date: Wed, 17 Jun 2020 20:05:20 +0800 [thread overview] Message-ID: <1592395520.30389.2.camel@mtksdaap41> (raw) In-Reply-To: <4087bcdb-a247-3d2d-96b2-16f965e8ba5c@samsung.com> On Thu, 2020-05-28 at 16:42 +0900, Chanwoo Choi wrote: > Hi, > > On 5/20/20 12:43 PM, Andrew-sh.Cheng wrote: > > This adds dt-binding documentation of cci devfreq > > for Mediatek MT8183 SoC platform. > > > > Signed-off-by: Andrew-sh.Cheng <andrew-sh.cheng@mediatek.com> > > --- > > .../devicetree/bindings/devfreq/mt8183-cci.yaml | 51 ++++++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/devfreq/mt8183-cci.yaml > > > > diff --git a/Documentation/devicetree/bindings/devfreq/mt8183-cci.yaml b/Documentation/devicetree/bindings/devfreq/mt8183-cci.yaml > > new file mode 100644 > > index 000000000000..a7341fd94097 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/devfreq/mt8183-cci.yaml > > @@ -0,0 +1,51 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: https://protect2.fireeye.com/url?k=33f1f15d-6e23ea05-33f07a12-0cc47a31c8b4-91b3f8aeecce95dc&q=1&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fdevfreq%2Fmt8183-cci.yaml%23 > > +$schema: https://protect2.fireeye.com/url?k=fc7d9089-a1af8bd1-fc7c1bc6-0cc47a31c8b4-b46f5afc59faf86d&q=1&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 > > + > > +title: CCI_DEVFREQ driver for MT8183. > > + > > +maintainers: > > + - Andrew-sh.Cheng <andrew-sh.cheng@mediatek.com> > > + > > +description: | > > + This module is used to create CCI DEVFREQ. > > + The performance will depend on both CCI frequency and CPU frequency. > > + For MT8183, CCI co-buck with Little core. > > + Contain CCI opp table for voltage and frequency scaling. > > + > > +properties: > > + compatible: > > + const: "mediatek,mt8183-cci" > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + const: "cci" > > + > > + operating-points-v2: true > > + opp-table: true > > + > > + proc-supply: > > + description: > > + Phandle of the regulator that provides the supply voltage. > > + > > +required: > > + - compatible > > + - clocks > > + - clock-names > > + - proc-supply > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/mt8183-clk.h> > > + cci: cci { > > + compatible = "mediatek,mt8183-cci"; > > + clocks = <&apmixedsys CLK_APMIXED_CCIPLL>; > > + clock-names = "cci"; > > + operating-points-v2 = <&cci_opp>; > > + proc-supply = <&mt6358_vproc12_reg>; > > + }; > > + > > > > I recommend that add the more detailed example > with OPP table with CPU node. > Hi Chanwoo Choi, Actually, for previous versions of my patch set, I didn't use governor_passive as cci_devfreq governor. So I think it is okay that not provide CPU OPP node for this cci device node. > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: andrew-sh.cheng <andrew-sh.cheng@mediatek.com> To: Chanwoo Choi <cw00.choi@samsung.com> Cc: Mark Rutland <mark.rutland@arm.com>, Nishanth Menon <nm@ti.com>, srv_heupstream@mediatek.com, linux-pm@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>, Mark Brown <broonie@kernel.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Liam Girdwood <lgirdwood@gmail.com>, Rob Herring <robh+dt@kernel.org>, linux-kernel@vger.kernel.org, Kyungmin Park <kyungmin.park@samsung.com>, MyungJoo Ham <myungjoo.ham@samsung.com>, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger <matthias.bgg@gmail.com>, devicetree@vger.kernel.org Subject: Re: [PATCH 08/12] dt-bindings: devfreq: add compatible for mt8183 cci devfreq Date: Wed, 17 Jun 2020 20:05:20 +0800 [thread overview] Message-ID: <1592395520.30389.2.camel@mtksdaap41> (raw) In-Reply-To: <4087bcdb-a247-3d2d-96b2-16f965e8ba5c@samsung.com> On Thu, 2020-05-28 at 16:42 +0900, Chanwoo Choi wrote: > Hi, > > On 5/20/20 12:43 PM, Andrew-sh.Cheng wrote: > > This adds dt-binding documentation of cci devfreq > > for Mediatek MT8183 SoC platform. > > > > Signed-off-by: Andrew-sh.Cheng <andrew-sh.cheng@mediatek.com> > > --- > > .../devicetree/bindings/devfreq/mt8183-cci.yaml | 51 ++++++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/devfreq/mt8183-cci.yaml > > > > diff --git a/Documentation/devicetree/bindings/devfreq/mt8183-cci.yaml b/Documentation/devicetree/bindings/devfreq/mt8183-cci.yaml > > new file mode 100644 > > index 000000000000..a7341fd94097 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/devfreq/mt8183-cci.yaml > > @@ -0,0 +1,51 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: https://protect2.fireeye.com/url?k=33f1f15d-6e23ea05-33f07a12-0cc47a31c8b4-91b3f8aeecce95dc&q=1&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fdevfreq%2Fmt8183-cci.yaml%23 > > +$schema: https://protect2.fireeye.com/url?k=fc7d9089-a1af8bd1-fc7c1bc6-0cc47a31c8b4-b46f5afc59faf86d&q=1&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 > > + > > +title: CCI_DEVFREQ driver for MT8183. > > + > > +maintainers: > > + - Andrew-sh.Cheng <andrew-sh.cheng@mediatek.com> > > + > > +description: | > > + This module is used to create CCI DEVFREQ. > > + The performance will depend on both CCI frequency and CPU frequency. > > + For MT8183, CCI co-buck with Little core. > > + Contain CCI opp table for voltage and frequency scaling. > > + > > +properties: > > + compatible: > > + const: "mediatek,mt8183-cci" > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + const: "cci" > > + > > + operating-points-v2: true > > + opp-table: true > > + > > + proc-supply: > > + description: > > + Phandle of the regulator that provides the supply voltage. > > + > > +required: > > + - compatible > > + - clocks > > + - clock-names > > + - proc-supply > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/mt8183-clk.h> > > + cci: cci { > > + compatible = "mediatek,mt8183-cci"; > > + clocks = <&apmixedsys CLK_APMIXED_CCIPLL>; > > + clock-names = "cci"; > > + operating-points-v2 = <&cci_opp>; > > + proc-supply = <&mt6358_vproc12_reg>; > > + }; > > + > > > > I recommend that add the more detailed example > with OPP table with CPU node. > Hi Chanwoo Choi, Actually, for previous versions of my patch set, I didn't use governor_passive as cci_devfreq governor. So I think it is okay that not provide CPU OPP node for this cci device node. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-17 12:05 UTC|newest] Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20200520034324epcas1p3affbd24bd1f3fe40d51baade07c1abba@epcas1p3.samsung.com> 2020-05-20 3:42 ` [PATCH 00/12] Add cpufreq and cci devfreq for mt8183, and SVS support Andrew-sh.Cheng 2020-05-20 3:42 ` Andrew-sh.Cheng 2020-05-20 3:42 ` [PATCH 01/12] OPP: Allow required-opps even if the device doesn't have power-domains Andrew-sh.Cheng 2020-05-20 3:42 ` Andrew-sh.Cheng 2020-05-20 14:54 ` Matthias Brugger 2020-05-20 14:54 ` Matthias Brugger 2020-05-20 14:54 ` Matthias Brugger 2020-05-21 1:50 ` andrew-sh.cheng 2020-05-21 1:50 ` andrew-sh.cheng 2020-05-20 3:42 ` [PATCH 02/12] OPP: Add function to look up required OPP's for a given OPP Andrew-sh.Cheng 2020-05-20 3:42 ` Andrew-sh.Cheng 2020-05-20 3:42 ` [PATCH 03/12] OPP: Improve required-opps linking Andrew-sh.Cheng 2020-05-20 3:42 ` Andrew-sh.Cheng 2020-05-20 22:46 ` kbuild test robot 2020-05-21 1:10 ` kbuild test robot 2020-05-20 3:42 ` [PATCH 04/12] PM / devfreq: Cache OPP table reference in devfreq Andrew-sh.Cheng 2020-05-20 3:42 ` Andrew-sh.Cheng 2020-05-20 3:43 ` [PATCH 05/12] PM / devfreq: Add required OPPs support to passive governor Andrew-sh.Cheng 2020-05-20 3:43 ` Andrew-sh.Cheng 2020-05-20 3:43 ` [PATCH 06/12] PM / devfreq: Add cpu based scaling support to passive_governor Andrew-sh.Cheng 2020-05-20 3:43 ` Andrew-sh.Cheng 2020-05-28 5:03 ` Chanwoo Choi 2020-05-28 5:03 ` Chanwoo Choi 2020-05-28 5:03 ` Chanwoo Choi 2020-05-28 6:14 ` Chanwoo Choi 2020-05-28 6:14 ` Chanwoo Choi 2020-05-28 6:14 ` Chanwoo Choi 2020-05-28 7:17 ` Chanwoo Choi 2020-05-28 7:17 ` Chanwoo Choi 2020-05-28 7:17 ` Chanwoo Choi 2020-06-02 12:23 ` andrew-sh.cheng 2020-06-02 12:23 ` andrew-sh.cheng 2020-06-03 4:12 ` Chanwoo Choi 2020-06-03 4:12 ` Chanwoo Choi 2020-06-03 4:12 ` Chanwoo Choi 2020-06-02 11:43 ` andrew-sh.cheng 2020-06-02 11:43 ` andrew-sh.cheng 2020-06-03 4:07 ` Chanwoo Choi 2020-06-03 4:07 ` Chanwoo Choi 2020-06-03 4:07 ` Chanwoo Choi 2020-06-17 7:59 ` andrew-sh.cheng 2020-06-17 7:59 ` andrew-sh.cheng 2020-05-20 3:43 ` [PATCH 07/12] cpufreq: mediatek: Enable clock and regulator Andrew-sh.Cheng 2020-05-20 3:43 ` Andrew-sh.Cheng 2020-05-20 3:43 ` [PATCH 08/12] dt-bindings: devfreq: add compatible for mt8183 cci devfreq Andrew-sh.Cheng 2020-05-20 3:43 ` Andrew-sh.Cheng 2020-05-28 7:42 ` Chanwoo Choi 2020-05-28 7:42 ` Chanwoo Choi 2020-05-28 7:42 ` Chanwoo Choi 2020-06-17 12:05 ` andrew-sh.cheng [this message] 2020-06-17 12:05 ` andrew-sh.cheng 2020-05-20 3:43 ` [PATCH 09/12] devfreq: add mediatek " Andrew-sh.Cheng 2020-05-20 3:43 ` Andrew-sh.Cheng 2020-05-20 12:31 ` Mark Brown 2020-05-20 12:31 ` Mark Brown 2020-05-20 12:31 ` Mark Brown 2020-05-21 8:52 ` andrew-sh.cheng 2020-05-21 8:52 ` andrew-sh.cheng 2020-05-21 8:52 ` andrew-sh.cheng 2020-05-28 7:35 ` Chanwoo Choi 2020-05-28 7:35 ` Chanwoo Choi 2020-05-28 7:35 ` Chanwoo Choi 2020-05-28 8:00 ` Chanwoo Choi 2020-05-28 8:00 ` Chanwoo Choi 2020-05-28 8:00 ` Chanwoo Choi 2020-05-20 3:43 ` [PATCH 10/12] opp: Modify opp API, dev_pm_opp_get_freq(), find freq in opp, even it is disabled Andrew-sh.Cheng 2020-05-20 3:43 ` Andrew-sh.Cheng 2020-05-20 3:43 ` [PATCH 11/12] cpufreq: mediatek: add opp notification for SVS support Andrew-sh.Cheng 2020-05-20 3:43 ` Andrew-sh.Cheng 2020-05-20 3:43 ` [PATCH 12/12] devfreq: mediatek: cci devfreq register " Andrew-sh.Cheng 2020-05-20 3:43 ` Andrew-sh.Cheng 2020-05-20 4:10 ` [PATCH 00/12] Add cpufreq and cci devfreq for mt8183, and " Chanwoo Choi 2020-05-20 4:10 ` Chanwoo Choi 2020-05-20 4:10 ` Chanwoo Choi 2020-05-20 5:36 ` andrew-sh.cheng 2020-05-20 5:36 ` andrew-sh.cheng 2020-05-20 6:24 ` Chanwoo Choi 2020-05-20 6:24 ` Chanwoo Choi 2020-05-20 6:24 ` Chanwoo Choi 2020-05-20 7:10 ` andrew-sh.cheng 2020-05-20 7:10 ` andrew-sh.cheng 2020-05-20 14:53 ` Matthias Brugger 2020-05-20 14:53 ` Matthias Brugger 2020-05-20 14:53 ` Matthias Brugger 2020-06-15 7:31 ` Viresh Kumar 2020-06-15 7:31 ` Viresh Kumar 2020-06-15 7:31 ` Viresh Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1592395520.30389.2.camel@mtksdaap41 \ --to=andrew-sh.cheng@mediatek.com \ --cc=broonie@kernel.org \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=kyungmin.park@samsung.com \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=matthias.bgg@gmail.com \ --cc=myungjoo.ham@samsung.com \ --cc=nm@ti.com \ --cc=rjw@rjwysocki.net \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=srv_heupstream@mediatek.com \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.