From: Pavel Machek <pavel@ucw.cz>
To: Michael Walle <michael@walle.cc>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Lee Jones <lee.jones@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Uwe Kleine-K??nig <u.kleine-koenig@pengutronix.de>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>, Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v5 12/13] arm64: dts: freescale: sl28: enable LED support
Date: Fri, 17 Jul 2020 10:36:10 +0200 [thread overview]
Message-ID: <20200717083610.GC1027@bug> (raw)
In-Reply-To: <20200706175353.16404-13-michael@walle.cc>
Hi!
> Now that we have support for GPIO lines of the SMARC connector, enable
> LED support on the KBox A-230-LS. There are two LEDs without fixed
> functions, one is yellow and one is green. Unfortunately, it is just one
> multi-color LED, thus while it is possible to enable both at the same
> time it is hard to tell the difference between "yellow only" and "yellow
> and green".
> + user_yellow {
> + label = "s1914:yellow:user";
> + gpios = <&sl28cpld_gpio0 0 0>;
> + };
> +
> + user_green {
> + label = "s1914:green:user";
> + gpios = <&sl28cpld_gpio1 3 0>;
> + };
This is not suitable label for such LEDs... there's zero chance userland will
know what to do with these.
Do they have some kind of "usual" function?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Michael Walle <michael@walle.cc>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Lee Jones <lee.jones@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Uwe Kleine-K??nig <u.kleine-koenig@pengutronix.de>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>, Mark Brown <broonie@>
Subject: Re: [PATCH v5 12/13] arm64: dts: freescale: sl28: enable LED support
Date: Fri, 17 Jul 2020 10:36:10 +0200 [thread overview]
Message-ID: <20200717083610.GC1027@bug> (raw)
In-Reply-To: <20200706175353.16404-13-michael@walle.cc>
Hi!
> Now that we have support for GPIO lines of the SMARC connector, enable
> LED support on the KBox A-230-LS. There are two LEDs without fixed
> functions, one is yellow and one is green. Unfortunately, it is just one
> multi-color LED, thus while it is possible to enable both at the same
> time it is hard to tell the difference between "yellow only" and "yellow
> and green".
> + user_yellow {
> + label = "s1914:yellow:user";
> + gpios = <&sl28cpld_gpio0 0 0>;
> + };
> +
> + user_green {
> + label = "s1914:green:user";
> + gpios = <&sl28cpld_gpio1 3 0>;
> + };
This is not suitable label for such LEDs... there's zero chance userland will
know what to do with these.
Do they have some kind of "usual" function?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Michael Walle <michael@walle.cc>
Cc: devicetree@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Jason Cooper <jason@lakedaemon.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Marc Zyngier <maz@kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Uwe Kleine-K??nig <u.kleine-koenig@pengutronix.de>,
Guenter Roeck <linux@roeck-us.net>,
linux-pwm@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
linux-watchdog@vger.kernel.org, linux-gpio@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-arm-kernel@lists.infradead.org,
linux-hwmon@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Li Yang <leoyang.li@nxp.com>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v5 12/13] arm64: dts: freescale: sl28: enable LED support
Date: Fri, 17 Jul 2020 10:36:10 +0200 [thread overview]
Message-ID: <20200717083610.GC1027@bug> (raw)
In-Reply-To: <20200706175353.16404-13-michael@walle.cc>
Hi!
> Now that we have support for GPIO lines of the SMARC connector, enable
> LED support on the KBox A-230-LS. There are two LEDs without fixed
> functions, one is yellow and one is green. Unfortunately, it is just one
> multi-color LED, thus while it is possible to enable both at the same
> time it is hard to tell the difference between "yellow only" and "yellow
> and green".
> + user_yellow {
> + label = "s1914:yellow:user";
> + gpios = <&sl28cpld_gpio0 0 0>;
> + };
> +
> + user_green {
> + label = "s1914:green:user";
> + gpios = <&sl28cpld_gpio1 3 0>;
> + };
This is not suitable label for such LEDs... there's zero chance userland will
know what to do with these.
Do they have some kind of "usual" function?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-17 8:36 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 17:53 [PATCH v5 00/13] Add support for Kontron sl28cpld Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-06 17:53 ` [PATCH v5 01/13] regmap-irq: use fwnode instead of device node in add_irq_chip() Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-08 10:22 ` Mark Brown
2020-07-08 10:22 ` Mark Brown
2020-07-08 10:22 ` Mark Brown
2020-07-06 17:53 ` [PATCH v5 02/13] mfd: add simple regmap based I2C driver Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-17 9:04 ` Lee Jones
2020-07-17 9:04 ` Lee Jones
2020-07-17 9:04 ` Lee Jones
2020-07-19 22:25 ` Michael Walle
2020-07-19 22:25 ` Michael Walle
2020-07-19 22:25 ` Michael Walle
2020-07-17 9:06 ` Lee Jones
2020-07-17 9:06 ` Lee Jones
2020-07-17 9:06 ` Lee Jones
2020-07-19 22:31 ` Michael Walle
2020-07-19 22:31 ` Michael Walle
2020-07-19 22:31 ` Michael Walle
2020-07-20 7:43 ` Lee Jones
2020-07-20 7:43 ` Lee Jones
2020-07-20 7:43 ` Lee Jones
2020-07-06 17:53 ` [PATCH v5 03/13] dt-bindings: mfd: Add bindings for sl28cpld Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-13 16:04 ` Rob Herring
2020-07-13 16:04 ` Rob Herring
2020-07-13 16:04 ` Rob Herring
2020-07-06 17:53 ` [PATCH v5 04/13] mfd: simple-mfd-i2c: add sl28cpld support Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-06 17:53 ` [PATCH v5 05/13] irqchip: add sl28cpld interrupt controller support Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-08 9:37 ` Marc Zyngier
2020-07-08 9:37 ` Marc Zyngier
2020-07-08 9:37 ` Marc Zyngier
2020-07-06 17:53 ` [PATCH v5 06/13] watchdog: add support for sl28cpld watchdog Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-06 17:53 ` [PATCH v5 07/13] pwm: add support for sl28cpld PWM controller Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-09 8:50 ` Uwe Kleine-König
2020-07-09 8:50 ` Uwe Kleine-König
2020-07-09 8:50 ` Uwe Kleine-König
2020-07-11 17:28 ` Michael Walle
2020-07-11 17:28 ` Michael Walle
2020-07-11 17:28 ` Michael Walle
2020-07-13 8:47 ` Uwe Kleine-König
2020-07-13 8:47 ` Uwe Kleine-König
2020-07-13 8:47 ` Uwe Kleine-König
2020-07-14 11:31 ` Michael Walle
2020-07-14 11:31 ` Michael Walle
2020-07-14 11:31 ` Michael Walle
2020-07-14 16:08 ` Uwe Kleine-König
2020-07-14 16:08 ` Uwe Kleine-König
2020-07-14 16:08 ` Uwe Kleine-König
2020-07-14 21:09 ` Michael Walle
2020-07-14 21:09 ` Michael Walle
2020-07-14 21:09 ` Michael Walle
2020-07-15 16:36 ` Uwe Kleine-König
2020-07-15 16:36 ` Uwe Kleine-König
2020-07-15 16:36 ` Uwe Kleine-König
2020-07-15 17:45 ` Michael Walle
2020-07-15 17:45 ` Michael Walle
2020-07-15 17:45 ` Michael Walle
2020-07-15 18:18 ` Uwe Kleine-König
2020-07-15 18:18 ` Uwe Kleine-König
2020-07-15 18:18 ` Uwe Kleine-König
2020-07-15 20:41 ` Michael Walle
2020-07-15 20:41 ` Michael Walle
2020-07-15 20:41 ` Michael Walle
2020-07-16 6:10 ` Uwe Kleine-König
2020-07-16 6:10 ` Uwe Kleine-König
2020-07-16 6:10 ` Uwe Kleine-König
2020-07-06 17:53 ` [PATCH v5 08/13] gpio: add support for the sl28cpld GPIO controller Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-08 7:35 ` Linus Walleij
2020-07-08 7:35 ` Linus Walleij
2020-07-08 7:35 ` Linus Walleij
2020-07-17 0:25 ` kernel test robot
2020-07-17 0:25 ` kernel test robot
2020-07-06 17:53 ` [PATCH v5 09/13] hwmon: add support for the sl28cpld hardware monitoring controller Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-06 17:53 ` [PATCH v5 10/13] arm64: dts: freescale: sl28: enable sl28cpld Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-06 17:53 ` [PATCH v5 11/13] arm64: dts: freescale: sl28: map GPIOs to input events Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-06 17:53 ` [PATCH v5 12/13] arm64: dts: freescale: sl28: enable LED support Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-17 8:36 ` Pavel Machek [this message]
2020-07-17 8:36 ` Pavel Machek
2020-07-17 8:36 ` Pavel Machek
2020-07-17 21:54 ` Michael Walle
2020-07-17 21:54 ` Michael Walle
2020-07-17 21:54 ` Michael Walle
2020-07-06 17:53 ` [PATCH v5 13/13] arm64: dts: freescale: sl28: enable fan support Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-08 7:39 ` Linus Walleij
2020-07-08 7:39 ` Linus Walleij
2020-07-08 7:39 ` Linus Walleij
2020-07-08 7:56 ` Michael Walle
2020-07-08 7:56 ` Michael Walle
2020-07-08 7:56 ` Michael Walle
2020-07-08 17:00 ` [PATCH v5 00/13] Add support for Kontron sl28cpld Mark Brown
2020-07-08 17:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717083610.GC1027@bug \
--to=pavel@ucw.cz \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason@lakedaemon.net \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maz@kernel.org \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.