From: Michael Walle <michael@walle.cc>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Shawn Guo" <shawnguo@kernel.org>, "Li Yang" <leoyang.li@nxp.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Jason Cooper" <jason@lakedaemon.net>,
"Marc Zyngier" <maz@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v5 02/13] mfd: add simple regmap based I2C driver
Date: Mon, 20 Jul 2020 00:31:29 +0200 [thread overview]
Message-ID: <52d85ea1ddc488762df547168e2001e9@walle.cc> (raw)
In-Reply-To: <20200717090656.GF3165313@dell>
Am 2020-07-17 11:06, schrieb Lee Jones:
> On Mon, 06 Jul 2020, Michael Walle wrote:
>
>> There are I2C devices which contain several different functions but
>> doesn't require any special access functions. For these kind of
>> drivers
>> an I2C regmap should be enough.
>>
>> Create an I2C driver which creates an I2C regmap and enumerates its
>> children. If a device wants to use this as its MFD core driver, it has
>> to add an individual compatible string. It may provide its own regmap
>> configuration.
>>
>> Subdevices can use dev_get_regmap() on the parent to get their regmap
>> instance.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> Changes since v4:
>> - new patch. Lee, please bear with me. I didn't want to delay the
>> new version (where a lot of remarks on the other patches were
>> addressed) even more, just because we haven't figured out how
>> to deal with the MFD part. So for now, I've included this one.
>>
>> drivers/mfd/Kconfig | 9 +++++++
>> drivers/mfd/Makefile | 1 +
>> drivers/mfd/simple-mfd-i2c.c | 50
>> ++++++++++++++++++++++++++++++++++++
>> 3 files changed, 60 insertions(+)
>> create mode 100644 drivers/mfd/simple-mfd-i2c.c
>>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index 33df0837ab41..f1536a710aca 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -1162,6 +1162,15 @@ config MFD_SI476X_CORE
>> To compile this driver as a module, choose M here: the
>> module will be called si476x-core.
>>
>> +config MFD_SIMPLE_MFD_I2C
>> + tristate "Simple regmap based I2C devices"
>
> Doesn't look like tristate to me.
>
> Haven't you made this builtin only?
Mh yeah, I forgot to change it to module in the driver. I don't
know whats better though, have it tristate or just offer a boolean
option because it should be small anyway. What do you think?
My interrupt driver will force it to boolean anyway.
>
>> + depends on I2C
>> + select MFD_CORE
>
> Why?
leftover :( I'll remove it.
>> + select REGMAP_I2C
>> + help
>> + This is a consolidated driver for all MFD devices which are
>> + basically just a regmap bus driver.
>
> Please expand on this. I think it deserves greater explanation.
ok.
>
>> config MFD_SM501
>> tristate "Silicon Motion SM501"
>> depends on HAS_DMA
--
-michael
WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael-QKn5cuLxLXY@public.gmane.org>
To: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-hwmon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
"Linus Walleij"
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Bartosz Golaszewski"
<bgolaszewski-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Jean Delvare" <jdelvare-IBi9RG/b67k@public.gmane.org>,
"Guenter Roeck" <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
"Thierry Reding"
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"Wim Van Sebroeck"
<wim-Q8PRGTgFL9WUCWQAtAn6Ix2eb7JE58TQ@public.gmane.org>,
"Shawn Guo" <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Li Yang" <leoyang.li-3arQi8VN3Tc@public.gmane.org>,
"Thomas Gleixner" <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
"Jason Cooper" <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
"Marc Zyngier" <maz-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Mark Brown" <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v5 02/13] mfd: add simple regmap based I2C driver
Date: Mon, 20 Jul 2020 00:31:29 +0200 [thread overview]
Message-ID: <52d85ea1ddc488762df547168e2001e9@walle.cc> (raw)
In-Reply-To: <20200717090656.GF3165313@dell>
Am 2020-07-17 11:06, schrieb Lee Jones:
> On Mon, 06 Jul 2020, Michael Walle wrote:
>
>> There are I2C devices which contain several different functions but
>> doesn't require any special access functions. For these kind of
>> drivers
>> an I2C regmap should be enough.
>>
>> Create an I2C driver which creates an I2C regmap and enumerates its
>> children. If a device wants to use this as its MFD core driver, it has
>> to add an individual compatible string. It may provide its own regmap
>> configuration.
>>
>> Subdevices can use dev_get_regmap() on the parent to get their regmap
>> instance.
>>
>> Signed-off-by: Michael Walle <michael-QKn5cuLxLXY@public.gmane.org>
>> ---
>> Changes since v4:
>> - new patch. Lee, please bear with me. I didn't want to delay the
>> new version (where a lot of remarks on the other patches were
>> addressed) even more, just because we haven't figured out how
>> to deal with the MFD part. So for now, I've included this one.
>>
>> drivers/mfd/Kconfig | 9 +++++++
>> drivers/mfd/Makefile | 1 +
>> drivers/mfd/simple-mfd-i2c.c | 50
>> ++++++++++++++++++++++++++++++++++++
>> 3 files changed, 60 insertions(+)
>> create mode 100644 drivers/mfd/simple-mfd-i2c.c
>>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index 33df0837ab41..f1536a710aca 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -1162,6 +1162,15 @@ config MFD_SI476X_CORE
>> To compile this driver as a module, choose M here: the
>> module will be called si476x-core.
>>
>> +config MFD_SIMPLE_MFD_I2C
>> + tristate "Simple regmap based I2C devices"
>
> Doesn't look like tristate to me.
>
> Haven't you made this builtin only?
Mh yeah, I forgot to change it to module in the driver. I don't
know whats better though, have it tristate or just offer a boolean
option because it should be small anyway. What do you think?
My interrupt driver will force it to boolean anyway.
>
>> + depends on I2C
>> + select MFD_CORE
>
> Why?
leftover :( I'll remove it.
>> + select REGMAP_I2C
>> + help
>> + This is a consolidated driver for all MFD devices which are
>> + basically just a regmap bus driver.
>
> Please expand on this. I think it deserves greater explanation.
ok.
>
>> config MFD_SM501
>> tristate "Silicon Motion SM501"
>> depends on HAS_DMA
--
-michael
WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc>
To: Lee Jones <lee.jones@linaro.org>
Cc: devicetree@vger.kernel.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jason Cooper" <jason@lakedaemon.net>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Marc Zyngier" <maz@kernel.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Guenter Roeck" <linux@roeck-us.net>,
linux-pwm@vger.kernel.org, "Jean Delvare" <jdelvare@suse.com>,
linux-watchdog@vger.kernel.org, linux-gpio@vger.kernel.org,
"Mark Brown" <broonie@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
linux-arm-kernel@lists.infradead.org,
linux-hwmon@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, "Li Yang" <leoyang.li@nxp.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>
Subject: Re: [PATCH v5 02/13] mfd: add simple regmap based I2C driver
Date: Mon, 20 Jul 2020 00:31:29 +0200 [thread overview]
Message-ID: <52d85ea1ddc488762df547168e2001e9@walle.cc> (raw)
In-Reply-To: <20200717090656.GF3165313@dell>
Am 2020-07-17 11:06, schrieb Lee Jones:
> On Mon, 06 Jul 2020, Michael Walle wrote:
>
>> There are I2C devices which contain several different functions but
>> doesn't require any special access functions. For these kind of
>> drivers
>> an I2C regmap should be enough.
>>
>> Create an I2C driver which creates an I2C regmap and enumerates its
>> children. If a device wants to use this as its MFD core driver, it has
>> to add an individual compatible string. It may provide its own regmap
>> configuration.
>>
>> Subdevices can use dev_get_regmap() on the parent to get their regmap
>> instance.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> Changes since v4:
>> - new patch. Lee, please bear with me. I didn't want to delay the
>> new version (where a lot of remarks on the other patches were
>> addressed) even more, just because we haven't figured out how
>> to deal with the MFD part. So for now, I've included this one.
>>
>> drivers/mfd/Kconfig | 9 +++++++
>> drivers/mfd/Makefile | 1 +
>> drivers/mfd/simple-mfd-i2c.c | 50
>> ++++++++++++++++++++++++++++++++++++
>> 3 files changed, 60 insertions(+)
>> create mode 100644 drivers/mfd/simple-mfd-i2c.c
>>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index 33df0837ab41..f1536a710aca 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -1162,6 +1162,15 @@ config MFD_SI476X_CORE
>> To compile this driver as a module, choose M here: the
>> module will be called si476x-core.
>>
>> +config MFD_SIMPLE_MFD_I2C
>> + tristate "Simple regmap based I2C devices"
>
> Doesn't look like tristate to me.
>
> Haven't you made this builtin only?
Mh yeah, I forgot to change it to module in the driver. I don't
know whats better though, have it tristate or just offer a boolean
option because it should be small anyway. What do you think?
My interrupt driver will force it to boolean anyway.
>
>> + depends on I2C
>> + select MFD_CORE
>
> Why?
leftover :( I'll remove it.
>> + select REGMAP_I2C
>> + help
>> + This is a consolidated driver for all MFD devices which are
>> + basically just a regmap bus driver.
>
> Please expand on this. I think it deserves greater explanation.
ok.
>
>> config MFD_SM501
>> tristate "Silicon Motion SM501"
>> depends on HAS_DMA
--
-michael
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-19 22:31 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 17:53 [PATCH v5 00/13] Add support for Kontron sl28cpld Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-06 17:53 ` [PATCH v5 01/13] regmap-irq: use fwnode instead of device node in add_irq_chip() Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-08 10:22 ` Mark Brown
2020-07-08 10:22 ` Mark Brown
2020-07-08 10:22 ` Mark Brown
2020-07-06 17:53 ` [PATCH v5 02/13] mfd: add simple regmap based I2C driver Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-17 9:04 ` Lee Jones
2020-07-17 9:04 ` Lee Jones
2020-07-17 9:04 ` Lee Jones
2020-07-19 22:25 ` Michael Walle
2020-07-19 22:25 ` Michael Walle
2020-07-19 22:25 ` Michael Walle
2020-07-17 9:06 ` Lee Jones
2020-07-17 9:06 ` Lee Jones
2020-07-17 9:06 ` Lee Jones
2020-07-19 22:31 ` Michael Walle [this message]
2020-07-19 22:31 ` Michael Walle
2020-07-19 22:31 ` Michael Walle
2020-07-20 7:43 ` Lee Jones
2020-07-20 7:43 ` Lee Jones
2020-07-20 7:43 ` Lee Jones
2020-07-06 17:53 ` [PATCH v5 03/13] dt-bindings: mfd: Add bindings for sl28cpld Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-13 16:04 ` Rob Herring
2020-07-13 16:04 ` Rob Herring
2020-07-13 16:04 ` Rob Herring
2020-07-06 17:53 ` [PATCH v5 04/13] mfd: simple-mfd-i2c: add sl28cpld support Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-06 17:53 ` [PATCH v5 05/13] irqchip: add sl28cpld interrupt controller support Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-08 9:37 ` Marc Zyngier
2020-07-08 9:37 ` Marc Zyngier
2020-07-08 9:37 ` Marc Zyngier
2020-07-06 17:53 ` [PATCH v5 06/13] watchdog: add support for sl28cpld watchdog Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-06 17:53 ` [PATCH v5 07/13] pwm: add support for sl28cpld PWM controller Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-09 8:50 ` Uwe Kleine-König
2020-07-09 8:50 ` Uwe Kleine-König
2020-07-09 8:50 ` Uwe Kleine-König
2020-07-11 17:28 ` Michael Walle
2020-07-11 17:28 ` Michael Walle
2020-07-11 17:28 ` Michael Walle
2020-07-13 8:47 ` Uwe Kleine-König
2020-07-13 8:47 ` Uwe Kleine-König
2020-07-13 8:47 ` Uwe Kleine-König
2020-07-14 11:31 ` Michael Walle
2020-07-14 11:31 ` Michael Walle
2020-07-14 11:31 ` Michael Walle
2020-07-14 16:08 ` Uwe Kleine-König
2020-07-14 16:08 ` Uwe Kleine-König
2020-07-14 16:08 ` Uwe Kleine-König
2020-07-14 21:09 ` Michael Walle
2020-07-14 21:09 ` Michael Walle
2020-07-14 21:09 ` Michael Walle
2020-07-15 16:36 ` Uwe Kleine-König
2020-07-15 16:36 ` Uwe Kleine-König
2020-07-15 16:36 ` Uwe Kleine-König
2020-07-15 17:45 ` Michael Walle
2020-07-15 17:45 ` Michael Walle
2020-07-15 17:45 ` Michael Walle
2020-07-15 18:18 ` Uwe Kleine-König
2020-07-15 18:18 ` Uwe Kleine-König
2020-07-15 18:18 ` Uwe Kleine-König
2020-07-15 20:41 ` Michael Walle
2020-07-15 20:41 ` Michael Walle
2020-07-15 20:41 ` Michael Walle
2020-07-16 6:10 ` Uwe Kleine-König
2020-07-16 6:10 ` Uwe Kleine-König
2020-07-16 6:10 ` Uwe Kleine-König
2020-07-06 17:53 ` [PATCH v5 08/13] gpio: add support for the sl28cpld GPIO controller Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-08 7:35 ` Linus Walleij
2020-07-08 7:35 ` Linus Walleij
2020-07-08 7:35 ` Linus Walleij
2020-07-17 0:25 ` kernel test robot
2020-07-17 0:25 ` kernel test robot
2020-07-06 17:53 ` [PATCH v5 09/13] hwmon: add support for the sl28cpld hardware monitoring controller Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-06 17:53 ` [PATCH v5 10/13] arm64: dts: freescale: sl28: enable sl28cpld Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-06 17:53 ` [PATCH v5 11/13] arm64: dts: freescale: sl28: map GPIOs to input events Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-06 17:53 ` [PATCH v5 12/13] arm64: dts: freescale: sl28: enable LED support Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-17 8:36 ` Pavel Machek
2020-07-17 8:36 ` Pavel Machek
2020-07-17 8:36 ` Pavel Machek
2020-07-17 21:54 ` Michael Walle
2020-07-17 21:54 ` Michael Walle
2020-07-17 21:54 ` Michael Walle
2020-07-06 17:53 ` [PATCH v5 13/13] arm64: dts: freescale: sl28: enable fan support Michael Walle
2020-07-06 17:53 ` Michael Walle
2020-07-08 7:39 ` Linus Walleij
2020-07-08 7:39 ` Linus Walleij
2020-07-08 7:39 ` Linus Walleij
2020-07-08 7:56 ` Michael Walle
2020-07-08 7:56 ` Michael Walle
2020-07-08 7:56 ` Michael Walle
2020-07-08 17:00 ` [PATCH v5 00/13] Add support for Kontron sl28cpld Mark Brown
2020-07-08 17:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52d85ea1ddc488762df547168e2001e9@walle.cc \
--to=michael@walle.cc \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason@lakedaemon.net \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.