From: Andre Przywara <andre.przywara@arm.com> To: Samuel Holland <samuel@sholland.org> Cc: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Rob Herring <robh+dt@kernel.org>, Mesih Kilinc <mesihkilinc@gmail.com>, Icenowy Zheng <icenowy@aosc.io>, Jesse Taube <mr.bossman075@gmail.com>, Giulio Benetti <giulio.benetti@benettiengineering.com>, George Hilliard <thirtythreeforty@gmail.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Wim Van Sebroeck <wim@linux-watchdog.org>, Guenter Roeck <linux@roeck-us.net>, linux-watchdog@vger.kernel.org Subject: Re: [PATCH 01/14] dt-bindings: watchdog: sunxi: fix F1C100s compatible Date: Mon, 14 Mar 2022 17:39:16 +0000 [thread overview] Message-ID: <20220314173839.2a7b593a@slackpad.lan> (raw) In-Reply-To: <661806b7-d63f-a7cf-9192-f67c4cd79f29@sholland.org> On Wed, 9 Mar 2022 18:46:46 -0600 Samuel Holland <samuel@sholland.org> wrote: > Hi Andre, > > On 3/7/22 8:34 AM, Andre Przywara wrote: > > The F1C100 series actually features a newer generation watchdog IP, so > > the compatible string was wrong. > > The F1C100s watchdog seems to be unique in that it uses LOSC/osc32k as its only > clock source instead of HOSC/osc24M. The current binding requires that the first > clock is "hosc", so it seems that the binding needs to be relaxed to allow for > this case. > > As long as there's only one clock source available, we don't really care where > it comes from. They are both divided to be approximately 32 kHz. So I don't > think this difference prevents using A31 as a fallback compatible. Right, these were roughly my findings as well, but I should have written them down, at least in the commit message. So shall the binding be explicit: 1) Most SoCs required exactly one clock, the 24 MHz HOSC. 2) The F1C100s requires exactly one clock, the 32KHz LOSC. 3) R329/D1 require two clocks with clock-names? Or do you want to collapse 1) and 2) into one relaxed case? Still not entirely sure what "LOSC / 32 KHz" means for the F1C100 (32768 or 32000 Hz), or where it really comes from, but it does not seem to matter. FreeBSD, Xen and U-Boot don't care about clocks at all, and Linux always uses the first clock and just enables it, so we should be good either way. > > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > > --- > > .../devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml > > index 43afa24513b9..d90655418d0e 100644 > > --- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml > > +++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml > > @@ -29,7 +29,7 @@ properties: > > - const: allwinner,sun6i-a31-wdt > > - items: > > - const: allwinner,suniv-f1c100s-wdt > > - - const: allwinner,sun4i-a10-wdt > > + - const: allwinner,sun6i-a31-wdt > > This can be combined with the enum of other compatibles that fall back to > allwinner,sun6i-a31-wdt (earlier in the file). Oh, right, I missed that. Cheers, Andre > > Regards, > Samuel > > > - const: allwinner,sun20i-d1-wdt > > - items: > > - const: allwinner,sun20i-d1-wdt-reset > > > >
WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com> To: Samuel Holland <samuel@sholland.org> Cc: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Rob Herring <robh+dt@kernel.org>, Mesih Kilinc <mesihkilinc@gmail.com>, Icenowy Zheng <icenowy@aosc.io>, Jesse Taube <mr.bossman075@gmail.com>, Giulio Benetti <giulio.benetti@benettiengineering.com>, George Hilliard <thirtythreeforty@gmail.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Wim Van Sebroeck <wim@linux-watchdog.org>, Guenter Roeck <linux@roeck-us.net>, linux-watchdog@vger.kernel.org Subject: Re: [PATCH 01/14] dt-bindings: watchdog: sunxi: fix F1C100s compatible Date: Mon, 14 Mar 2022 17:39:16 +0000 [thread overview] Message-ID: <20220314173839.2a7b593a@slackpad.lan> (raw) In-Reply-To: <661806b7-d63f-a7cf-9192-f67c4cd79f29@sholland.org> On Wed, 9 Mar 2022 18:46:46 -0600 Samuel Holland <samuel@sholland.org> wrote: > Hi Andre, > > On 3/7/22 8:34 AM, Andre Przywara wrote: > > The F1C100 series actually features a newer generation watchdog IP, so > > the compatible string was wrong. > > The F1C100s watchdog seems to be unique in that it uses LOSC/osc32k as its only > clock source instead of HOSC/osc24M. The current binding requires that the first > clock is "hosc", so it seems that the binding needs to be relaxed to allow for > this case. > > As long as there's only one clock source available, we don't really care where > it comes from. They are both divided to be approximately 32 kHz. So I don't > think this difference prevents using A31 as a fallback compatible. Right, these were roughly my findings as well, but I should have written them down, at least in the commit message. So shall the binding be explicit: 1) Most SoCs required exactly one clock, the 24 MHz HOSC. 2) The F1C100s requires exactly one clock, the 32KHz LOSC. 3) R329/D1 require two clocks with clock-names? Or do you want to collapse 1) and 2) into one relaxed case? Still not entirely sure what "LOSC / 32 KHz" means for the F1C100 (32768 or 32000 Hz), or where it really comes from, but it does not seem to matter. FreeBSD, Xen and U-Boot don't care about clocks at all, and Linux always uses the first clock and just enables it, so we should be good either way. > > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > > --- > > .../devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml > > index 43afa24513b9..d90655418d0e 100644 > > --- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml > > +++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml > > @@ -29,7 +29,7 @@ properties: > > - const: allwinner,sun6i-a31-wdt > > - items: > > - const: allwinner,suniv-f1c100s-wdt > > - - const: allwinner,sun4i-a10-wdt > > + - const: allwinner,sun6i-a31-wdt > > This can be combined with the enum of other compatibles that fall back to > allwinner,sun6i-a31-wdt (earlier in the file). Oh, right, I missed that. Cheers, Andre > > Regards, > Samuel > > > - const: allwinner,sun20i-d1-wdt > > - items: > > - const: allwinner,sun20i-d1-wdt-reset > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-14 17:40 UTC|newest] Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-07 14:34 [PATCH 00/14] ARM: suniv: dts: update Allwinner F1C100 Andre Przywara 2022-03-07 14:34 ` Andre Przywara 2022-03-07 14:34 ` [PATCH 01/14] dt-bindings: watchdog: sunxi: fix F1C100s compatible Andre Przywara 2022-03-07 14:34 ` Andre Przywara 2022-03-08 16:08 ` Rob Herring 2022-03-08 16:08 ` Rob Herring 2022-03-09 23:02 ` Guenter Roeck 2022-03-09 23:02 ` Guenter Roeck 2022-03-10 0:46 ` Samuel Holland 2022-03-10 0:46 ` Samuel Holland 2022-03-14 17:39 ` Andre Przywara [this message] 2022-03-14 17:39 ` Andre Przywara 2022-03-07 14:34 ` [PATCH 02/14] ARM: dts: suniv: F1C100: fix watchdog compatible Andre Przywara 2022-03-07 14:34 ` Andre Przywara 2022-03-09 23:03 ` Guenter Roeck 2022-03-09 23:03 ` Guenter Roeck 2022-03-07 14:34 ` [PATCH 03/14] dt-bindings: arm: sunxi: document LicheePi Nano name Andre Przywara 2022-03-07 14:34 ` Andre Przywara 2022-03-08 16:09 ` Rob Herring 2022-03-08 16:09 ` Rob Herring 2022-03-11 1:27 ` Samuel Holland 2022-03-11 1:27 ` Samuel Holland 2022-03-07 14:34 ` [PATCH 04/14] ARM: dts: suniv: F1C100: add clock and reset macros Andre Przywara 2022-03-07 14:34 ` Andre Przywara 2022-03-11 1:30 ` Samuel Holland 2022-03-11 1:30 ` Samuel Holland 2022-03-07 14:34 ` [PATCH 05/14] ARM: dts: suniv: F1C100: fix CPU node Andre Przywara 2022-03-07 14:34 ` Andre Przywara 2022-03-08 2:44 ` Jesse Taube 2022-03-08 2:44 ` Jesse Taube 2022-03-08 4:23 ` Icenowy Zheng 2022-03-08 4:23 ` Icenowy Zheng 2022-03-08 10:42 ` Andre Przywara 2022-03-08 10:42 ` Andre Przywara 2022-03-07 14:34 ` [PATCH 06/14] ARM: dts: suniv: F1C100: fix timer node Andre Przywara 2022-03-07 14:34 ` Andre Przywara 2022-03-11 2:19 ` Samuel Holland 2022-03-11 2:19 ` Samuel Holland 2022-03-07 14:34 ` [PATCH 07/14] dt-bindings: mmc: sunxi: add Allwinner F1c100s compatible Andre Przywara 2022-03-07 14:34 ` Andre Przywara 2022-03-08 16:10 ` Rob Herring 2022-03-08 16:10 ` Rob Herring 2022-03-11 2:19 ` Samuel Holland 2022-03-11 2:19 ` Samuel Holland 2022-03-11 15:41 ` Ulf Hansson 2022-03-11 15:41 ` Ulf Hansson 2022-03-07 14:34 ` [PATCH 08/14] ARM: dts: suniv: F1C100: add MMC controllers Andre Przywara 2022-03-07 14:34 ` Andre Przywara 2022-03-11 2:19 ` Samuel Holland 2022-03-11 2:19 ` Samuel Holland 2022-03-07 14:34 ` [PATCH 09/14] ARM: dts: suniv: licheepi-nano: add microSD card Andre Przywara 2022-03-07 14:34 ` Andre Przywara 2022-03-11 2:19 ` Samuel Holland 2022-03-11 2:19 ` Samuel Holland 2022-03-07 14:34 ` [PATCH 10/14] dt-bindings: spi: sunxi: document F1C100 controllers Andre Przywara 2022-03-07 14:34 ` Andre Przywara 2022-03-08 16:10 ` Rob Herring 2022-03-08 16:10 ` Rob Herring 2022-03-11 2:19 ` Samuel Holland 2022-03-11 2:19 ` Samuel Holland 2022-03-07 14:34 ` [PATCH 11/14] ARM: dts: suniv: F1C100: add SPI support Andre Przywara 2022-03-07 14:34 ` Andre Przywara 2022-03-11 2:19 ` Samuel Holland 2022-03-11 2:19 ` Samuel Holland 2022-03-11 13:33 ` Andre Przywara 2022-03-11 13:33 ` Andre Przywara 2022-03-07 14:34 ` [PATCH 12/14] ARM: dts: suniv: licheepi-nano: add SPI flash Andre Przywara 2022-03-07 14:34 ` Andre Przywara 2022-03-11 2:20 ` Samuel Holland 2022-03-11 2:20 ` Samuel Holland 2022-03-07 14:34 ` [PATCH 13/14] ARM: configs: sync multi_v5_defconfig from savedefconfig Andre Przywara 2022-03-07 14:34 ` Andre Przywara 2022-03-08 9:38 ` Arnd Bergmann 2022-03-08 9:38 ` Arnd Bergmann 2022-03-08 12:07 ` Andre Przywara 2022-03-08 12:07 ` Andre Przywara 2022-03-08 13:33 ` Arnd Bergmann 2022-03-08 13:33 ` Arnd Bergmann 2022-03-08 13:40 ` Arnd Bergmann 2022-03-08 13:40 ` Arnd Bergmann 2022-03-08 14:30 ` Nicolas Ferre 2022-03-08 14:30 ` Nicolas Ferre 2022-03-08 15:17 ` Arnd Bergmann 2022-03-08 15:17 ` Arnd Bergmann 2022-03-10 10:33 ` Andre Przywara 2022-03-10 10:33 ` Andre Przywara 2022-03-07 14:34 ` [PATCH 14/14] ARM: configs: multi_v5: Enable Allwinner F1C100 Andre Przywara 2022-03-07 14:34 ` Andre Przywara 2022-03-07 18:03 ` [PATCH 00/14] ARM: suniv: dts: update " Jesse Taube 2022-03-07 18:03 ` Jesse Taube 2022-03-07 18:22 ` Giulio Benetti 2022-03-07 18:22 ` Giulio Benetti 2022-03-11 1:38 ` Jesse Taube 2022-03-11 1:38 ` Jesse Taube
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220314173839.2a7b593a@slackpad.lan \ --to=andre.przywara@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=giulio.benetti@benettiengineering.com \ --cc=icenowy@aosc.io \ --cc=jernej.skrabec@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=mesihkilinc@gmail.com \ --cc=mr.bossman075@gmail.com \ --cc=mripard@kernel.org \ --cc=robh+dt@kernel.org \ --cc=samuel@sholland.org \ --cc=thirtythreeforty@gmail.com \ --cc=wens@csie.org \ --cc=wim@linux-watchdog.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.