From: Sudeep Holla <sudeep.holla@arm.com>
To: Nikunj Kela <quic_nkela@quicinc.com>
Cc: cristian.marussi@arm.com, robh+dt@kernel.org,
Sudeep Holla <sudeep.holla@arm.com>,
Brian Masney <bmasney@redhat.com>,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
andersson@kernel.org, konrad.dybcio@linaro.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4 1/4] firmware: arm_scmi: Add polling support for completion in smc
Date: Wed, 4 Oct 2023 17:11:40 +0100 [thread overview]
Message-ID: <20231004161140.uzqb4eapyo6gd7xm@bogus> (raw)
In-Reply-To: <1c58a05b-1337-0287-225f-5a73b4c6828e@quicinc.com>
On Tue, Oct 03, 2023 at 08:53:20AM -0700, Nikunj Kela wrote:
>
> On 10/3/2023 3:33 AM, Sudeep Holla wrote:
> > On Mon, Sep 11, 2023 at 12:43:56PM -0700, Nikunj Kela wrote:
> > > Currently, the return from the smc call assumes the completion of
> > > the scmi request. However this may not be true in virtual platforms
> > > that are using hvc doorbell.
> > >
> > Hmm, it is expectation from SMCCC for the fast calls. Is you HVC FID
> > not a fast call. AFAIK, only TOS use yielding calls. Are you using them
> > here ? If not, this must complete when the SMC/HVC returns. We added
> > support for platforms indicating the same via interrupt.
> >
> > I would like to avoid adding this build config. Why does it require polling ?
> > Broken firmware ? I would add a compatible for that. Or if the qcom always
> > wants to do this way, just make it specific to the qcom compatible.
> >
> > I would avoid a config flag as it needs to be always enabled for single
> > image and affects other platforms as well. So please drop this change.
> > If this is absolutely needed, just add additional property which DT
> > maintainers may not like as it is more like a policy or just make it
> > compatible specific.
> >
> > --
> > Regards,
> > Sudeep
> We are using Fast call FID. We are using completion IRQ for all the scmi
> instances except one where we need to communicate with the server when GIC
> is in suspended state in HLOS. We will need to poll the channel for
> completion in that use case. I am open to suggestions.
IIUC, for the sake of that one corner case, you have added the polling
Kconfig and will be enabled for all the case and even on other platforms
in a single Image. I think we could be something better, no ?
Please share details on that one corner case.
Is it in the scmi drivers already ? If so, specifics please.
If no, again provide details on how you plan to use. We do have ways
to make a polling call, but haven't mixed it with interrupt based calls
for a reason, but we can revisit if it makes sense.
--
Regards,
Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Nikunj Kela <quic_nkela@quicinc.com>
Cc: cristian.marussi@arm.com, robh+dt@kernel.org,
Sudeep Holla <sudeep.holla@arm.com>,
Brian Masney <bmasney@redhat.com>,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
andersson@kernel.org, konrad.dybcio@linaro.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4 1/4] firmware: arm_scmi: Add polling support for completion in smc
Date: Wed, 4 Oct 2023 17:11:40 +0100 [thread overview]
Message-ID: <20231004161140.uzqb4eapyo6gd7xm@bogus> (raw)
In-Reply-To: <1c58a05b-1337-0287-225f-5a73b4c6828e@quicinc.com>
On Tue, Oct 03, 2023 at 08:53:20AM -0700, Nikunj Kela wrote:
>
> On 10/3/2023 3:33 AM, Sudeep Holla wrote:
> > On Mon, Sep 11, 2023 at 12:43:56PM -0700, Nikunj Kela wrote:
> > > Currently, the return from the smc call assumes the completion of
> > > the scmi request. However this may not be true in virtual platforms
> > > that are using hvc doorbell.
> > >
> > Hmm, it is expectation from SMCCC for the fast calls. Is you HVC FID
> > not a fast call. AFAIK, only TOS use yielding calls. Are you using them
> > here ? If not, this must complete when the SMC/HVC returns. We added
> > support for platforms indicating the same via interrupt.
> >
> > I would like to avoid adding this build config. Why does it require polling ?
> > Broken firmware ? I would add a compatible for that. Or if the qcom always
> > wants to do this way, just make it specific to the qcom compatible.
> >
> > I would avoid a config flag as it needs to be always enabled for single
> > image and affects other platforms as well. So please drop this change.
> > If this is absolutely needed, just add additional property which DT
> > maintainers may not like as it is more like a policy or just make it
> > compatible specific.
> >
> > --
> > Regards,
> > Sudeep
> We are using Fast call FID. We are using completion IRQ for all the scmi
> instances except one where we need to communicate with the server when GIC
> is in suspended state in HLOS. We will need to poll the channel for
> completion in that use case. I am open to suggestions.
IIUC, for the sake of that one corner case, you have added the polling
Kconfig and will be enabled for all the case and even on other platforms
in a single Image. I think we could be something better, no ?
Please share details on that one corner case.
Is it in the scmi drivers already ? If so, specifics please.
If no, again provide details on how you plan to use. We do have ways
to make a polling call, but haven't mixed it with interrupt based calls
for a reason, but we can revisit if it makes sense.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-04 16:12 UTC|newest]
Thread overview: 186+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 16:08 [PATCH 0/2] Add qcom hvc/shmem transport Nikunj Kela
2023-07-18 16:08 ` Nikunj Kela
2023-07-18 16:08 ` [PATCH 1/2] dt-bindings: arm: Add qcom specific hvc transport for SCMI Nikunj Kela
2023-07-18 16:08 ` Nikunj Kela
2023-07-18 17:21 ` Rob Herring
2023-07-18 17:21 ` Rob Herring
2023-07-18 18:12 ` Krzysztof Kozlowski
2023-07-18 18:12 ` Krzysztof Kozlowski
2023-07-18 18:18 ` Nikunj Kela
2023-07-18 18:18 ` Nikunj Kela
2023-07-19 10:39 ` Sudeep Holla
2023-07-19 10:39 ` Sudeep Holla
2023-07-19 13:58 ` Nikunj Kela
2023-07-19 13:58 ` Nikunj Kela
2023-07-18 16:08 ` [PATCH 2/2] firmware: arm_scmi: Add qcom hvc/shmem transport Nikunj Kela
2023-07-18 16:08 ` Nikunj Kela
2023-07-18 18:17 ` Krzysztof Kozlowski
2023-07-18 18:17 ` Krzysztof Kozlowski
2023-07-18 18:25 ` Nikunj Kela
2023-07-18 18:25 ` Nikunj Kela
2023-07-18 18:42 ` Krzysztof Kozlowski
2023-07-18 18:42 ` Krzysztof Kozlowski
2023-07-18 21:16 ` Nikunj Kela
2023-07-18 21:16 ` Nikunj Kela
2023-07-19 6:15 ` Krzysztof Kozlowski
2023-07-19 6:15 ` Krzysztof Kozlowski
2023-07-18 18:29 ` Bjorn Andersson
2023-07-18 18:29 ` Bjorn Andersson
2023-07-18 18:53 ` Nikunj Kela
2023-07-18 18:53 ` Nikunj Kela
2023-07-18 19:07 ` Bjorn Andersson
2023-07-18 19:07 ` Bjorn Andersson
2023-07-18 19:10 ` Nikunj Kela
2023-07-18 19:10 ` Nikunj Kela
2023-07-18 19:30 ` Bjorn Andersson
2023-07-18 19:30 ` Bjorn Andersson
2023-07-18 22:05 ` Nikunj Kela
2023-07-18 22:05 ` Nikunj Kela
2023-07-19 10:55 ` Cristian Marussi
2023-07-19 10:55 ` Cristian Marussi
2023-07-19 14:02 ` Nikunj Kela
2023-07-19 14:02 ` Nikunj Kela
2023-07-23 2:15 ` kernel test robot
2023-07-23 2:15 ` kernel test robot
2023-07-24 16:44 ` [PATCH v2 0/3] " Nikunj Kela
2023-07-24 16:44 ` [PATCH v2 1/3] dt-bindings: arm: convert nested if-else construct to allOf Nikunj Kela
2023-07-25 6:01 ` Krzysztof Kozlowski
2023-07-24 16:44 ` [PATCH v2 2/3] dt-bindings: arm: Add qcom specific hvc transport for SCMI Nikunj Kela
2023-07-25 6:06 ` Krzysztof Kozlowski
2023-07-24 16:44 ` [PATCH v2 3/3] firmware: arm_scmi: Add qcom hvc/shmem transport Nikunj Kela
2023-07-25 17:03 ` Cristian Marussi
2023-07-25 17:12 ` Nikunj Kela
2023-07-31 14:04 ` Nikunj Kela
2023-07-31 14:04 ` Nikunj Kela
2023-08-01 7:27 ` kernel test robot
2023-08-01 7:27 ` kernel test robot
2023-08-11 17:57 ` [PATCH v3 0/3] " Nikunj Kela
2023-08-11 17:57 ` Nikunj Kela
2023-08-11 17:57 ` [PATCH v3 1/3] dt-bindings: arm: convert nested if-else construct to allOf Nikunj Kela
2023-08-11 17:57 ` Nikunj Kela
2023-08-11 17:57 ` [PATCH v3 2/3] dt-bindings: arm: Add qcom specific hvc transport for SCMI Nikunj Kela
2023-08-11 17:57 ` Nikunj Kela
2023-08-11 17:57 ` [PATCH v3 3/3] firmware: arm_scmi: Add qcom hvc/shmem transport Nikunj Kela
2023-08-11 17:57 ` Nikunj Kela
2023-09-05 16:06 ` [PATCH v3 0/3] " Nikunj Kela
2023-09-05 16:06 ` Nikunj Kela
2023-09-05 16:37 ` Krzysztof Kozlowski
2023-09-05 16:37 ` Krzysztof Kozlowski
2023-09-07 10:36 ` Sudeep Holla
2023-09-07 10:36 ` Sudeep Holla
2023-09-07 14:20 ` Nikunj Kela
2023-09-07 14:20 ` Nikunj Kela
2023-09-07 16:16 ` [PATCH 0/2] " Konrad Dybcio
2023-09-07 16:16 ` Konrad Dybcio
2023-09-07 22:32 ` Nikunj Kela
2023-09-07 22:32 ` Nikunj Kela
2023-09-11 19:43 ` [PATCH v4 0/4] Add qcom hvc/shmem transport support Nikunj Kela
2023-09-11 19:43 ` Nikunj Kela
2023-09-11 19:43 ` [PATCH v4 1/4] firmware: arm_scmi: Add polling support for completion in smc Nikunj Kela
2023-09-11 19:43 ` Nikunj Kela
2023-10-02 18:18 ` Brian Masney
2023-10-02 18:18 ` Brian Masney
2023-10-02 18:36 ` Nikunj Kela
2023-10-02 18:36 ` Nikunj Kela
2023-10-03 10:33 ` Sudeep Holla
2023-10-03 10:33 ` Sudeep Holla
2023-10-03 10:50 ` Cristian Marussi
2023-10-03 10:50 ` Cristian Marussi
2023-10-03 15:53 ` Nikunj Kela
2023-10-03 15:53 ` Nikunj Kela
2023-10-04 16:11 ` Sudeep Holla [this message]
2023-10-04 16:11 ` Sudeep Holla
2023-10-05 3:25 ` Nikunj Kela
2023-10-05 3:25 ` Nikunj Kela
2023-09-11 19:43 ` [PATCH v4 2/4] dt-bindings: arm: convert nested if-else construct to allOf Nikunj Kela
2023-09-11 19:43 ` Nikunj Kela
2023-09-11 19:43 ` [PATCH v4 3/4] dt-bindings: arm: Add new compatible for smc/hvc transport for SCMI Nikunj Kela
2023-09-11 19:43 ` Nikunj Kela
2023-10-03 10:44 ` Sudeep Holla
2023-10-03 10:44 ` Sudeep Holla
2023-10-03 15:59 ` Nikunj Kela
2023-10-03 15:59 ` Nikunj Kela
2023-10-04 15:53 ` Sudeep Holla
2023-10-04 15:53 ` Sudeep Holla
2023-10-05 21:51 ` Nikunj Kela
2023-10-05 21:51 ` Nikunj Kela
2023-09-11 19:43 ` [PATCH v4 4/4] firmware: arm_scmi: Add qcom hvc/shmem transport support Nikunj Kela
2023-09-11 19:43 ` Nikunj Kela
2023-10-02 18:34 ` Brian Masney
2023-10-02 18:34 ` Brian Masney
2023-10-02 18:39 ` Brian Masney
2023-10-02 18:39 ` Brian Masney
2023-10-02 18:45 ` Nikunj Kela
2023-10-02 18:45 ` Nikunj Kela
2023-10-02 18:42 ` Nikunj Kela
2023-10-02 18:42 ` Nikunj Kela
2023-10-03 10:48 ` Sudeep Holla
2023-10-03 10:48 ` Sudeep Holla
2023-10-03 11:19 ` Sudeep Holla
2023-10-03 11:19 ` Sudeep Holla
2023-10-03 16:16 ` Nikunj Kela
2023-10-03 16:16 ` Nikunj Kela
2023-10-04 16:06 ` Sudeep Holla
2023-10-04 16:06 ` Sudeep Holla
2023-10-04 17:48 ` Nikunj Kela
2023-10-04 17:48 ` Nikunj Kela
2023-10-05 22:20 ` Bjorn Andersson
2023-10-05 22:20 ` Bjorn Andersson
2023-10-05 22:33 ` Nikunj Kela
2023-10-05 22:33 ` Nikunj Kela
2023-10-06 7:26 ` Sudeep Holla
2023-10-06 7:26 ` Sudeep Holla
2023-09-18 15:01 ` [PATCH v4 0/4] " Nikunj Kela
2023-09-18 15:01 ` Nikunj Kela
2023-09-18 15:15 ` Sudeep Holla
2023-09-18 15:15 ` Sudeep Holla
2023-09-18 15:54 ` Brian Masney
2023-09-18 15:54 ` Brian Masney
2023-09-19 8:56 ` Sudeep Holla
2023-09-19 8:56 ` Sudeep Holla
2023-10-02 17:31 ` Nikunj Kela
2023-10-02 17:31 ` Nikunj Kela
2023-10-02 17:58 ` Cristian Marussi
2023-10-02 17:58 ` Cristian Marussi
2023-10-03 10:34 ` Sudeep Holla
2023-10-03 10:34 ` Sudeep Holla
2023-09-18 20:32 ` Krzysztof Kozlowski
2023-09-18 20:32 ` Krzysztof Kozlowski
2023-10-06 16:42 ` [PATCH v5 0/2] Add qcom smc/hvc " Nikunj Kela
2023-10-06 16:42 ` Nikunj Kela
2023-10-06 16:42 ` [PATCH v5 1/2] dt-bindings: arm: Add new compatible for smc/hvc transport for SCMI Nikunj Kela
2023-10-06 16:42 ` Nikunj Kela
2023-10-06 20:08 ` Brian Masney
2023-10-06 20:08 ` Brian Masney
2023-10-09 14:41 ` Sudeep Holla
2023-10-09 14:41 ` Sudeep Holla
2023-10-09 14:52 ` Nikunj Kela
2023-10-09 14:52 ` Nikunj Kela
2023-10-09 21:03 ` Konrad Dybcio
2023-10-09 21:03 ` Konrad Dybcio
2023-10-06 16:42 ` [PATCH v5 2/2] firmware: arm_scmi: Add qcom smc/hvc transport support Nikunj Kela
2023-10-06 16:42 ` Nikunj Kela
2023-10-06 20:17 ` Brian Masney
2023-10-06 20:17 ` Brian Masney
2023-10-09 14:47 ` Sudeep Holla
2023-10-09 14:47 ` Sudeep Holla
2023-10-09 14:59 ` Nikunj Kela
2023-10-09 14:59 ` Nikunj Kela
2023-10-09 15:29 ` Sudeep Holla
2023-10-09 15:29 ` Sudeep Holla
2023-10-09 17:49 ` Nikunj Kela
2023-10-09 17:49 ` Nikunj Kela
2023-10-09 19:08 ` Sudeep Holla
2023-10-09 19:08 ` Sudeep Holla
2023-10-09 19:16 ` Nikunj Kela
2023-10-09 19:16 ` Nikunj Kela
2023-10-09 19:14 ` [PATCH v6 0/2] " Nikunj Kela
2023-10-09 19:14 ` Nikunj Kela
2023-10-09 19:14 ` [PATCH v6 1/2] dt-bindings: arm: Add new compatible for smc/hvc transport for SCMI Nikunj Kela
2023-10-09 19:14 ` Nikunj Kela
2023-10-09 19:14 ` [PATCH v6 2/2] firmware: arm_scmi: Add qcom smc/hvc transport support Nikunj Kela
2023-10-09 19:14 ` Nikunj Kela
2023-10-10 10:42 ` Sudeep Holla
2023-10-10 10:42 ` Sudeep Holla
2023-10-10 10:21 ` [PATCH v6 0/2] " Sudeep Holla
2023-10-10 10:21 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004161140.uzqb4eapyo6gd7xm@bogus \
--to=sudeep.holla@arm.com \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_nkela@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.