From: Nikunj Kela <quic_nkela@quicinc.com> To: Sudeep Holla <sudeep.holla@arm.com> Cc: <cristian.marussi@arm.com>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>, <andersson@kernel.org>, <konrad.dybcio@linaro.org>, <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org> Subject: Re: [PATCH v4 3/4] dt-bindings: arm: Add new compatible for smc/hvc transport for SCMI Date: Thu, 5 Oct 2023 14:51:28 -0700 [thread overview] Message-ID: <2c196f9a-b61e-914b-1999-e9e82d16dc6e@quicinc.com> (raw) In-Reply-To: <20231004155310.zqwlj6boy65atoyq@bogus> On 10/4/2023 8:53 AM, Sudeep Holla wrote: > On Tue, Oct 03, 2023 at 08:59:45AM -0700, Nikunj Kela wrote: >> On 10/3/2023 3:44 AM, Sudeep Holla wrote: >>> On Mon, Sep 11, 2023 at 12:43:58PM -0700, Nikunj Kela wrote: >>>> Introduce compatible "qcom,scmi-hvc-shmem" for SCMI smc/hvc >>>> transport channel for Qualcomm virtual platforms. >>>> The compatible mandates a shared memory channel. >>>> >>>> Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com> >>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> --- >>>> .../devicetree/bindings/firmware/arm,scmi.yaml | 12 ++++++++++++ >>>> 1 file changed, 12 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >>>> index 8d54ea768d38..4090240f45b1 100644 >>>> --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >>>> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >>>> @@ -45,6 +45,9 @@ properties: >>>> - description: SCMI compliant firmware with OP-TEE transport >>>> items: >>>> - const: linaro,scmi-optee >>>> + - description: SCMI compliant firmware with Qualcomm hvc/shmem transport >>>> + items: >>>> + - const: qcom,scmi-hvc-shmem >>> Can it be simply "qcom,scmi-smc" for 2 reasons ? >>> 1. We don't support SMC/HVC without shmem, so what is your argument to add >>> '-shmem' in the compatible here ? >> In our platforms, there are multiple ways to allocate memory. One is >> preallocated shmem as used here, another is dynamically by hypervisor APIs. >> shmem was to just to indicate it is preallocated. >> > Let us keep it without shmem. If it is dynamically allocated, you must not > need another compatible as you can check it at the runtime. > >>> 2. The exact conduit(SMC/HVC) used is detected runtime, so I prefer to keep >>> '-smc' instead of '-hvc' in the compatible just to avoid giving an illusion >>> that HVC is the conduit chosen here based on the compatible. It can be true >>> for other reason but I don't want to mislead here by using HVC. >> IUUC, currently, conduit comes from PSCI dt node. We have been using smc for >> PSCI but want to use hvc here. That being said, I am fine to explore if we >> can change PSCI to use hvc too. >> > I think only OPTEE has explicit conduit other than PSCI and it is continued > for legacy/compatibility reasons IIUC and IIRC. Anything else depends on > the conduit used by PSCI to be consistent. So yes you need to use what the > PSCI conduit is and you don't need the extra information from the DT either > as new property or in the compatible. Ok, will use conduit then. Thanks! >
WARNING: multiple messages have this Message-ID (diff)
From: Nikunj Kela <quic_nkela@quicinc.com> To: Sudeep Holla <sudeep.holla@arm.com> Cc: <cristian.marussi@arm.com>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>, <andersson@kernel.org>, <konrad.dybcio@linaro.org>, <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org> Subject: Re: [PATCH v4 3/4] dt-bindings: arm: Add new compatible for smc/hvc transport for SCMI Date: Thu, 5 Oct 2023 14:51:28 -0700 [thread overview] Message-ID: <2c196f9a-b61e-914b-1999-e9e82d16dc6e@quicinc.com> (raw) In-Reply-To: <20231004155310.zqwlj6boy65atoyq@bogus> On 10/4/2023 8:53 AM, Sudeep Holla wrote: > On Tue, Oct 03, 2023 at 08:59:45AM -0700, Nikunj Kela wrote: >> On 10/3/2023 3:44 AM, Sudeep Holla wrote: >>> On Mon, Sep 11, 2023 at 12:43:58PM -0700, Nikunj Kela wrote: >>>> Introduce compatible "qcom,scmi-hvc-shmem" for SCMI smc/hvc >>>> transport channel for Qualcomm virtual platforms. >>>> The compatible mandates a shared memory channel. >>>> >>>> Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com> >>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> --- >>>> .../devicetree/bindings/firmware/arm,scmi.yaml | 12 ++++++++++++ >>>> 1 file changed, 12 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >>>> index 8d54ea768d38..4090240f45b1 100644 >>>> --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >>>> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >>>> @@ -45,6 +45,9 @@ properties: >>>> - description: SCMI compliant firmware with OP-TEE transport >>>> items: >>>> - const: linaro,scmi-optee >>>> + - description: SCMI compliant firmware with Qualcomm hvc/shmem transport >>>> + items: >>>> + - const: qcom,scmi-hvc-shmem >>> Can it be simply "qcom,scmi-smc" for 2 reasons ? >>> 1. We don't support SMC/HVC without shmem, so what is your argument to add >>> '-shmem' in the compatible here ? >> In our platforms, there are multiple ways to allocate memory. One is >> preallocated shmem as used here, another is dynamically by hypervisor APIs. >> shmem was to just to indicate it is preallocated. >> > Let us keep it without shmem. If it is dynamically allocated, you must not > need another compatible as you can check it at the runtime. > >>> 2. The exact conduit(SMC/HVC) used is detected runtime, so I prefer to keep >>> '-smc' instead of '-hvc' in the compatible just to avoid giving an illusion >>> that HVC is the conduit chosen here based on the compatible. It can be true >>> for other reason but I don't want to mislead here by using HVC. >> IUUC, currently, conduit comes from PSCI dt node. We have been using smc for >> PSCI but want to use hvc here. That being said, I am fine to explore if we >> can change PSCI to use hvc too. >> > I think only OPTEE has explicit conduit other than PSCI and it is continued > for legacy/compatibility reasons IIUC and IIRC. Anything else depends on > the conduit used by PSCI to be consistent. So yes you need to use what the > PSCI conduit is and you don't need the extra information from the DT either > as new property or in the compatible. Ok, will use conduit then. Thanks! > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-05 21:51 UTC|newest] Thread overview: 186+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-18 16:08 [PATCH 0/2] Add qcom hvc/shmem transport Nikunj Kela 2023-07-18 16:08 ` Nikunj Kela 2023-07-18 16:08 ` [PATCH 1/2] dt-bindings: arm: Add qcom specific hvc transport for SCMI Nikunj Kela 2023-07-18 16:08 ` Nikunj Kela 2023-07-18 17:21 ` Rob Herring 2023-07-18 17:21 ` Rob Herring 2023-07-18 18:12 ` Krzysztof Kozlowski 2023-07-18 18:12 ` Krzysztof Kozlowski 2023-07-18 18:18 ` Nikunj Kela 2023-07-18 18:18 ` Nikunj Kela 2023-07-19 10:39 ` Sudeep Holla 2023-07-19 10:39 ` Sudeep Holla 2023-07-19 13:58 ` Nikunj Kela 2023-07-19 13:58 ` Nikunj Kela 2023-07-18 16:08 ` [PATCH 2/2] firmware: arm_scmi: Add qcom hvc/shmem transport Nikunj Kela 2023-07-18 16:08 ` Nikunj Kela 2023-07-18 18:17 ` Krzysztof Kozlowski 2023-07-18 18:17 ` Krzysztof Kozlowski 2023-07-18 18:25 ` Nikunj Kela 2023-07-18 18:25 ` Nikunj Kela 2023-07-18 18:42 ` Krzysztof Kozlowski 2023-07-18 18:42 ` Krzysztof Kozlowski 2023-07-18 21:16 ` Nikunj Kela 2023-07-18 21:16 ` Nikunj Kela 2023-07-19 6:15 ` Krzysztof Kozlowski 2023-07-19 6:15 ` Krzysztof Kozlowski 2023-07-18 18:29 ` Bjorn Andersson 2023-07-18 18:29 ` Bjorn Andersson 2023-07-18 18:53 ` Nikunj Kela 2023-07-18 18:53 ` Nikunj Kela 2023-07-18 19:07 ` Bjorn Andersson 2023-07-18 19:07 ` Bjorn Andersson 2023-07-18 19:10 ` Nikunj Kela 2023-07-18 19:10 ` Nikunj Kela 2023-07-18 19:30 ` Bjorn Andersson 2023-07-18 19:30 ` Bjorn Andersson 2023-07-18 22:05 ` Nikunj Kela 2023-07-18 22:05 ` Nikunj Kela 2023-07-19 10:55 ` Cristian Marussi 2023-07-19 10:55 ` Cristian Marussi 2023-07-19 14:02 ` Nikunj Kela 2023-07-19 14:02 ` Nikunj Kela 2023-07-23 2:15 ` kernel test robot 2023-07-23 2:15 ` kernel test robot 2023-07-24 16:44 ` [PATCH v2 0/3] " Nikunj Kela 2023-07-24 16:44 ` [PATCH v2 1/3] dt-bindings: arm: convert nested if-else construct to allOf Nikunj Kela 2023-07-25 6:01 ` Krzysztof Kozlowski 2023-07-24 16:44 ` [PATCH v2 2/3] dt-bindings: arm: Add qcom specific hvc transport for SCMI Nikunj Kela 2023-07-25 6:06 ` Krzysztof Kozlowski 2023-07-24 16:44 ` [PATCH v2 3/3] firmware: arm_scmi: Add qcom hvc/shmem transport Nikunj Kela 2023-07-25 17:03 ` Cristian Marussi 2023-07-25 17:12 ` Nikunj Kela 2023-07-31 14:04 ` Nikunj Kela 2023-07-31 14:04 ` Nikunj Kela 2023-08-01 7:27 ` kernel test robot 2023-08-01 7:27 ` kernel test robot 2023-08-11 17:57 ` [PATCH v3 0/3] " Nikunj Kela 2023-08-11 17:57 ` Nikunj Kela 2023-08-11 17:57 ` [PATCH v3 1/3] dt-bindings: arm: convert nested if-else construct to allOf Nikunj Kela 2023-08-11 17:57 ` Nikunj Kela 2023-08-11 17:57 ` [PATCH v3 2/3] dt-bindings: arm: Add qcom specific hvc transport for SCMI Nikunj Kela 2023-08-11 17:57 ` Nikunj Kela 2023-08-11 17:57 ` [PATCH v3 3/3] firmware: arm_scmi: Add qcom hvc/shmem transport Nikunj Kela 2023-08-11 17:57 ` Nikunj Kela 2023-09-05 16:06 ` [PATCH v3 0/3] " Nikunj Kela 2023-09-05 16:06 ` Nikunj Kela 2023-09-05 16:37 ` Krzysztof Kozlowski 2023-09-05 16:37 ` Krzysztof Kozlowski 2023-09-07 10:36 ` Sudeep Holla 2023-09-07 10:36 ` Sudeep Holla 2023-09-07 14:20 ` Nikunj Kela 2023-09-07 14:20 ` Nikunj Kela 2023-09-07 16:16 ` [PATCH 0/2] " Konrad Dybcio 2023-09-07 16:16 ` Konrad Dybcio 2023-09-07 22:32 ` Nikunj Kela 2023-09-07 22:32 ` Nikunj Kela 2023-09-11 19:43 ` [PATCH v4 0/4] Add qcom hvc/shmem transport support Nikunj Kela 2023-09-11 19:43 ` Nikunj Kela 2023-09-11 19:43 ` [PATCH v4 1/4] firmware: arm_scmi: Add polling support for completion in smc Nikunj Kela 2023-09-11 19:43 ` Nikunj Kela 2023-10-02 18:18 ` Brian Masney 2023-10-02 18:18 ` Brian Masney 2023-10-02 18:36 ` Nikunj Kela 2023-10-02 18:36 ` Nikunj Kela 2023-10-03 10:33 ` Sudeep Holla 2023-10-03 10:33 ` Sudeep Holla 2023-10-03 10:50 ` Cristian Marussi 2023-10-03 10:50 ` Cristian Marussi 2023-10-03 15:53 ` Nikunj Kela 2023-10-03 15:53 ` Nikunj Kela 2023-10-04 16:11 ` Sudeep Holla 2023-10-04 16:11 ` Sudeep Holla 2023-10-05 3:25 ` Nikunj Kela 2023-10-05 3:25 ` Nikunj Kela 2023-09-11 19:43 ` [PATCH v4 2/4] dt-bindings: arm: convert nested if-else construct to allOf Nikunj Kela 2023-09-11 19:43 ` Nikunj Kela 2023-09-11 19:43 ` [PATCH v4 3/4] dt-bindings: arm: Add new compatible for smc/hvc transport for SCMI Nikunj Kela 2023-09-11 19:43 ` Nikunj Kela 2023-10-03 10:44 ` Sudeep Holla 2023-10-03 10:44 ` Sudeep Holla 2023-10-03 15:59 ` Nikunj Kela 2023-10-03 15:59 ` Nikunj Kela 2023-10-04 15:53 ` Sudeep Holla 2023-10-04 15:53 ` Sudeep Holla 2023-10-05 21:51 ` Nikunj Kela [this message] 2023-10-05 21:51 ` Nikunj Kela 2023-09-11 19:43 ` [PATCH v4 4/4] firmware: arm_scmi: Add qcom hvc/shmem transport support Nikunj Kela 2023-09-11 19:43 ` Nikunj Kela 2023-10-02 18:34 ` Brian Masney 2023-10-02 18:34 ` Brian Masney 2023-10-02 18:39 ` Brian Masney 2023-10-02 18:39 ` Brian Masney 2023-10-02 18:45 ` Nikunj Kela 2023-10-02 18:45 ` Nikunj Kela 2023-10-02 18:42 ` Nikunj Kela 2023-10-02 18:42 ` Nikunj Kela 2023-10-03 10:48 ` Sudeep Holla 2023-10-03 10:48 ` Sudeep Holla 2023-10-03 11:19 ` Sudeep Holla 2023-10-03 11:19 ` Sudeep Holla 2023-10-03 16:16 ` Nikunj Kela 2023-10-03 16:16 ` Nikunj Kela 2023-10-04 16:06 ` Sudeep Holla 2023-10-04 16:06 ` Sudeep Holla 2023-10-04 17:48 ` Nikunj Kela 2023-10-04 17:48 ` Nikunj Kela 2023-10-05 22:20 ` Bjorn Andersson 2023-10-05 22:20 ` Bjorn Andersson 2023-10-05 22:33 ` Nikunj Kela 2023-10-05 22:33 ` Nikunj Kela 2023-10-06 7:26 ` Sudeep Holla 2023-10-06 7:26 ` Sudeep Holla 2023-09-18 15:01 ` [PATCH v4 0/4] " Nikunj Kela 2023-09-18 15:01 ` Nikunj Kela 2023-09-18 15:15 ` Sudeep Holla 2023-09-18 15:15 ` Sudeep Holla 2023-09-18 15:54 ` Brian Masney 2023-09-18 15:54 ` Brian Masney 2023-09-19 8:56 ` Sudeep Holla 2023-09-19 8:56 ` Sudeep Holla 2023-10-02 17:31 ` Nikunj Kela 2023-10-02 17:31 ` Nikunj Kela 2023-10-02 17:58 ` Cristian Marussi 2023-10-02 17:58 ` Cristian Marussi 2023-10-03 10:34 ` Sudeep Holla 2023-10-03 10:34 ` Sudeep Holla 2023-09-18 20:32 ` Krzysztof Kozlowski 2023-09-18 20:32 ` Krzysztof Kozlowski 2023-10-06 16:42 ` [PATCH v5 0/2] Add qcom smc/hvc " Nikunj Kela 2023-10-06 16:42 ` Nikunj Kela 2023-10-06 16:42 ` [PATCH v5 1/2] dt-bindings: arm: Add new compatible for smc/hvc transport for SCMI Nikunj Kela 2023-10-06 16:42 ` Nikunj Kela 2023-10-06 20:08 ` Brian Masney 2023-10-06 20:08 ` Brian Masney 2023-10-09 14:41 ` Sudeep Holla 2023-10-09 14:41 ` Sudeep Holla 2023-10-09 14:52 ` Nikunj Kela 2023-10-09 14:52 ` Nikunj Kela 2023-10-09 21:03 ` Konrad Dybcio 2023-10-09 21:03 ` Konrad Dybcio 2023-10-06 16:42 ` [PATCH v5 2/2] firmware: arm_scmi: Add qcom smc/hvc transport support Nikunj Kela 2023-10-06 16:42 ` Nikunj Kela 2023-10-06 20:17 ` Brian Masney 2023-10-06 20:17 ` Brian Masney 2023-10-09 14:47 ` Sudeep Holla 2023-10-09 14:47 ` Sudeep Holla 2023-10-09 14:59 ` Nikunj Kela 2023-10-09 14:59 ` Nikunj Kela 2023-10-09 15:29 ` Sudeep Holla 2023-10-09 15:29 ` Sudeep Holla 2023-10-09 17:49 ` Nikunj Kela 2023-10-09 17:49 ` Nikunj Kela 2023-10-09 19:08 ` Sudeep Holla 2023-10-09 19:08 ` Sudeep Holla 2023-10-09 19:16 ` Nikunj Kela 2023-10-09 19:16 ` Nikunj Kela 2023-10-09 19:14 ` [PATCH v6 0/2] " Nikunj Kela 2023-10-09 19:14 ` Nikunj Kela 2023-10-09 19:14 ` [PATCH v6 1/2] dt-bindings: arm: Add new compatible for smc/hvc transport for SCMI Nikunj Kela 2023-10-09 19:14 ` Nikunj Kela 2023-10-09 19:14 ` [PATCH v6 2/2] firmware: arm_scmi: Add qcom smc/hvc transport support Nikunj Kela 2023-10-09 19:14 ` Nikunj Kela 2023-10-10 10:42 ` Sudeep Holla 2023-10-10 10:42 ` Sudeep Holla 2023-10-10 10:21 ` [PATCH v6 0/2] " Sudeep Holla 2023-10-10 10:21 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2c196f9a-b61e-914b-1999-e9e82d16dc6e@quicinc.com \ --to=quic_nkela@quicinc.com \ --cc=andersson@kernel.org \ --cc=conor+dt@kernel.org \ --cc=cristian.marussi@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=konrad.dybcio@linaro.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=sudeep.holla@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.