From: Sudeep Holla <sudeep.holla@arm.com> To: Nikunj Kela <quic_nkela@quicinc.com> Cc: cristian.marussi@arm.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, Sudeep Holla <sudeep.holla@arm.com>, andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v5 2/2] firmware: arm_scmi: Add qcom smc/hvc transport support Date: Mon, 9 Oct 2023 15:47:44 +0100 [thread overview] Message-ID: <20231009144744.yi44ljq4llaxjsb7@bogus> (raw) In-Reply-To: <20231006164206.40710-3-quic_nkela@quicinc.com> On Fri, Oct 06, 2023 at 09:42:06AM -0700, Nikunj Kela wrote: > This change adds the support for SCMI message exchange on Qualcomm > virtual platforms. > > The hypervisor associates an object-id also known as capability-id > with each smc/hvc doorbell object. The capability-id is used to > identify the doorbell from the VM's capability namespace, similar > to a file-descriptor. > > The hypervisor, in addition to the function-id, expects the capability-id > to be passed in x1 register when SMC/HVC call is invoked. > > The capability-id is allocated by the hypervisor on bootup and is stored in > the shmem region by the firmware before starting Linux. > Since you are happy to move to signed value, I assume you are happy to loose upper half of the range values ? Anyways after Bjorn pointed out inconsistency, I am thinking of moving all the values to unsigned long to work with both 32bit and 64bit. Does the below delta on top of this patch works for you and makes sense? -- Regards, Sudeep -->8 diff --git c/drivers/firmware/arm_scmi/smc.c i/drivers/firmware/arm_scmi/smc.c index bf0b7769c7b2..e00c5e81c8d9 100644 --- c/drivers/firmware/arm_scmi/smc.c +++ i/drivers/firmware/arm_scmi/smc.c @@ -15,6 +15,7 @@ #include <linux/of.h> #include <linux/of_address.h> #include <linux/of_irq.h> +#include <linux/limits.h> #include <linux/processor.h> #include <linux/slab.h> @@ -65,7 +66,7 @@ struct scmi_smc { unsigned long func_id; unsigned long param_page; unsigned long param_offset; - s64 cap_id; + unsigned long cap_id; }; static irqreturn_t smc_msg_done_isr(int irq, void *data) @@ -127,11 +128,11 @@ static int smc_chan_setup(struct scmi_chan_info *cinfo, struct device *dev, bool tx) { struct device *cdev = cinfo->dev; + unsigned long cap_id = ULONG_MAX; struct scmi_smc *scmi_info; resource_size_t size; struct resource res; struct device_node *np; - s64 cap_id = -EINVAL; u32 func_id; int ret; @@ -167,6 +168,7 @@ static int smc_chan_setup(struct scmi_chan_info *cinfo, struct device *dev, return ret; if (of_device_is_compatible(dev->of_node, "qcom,scmi-smc")) { + void __iomem *ptr = (void __iomem *)scmi_info->shmem + size - 8; /* The capability-id is kept in last 8 bytes of shmem. * +-------+ * | | @@ -177,12 +179,7 @@ static int smc_chan_setup(struct scmi_chan_info *cinfo, struct device *dev, * | capId | * +-------+ <-- size */ - -#ifdef CONFIG_64BIT - cap_id = ioread64((void *)scmi_info->shmem + size - 8); -#else - cap_id = ioread32((void *)scmi_info->shmem + size - 8); -#endif + memcpy_fromio(&cap_id, ptr, sizeof(cap_id)); } if (of_device_is_compatible(dev->of_node, "arm,scmi-smc-param")) { @@ -247,7 +244,7 @@ static int smc_send_message(struct scmi_chan_info *cinfo, shmem_tx_prepare(scmi_info->shmem, xfer, cinfo); - if (cap_id >= 0) + if (cap_id != ULONG_MAX) arm_smccc_1_1_invoke(scmi_info->func_id, cap_id, 0, 0, 0, 0, 0, 0, &res); else
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com> To: Nikunj Kela <quic_nkela@quicinc.com> Cc: cristian.marussi@arm.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, Sudeep Holla <sudeep.holla@arm.com>, andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v5 2/2] firmware: arm_scmi: Add qcom smc/hvc transport support Date: Mon, 9 Oct 2023 15:47:44 +0100 [thread overview] Message-ID: <20231009144744.yi44ljq4llaxjsb7@bogus> (raw) In-Reply-To: <20231006164206.40710-3-quic_nkela@quicinc.com> On Fri, Oct 06, 2023 at 09:42:06AM -0700, Nikunj Kela wrote: > This change adds the support for SCMI message exchange on Qualcomm > virtual platforms. > > The hypervisor associates an object-id also known as capability-id > with each smc/hvc doorbell object. The capability-id is used to > identify the doorbell from the VM's capability namespace, similar > to a file-descriptor. > > The hypervisor, in addition to the function-id, expects the capability-id > to be passed in x1 register when SMC/HVC call is invoked. > > The capability-id is allocated by the hypervisor on bootup and is stored in > the shmem region by the firmware before starting Linux. > Since you are happy to move to signed value, I assume you are happy to loose upper half of the range values ? Anyways after Bjorn pointed out inconsistency, I am thinking of moving all the values to unsigned long to work with both 32bit and 64bit. Does the below delta on top of this patch works for you and makes sense? -- Regards, Sudeep -->8 diff --git c/drivers/firmware/arm_scmi/smc.c i/drivers/firmware/arm_scmi/smc.c index bf0b7769c7b2..e00c5e81c8d9 100644 --- c/drivers/firmware/arm_scmi/smc.c +++ i/drivers/firmware/arm_scmi/smc.c @@ -15,6 +15,7 @@ #include <linux/of.h> #include <linux/of_address.h> #include <linux/of_irq.h> +#include <linux/limits.h> #include <linux/processor.h> #include <linux/slab.h> @@ -65,7 +66,7 @@ struct scmi_smc { unsigned long func_id; unsigned long param_page; unsigned long param_offset; - s64 cap_id; + unsigned long cap_id; }; static irqreturn_t smc_msg_done_isr(int irq, void *data) @@ -127,11 +128,11 @@ static int smc_chan_setup(struct scmi_chan_info *cinfo, struct device *dev, bool tx) { struct device *cdev = cinfo->dev; + unsigned long cap_id = ULONG_MAX; struct scmi_smc *scmi_info; resource_size_t size; struct resource res; struct device_node *np; - s64 cap_id = -EINVAL; u32 func_id; int ret; @@ -167,6 +168,7 @@ static int smc_chan_setup(struct scmi_chan_info *cinfo, struct device *dev, return ret; if (of_device_is_compatible(dev->of_node, "qcom,scmi-smc")) { + void __iomem *ptr = (void __iomem *)scmi_info->shmem + size - 8; /* The capability-id is kept in last 8 bytes of shmem. * +-------+ * | | @@ -177,12 +179,7 @@ static int smc_chan_setup(struct scmi_chan_info *cinfo, struct device *dev, * | capId | * +-------+ <-- size */ - -#ifdef CONFIG_64BIT - cap_id = ioread64((void *)scmi_info->shmem + size - 8); -#else - cap_id = ioread32((void *)scmi_info->shmem + size - 8); -#endif + memcpy_fromio(&cap_id, ptr, sizeof(cap_id)); } if (of_device_is_compatible(dev->of_node, "arm,scmi-smc-param")) { @@ -247,7 +244,7 @@ static int smc_send_message(struct scmi_chan_info *cinfo, shmem_tx_prepare(scmi_info->shmem, xfer, cinfo); - if (cap_id >= 0) + if (cap_id != ULONG_MAX) arm_smccc_1_1_invoke(scmi_info->func_id, cap_id, 0, 0, 0, 0, 0, 0, &res); else _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-09 14:47 UTC|newest] Thread overview: 186+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-18 16:08 [PATCH 0/2] Add qcom hvc/shmem transport Nikunj Kela 2023-07-18 16:08 ` Nikunj Kela 2023-07-18 16:08 ` [PATCH 1/2] dt-bindings: arm: Add qcom specific hvc transport for SCMI Nikunj Kela 2023-07-18 16:08 ` Nikunj Kela 2023-07-18 17:21 ` Rob Herring 2023-07-18 17:21 ` Rob Herring 2023-07-18 18:12 ` Krzysztof Kozlowski 2023-07-18 18:12 ` Krzysztof Kozlowski 2023-07-18 18:18 ` Nikunj Kela 2023-07-18 18:18 ` Nikunj Kela 2023-07-19 10:39 ` Sudeep Holla 2023-07-19 10:39 ` Sudeep Holla 2023-07-19 13:58 ` Nikunj Kela 2023-07-19 13:58 ` Nikunj Kela 2023-07-18 16:08 ` [PATCH 2/2] firmware: arm_scmi: Add qcom hvc/shmem transport Nikunj Kela 2023-07-18 16:08 ` Nikunj Kela 2023-07-18 18:17 ` Krzysztof Kozlowski 2023-07-18 18:17 ` Krzysztof Kozlowski 2023-07-18 18:25 ` Nikunj Kela 2023-07-18 18:25 ` Nikunj Kela 2023-07-18 18:42 ` Krzysztof Kozlowski 2023-07-18 18:42 ` Krzysztof Kozlowski 2023-07-18 21:16 ` Nikunj Kela 2023-07-18 21:16 ` Nikunj Kela 2023-07-19 6:15 ` Krzysztof Kozlowski 2023-07-19 6:15 ` Krzysztof Kozlowski 2023-07-18 18:29 ` Bjorn Andersson 2023-07-18 18:29 ` Bjorn Andersson 2023-07-18 18:53 ` Nikunj Kela 2023-07-18 18:53 ` Nikunj Kela 2023-07-18 19:07 ` Bjorn Andersson 2023-07-18 19:07 ` Bjorn Andersson 2023-07-18 19:10 ` Nikunj Kela 2023-07-18 19:10 ` Nikunj Kela 2023-07-18 19:30 ` Bjorn Andersson 2023-07-18 19:30 ` Bjorn Andersson 2023-07-18 22:05 ` Nikunj Kela 2023-07-18 22:05 ` Nikunj Kela 2023-07-19 10:55 ` Cristian Marussi 2023-07-19 10:55 ` Cristian Marussi 2023-07-19 14:02 ` Nikunj Kela 2023-07-19 14:02 ` Nikunj Kela 2023-07-23 2:15 ` kernel test robot 2023-07-23 2:15 ` kernel test robot 2023-07-24 16:44 ` [PATCH v2 0/3] " Nikunj Kela 2023-07-24 16:44 ` [PATCH v2 1/3] dt-bindings: arm: convert nested if-else construct to allOf Nikunj Kela 2023-07-25 6:01 ` Krzysztof Kozlowski 2023-07-24 16:44 ` [PATCH v2 2/3] dt-bindings: arm: Add qcom specific hvc transport for SCMI Nikunj Kela 2023-07-25 6:06 ` Krzysztof Kozlowski 2023-07-24 16:44 ` [PATCH v2 3/3] firmware: arm_scmi: Add qcom hvc/shmem transport Nikunj Kela 2023-07-25 17:03 ` Cristian Marussi 2023-07-25 17:12 ` Nikunj Kela 2023-07-31 14:04 ` Nikunj Kela 2023-07-31 14:04 ` Nikunj Kela 2023-08-01 7:27 ` kernel test robot 2023-08-01 7:27 ` kernel test robot 2023-08-11 17:57 ` [PATCH v3 0/3] " Nikunj Kela 2023-08-11 17:57 ` Nikunj Kela 2023-08-11 17:57 ` [PATCH v3 1/3] dt-bindings: arm: convert nested if-else construct to allOf Nikunj Kela 2023-08-11 17:57 ` Nikunj Kela 2023-08-11 17:57 ` [PATCH v3 2/3] dt-bindings: arm: Add qcom specific hvc transport for SCMI Nikunj Kela 2023-08-11 17:57 ` Nikunj Kela 2023-08-11 17:57 ` [PATCH v3 3/3] firmware: arm_scmi: Add qcom hvc/shmem transport Nikunj Kela 2023-08-11 17:57 ` Nikunj Kela 2023-09-05 16:06 ` [PATCH v3 0/3] " Nikunj Kela 2023-09-05 16:06 ` Nikunj Kela 2023-09-05 16:37 ` Krzysztof Kozlowski 2023-09-05 16:37 ` Krzysztof Kozlowski 2023-09-07 10:36 ` Sudeep Holla 2023-09-07 10:36 ` Sudeep Holla 2023-09-07 14:20 ` Nikunj Kela 2023-09-07 14:20 ` Nikunj Kela 2023-09-07 16:16 ` [PATCH 0/2] " Konrad Dybcio 2023-09-07 16:16 ` Konrad Dybcio 2023-09-07 22:32 ` Nikunj Kela 2023-09-07 22:32 ` Nikunj Kela 2023-09-11 19:43 ` [PATCH v4 0/4] Add qcom hvc/shmem transport support Nikunj Kela 2023-09-11 19:43 ` Nikunj Kela 2023-09-11 19:43 ` [PATCH v4 1/4] firmware: arm_scmi: Add polling support for completion in smc Nikunj Kela 2023-09-11 19:43 ` Nikunj Kela 2023-10-02 18:18 ` Brian Masney 2023-10-02 18:18 ` Brian Masney 2023-10-02 18:36 ` Nikunj Kela 2023-10-02 18:36 ` Nikunj Kela 2023-10-03 10:33 ` Sudeep Holla 2023-10-03 10:33 ` Sudeep Holla 2023-10-03 10:50 ` Cristian Marussi 2023-10-03 10:50 ` Cristian Marussi 2023-10-03 15:53 ` Nikunj Kela 2023-10-03 15:53 ` Nikunj Kela 2023-10-04 16:11 ` Sudeep Holla 2023-10-04 16:11 ` Sudeep Holla 2023-10-05 3:25 ` Nikunj Kela 2023-10-05 3:25 ` Nikunj Kela 2023-09-11 19:43 ` [PATCH v4 2/4] dt-bindings: arm: convert nested if-else construct to allOf Nikunj Kela 2023-09-11 19:43 ` Nikunj Kela 2023-09-11 19:43 ` [PATCH v4 3/4] dt-bindings: arm: Add new compatible for smc/hvc transport for SCMI Nikunj Kela 2023-09-11 19:43 ` Nikunj Kela 2023-10-03 10:44 ` Sudeep Holla 2023-10-03 10:44 ` Sudeep Holla 2023-10-03 15:59 ` Nikunj Kela 2023-10-03 15:59 ` Nikunj Kela 2023-10-04 15:53 ` Sudeep Holla 2023-10-04 15:53 ` Sudeep Holla 2023-10-05 21:51 ` Nikunj Kela 2023-10-05 21:51 ` Nikunj Kela 2023-09-11 19:43 ` [PATCH v4 4/4] firmware: arm_scmi: Add qcom hvc/shmem transport support Nikunj Kela 2023-09-11 19:43 ` Nikunj Kela 2023-10-02 18:34 ` Brian Masney 2023-10-02 18:34 ` Brian Masney 2023-10-02 18:39 ` Brian Masney 2023-10-02 18:39 ` Brian Masney 2023-10-02 18:45 ` Nikunj Kela 2023-10-02 18:45 ` Nikunj Kela 2023-10-02 18:42 ` Nikunj Kela 2023-10-02 18:42 ` Nikunj Kela 2023-10-03 10:48 ` Sudeep Holla 2023-10-03 10:48 ` Sudeep Holla 2023-10-03 11:19 ` Sudeep Holla 2023-10-03 11:19 ` Sudeep Holla 2023-10-03 16:16 ` Nikunj Kela 2023-10-03 16:16 ` Nikunj Kela 2023-10-04 16:06 ` Sudeep Holla 2023-10-04 16:06 ` Sudeep Holla 2023-10-04 17:48 ` Nikunj Kela 2023-10-04 17:48 ` Nikunj Kela 2023-10-05 22:20 ` Bjorn Andersson 2023-10-05 22:20 ` Bjorn Andersson 2023-10-05 22:33 ` Nikunj Kela 2023-10-05 22:33 ` Nikunj Kela 2023-10-06 7:26 ` Sudeep Holla 2023-10-06 7:26 ` Sudeep Holla 2023-09-18 15:01 ` [PATCH v4 0/4] " Nikunj Kela 2023-09-18 15:01 ` Nikunj Kela 2023-09-18 15:15 ` Sudeep Holla 2023-09-18 15:15 ` Sudeep Holla 2023-09-18 15:54 ` Brian Masney 2023-09-18 15:54 ` Brian Masney 2023-09-19 8:56 ` Sudeep Holla 2023-09-19 8:56 ` Sudeep Holla 2023-10-02 17:31 ` Nikunj Kela 2023-10-02 17:31 ` Nikunj Kela 2023-10-02 17:58 ` Cristian Marussi 2023-10-02 17:58 ` Cristian Marussi 2023-10-03 10:34 ` Sudeep Holla 2023-10-03 10:34 ` Sudeep Holla 2023-09-18 20:32 ` Krzysztof Kozlowski 2023-09-18 20:32 ` Krzysztof Kozlowski 2023-10-06 16:42 ` [PATCH v5 0/2] Add qcom smc/hvc " Nikunj Kela 2023-10-06 16:42 ` Nikunj Kela 2023-10-06 16:42 ` [PATCH v5 1/2] dt-bindings: arm: Add new compatible for smc/hvc transport for SCMI Nikunj Kela 2023-10-06 16:42 ` Nikunj Kela 2023-10-06 20:08 ` Brian Masney 2023-10-06 20:08 ` Brian Masney 2023-10-09 14:41 ` Sudeep Holla 2023-10-09 14:41 ` Sudeep Holla 2023-10-09 14:52 ` Nikunj Kela 2023-10-09 14:52 ` Nikunj Kela 2023-10-09 21:03 ` Konrad Dybcio 2023-10-09 21:03 ` Konrad Dybcio 2023-10-06 16:42 ` [PATCH v5 2/2] firmware: arm_scmi: Add qcom smc/hvc transport support Nikunj Kela 2023-10-06 16:42 ` Nikunj Kela 2023-10-06 20:17 ` Brian Masney 2023-10-06 20:17 ` Brian Masney 2023-10-09 14:47 ` Sudeep Holla [this message] 2023-10-09 14:47 ` Sudeep Holla 2023-10-09 14:59 ` Nikunj Kela 2023-10-09 14:59 ` Nikunj Kela 2023-10-09 15:29 ` Sudeep Holla 2023-10-09 15:29 ` Sudeep Holla 2023-10-09 17:49 ` Nikunj Kela 2023-10-09 17:49 ` Nikunj Kela 2023-10-09 19:08 ` Sudeep Holla 2023-10-09 19:08 ` Sudeep Holla 2023-10-09 19:16 ` Nikunj Kela 2023-10-09 19:16 ` Nikunj Kela 2023-10-09 19:14 ` [PATCH v6 0/2] " Nikunj Kela 2023-10-09 19:14 ` Nikunj Kela 2023-10-09 19:14 ` [PATCH v6 1/2] dt-bindings: arm: Add new compatible for smc/hvc transport for SCMI Nikunj Kela 2023-10-09 19:14 ` Nikunj Kela 2023-10-09 19:14 ` [PATCH v6 2/2] firmware: arm_scmi: Add qcom smc/hvc transport support Nikunj Kela 2023-10-09 19:14 ` Nikunj Kela 2023-10-10 10:42 ` Sudeep Holla 2023-10-10 10:42 ` Sudeep Holla 2023-10-10 10:21 ` [PATCH v6 0/2] " Sudeep Holla 2023-10-10 10:21 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231009144744.yi44ljq4llaxjsb7@bogus \ --to=sudeep.holla@arm.com \ --cc=andersson@kernel.org \ --cc=conor+dt@kernel.org \ --cc=cristian.marussi@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=konrad.dybcio@linaro.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_nkela@quicinc.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.