From: Bjorn Andersson <andersson@kernel.org>
To: Nikunj Kela <quic_nkela@quicinc.com>
Cc: sudeep.holla@arm.com, cristian.marussi@arm.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, agross@kernel.org, konrad.dybcio@linaro.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/2] firmware: arm_scmi: Add qcom hvc/shmem transport
Date: Tue, 18 Jul 2023 12:30:04 -0700 [thread overview]
Message-ID: <rum7gnnouoz2irn57taxn4j2aajkxf6em6ft6u4w3rxwsym2su@acgczsnl2huz> (raw)
In-Reply-To: <d2d01794-ef13-07f9-7695-b56b58cc01ac@quicinc.com>
On Tue, Jul 18, 2023 at 12:10:16PM -0700, Nikunj Kela wrote:
>
> On 7/18/2023 12:07 PM, Bjorn Andersson wrote:
> > On Tue, Jul 18, 2023 at 11:53:24AM -0700, Nikunj Kela wrote:
> > > On 7/18/2023 11:29 AM, Bjorn Andersson wrote:
> > > > On Tue, Jul 18, 2023 at 09:08:33AM -0700, Nikunj Kela wrote:
> > > > > diff --git a/drivers/firmware/arm_scmi/qcom_hvc.c b/drivers/firmware/arm_scmi/qcom_hvc.c
> > [..]
[..]
> > > > > +#ifdef CONFIG_ARM64
> > > > > + cap_id = readq((void *)(scmi_info->shmem) + size +
> > > > > + sizeof(unsigned long));
> > > > > +#else
> > > > > + cap_id = readl((void *)(scmi_info->shmem) + size +
> > > > > + sizeof(unsigned long));
> > > > > +#endif
> > > > Please don't make the in-memory representation depend on architecture
> > > > specific data types. Quite likely you didn't compile test one of these
> > > > variants?
> > > >
> > > > Just define the in-memory representation as u32 + u64.
> > > I tested this for ARM64, I didn't test it for 32bit since Hypervisor doesn't
> > > support it currently. In future, it may add 32 bit support too.
> > I'd not be surprised if the capability id is 64 bit on a 32-bit machine
> > as well, it's not really a property of the architecture.
>
> on 32bit machine, you will have to use SMC32 convention. lt will mean that
> the parameters can only be 32 bit long. If you keep cap-id 64 bit in 32bit
> machines, then it has to be passed in two parameters. Are you suggesting, I
> make this driver dependent on ARM64 and only care about 64 bit for now?
>
I'm suggesting that the calling convention is one thing and the
in-memory format for passing the information to the driver is a
different thing.
Keep the arguments passed in memory architecture-independent (i.e. make
it u64).
If you're saying that the calling convention would be different on a
32-bit system, then you are also saying that your driver _is_ 64-bit
specific. Please confirm what the size of your capability id would be in
such a system and make sure the Kconfig and/or the code, reflects
reality.
Thanks,
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <andersson@kernel.org>
To: Nikunj Kela <quic_nkela@quicinc.com>
Cc: sudeep.holla@arm.com, cristian.marussi@arm.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, agross@kernel.org, konrad.dybcio@linaro.org,
linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/2] firmware: arm_scmi: Add qcom hvc/shmem transport
Date: Tue, 18 Jul 2023 12:30:04 -0700 [thread overview]
Message-ID: <rum7gnnouoz2irn57taxn4j2aajkxf6em6ft6u4w3rxwsym2su@acgczsnl2huz> (raw)
In-Reply-To: <d2d01794-ef13-07f9-7695-b56b58cc01ac@quicinc.com>
On Tue, Jul 18, 2023 at 12:10:16PM -0700, Nikunj Kela wrote:
>
> On 7/18/2023 12:07 PM, Bjorn Andersson wrote:
> > On Tue, Jul 18, 2023 at 11:53:24AM -0700, Nikunj Kela wrote:
> > > On 7/18/2023 11:29 AM, Bjorn Andersson wrote:
> > > > On Tue, Jul 18, 2023 at 09:08:33AM -0700, Nikunj Kela wrote:
> > > > > diff --git a/drivers/firmware/arm_scmi/qcom_hvc.c b/drivers/firmware/arm_scmi/qcom_hvc.c
> > [..]
[..]
> > > > > +#ifdef CONFIG_ARM64
> > > > > + cap_id = readq((void *)(scmi_info->shmem) + size +
> > > > > + sizeof(unsigned long));
> > > > > +#else
> > > > > + cap_id = readl((void *)(scmi_info->shmem) + size +
> > > > > + sizeof(unsigned long));
> > > > > +#endif
> > > > Please don't make the in-memory representation depend on architecture
> > > > specific data types. Quite likely you didn't compile test one of these
> > > > variants?
> > > >
> > > > Just define the in-memory representation as u32 + u64.
> > > I tested this for ARM64, I didn't test it for 32bit since Hypervisor doesn't
> > > support it currently. In future, it may add 32 bit support too.
> > I'd not be surprised if the capability id is 64 bit on a 32-bit machine
> > as well, it's not really a property of the architecture.
>
> on 32bit machine, you will have to use SMC32 convention. lt will mean that
> the parameters can only be 32 bit long. If you keep cap-id 64 bit in 32bit
> machines, then it has to be passed in two parameters. Are you suggesting, I
> make this driver dependent on ARM64 and only care about 64 bit for now?
>
I'm suggesting that the calling convention is one thing and the
in-memory format for passing the information to the driver is a
different thing.
Keep the arguments passed in memory architecture-independent (i.e. make
it u64).
If you're saying that the calling convention would be different on a
32-bit system, then you are also saying that your driver _is_ 64-bit
specific. Please confirm what the size of your capability id would be in
such a system and make sure the Kconfig and/or the code, reflects
reality.
Thanks,
Bjorn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-18 19:26 UTC|newest]
Thread overview: 186+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 16:08 [PATCH 0/2] Add qcom hvc/shmem transport Nikunj Kela
2023-07-18 16:08 ` Nikunj Kela
2023-07-18 16:08 ` [PATCH 1/2] dt-bindings: arm: Add qcom specific hvc transport for SCMI Nikunj Kela
2023-07-18 16:08 ` Nikunj Kela
2023-07-18 17:21 ` Rob Herring
2023-07-18 17:21 ` Rob Herring
2023-07-18 18:12 ` Krzysztof Kozlowski
2023-07-18 18:12 ` Krzysztof Kozlowski
2023-07-18 18:18 ` Nikunj Kela
2023-07-18 18:18 ` Nikunj Kela
2023-07-19 10:39 ` Sudeep Holla
2023-07-19 10:39 ` Sudeep Holla
2023-07-19 13:58 ` Nikunj Kela
2023-07-19 13:58 ` Nikunj Kela
2023-07-18 16:08 ` [PATCH 2/2] firmware: arm_scmi: Add qcom hvc/shmem transport Nikunj Kela
2023-07-18 16:08 ` Nikunj Kela
2023-07-18 18:17 ` Krzysztof Kozlowski
2023-07-18 18:17 ` Krzysztof Kozlowski
2023-07-18 18:25 ` Nikunj Kela
2023-07-18 18:25 ` Nikunj Kela
2023-07-18 18:42 ` Krzysztof Kozlowski
2023-07-18 18:42 ` Krzysztof Kozlowski
2023-07-18 21:16 ` Nikunj Kela
2023-07-18 21:16 ` Nikunj Kela
2023-07-19 6:15 ` Krzysztof Kozlowski
2023-07-19 6:15 ` Krzysztof Kozlowski
2023-07-18 18:29 ` Bjorn Andersson
2023-07-18 18:29 ` Bjorn Andersson
2023-07-18 18:53 ` Nikunj Kela
2023-07-18 18:53 ` Nikunj Kela
2023-07-18 19:07 ` Bjorn Andersson
2023-07-18 19:07 ` Bjorn Andersson
2023-07-18 19:10 ` Nikunj Kela
2023-07-18 19:10 ` Nikunj Kela
2023-07-18 19:30 ` Bjorn Andersson [this message]
2023-07-18 19:30 ` Bjorn Andersson
2023-07-18 22:05 ` Nikunj Kela
2023-07-18 22:05 ` Nikunj Kela
2023-07-19 10:55 ` Cristian Marussi
2023-07-19 10:55 ` Cristian Marussi
2023-07-19 14:02 ` Nikunj Kela
2023-07-19 14:02 ` Nikunj Kela
2023-07-23 2:15 ` kernel test robot
2023-07-23 2:15 ` kernel test robot
2023-07-24 16:44 ` [PATCH v2 0/3] " Nikunj Kela
2023-07-24 16:44 ` [PATCH v2 1/3] dt-bindings: arm: convert nested if-else construct to allOf Nikunj Kela
2023-07-25 6:01 ` Krzysztof Kozlowski
2023-07-24 16:44 ` [PATCH v2 2/3] dt-bindings: arm: Add qcom specific hvc transport for SCMI Nikunj Kela
2023-07-25 6:06 ` Krzysztof Kozlowski
2023-07-24 16:44 ` [PATCH v2 3/3] firmware: arm_scmi: Add qcom hvc/shmem transport Nikunj Kela
2023-07-25 17:03 ` Cristian Marussi
2023-07-25 17:12 ` Nikunj Kela
2023-07-31 14:04 ` Nikunj Kela
2023-07-31 14:04 ` Nikunj Kela
2023-08-01 7:27 ` kernel test robot
2023-08-01 7:27 ` kernel test robot
2023-08-11 17:57 ` [PATCH v3 0/3] " Nikunj Kela
2023-08-11 17:57 ` Nikunj Kela
2023-08-11 17:57 ` [PATCH v3 1/3] dt-bindings: arm: convert nested if-else construct to allOf Nikunj Kela
2023-08-11 17:57 ` Nikunj Kela
2023-08-11 17:57 ` [PATCH v3 2/3] dt-bindings: arm: Add qcom specific hvc transport for SCMI Nikunj Kela
2023-08-11 17:57 ` Nikunj Kela
2023-08-11 17:57 ` [PATCH v3 3/3] firmware: arm_scmi: Add qcom hvc/shmem transport Nikunj Kela
2023-08-11 17:57 ` Nikunj Kela
2023-09-05 16:06 ` [PATCH v3 0/3] " Nikunj Kela
2023-09-05 16:06 ` Nikunj Kela
2023-09-05 16:37 ` Krzysztof Kozlowski
2023-09-05 16:37 ` Krzysztof Kozlowski
2023-09-07 10:36 ` Sudeep Holla
2023-09-07 10:36 ` Sudeep Holla
2023-09-07 14:20 ` Nikunj Kela
2023-09-07 14:20 ` Nikunj Kela
2023-09-07 16:16 ` [PATCH 0/2] " Konrad Dybcio
2023-09-07 16:16 ` Konrad Dybcio
2023-09-07 22:32 ` Nikunj Kela
2023-09-07 22:32 ` Nikunj Kela
2023-09-11 19:43 ` [PATCH v4 0/4] Add qcom hvc/shmem transport support Nikunj Kela
2023-09-11 19:43 ` Nikunj Kela
2023-09-11 19:43 ` [PATCH v4 1/4] firmware: arm_scmi: Add polling support for completion in smc Nikunj Kela
2023-09-11 19:43 ` Nikunj Kela
2023-10-02 18:18 ` Brian Masney
2023-10-02 18:18 ` Brian Masney
2023-10-02 18:36 ` Nikunj Kela
2023-10-02 18:36 ` Nikunj Kela
2023-10-03 10:33 ` Sudeep Holla
2023-10-03 10:33 ` Sudeep Holla
2023-10-03 10:50 ` Cristian Marussi
2023-10-03 10:50 ` Cristian Marussi
2023-10-03 15:53 ` Nikunj Kela
2023-10-03 15:53 ` Nikunj Kela
2023-10-04 16:11 ` Sudeep Holla
2023-10-04 16:11 ` Sudeep Holla
2023-10-05 3:25 ` Nikunj Kela
2023-10-05 3:25 ` Nikunj Kela
2023-09-11 19:43 ` [PATCH v4 2/4] dt-bindings: arm: convert nested if-else construct to allOf Nikunj Kela
2023-09-11 19:43 ` Nikunj Kela
2023-09-11 19:43 ` [PATCH v4 3/4] dt-bindings: arm: Add new compatible for smc/hvc transport for SCMI Nikunj Kela
2023-09-11 19:43 ` Nikunj Kela
2023-10-03 10:44 ` Sudeep Holla
2023-10-03 10:44 ` Sudeep Holla
2023-10-03 15:59 ` Nikunj Kela
2023-10-03 15:59 ` Nikunj Kela
2023-10-04 15:53 ` Sudeep Holla
2023-10-04 15:53 ` Sudeep Holla
2023-10-05 21:51 ` Nikunj Kela
2023-10-05 21:51 ` Nikunj Kela
2023-09-11 19:43 ` [PATCH v4 4/4] firmware: arm_scmi: Add qcom hvc/shmem transport support Nikunj Kela
2023-09-11 19:43 ` Nikunj Kela
2023-10-02 18:34 ` Brian Masney
2023-10-02 18:34 ` Brian Masney
2023-10-02 18:39 ` Brian Masney
2023-10-02 18:39 ` Brian Masney
2023-10-02 18:45 ` Nikunj Kela
2023-10-02 18:45 ` Nikunj Kela
2023-10-02 18:42 ` Nikunj Kela
2023-10-02 18:42 ` Nikunj Kela
2023-10-03 10:48 ` Sudeep Holla
2023-10-03 10:48 ` Sudeep Holla
2023-10-03 11:19 ` Sudeep Holla
2023-10-03 11:19 ` Sudeep Holla
2023-10-03 16:16 ` Nikunj Kela
2023-10-03 16:16 ` Nikunj Kela
2023-10-04 16:06 ` Sudeep Holla
2023-10-04 16:06 ` Sudeep Holla
2023-10-04 17:48 ` Nikunj Kela
2023-10-04 17:48 ` Nikunj Kela
2023-10-05 22:20 ` Bjorn Andersson
2023-10-05 22:20 ` Bjorn Andersson
2023-10-05 22:33 ` Nikunj Kela
2023-10-05 22:33 ` Nikunj Kela
2023-10-06 7:26 ` Sudeep Holla
2023-10-06 7:26 ` Sudeep Holla
2023-09-18 15:01 ` [PATCH v4 0/4] " Nikunj Kela
2023-09-18 15:01 ` Nikunj Kela
2023-09-18 15:15 ` Sudeep Holla
2023-09-18 15:15 ` Sudeep Holla
2023-09-18 15:54 ` Brian Masney
2023-09-18 15:54 ` Brian Masney
2023-09-19 8:56 ` Sudeep Holla
2023-09-19 8:56 ` Sudeep Holla
2023-10-02 17:31 ` Nikunj Kela
2023-10-02 17:31 ` Nikunj Kela
2023-10-02 17:58 ` Cristian Marussi
2023-10-02 17:58 ` Cristian Marussi
2023-10-03 10:34 ` Sudeep Holla
2023-10-03 10:34 ` Sudeep Holla
2023-09-18 20:32 ` Krzysztof Kozlowski
2023-09-18 20:32 ` Krzysztof Kozlowski
2023-10-06 16:42 ` [PATCH v5 0/2] Add qcom smc/hvc " Nikunj Kela
2023-10-06 16:42 ` Nikunj Kela
2023-10-06 16:42 ` [PATCH v5 1/2] dt-bindings: arm: Add new compatible for smc/hvc transport for SCMI Nikunj Kela
2023-10-06 16:42 ` Nikunj Kela
2023-10-06 20:08 ` Brian Masney
2023-10-06 20:08 ` Brian Masney
2023-10-09 14:41 ` Sudeep Holla
2023-10-09 14:41 ` Sudeep Holla
2023-10-09 14:52 ` Nikunj Kela
2023-10-09 14:52 ` Nikunj Kela
2023-10-09 21:03 ` Konrad Dybcio
2023-10-09 21:03 ` Konrad Dybcio
2023-10-06 16:42 ` [PATCH v5 2/2] firmware: arm_scmi: Add qcom smc/hvc transport support Nikunj Kela
2023-10-06 16:42 ` Nikunj Kela
2023-10-06 20:17 ` Brian Masney
2023-10-06 20:17 ` Brian Masney
2023-10-09 14:47 ` Sudeep Holla
2023-10-09 14:47 ` Sudeep Holla
2023-10-09 14:59 ` Nikunj Kela
2023-10-09 14:59 ` Nikunj Kela
2023-10-09 15:29 ` Sudeep Holla
2023-10-09 15:29 ` Sudeep Holla
2023-10-09 17:49 ` Nikunj Kela
2023-10-09 17:49 ` Nikunj Kela
2023-10-09 19:08 ` Sudeep Holla
2023-10-09 19:08 ` Sudeep Holla
2023-10-09 19:16 ` Nikunj Kela
2023-10-09 19:16 ` Nikunj Kela
2023-10-09 19:14 ` [PATCH v6 0/2] " Nikunj Kela
2023-10-09 19:14 ` Nikunj Kela
2023-10-09 19:14 ` [PATCH v6 1/2] dt-bindings: arm: Add new compatible for smc/hvc transport for SCMI Nikunj Kela
2023-10-09 19:14 ` Nikunj Kela
2023-10-09 19:14 ` [PATCH v6 2/2] firmware: arm_scmi: Add qcom smc/hvc transport support Nikunj Kela
2023-10-09 19:14 ` Nikunj Kela
2023-10-10 10:42 ` Sudeep Holla
2023-10-10 10:42 ` Sudeep Holla
2023-10-10 10:21 ` [PATCH v6 0/2] " Sudeep Holla
2023-10-10 10:21 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=rum7gnnouoz2irn57taxn4j2aajkxf6em6ft6u4w3rxwsym2su@acgczsnl2huz \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_nkela@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.