From: Anthony Liguori <aliguori@linux.vnet.ibm.com> To: Jan Kiszka <jan.kiszka@web.de> Cc: Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org, Alexander Graf <agraf@suse.de> Subject: Re: [PATCH 26/35] kvm: Eliminate KVMState arguments Date: Mon, 10 Jan 2011 13:59:02 -0600 [thread overview] Message-ID: <4D2B6506.6070907@linux.vnet.ibm.com> (raw) In-Reply-To: <4D282489.90506@web.de> On 01/08/2011 02:47 AM, Jan Kiszka wrote: > Am 08.01.2011 00:27, Anthony Liguori wrote: > >> On 01/07/2011 03:03 AM, Jan Kiszka wrote: >> >>> Am 06.01.2011 20:24, Anthony Liguori wrote: >>> >>> >>>> On 01/06/2011 11:56 AM, Marcelo Tosatti wrote: >>>> >>>> >>>>> From: Jan Kiszka<jan.kiszka@siemens.com> >>>>> >>>>> QEMU supports only one VM, so there is only one kvm_state per process, >>>>> and we gain nothing passing a reference to it around. Eliminate any >>>>> need >>>>> to refer to it outside of kvm-all.c. >>>>> >>>>> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com> >>>>> CC: Alexander Graf<agraf@suse.de> >>>>> Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com> >>>>> >>>>> >>>>> >>>> I think this is a big mistake. >>>> >>>> >>> Obviously, I don't share your concerns. :) >>> >>> >>> >>>> Having to manage kvm_state keeps the abstraction lines well defined. >>>> >>>> >>> How does it help? >>> >>> >>> >>>> Otherwise, it's far too easy for portions of code to call into KVM >>>> functions that really shouldn't. >>>> >>>> >>> I can't imagine we gain anything from requiring kvm_check_extension >>> callers to hold a kvm_state "capability". Yes, it's now much easier to >>> call kvm_[vm_]ioctl, but that's the key point of this change: >>> >>> So far we primarily complicated the internal interface between generic >>> and arch-dependent kvm parts by requiring kvm_state joggling. But >>> external users already find interfaces without this restriction >>> (kvm_log_*, kvm_ioeventfd_*, ...). That's because it's at least >>> complicated to _cleanly_ pass kvm_state references to all users that >>> need it - e.g. sysbus devices like kvmclock or upcoming in-kernel >>> irqchips. >>> >>> >> I think you're basically making my point for me. >> >> ioeventfd is a broken interface. It shouldn't be a VM ioctl but rather >> a VCPU ioctl because PIO events are dispatched on a per-VCPU basis. >> > OK, but I don't want to argue about the ioeventfd API. So let's put this > case aside. :) > > >> kvm_state is available as part of CPU state so it's quite easy to get at >> if these interfaces just took a CPUState argument (and they should). >> > My point is definitely NOT about cpu-bound devices. That case is clear > and is not touched at all by this patch. > > My point is about devices that have clear system scope like kvmclock, > ioapic, pit, pic, I don't see how ioapic, pit, or pic have a system scope. I don't know enough about kvmclock. > whatever-the-future-will-bring. And about KVM services > that have global scope like capability checks and other feature > explorations or VM configurations done by the KVM arch code. You still > didn't explain what we gain in these concrete scenarios by handing the > technically redundant abstraction kvm_state around, especially _inside_ > the KVM core. > If you have to pass around a KVMState pointer, you establish an explicit relationship and communication between subsystems. Any place where the global KVMState is used is a red flag that something is wrong. I don't see what the advantage to making all of the KVMState global and implicit. It seems like a big step backwards to me. Can you give a very concrete example of where you think it results in easier to understand code as I don't see how making relationships implicit ever makes code easier to understand? Regards, Anthony Liguori > Jan > >
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <aliguori@linux.vnet.ibm.com> To: Jan Kiszka <jan.kiszka@web.de> Cc: Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org, Alexander Graf <agraf@suse.de> Subject: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments Date: Mon, 10 Jan 2011 13:59:02 -0600 [thread overview] Message-ID: <4D2B6506.6070907@linux.vnet.ibm.com> (raw) In-Reply-To: <4D282489.90506@web.de> On 01/08/2011 02:47 AM, Jan Kiszka wrote: > Am 08.01.2011 00:27, Anthony Liguori wrote: > >> On 01/07/2011 03:03 AM, Jan Kiszka wrote: >> >>> Am 06.01.2011 20:24, Anthony Liguori wrote: >>> >>> >>>> On 01/06/2011 11:56 AM, Marcelo Tosatti wrote: >>>> >>>> >>>>> From: Jan Kiszka<jan.kiszka@siemens.com> >>>>> >>>>> QEMU supports only one VM, so there is only one kvm_state per process, >>>>> and we gain nothing passing a reference to it around. Eliminate any >>>>> need >>>>> to refer to it outside of kvm-all.c. >>>>> >>>>> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com> >>>>> CC: Alexander Graf<agraf@suse.de> >>>>> Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com> >>>>> >>>>> >>>>> >>>> I think this is a big mistake. >>>> >>>> >>> Obviously, I don't share your concerns. :) >>> >>> >>> >>>> Having to manage kvm_state keeps the abstraction lines well defined. >>>> >>>> >>> How does it help? >>> >>> >>> >>>> Otherwise, it's far too easy for portions of code to call into KVM >>>> functions that really shouldn't. >>>> >>>> >>> I can't imagine we gain anything from requiring kvm_check_extension >>> callers to hold a kvm_state "capability". Yes, it's now much easier to >>> call kvm_[vm_]ioctl, but that's the key point of this change: >>> >>> So far we primarily complicated the internal interface between generic >>> and arch-dependent kvm parts by requiring kvm_state joggling. But >>> external users already find interfaces without this restriction >>> (kvm_log_*, kvm_ioeventfd_*, ...). That's because it's at least >>> complicated to _cleanly_ pass kvm_state references to all users that >>> need it - e.g. sysbus devices like kvmclock or upcoming in-kernel >>> irqchips. >>> >>> >> I think you're basically making my point for me. >> >> ioeventfd is a broken interface. It shouldn't be a VM ioctl but rather >> a VCPU ioctl because PIO events are dispatched on a per-VCPU basis. >> > OK, but I don't want to argue about the ioeventfd API. So let's put this > case aside. :) > > >> kvm_state is available as part of CPU state so it's quite easy to get at >> if these interfaces just took a CPUState argument (and they should). >> > My point is definitely NOT about cpu-bound devices. That case is clear > and is not touched at all by this patch. > > My point is about devices that have clear system scope like kvmclock, > ioapic, pit, pic, I don't see how ioapic, pit, or pic have a system scope. I don't know enough about kvmclock. > whatever-the-future-will-bring. And about KVM services > that have global scope like capability checks and other feature > explorations or VM configurations done by the KVM arch code. You still > didn't explain what we gain in these concrete scenarios by handing the > technically redundant abstraction kvm_state around, especially _inside_ > the KVM core. > If you have to pass around a KVMState pointer, you establish an explicit relationship and communication between subsystems. Any place where the global KVMState is used is a red flag that something is wrong. I don't see what the advantage to making all of the KVMState global and implicit. It seems like a big step backwards to me. Can you give a very concrete example of where you think it results in easier to understand code as I don't see how making relationships implicit ever makes code easier to understand? Regards, Anthony Liguori > Jan > >
next prev parent reply other threads:[~2011-01-10 19:59 UTC|newest] Thread overview: 300+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-01-06 17:56 [PATCH 00/35] [PULL] qemu-kvm.git uq/master queue Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 01/35] kvm: Enable user space NMI injection for kvm guest Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 02/35] kvm: convert kvm_ioctl(KVM_CHECK_EXTENSION) to kvm_check_extension() Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 03/35] Clean up cpu_inject_x86_mce() Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 04/35] Add "broadcast" option for mce command Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-09 18:51 ` Jan Kiszka 2011-01-09 18:51 ` [Qemu-devel] " Jan Kiszka 2011-01-15 16:24 ` Jan Kiszka 2011-01-15 16:24 ` [Qemu-devel] " Jan Kiszka 2011-01-06 17:56 ` [PATCH 05/35] Add function for checking mca broadcast of CPU Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 06/35] kvm: introduce kvm_mce_in_progress Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 07/35] kvm: kvm_mce_inj_* subroutines for templated error injections Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 08/35] kvm: introduce kvm_inject_x86_mce_on Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 09/35] kvm: x86: Fix DPL write back of segment registers Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 10/35] kvm: x86: Remove obsolete SS.RPL/DPL aligment Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 11/35] kvm: x86: Prevent sign extension of DR7 in guest debugging mode Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 12/35] kvm: x86: Fix a few coding style violations Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 13/35] kvm: Fix " Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 14/35] kvm: Drop return value of kvm_cpu_exec Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-08 13:09 ` Jan Kiszka 2011-01-08 13:09 ` [Qemu-devel] " Jan Kiszka 2011-01-06 17:56 ` [PATCH 15/35] kvm: Stop on all fatal exit reasons Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 16/35] kvm: Improve reporting of fatal errors Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 17/35] x86: Optionally dump code bytes on cpu_dump_state Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 18/35] kvm: x86: Align kvm_arch_put_registers code with comment Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 19/35] kvm: x86: Prepare kvm_get_mp_state for in-kernel irqchip Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 20/35] kvm: x86: Remove redundant mp_state initialization Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 21/35] kvm: x86: Fix xcr0 reset mismerge Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 22/35] kvm: x86: Refactor msr_star/hsave_pa setup and checks Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 23/35] kvm: x86: Reset paravirtual MSRs Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 24/35] Synchronize VCPU states before reset Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 25/35] kvm: x86: Drop MCE MSRs write back restrictions Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 26/35] kvm: Eliminate KVMState arguments Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 19:24 ` Anthony Liguori 2011-01-06 19:24 ` [Qemu-devel] " Anthony Liguori 2011-01-07 9:03 ` Jan Kiszka 2011-01-07 9:03 ` [Qemu-devel] " Jan Kiszka 2011-01-07 23:27 ` Anthony Liguori 2011-01-07 23:27 ` [Qemu-devel] " Anthony Liguori 2011-01-08 8:47 ` Jan Kiszka 2011-01-08 8:47 ` [Qemu-devel] " Jan Kiszka 2011-01-10 19:59 ` Anthony Liguori [this message] 2011-01-10 19:59 ` Anthony Liguori 2011-01-10 20:12 ` Jan Kiszka 2011-01-10 20:12 ` [Qemu-devel] " Jan Kiszka 2011-01-10 20:23 ` Anthony Liguori 2011-01-10 20:34 ` Jan Kiszka 2011-01-11 9:01 ` Avi Kivity 2011-01-11 9:01 ` Avi Kivity 2011-01-11 14:00 ` Anthony Liguori 2011-01-11 14:00 ` Anthony Liguori 2011-01-11 14:06 ` Alexander Graf 2011-01-11 14:06 ` Alexander Graf 2011-01-11 14:09 ` Anthony Liguori 2011-01-11 14:09 ` Anthony Liguori 2011-01-11 14:22 ` Avi Kivity 2011-01-11 14:22 ` Avi Kivity 2011-01-11 14:36 ` Anthony Liguori 2011-01-11 14:36 ` Anthony Liguori 2011-01-11 14:56 ` Avi Kivity 2011-01-11 14:56 ` Avi Kivity 2011-01-11 15:12 ` Anthony Liguori 2011-01-11 15:12 ` Anthony Liguori 2011-01-11 15:17 ` Alexander Graf 2011-01-11 15:17 ` Alexander Graf 2011-01-11 15:37 ` Avi Kivity 2011-01-11 15:37 ` Avi Kivity 2011-01-11 15:55 ` Anthony Liguori 2011-01-11 15:55 ` Anthony Liguori 2011-01-11 16:03 ` Avi Kivity 2011-01-11 16:03 ` Avi Kivity 2011-01-11 16:26 ` Anthony Liguori 2011-01-11 16:26 ` Anthony Liguori 2011-01-11 17:05 ` Avi Kivity 2011-01-11 17:05 ` Avi Kivity 2011-01-11 14:24 ` Alexander Graf 2011-01-11 14:24 ` Alexander Graf 2011-01-11 14:18 ` Avi Kivity 2011-01-11 14:18 ` Avi Kivity 2011-01-11 14:28 ` Anthony Liguori 2011-01-11 14:28 ` Anthony Liguori 2011-01-11 14:52 ` Avi Kivity 2011-01-11 14:52 ` Avi Kivity 2011-01-10 20:11 ` Anthony Liguori 2011-01-10 20:15 ` Jan Kiszka 2011-01-11 9:17 ` Avi Kivity 2011-01-11 9:17 ` Avi Kivity 2011-01-06 17:56 ` [PATCH 27/35] kvm: x86: Fix !CONFIG_KVM_PARA build Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-10 20:31 ` Anthony Liguori 2011-01-10 20:31 ` Anthony Liguori 2011-01-10 21:06 ` Jan Kiszka 2011-01-10 21:06 ` Jan Kiszka 2011-01-10 22:21 ` Jan Kiszka 2011-01-10 22:21 ` Jan Kiszka 2011-01-10 23:02 ` Anthony Liguori 2011-01-10 23:02 ` Anthony Liguori 2011-01-11 5:54 ` Jan Kiszka 2011-01-11 5:54 ` Jan Kiszka 2011-01-11 8:00 ` Paolo Bonzini 2011-01-11 8:00 ` Paolo Bonzini 2011-01-11 8:53 ` Gerd Hoffmann 2011-01-11 8:53 ` Gerd Hoffmann 2011-01-11 17:13 ` Jan Kiszka 2011-01-11 17:13 ` Jan Kiszka 2011-01-11 9:31 ` Markus Armbruster 2011-01-11 9:31 ` Markus Armbruster 2011-01-11 13:54 ` Anthony Liguori 2011-01-11 13:54 ` Anthony Liguori 2011-01-12 10:22 ` Avi Kivity 2011-01-12 10:22 ` Avi Kivity 2011-01-12 10:31 ` Jan Kiszka 2011-01-12 10:31 ` Jan Kiszka 2011-01-18 14:28 ` Jan Kiszka 2011-01-18 14:28 ` Jan Kiszka 2011-01-18 15:04 ` Anthony Liguori 2011-01-18 15:04 ` Anthony Liguori 2011-01-18 15:43 ` Jan Kiszka 2011-01-18 15:43 ` Jan Kiszka 2011-01-18 15:48 ` Anthony Liguori 2011-01-18 15:48 ` Anthony Liguori 2011-01-18 15:54 ` Jan Kiszka 2011-01-18 15:54 ` Jan Kiszka 2011-01-18 17:02 ` Alex Williamson 2011-01-18 17:02 ` Alex Williamson 2011-01-18 17:08 ` Jan Kiszka 2011-01-18 17:08 ` Jan Kiszka 2011-01-18 17:39 ` Alex Williamson 2011-01-18 17:39 ` Alex Williamson 2011-01-18 15:50 ` Anthony Liguori 2011-01-18 15:50 ` Anthony Liguori 2011-01-18 16:01 ` Jan Kiszka 2011-01-18 16:01 ` Jan Kiszka 2011-01-18 16:04 ` Anthony Liguori 2011-01-18 16:04 ` Anthony Liguori 2011-01-18 16:17 ` Jan Kiszka 2011-01-18 16:17 ` Jan Kiszka 2011-01-18 16:37 ` Anthony Liguori 2011-01-18 16:37 ` Anthony Liguori 2011-01-18 16:56 ` Jan Kiszka 2011-01-18 16:56 ` Jan Kiszka 2011-01-18 17:09 ` Anthony Liguori 2011-01-18 17:09 ` Anthony Liguori 2011-01-18 17:20 ` Jan Kiszka 2011-01-18 17:20 ` Jan Kiszka 2011-01-18 17:31 ` Anthony Liguori 2011-01-18 17:31 ` Anthony Liguori 2011-01-18 17:45 ` Jan Kiszka 2011-01-18 17:45 ` Jan Kiszka 2011-01-19 9:48 ` Gerd Hoffmann 2011-01-19 9:48 ` Gerd Hoffmann 2011-01-19 13:11 ` Markus Armbruster 2011-01-19 13:11 ` Markus Armbruster 2011-01-19 16:54 ` Anthony Liguori 2011-01-19 16:54 ` Anthony Liguori 2011-01-19 17:19 ` Daniel P. Berrange 2011-01-19 17:19 ` Daniel P. Berrange 2011-01-19 17:43 ` Anthony Liguori 2011-01-19 17:43 ` Anthony Liguori 2011-01-20 8:44 ` Gerd Hoffmann 2011-01-20 8:44 ` Gerd Hoffmann 2011-01-20 10:33 ` Daniel P. Berrange 2011-01-20 10:33 ` Daniel P. Berrange 2011-01-20 19:42 ` Anthony Liguori 2011-01-20 19:42 ` Anthony Liguori 2011-01-20 19:39 ` Anthony Liguori 2011-01-20 19:39 ` Anthony Liguori 2011-01-21 8:35 ` Gerd Hoffmann 2011-01-21 8:35 ` Gerd Hoffmann 2011-01-21 10:03 ` Markus Armbruster 2011-01-21 10:03 ` Markus Armbruster 2011-01-19 16:53 ` Anthony Liguori 2011-01-19 16:53 ` Anthony Liguori 2011-01-19 17:01 ` Daniel P. Berrange 2011-01-19 17:01 ` Daniel P. Berrange 2011-01-19 17:51 ` Anthony Liguori 2011-01-19 17:51 ` Anthony Liguori 2011-01-19 18:52 ` Daniel P. Berrange 2011-01-19 18:52 ` Daniel P. Berrange 2011-01-19 18:58 ` Anthony Liguori 2011-01-19 18:58 ` Anthony Liguori 2011-01-19 17:35 ` Daniel P. Berrange 2011-01-19 17:35 ` Daniel P. Berrange 2011-01-19 17:42 ` Anthony Liguori 2011-01-19 17:42 ` Anthony Liguori 2011-01-19 18:53 ` Daniel P. Berrange 2011-01-19 18:53 ` Daniel P. Berrange 2011-01-19 13:09 ` Markus Armbruster 2011-01-19 13:09 ` Markus Armbruster 2011-01-24 8:45 ` Gleb Natapov 2011-01-24 8:45 ` Gleb Natapov 2011-01-19 13:15 ` Markus Armbruster 2011-01-19 13:15 ` Markus Armbruster 2011-01-19 16:57 ` Anthony Liguori 2011-01-19 16:57 ` [Qemu-devel] " Anthony Liguori 2011-01-19 17:25 ` Jan Kiszka 2011-01-19 17:25 ` Jan Kiszka 2011-01-19 19:32 ` Blue Swirl 2011-01-19 19:32 ` Blue Swirl 2011-01-20 9:33 ` Jan Kiszka 2011-01-20 9:33 ` Jan Kiszka 2011-01-20 19:27 ` Blue Swirl 2011-01-20 19:27 ` Blue Swirl 2011-01-20 21:22 ` Jan Kiszka 2011-01-20 21:22 ` Jan Kiszka 2011-01-20 21:40 ` Blue Swirl 2011-01-20 21:40 ` Blue Swirl 2011-01-20 21:53 ` Jan Kiszka 2011-01-20 21:53 ` Jan Kiszka 2011-01-25 11:10 ` Avi Kivity 2011-01-25 11:10 ` Avi Kivity 2011-01-21 8:46 ` Gerd Hoffmann 2011-01-21 8:46 ` Gerd Hoffmann 2011-01-21 10:05 ` Markus Armbruster 2011-01-21 10:05 ` Markus Armbruster 2011-01-21 16:37 ` Blue Swirl 2011-01-21 16:37 ` Blue Swirl 2011-01-21 17:21 ` Jan Kiszka 2011-01-21 17:21 ` Jan Kiszka 2011-01-21 18:04 ` Blue Swirl 2011-01-21 18:04 ` Blue Swirl 2011-01-21 18:17 ` Jan Kiszka 2011-01-21 18:17 ` Jan Kiszka 2011-01-21 18:49 ` Blue Swirl 2011-01-21 18:49 ` Blue Swirl 2011-01-24 14:08 ` Jan Kiszka 2011-01-24 14:08 ` Jan Kiszka 2011-01-24 21:35 ` Blue Swirl 2011-01-24 21:35 ` Blue Swirl 2011-01-24 21:57 ` Jan Kiszka 2011-01-24 21:57 ` Jan Kiszka 2011-01-20 19:37 ` Anthony Liguori 2011-01-20 19:37 ` Anthony Liguori 2011-01-20 20:02 ` Blue Swirl 2011-01-20 20:02 ` Blue Swirl 2011-01-20 21:42 ` Jan Kiszka 2011-01-20 21:42 ` Jan Kiszka 2011-01-20 21:27 ` Jan Kiszka 2011-01-20 21:27 ` Jan Kiszka 2011-01-25 11:06 ` Avi Kivity 2011-01-25 11:06 ` Avi Kivity 2011-01-25 14:30 ` Anthony Liguori 2011-01-25 14:30 ` Anthony Liguori 2011-01-25 10:34 ` Avi Kivity 2011-01-25 10:34 ` Avi Kivity 2011-01-25 10:27 ` Avi Kivity 2011-01-25 10:27 ` Avi Kivity 2011-01-25 13:58 ` Anthony Liguori 2011-01-25 13:58 ` Anthony Liguori 2011-01-12 12:04 ` Markus Armbruster 2011-01-12 12:04 ` Markus Armbruster 2011-01-10 23:04 ` Anthony Liguori 2011-01-10 23:04 ` Anthony Liguori 2011-01-11 5:55 ` Jan Kiszka 2011-01-11 5:55 ` Jan Kiszka 2011-01-06 17:56 ` [PATCH 29/35] kvm: Drop smp_cpus argument from init functions Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 30/35] kvm: Consolidate must-have capability checks Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 31/35] kvm: x86: Rework identity map and TSS setup for larger BIOS sizes Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 32/35] kvm: Flush coalesced mmio buffer on IO window exits Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 33/35] kvm: Do not use qemu_fair_mutex Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 34/35] kvm: x86: Implicitly clear nmi_injected/pending on reset Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-06 17:56 ` [PATCH 35/35] kvm: x86: Only read/write MSR_KVM_ASYNC_PF_EN if supported Marcelo Tosatti 2011-01-06 17:56 ` [Qemu-devel] " Marcelo Tosatti 2011-01-27 14:39 ` [PATCH] kvm: x86: Fix build in absence of KVM_CAP_ASYNC_PF Jan Kiszka 2011-01-27 14:39 ` [Qemu-devel] " Jan Kiszka
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4D2B6506.6070907@linux.vnet.ibm.com \ --to=aliguori@linux.vnet.ibm.com \ --cc=agraf@suse.de \ --cc=jan.kiszka@web.de \ --cc=kvm@vger.kernel.org \ --cc=mtosatti@redhat.com \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.