From: Yakir Yang <ykk@rock-chips.com> To: Thierry Reding <treding@nvidia.com> Cc: Rob Herring <robherring2@gmail.com>, Heiko Stuebner <heiko@sntech.de>, Jingoo Han <jingoohan1@gmail.com>, Fabio Estevam <fabio.estevam@freescale.com>, Inki Dae <inki.dae@samsung.com>, Joe Perches <joe@perches.com>, Russell King <rmk+kernel@arm.linux.org.uk>, Sean Paul <seanpaul@google.com>, Takashi Iwai <tiwai@suse.de>, dri-devel <dri-devel@lists.freedesktop.org>, Andrzej Hajda <a.hajda@samsung.com>, Gustavo Padovan <gustavo.padovan@collabora.co.uk>, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, Vincent Palatin <vpalatin@chromium.org>, linux-rockchip@lists.infradead.org, Kishon Vijay Abraham I <kishon@ti.com>, David Airlie <airlied@linux.ie>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Pawel Moll <pawel.moll@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Doug Anderson <dianders@google.com>, Rob Herring <robh+dt@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Mark Yao <mark.yao@rock-chips.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Kyungmin Park <kyungmin.park@samsung.com>, Daniel Kurtz <djkurtz@google.com>, Philipp Zabel <p.zabel@pengutronix.de>, Kumar Gala <galak@codeaurora.org>, Ajay kumar <ajaynumb@gmail.com>, Andy Yan <andy.yan@rock-chips.com> Subject: Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp Date: Tue, 25 Aug 2015 22:23:24 +0800 [thread overview] Message-ID: <55DC7A5C.1010108@rock-chips.com> (raw) In-Reply-To: <20150825141642.GA3820@ulmo.nvidia.com> Hi Thierry, 在 2015/8/25 22:16, Thierry Reding 写道: > On Tue, Aug 25, 2015 at 09:48:01PM +0800, Yakir Yang wrote: >> Hi Thierry & Rob, >> >> 在 2015/8/25 21:27, Rob Herring 写道: >>> On Tue, Aug 25, 2015 at 4:15 AM, Thierry Reding <treding@nvidia.com> wrote: >>>> On Sun, Aug 23, 2015 at 06:23:14PM -0500, Rob Herring wrote: >>>>> On Wed, Aug 19, 2015 at 9:50 AM, Yakir Yang <ykk@rock-chips.com> wrote: >>>> [...] >>>>>> + -analogix,link-rate: >>>>>> + max link rate supported by the eDP controller. >>>>>> + LINK_RATE_1_62GBPS = 0x6, LINK_RATE_2_70GBPS = 0x0A, >>>>>> + LINK_RATE_5_40GBPS = 0x14 >>>>> Same here. I'd rather see something like "link-rate-mbps" and use the >>>>> actual rate. >>>> There is no need whatsoever to hard-code this in DT. (e)DP provides the >>>> means to detect what rate the link supports and the specification >>>> provides guidance on how to select an appropriate one. >>> Good, even better. >> I do think we still need keep this DT prop yet. >> >> I think drm_dp_help.c could get the "panel" max link-rate and lane-count, >> but it's not enough, we still need knew the "eDP controller" max link-rate >> and lane-count. >> >> Let me show the exact example that happened in my side. When I connect >> my board to my 2K DP-1.2 TV. Analogix dp driver would get the max link-rate >> from dpcd, and the max link-rate is 5.4Gbps. So if I just set eDP controller >> link-rate >> to 5.4Gbps, the DP TV just broken, do not light up normally. >> >> This reason why TV broken is the max link-rate which support by RK3288 eDP >> controller is 2.7Gbps. Here are the exact words that RK3288 eDP TRM said: >> >> *Compliant with DisplayPortTM Specification, Version 1.2. >> Compliant with eDPTM Specification, Version 1.3. >> HDCP v1.3 amendment for DisplayPortTM Revision 1.0. >> Main link containing 4 physical lanes of 2.7/1.62 Gbps/lane >> * >> ** >> >> >> Beside I haven't found there are some registers would indicate the eDP >> controller >> max link-rate and lane-count, so this is why I still instance that we need >> this DT >> prop to indicata "Max rate controller support". >> >> So, I wish you could agree with me on this point. > Your driver should know what link rates it supports and restrict itself > to use those. This is implied by the compatible string and doesn't need > to be duplicated into device tree. Oh, yeah, good idea :-D Thanks for your point out. - Yakir > Thierry
WARNING: multiple messages have this Message-ID (diff)
From: Yakir Yang <ykk@rock-chips.com> To: Thierry Reding <treding@nvidia.com> Cc: Rob Herring <robherring2@gmail.com>, Heiko Stuebner <heiko@sntech.de>, Jingoo Han <jingoohan1@gmail.com>, Fabio Estevam <fabio.estevam@freescale.com>, Inki Dae <inki.dae@samsung.com>, Joe Perches <joe@perches.com>, Russell King <rmk+kernel@arm.linux.org.uk>, Sean Paul <seanpaul@google.com>, Takashi Iwai <tiwai@suse.de>, dri-devel <dri-devel@lists.freedesktop.org>, Andrzej Hajda <a.hajda@samsung.com>, Gustavo Padovan <gustavo.padovan@collabora.co.uk>, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, Vincent Palatin <vpalatin@chromium.org>, linux-rockchip@lists.infradead.org, Kishon Vijay Abraham I <kishon@ti.com>, David Airlie <airlied@linux.ie>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Pawel Moll <pawel.moll@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Doug Anderson <dianders@google.com>, Rob Herring <robh+dt@k> Subject: Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp Date: Tue, 25 Aug 2015 22:23:24 +0800 [thread overview] Message-ID: <55DC7A5C.1010108@rock-chips.com> (raw) In-Reply-To: <20150825141642.GA3820@ulmo.nvidia.com> Hi Thierry, 在 2015/8/25 22:16, Thierry Reding 写道: > On Tue, Aug 25, 2015 at 09:48:01PM +0800, Yakir Yang wrote: >> Hi Thierry & Rob, >> >> 在 2015/8/25 21:27, Rob Herring 写道: >>> On Tue, Aug 25, 2015 at 4:15 AM, Thierry Reding <treding@nvidia.com> wrote: >>>> On Sun, Aug 23, 2015 at 06:23:14PM -0500, Rob Herring wrote: >>>>> On Wed, Aug 19, 2015 at 9:50 AM, Yakir Yang <ykk@rock-chips.com> wrote: >>>> [...] >>>>>> + -analogix,link-rate: >>>>>> + max link rate supported by the eDP controller. >>>>>> + LINK_RATE_1_62GBPS = 0x6, LINK_RATE_2_70GBPS = 0x0A, >>>>>> + LINK_RATE_5_40GBPS = 0x14 >>>>> Same here. I'd rather see something like "link-rate-mbps" and use the >>>>> actual rate. >>>> There is no need whatsoever to hard-code this in DT. (e)DP provides the >>>> means to detect what rate the link supports and the specification >>>> provides guidance on how to select an appropriate one. >>> Good, even better. >> I do think we still need keep this DT prop yet. >> >> I think drm_dp_help.c could get the "panel" max link-rate and lane-count, >> but it's not enough, we still need knew the "eDP controller" max link-rate >> and lane-count. >> >> Let me show the exact example that happened in my side. When I connect >> my board to my 2K DP-1.2 TV. Analogix dp driver would get the max link-rate >> from dpcd, and the max link-rate is 5.4Gbps. So if I just set eDP controller >> link-rate >> to 5.4Gbps, the DP TV just broken, do not light up normally. >> >> This reason why TV broken is the max link-rate which support by RK3288 eDP >> controller is 2.7Gbps. Here are the exact words that RK3288 eDP TRM said: >> >> *Compliant with DisplayPortTM Specification, Version 1.2. >> Compliant with eDPTM Specification, Version 1.3. >> HDCP v1.3 amendment for DisplayPortTM Revision 1.0. >> Main link containing 4 physical lanes of 2.7/1.62 Gbps/lane >> * >> ** >> >> >> Beside I haven't found there are some registers would indicate the eDP >> controller >> max link-rate and lane-count, so this is why I still instance that we need >> this DT >> prop to indicata "Max rate controller support". >> >> So, I wish you could agree with me on this point. > Your driver should know what link rates it supports and restrict itself > to use those. This is implied by the compatible string and doesn't need > to be duplicated into device tree. Oh, yeah, good idea :-D Thanks for your point out. - Yakir > Thierry
next prev parent reply other threads:[~2015-08-25 14:23 UTC|newest] Thread overview: 187+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-08-19 14:48 [PATCH v3 0/14] Add Analogix Core Display Port Driver Yakir Yang 2015-08-19 14:48 ` Yakir Yang 2015-08-19 14:49 ` [PATCH v3 01/14] drm: exynos/dp: fix code style Yakir Yang 2015-08-19 14:49 ` Yakir Yang 2015-08-19 14:49 ` [PATCH v3 02/14] drm: exynos/dp: convert to drm bridge mode Yakir Yang 2015-08-19 14:49 ` Yakir Yang 2015-08-19 14:50 ` [PATCH v3 03/14] drm: bridge: analogix_dp: split exynos dp driver to bridge dir Yakir Yang 2015-08-19 14:50 ` Yakir Yang 2015-08-19 14:50 ` [PATCH v3 04/14] drm: bridge/analogix_dp: dynamic parse sync_pol & interlace & colorimetry Yakir Yang 2015-08-19 14:50 ` Yakir Yang 2015-08-19 14:50 ` [PATCH v3 05/14] drm: bridge/analogix_dp: fix link_rate & lane_count bug Yakir Yang 2015-08-19 14:50 ` Yakir Yang 2015-08-20 7:22 ` Jingoo Han 2015-08-20 7:22 ` Jingoo Han 2015-08-20 7:22 ` Jingoo Han 2015-08-20 8:04 ` Yakir Yang 2015-08-20 8:04 ` Yakir Yang 2015-08-20 8:04 ` Yakir Yang 2015-08-19 14:50 ` [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp Yakir Yang 2015-08-19 14:50 ` Yakir Yang 2015-08-23 23:23 ` Rob Herring 2015-08-23 23:23 ` Rob Herring 2015-08-23 23:23 ` Rob Herring 2015-08-24 0:43 ` Krzysztof Kozlowski 2015-08-24 0:43 ` Krzysztof Kozlowski 2015-08-24 0:43 ` Krzysztof Kozlowski 2015-08-24 2:42 ` Yakir Yang 2015-08-24 2:42 ` Yakir Yang 2015-08-24 4:20 ` Krzysztof Kozlowski 2015-08-24 4:20 ` Krzysztof Kozlowski 2015-08-24 4:20 ` Krzysztof Kozlowski 2015-08-24 12:48 ` Yakir Yang 2015-08-24 12:48 ` Yakir Yang 2015-08-24 12:48 ` Yakir Yang 2015-08-24 13:03 ` Heiko Stuebner 2015-08-24 13:03 ` Heiko Stuebner 2015-08-24 13:03 ` Heiko Stuebner 2015-08-25 1:37 ` Yakir Yang 2015-08-25 1:37 ` Yakir Yang 2015-08-25 1:37 ` Yakir Yang 2015-08-24 23:49 ` Krzysztof Kozlowski 2015-08-24 23:49 ` Krzysztof Kozlowski 2015-08-24 23:49 ` Krzysztof Kozlowski [not found] ` <55DBAD90.3040901-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2015-08-25 1:32 ` Yakir Yang 2015-08-25 1:33 ` Yakir Yang 2015-08-25 1:33 ` Yakir Yang 2015-08-25 1:33 ` Yakir Yang 2015-08-25 1:35 ` Krzysztof Kozlowski 2015-08-25 1:35 ` Krzysztof Kozlowski 2015-08-25 1:35 ` Krzysztof Kozlowski 2015-08-24 7:40 ` Jingoo Han 2015-08-24 7:40 ` Jingoo Han 2015-08-24 7:40 ` Jingoo Han 2015-08-24 12:55 ` Yakir Yang 2015-08-24 12:55 ` Yakir Yang 2015-08-24 12:55 ` Yakir Yang 2015-08-24 2:19 ` Yakir Yang 2015-08-24 2:19 ` Yakir Yang 2015-08-24 12:57 ` Russell King - ARM Linux 2015-08-24 12:57 ` Russell King - ARM Linux 2015-08-24 12:57 ` Russell King - ARM Linux 2015-08-24 14:48 ` Rob Herring 2015-08-24 14:48 ` Rob Herring 2015-08-24 14:48 ` Rob Herring 2015-08-24 16:16 ` Heiko Stuebner 2015-08-24 16:16 ` Heiko Stuebner 2015-08-24 16:16 ` Heiko Stuebner 2015-08-25 1:21 ` Yakir Yang 2015-08-25 1:21 ` Yakir Yang 2015-08-25 1:21 ` Yakir Yang 2015-08-25 9:12 ` Thierry Reding 2015-08-25 9:12 ` Thierry Reding 2015-08-25 9:12 ` Thierry Reding 2015-08-25 9:29 ` Russell King - ARM Linux 2015-08-25 9:29 ` Russell King - ARM Linux 2015-08-25 9:29 ` Russell King - ARM Linux 2015-08-25 10:40 ` Thierry Reding 2015-08-25 10:40 ` Thierry Reding 2015-08-25 10:40 ` Thierry Reding 2015-08-25 10:52 ` Russell King - ARM Linux 2015-08-25 10:52 ` Russell King - ARM Linux 2015-08-25 10:52 ` Russell King - ARM Linux 2015-08-25 9:41 ` Yakir Yang 2015-08-25 9:41 ` Yakir Yang 2015-08-25 10:06 ` Thierry Reding 2015-08-25 10:06 ` Thierry Reding 2015-08-25 10:06 ` Thierry Reding 2015-08-25 14:02 ` Yakir Yang 2015-08-25 14:02 ` Yakir Yang 2015-08-25 9:15 ` Thierry Reding 2015-08-25 9:15 ` Thierry Reding 2015-08-25 9:15 ` Thierry Reding 2015-08-25 9:37 ` Yakir Yang 2015-08-25 9:37 ` Yakir Yang 2015-08-25 13:27 ` Rob Herring 2015-08-25 13:27 ` Rob Herring 2015-08-25 13:27 ` Rob Herring 2015-08-25 13:48 ` Yakir Yang 2015-08-25 14:16 ` Thierry Reding 2015-08-25 14:16 ` Thierry Reding 2015-08-25 14:16 ` Thierry Reding 2015-08-25 14:23 ` Yakir Yang [this message] 2015-08-25 14:23 ` Yakir Yang 2015-08-25 9:58 ` Thierry Reding 2015-08-25 9:58 ` Thierry Reding 2015-08-25 9:58 ` Thierry Reding 2015-08-25 14:03 ` Yakir Yang 2015-08-25 14:03 ` Yakir Yang 2015-08-25 14:21 ` Thierry Reding 2015-08-25 14:21 ` Thierry Reding 2015-08-25 14:21 ` Thierry Reding 2015-08-25 15:57 ` Russell King - ARM Linux 2015-08-25 15:57 ` Russell King - ARM Linux 2015-08-25 15:57 ` Russell King - ARM Linux 2015-08-19 14:50 ` [PATCH v3 07/14] drm: rockchip/dp: add rockchip platform dp driver Yakir Yang 2015-08-19 14:50 ` Yakir Yang 2015-08-19 14:50 ` Yakir Yang 2015-08-19 14:51 ` [PATCH v3 08/14] phy: Add driver for rockchip Display Port PHY Yakir Yang 2015-08-19 14:51 ` Yakir Yang 2015-08-20 4:40 ` Kishon Vijay Abraham I 2015-08-20 4:40 ` Kishon Vijay Abraham I 2015-08-20 4:40 ` Kishon Vijay Abraham I 2015-08-20 6:56 ` Yakir Yang 2015-08-20 7:01 ` Yakir Yang 2015-08-19 14:51 ` [PATCH v3 09/14] drm: bridge/analogix_dp: add platform device type support Yakir Yang 2015-08-19 14:51 ` Yakir Yang 2015-08-19 14:51 ` Yakir Yang 2015-08-19 14:51 ` [PATCH v3 10/14] drm: bridge: analogix_dp: add some rk3288 special registers setting Yakir Yang 2015-08-19 14:51 ` Yakir Yang 2015-08-19 14:51 ` [PATCH v3 11/14] drm: bridge: analogix_dp: try force hpd after plug in lookup failed Yakir Yang 2015-08-19 14:51 ` Yakir Yang 2015-08-19 14:52 ` [PATCH v3 12/14] drm: bridge/analogix_dp: expand the delay time for hpd detect Yakir Yang 2015-08-19 14:52 ` Yakir Yang 2015-08-19 14:52 ` Yakir Yang 2015-08-20 6:11 ` Jingoo Han 2015-08-20 6:11 ` Jingoo Han 2015-08-20 6:11 ` Jingoo Han 2015-08-20 8:02 ` Yakir Yang 2015-08-20 8:02 ` Yakir Yang 2015-08-20 8:02 ` Yakir Yang 2015-08-19 14:52 ` [PATCH v3 13/14] drm: bridge/analogix_dp: move hpd detect to connector detect function Yakir Yang 2015-08-19 14:52 ` Yakir Yang 2015-08-20 7:49 ` Jingoo Han 2015-08-20 7:49 ` Jingoo Han 2015-08-20 7:49 ` Jingoo Han 2015-08-20 8:18 ` Yakir Yang 2015-08-20 8:18 ` Yakir Yang 2015-08-20 8:18 ` Yakir Yang 2015-08-19 14:52 ` [PATCH v3 14/14] drm: bridge/analogix_dp: add edid modes parse in get_modes method Yakir Yang 2015-08-19 14:52 ` Yakir Yang 2015-08-19 23:54 ` [PATCH v3 0/14] Add Analogix Core Display Port Driver Dave Airlie 2015-08-19 23:54 ` Dave Airlie 2015-08-19 23:54 ` Dave Airlie 2015-08-20 1:02 ` Yakir Yang 2015-08-20 1:02 ` Yakir Yang 2015-08-20 1:02 ` Yakir Yang 2015-08-20 4:29 ` Archit Taneja 2015-08-20 4:29 ` Archit Taneja 2015-08-20 4:29 ` Archit Taneja 2015-08-20 5:54 ` Jingoo Han 2015-08-20 5:54 ` Jingoo Han 2015-08-20 5:54 ` Jingoo Han 2015-08-20 6:23 ` Yakir Yang 2015-08-20 6:23 ` Yakir Yang 2015-08-20 6:23 ` Yakir Yang 2015-08-20 6:55 ` Jingoo Han 2015-08-20 6:55 ` Jingoo Han 2015-08-20 6:55 ` Jingoo Han 2015-08-20 8:03 ` Yakir Yang 2015-08-20 8:03 ` Yakir Yang 2015-08-20 8:03 ` Yakir Yang 2015-08-21 8:20 ` Jingoo Han 2015-08-21 8:20 ` Jingoo Han 2015-08-21 8:20 ` Jingoo Han 2015-08-21 10:01 ` Yakir Yang 2015-08-21 11:24 ` Jingoo Han 2015-08-21 13:16 ` Thierry Reding 2015-08-21 13:16 ` Thierry Reding 2015-08-21 13:16 ` Thierry Reding 2015-08-22 10:13 ` Yakir Yang 2015-08-30 12:16 ` Romain Perier 2015-08-30 12:16 ` Romain Perier 2015-08-30 12:16 ` Romain Perier 2015-08-31 2:40 ` Yakir Yang 2015-08-31 2:40 ` Yakir Yang 2015-08-31 2:40 ` Yakir Yang 2015-08-22 9:42 ` Yakir Yang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55DC7A5C.1010108@rock-chips.com \ --to=ykk@rock-chips.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=ajaynumb@gmail.com \ --cc=andy.yan@rock-chips.com \ --cc=devicetree@vger.kernel.org \ --cc=dianders@google.com \ --cc=djkurtz@google.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=fabio.estevam@freescale.com \ --cc=galak@codeaurora.org \ --cc=gustavo.padovan@collabora.co.uk \ --cc=heiko@sntech.de \ --cc=ijc+devicetree@hellion.org.uk \ --cc=inki.dae@samsung.com \ --cc=jingoohan1@gmail.com \ --cc=joe@perches.com \ --cc=kishon@ti.com \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mark.yao@rock-chips.com \ --cc=p.zabel@pengutronix.de \ --cc=pawel.moll@arm.com \ --cc=rmk+kernel@arm.linux.org.uk \ --cc=robh+dt@kernel.org \ --cc=robherring2@gmail.com \ --cc=seanpaul@google.com \ --cc=tiwai@suse.de \ --cc=treding@nvidia.com \ --cc=vpalatin@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.