Re: [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

From: Liran Alon <liran.alon@oracle.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	kvm@vger.kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
	Paolo Bonzini <pbonzini@redhat.com>,
	jmattson@google.com, rth@twiddle.net
Subject: Re: [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state
Date: Thu, 1 Nov 2018 01:17:28 +0200	[thread overview]
Message-ID: <5FA867F7-3520-4903-BC2F-B55227A04FED@oracle.com> (raw)
In-Reply-To: <20181031185930.GC2403@work-vm>

> On 31 Oct 2018, at 20:59, Dr. David Alan Gilbert <dgilbert@redhat.com> wrote:
> 
> * Liran Alon (liran.alon@oracle.com) wrote:
>> 
>> 
>>> On 31 Oct 2018, at 20:19, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>> 
>>> On 31/10/2018 19:17, Eduardo Habkost wrote:
>>>> On Wed, Oct 31, 2018 at 03:03:34AM +0200, Liran Alon wrote:
>>>>> Ping.
>>>>> Patch was submitted almost two months ago and I haven’t seen any respond for the v2 of this series.
>>>> Sorry for the long delay.  This was on my queue of patches to be
>>>> reviewed, but I'm failing to keep up to the rate of incoming
>>>> patches.  I will try to review the series next week.
>>> 
>>> I have already reviewed it; unfortunately I have missed the soft freeze
>>> for posting the version I had also been working on when Liran posted
>>> these patches.
>>> 
>>> Paolo
>> 
>> Paolo, note that this is v2 of this patch series. It’s not the one you have already reviewed.
>> It now correctly handles the case you mentioned in review of v1 of migrating with various nested_state buffer sizes.
>> The following scenarios were tested:
>> (a) src and dest have same nested state size.
>> 	==> Migration succeeds.
>> (b) src don't have nested state while dest do.
>> 	==> Migration succeed and src don't send it's nested state.
>> (c) src have nested state while dest don't.
>> 	==> Migration fails as it cannot restore nested state.
>> (d) dest have bigger max nested state size than src
>> 	==> Migration succeeds.
>> (e) dest have smaller max nested state size than src but enough to store it's saved nested state
>> 	==> Migration succeeds
>> (f) dest have smaller max nested state size than src but not enough to store it's saved nested state
>> 	==> Migration fails
> 
> Is it possible to tell these limits before the start of the migration,
> or do we only find out that a nested migration won't work by trying it?
> 
> Dave

It is possible for the destination host to query what is it’s max nested state size.
(This is what is returned from "kvm_check_extension(s, KVM_CAP_NESTED_STATE);” See kvm_init() code)

However, I didn’t find any suitable mechanism in QEMU Live-Migration code to negotiate
this destination host information with source prior to migration. Which kinda makes sense as
this code is also used to my understanding in standard suspend/resume flow. In that scenario,
there is no other side to negotiate with.

So currently what happens in my patch is that source prepares the nested state buffer and sends it to destination as part of VMState,
and destination attempts to load this nested state in it’s nested_state_post_load() function.
If destination kernel cannot handle loading the nested state it has received from source, it fails the migration by returning
failure from nested_state_post_load().

Do you have a better suggestion?

-Liran

> 
>> -Liran
>> 
>> 
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK