From: Paolo Bonzini <pbonzini@redhat.com> To: Liran Alon <liran.alon@oracle.com> Cc: Eduardo Habkost <ehabkost@redhat.com>, kvm list <kvm@vger.kernel.org>, mtosatti@redhat.com, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, qemu-devel@nongnu.org, Jim Mattson <jmattson@google.com>, rth@twiddle.net Subject: Re: [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state Date: Thu, 8 Nov 2018 21:34:31 +0100 [thread overview] Message-ID: <cb9e672a-9d5f-6a6c-2fa6-2c097c1892ab@redhat.com> (raw) In-Reply-To: <59EE7141-6771-47E2-8473-C1429676AD7B@oracle.com> On 08/11/2018 19:41, Liran Alon wrote: > So what I plan to do is indeed to define first 4K of data as vmcs12 and next 4K as shadow_vmcs12. > I will also define each of them in a separate VMState subsection that each will have it’s own .needed() > method that will decide if it’s relevant to send it based on kvm_state.size. > vmcs12 and shadow_vmcs12 will be put in a struct which is unioned with a struct > of 2 pages buffer to clearly indicate that one well-defined struct is used for VMX and the other for SVM. > (based on kvm_state.format) And SVM will use other subsections. > In addition, I will change KVM_{GET,SET}_NESTED_STATE documentation to indicate that > future nested state fields should be added at the end of struct and weather they are valid should > be determined by a flag in kvm_state.flags. > QEMU will handle these new states in the future by adding more VMState subsections that have > .needed() method based on appropriate flag in kvm_state.flags. > The struct itself that userspace use against it’s local kernel will be determined based on KVM_CAPs. > > If there are no objections, I will write the needed patches for QEMU (and the documentation patch for KVM). Sure. You can also place the flags and format in yet another subsection. Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com> To: Liran Alon <liran.alon@oracle.com> Cc: Jim Mattson <jmattson@google.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, kvm list <kvm@vger.kernel.org>, mtosatti@redhat.com, rth@twiddle.net, qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state Date: Thu, 8 Nov 2018 21:34:31 +0100 [thread overview] Message-ID: <cb9e672a-9d5f-6a6c-2fa6-2c097c1892ab@redhat.com> (raw) In-Reply-To: <59EE7141-6771-47E2-8473-C1429676AD7B@oracle.com> On 08/11/2018 19:41, Liran Alon wrote: > So what I plan to do is indeed to define first 4K of data as vmcs12 and next 4K as shadow_vmcs12. > I will also define each of them in a separate VMState subsection that each will have it’s own .needed() > method that will decide if it’s relevant to send it based on kvm_state.size. > vmcs12 and shadow_vmcs12 will be put in a struct which is unioned with a struct > of 2 pages buffer to clearly indicate that one well-defined struct is used for VMX and the other for SVM. > (based on kvm_state.format) And SVM will use other subsections. > In addition, I will change KVM_{GET,SET}_NESTED_STATE documentation to indicate that > future nested state fields should be added at the end of struct and weather they are valid should > be determined by a flag in kvm_state.flags. > QEMU will handle these new states in the future by adding more VMState subsections that have > .needed() method based on appropriate flag in kvm_state.flags. > The struct itself that userspace use against it’s local kernel will be determined based on KVM_CAPs. > > If there are no objections, I will write the needed patches for QEMU (and the documentation patch for KVM). Sure. You can also place the flags and format in yet another subsection. Paolo
next prev parent reply other threads:[~2018-11-08 20:34 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-16 12:46 [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state Liran Alon 2018-09-16 12:46 ` [Qemu-devel] " Liran Alon 2018-09-16 12:46 ` [QEMU PATCH v2 1/2] i386: Compile CPUX86State xsave_buf only when support KVM or HVF Liran Alon 2018-09-16 12:46 ` [Qemu-devel] " Liran Alon 2018-09-16 12:46 ` [QEMU PATCH v2 2/2] KVM: i386: Add support for save and restore nested state Liran Alon 2018-09-16 12:46 ` [Qemu-devel] " Liran Alon 2018-10-08 17:21 ` [QEMU PATCH v2 0/2]: " Liran Alon 2018-10-08 17:21 ` [Qemu-devel] " Liran Alon 2018-10-15 18:10 ` Liran Alon 2018-10-15 18:10 ` [Qemu-devel] " Liran Alon 2018-10-31 1:03 ` Liran Alon 2018-10-31 1:03 ` [Qemu-devel] " Liran Alon 2018-10-31 18:17 ` Eduardo Habkost 2018-10-31 18:17 ` [Qemu-devel] " Eduardo Habkost 2018-10-31 18:19 ` Paolo Bonzini 2018-10-31 18:19 ` [Qemu-devel] " Paolo Bonzini 2018-10-31 18:50 ` Liran Alon 2018-10-31 18:50 ` [Qemu-devel] " Liran Alon 2018-10-31 18:59 ` Dr. David Alan Gilbert 2018-10-31 18:59 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-10-31 23:17 ` Liran Alon 2018-10-31 23:17 ` [Qemu-devel] " Liran Alon 2018-11-01 13:10 ` Dr. David Alan Gilbert 2018-11-01 13:10 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-11-01 15:23 ` Liran Alon 2018-11-01 15:23 ` [Qemu-devel] " Liran Alon 2018-11-01 15:56 ` Dr. David Alan Gilbert 2018-11-01 15:56 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-11-01 16:45 ` Jim Mattson via Qemu-devel 2018-11-01 16:45 ` [Qemu-devel] " Jim Mattson 2018-11-02 3:46 ` Liran Alon 2018-11-02 3:46 ` [Qemu-devel] " Liran Alon 2018-11-02 9:40 ` Paolo Bonzini 2018-11-02 9:40 ` [Qemu-devel] " Paolo Bonzini 2018-11-02 12:35 ` Dr. David Alan Gilbert 2018-11-02 12:35 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-11-02 12:40 ` Daniel P. Berrangé 2018-11-02 12:40 ` [Qemu-devel] " Daniel P. Berrangé 2018-11-04 22:12 ` Paolo Bonzini 2018-11-04 22:12 ` [Qemu-devel] " Paolo Bonzini 2018-11-02 12:59 ` Liran Alon 2018-11-02 12:59 ` [Qemu-devel] " Liran Alon 2018-11-02 16:44 ` Jim Mattson via Qemu-devel 2018-11-02 16:44 ` [Qemu-devel] " Jim Mattson 2018-11-02 16:58 ` Daniel P. Berrangé 2018-11-02 16:58 ` [Qemu-devel] " Daniel P. Berrangé 2018-11-02 17:01 ` Jim Mattson via Qemu-devel 2018-11-02 17:01 ` [Qemu-devel] " Jim Mattson 2018-11-02 16:54 ` Daniel P. Berrangé 2018-11-02 16:54 ` [Qemu-devel] " Daniel P. Berrangé 2018-11-02 16:58 ` Dr. David Alan Gilbert 2018-11-02 16:58 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-11-04 22:19 ` Paolo Bonzini 2018-11-04 22:19 ` [Qemu-devel] " Paolo Bonzini 2018-11-12 16:18 ` Daniel P. Berrangé 2018-11-12 16:18 ` [Qemu-devel] " Daniel P. Berrangé 2018-11-12 16:50 ` Dr. David Alan Gilbert 2018-11-12 16:50 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-11-12 16:53 ` Paolo Bonzini 2018-11-12 16:53 ` [Qemu-devel] " Paolo Bonzini 2018-11-12 16:54 ` Daniel P. Berrangé 2018-11-12 16:54 ` [Qemu-devel] " Daniel P. Berrangé 2018-11-13 0:00 ` Liran Alon 2018-11-13 0:00 ` [Qemu-devel] " Liran Alon 2018-11-13 0:07 ` Jim Mattson via Qemu-devel 2018-11-13 0:07 ` [Qemu-devel] " Jim Mattson 2018-11-13 0:09 ` Liran Alon 2018-11-13 0:09 ` [Qemu-devel] " Liran Alon 2018-11-12 23:58 ` Liran Alon 2018-11-12 23:58 ` [Qemu-devel] " Liran Alon 2018-11-02 16:39 ` Jim Mattson via Qemu-devel 2018-11-02 16:39 ` [Qemu-devel] " Jim Mattson 2018-11-03 2:02 ` Liran Alon 2018-11-03 2:02 ` [Qemu-devel] " Liran Alon 2018-11-08 0:13 ` Liran Alon 2018-11-08 0:13 ` [Qemu-devel] " Liran Alon 2018-11-08 0:45 ` Jim Mattson via Qemu-devel 2018-11-08 0:45 ` [Qemu-devel] " Jim Mattson 2018-11-08 9:50 ` Paolo Bonzini 2018-11-08 9:50 ` [Qemu-devel] " Paolo Bonzini 2018-11-08 9:57 ` Liran Alon 2018-11-08 9:57 ` [Qemu-devel] " Liran Alon 2018-11-08 17:02 ` Paolo Bonzini 2018-11-08 17:02 ` [Qemu-devel] " Paolo Bonzini 2018-11-08 18:41 ` Liran Alon 2018-11-08 18:41 ` [Qemu-devel] " Liran Alon 2018-11-08 20:34 ` Paolo Bonzini [this message] 2018-11-08 20:34 ` Paolo Bonzini 2018-11-12 14:51 ` Dr. David Alan Gilbert 2018-11-12 14:51 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-11-01 19:03 ` Liran Alon 2018-11-01 19:03 ` [Qemu-devel] " Liran Alon 2018-11-01 19:07 ` Dr. David Alan Gilbert 2018-11-01 19:07 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-11-01 19:41 ` Jim Mattson via Qemu-devel 2018-11-01 19:41 ` [Qemu-devel] " Jim Mattson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cb9e672a-9d5f-6a6c-2fa6-2c097c1892ab@redhat.com \ --to=pbonzini@redhat.com \ --cc=dgilbert@redhat.com \ --cc=ehabkost@redhat.com \ --cc=jmattson@google.com \ --cc=kvm@vger.kernel.org \ --cc=liran.alon@oracle.com \ --cc=mtosatti@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.