From: Liran Alon <liran.alon@oracle.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
kvm@vger.kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
rth@twiddle.net, jmattson@google.com
Subject: Re: [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state
Date: Wed, 31 Oct 2018 20:50:04 +0200 [thread overview]
Message-ID: <B34C4E8C-748D-4D78-807F-3F51C80EA5B2@oracle.com> (raw)
In-Reply-To: <a5b6cdf7-6ff9-7bd8-d591-3e2669b4f802@redhat.com>
> On 31 Oct 2018, at 20:19, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 31/10/2018 19:17, Eduardo Habkost wrote:
>> On Wed, Oct 31, 2018 at 03:03:34AM +0200, Liran Alon wrote:
>>> Ping.
>>> Patch was submitted almost two months ago and I haven’t seen any respond for the v2 of this series.
>> Sorry for the long delay. This was on my queue of patches to be
>> reviewed, but I'm failing to keep up to the rate of incoming
>> patches. I will try to review the series next week.
>
> I have already reviewed it; unfortunately I have missed the soft freeze
> for posting the version I had also been working on when Liran posted
> these patches.
>
> Paolo
Paolo, note that this is v2 of this patch series. It’s not the one you have already reviewed.
It now correctly handles the case you mentioned in review of v1 of migrating with various nested_state buffer sizes.
The following scenarios were tested:
(a) src and dest have same nested state size.
==> Migration succeeds.
(b) src don't have nested state while dest do.
==> Migration succeed and src don't send it's nested state.
(c) src have nested state while dest don't.
==> Migration fails as it cannot restore nested state.
(d) dest have bigger max nested state size than src
==> Migration succeeds.
(e) dest have smaller max nested state size than src but enough to store it's saved nested state
==> Migration succeeds
(f) dest have smaller max nested state size than src but not enough to store it's saved nested state
==> Migration fails
-Liran
WARNING: multiple messages have this Message-ID (diff)
From: Liran Alon <liran.alon@oracle.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
qemu-devel@nongnu.org, mtosatti@redhat.com, rth@twiddle.net,
kvm@vger.kernel.org, jmattson@google.com
Subject: Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state
Date: Wed, 31 Oct 2018 20:50:04 +0200 [thread overview]
Message-ID: <B34C4E8C-748D-4D78-807F-3F51C80EA5B2@oracle.com> (raw)
In-Reply-To: <a5b6cdf7-6ff9-7bd8-d591-3e2669b4f802@redhat.com>
> On 31 Oct 2018, at 20:19, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 31/10/2018 19:17, Eduardo Habkost wrote:
>> On Wed, Oct 31, 2018 at 03:03:34AM +0200, Liran Alon wrote:
>>> Ping.
>>> Patch was submitted almost two months ago and I haven’t seen any respond for the v2 of this series.
>> Sorry for the long delay. This was on my queue of patches to be
>> reviewed, but I'm failing to keep up to the rate of incoming
>> patches. I will try to review the series next week.
>
> I have already reviewed it; unfortunately I have missed the soft freeze
> for posting the version I had also been working on when Liran posted
> these patches.
>
> Paolo
Paolo, note that this is v2 of this patch series. It’s not the one you have already reviewed.
It now correctly handles the case you mentioned in review of v1 of migrating with various nested_state buffer sizes.
The following scenarios were tested:
(a) src and dest have same nested state size.
==> Migration succeeds.
(b) src don't have nested state while dest do.
==> Migration succeed and src don't send it's nested state.
(c) src have nested state while dest don't.
==> Migration fails as it cannot restore nested state.
(d) dest have bigger max nested state size than src
==> Migration succeeds.
(e) dest have smaller max nested state size than src but enough to store it's saved nested state
==> Migration succeeds
(f) dest have smaller max nested state size than src but not enough to store it's saved nested state
==> Migration fails
-Liran
next prev parent reply other threads:[~2018-10-31 18:50 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-16 12:46 [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state Liran Alon
2018-09-16 12:46 ` [Qemu-devel] " Liran Alon
2018-09-16 12:46 ` [QEMU PATCH v2 1/2] i386: Compile CPUX86State xsave_buf only when support KVM or HVF Liran Alon
2018-09-16 12:46 ` [Qemu-devel] " Liran Alon
2018-09-16 12:46 ` [QEMU PATCH v2 2/2] KVM: i386: Add support for save and restore nested state Liran Alon
2018-09-16 12:46 ` [Qemu-devel] " Liran Alon
2018-10-08 17:21 ` [QEMU PATCH v2 0/2]: " Liran Alon
2018-10-08 17:21 ` [Qemu-devel] " Liran Alon
2018-10-15 18:10 ` Liran Alon
2018-10-15 18:10 ` [Qemu-devel] " Liran Alon
2018-10-31 1:03 ` Liran Alon
2018-10-31 1:03 ` [Qemu-devel] " Liran Alon
2018-10-31 18:17 ` Eduardo Habkost
2018-10-31 18:17 ` [Qemu-devel] " Eduardo Habkost
2018-10-31 18:19 ` Paolo Bonzini
2018-10-31 18:19 ` [Qemu-devel] " Paolo Bonzini
2018-10-31 18:50 ` Liran Alon [this message]
2018-10-31 18:50 ` Liran Alon
2018-10-31 18:59 ` Dr. David Alan Gilbert
2018-10-31 18:59 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-10-31 23:17 ` Liran Alon
2018-10-31 23:17 ` [Qemu-devel] " Liran Alon
2018-11-01 13:10 ` Dr. David Alan Gilbert
2018-11-01 13:10 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-11-01 15:23 ` Liran Alon
2018-11-01 15:23 ` [Qemu-devel] " Liran Alon
2018-11-01 15:56 ` Dr. David Alan Gilbert
2018-11-01 15:56 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-11-01 16:45 ` Jim Mattson via Qemu-devel
2018-11-01 16:45 ` [Qemu-devel] " Jim Mattson
2018-11-02 3:46 ` Liran Alon
2018-11-02 3:46 ` [Qemu-devel] " Liran Alon
2018-11-02 9:40 ` Paolo Bonzini
2018-11-02 9:40 ` [Qemu-devel] " Paolo Bonzini
2018-11-02 12:35 ` Dr. David Alan Gilbert
2018-11-02 12:35 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-11-02 12:40 ` Daniel P. Berrangé
2018-11-02 12:40 ` [Qemu-devel] " Daniel P. Berrangé
2018-11-04 22:12 ` Paolo Bonzini
2018-11-04 22:12 ` [Qemu-devel] " Paolo Bonzini
2018-11-02 12:59 ` Liran Alon
2018-11-02 12:59 ` [Qemu-devel] " Liran Alon
2018-11-02 16:44 ` Jim Mattson via Qemu-devel
2018-11-02 16:44 ` [Qemu-devel] " Jim Mattson
2018-11-02 16:58 ` Daniel P. Berrangé
2018-11-02 16:58 ` [Qemu-devel] " Daniel P. Berrangé
2018-11-02 17:01 ` Jim Mattson via Qemu-devel
2018-11-02 17:01 ` [Qemu-devel] " Jim Mattson
2018-11-02 16:54 ` Daniel P. Berrangé
2018-11-02 16:54 ` [Qemu-devel] " Daniel P. Berrangé
2018-11-02 16:58 ` Dr. David Alan Gilbert
2018-11-02 16:58 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-11-04 22:19 ` Paolo Bonzini
2018-11-04 22:19 ` [Qemu-devel] " Paolo Bonzini
2018-11-12 16:18 ` Daniel P. Berrangé
2018-11-12 16:18 ` [Qemu-devel] " Daniel P. Berrangé
2018-11-12 16:50 ` Dr. David Alan Gilbert
2018-11-12 16:50 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-11-12 16:53 ` Paolo Bonzini
2018-11-12 16:53 ` [Qemu-devel] " Paolo Bonzini
2018-11-12 16:54 ` Daniel P. Berrangé
2018-11-12 16:54 ` [Qemu-devel] " Daniel P. Berrangé
2018-11-13 0:00 ` Liran Alon
2018-11-13 0:00 ` [Qemu-devel] " Liran Alon
2018-11-13 0:07 ` Jim Mattson via Qemu-devel
2018-11-13 0:07 ` [Qemu-devel] " Jim Mattson
2018-11-13 0:09 ` Liran Alon
2018-11-13 0:09 ` [Qemu-devel] " Liran Alon
2018-11-12 23:58 ` Liran Alon
2018-11-12 23:58 ` [Qemu-devel] " Liran Alon
2018-11-02 16:39 ` Jim Mattson via Qemu-devel
2018-11-02 16:39 ` [Qemu-devel] " Jim Mattson
2018-11-03 2:02 ` Liran Alon
2018-11-03 2:02 ` [Qemu-devel] " Liran Alon
2018-11-08 0:13 ` Liran Alon
2018-11-08 0:13 ` [Qemu-devel] " Liran Alon
2018-11-08 0:45 ` Jim Mattson via Qemu-devel
2018-11-08 0:45 ` [Qemu-devel] " Jim Mattson
2018-11-08 9:50 ` Paolo Bonzini
2018-11-08 9:50 ` [Qemu-devel] " Paolo Bonzini
2018-11-08 9:57 ` Liran Alon
2018-11-08 9:57 ` [Qemu-devel] " Liran Alon
2018-11-08 17:02 ` Paolo Bonzini
2018-11-08 17:02 ` [Qemu-devel] " Paolo Bonzini
2018-11-08 18:41 ` Liran Alon
2018-11-08 18:41 ` [Qemu-devel] " Liran Alon
2018-11-08 20:34 ` Paolo Bonzini
2018-11-08 20:34 ` [Qemu-devel] " Paolo Bonzini
2018-11-12 14:51 ` Dr. David Alan Gilbert
2018-11-12 14:51 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-11-01 19:03 ` Liran Alon
2018-11-01 19:03 ` [Qemu-devel] " Liran Alon
2018-11-01 19:07 ` Dr. David Alan Gilbert
2018-11-01 19:07 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-11-01 19:41 ` Jim Mattson via Qemu-devel
2018-11-01 19:41 ` [Qemu-devel] " Jim Mattson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B34C4E8C-748D-4D78-807F-3F51C80EA5B2@oracle.com \
--to=liran.alon@oracle.com \
--cc=ehabkost@redhat.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.