From: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org> To: Vivek Gautam <vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm <linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>, open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, robh+dt <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Subject: Re: [PATCH v9 4/5] iommu/arm-smmu: Add the device_link between masters and smmu Date: Thu, 15 Mar 2018 11:12:06 +0000 [thread overview] Message-ID: <63943de8-198d-32ff-36fe-c3f6c4c10f1d@arm.com> (raw) In-Reply-To: <CAFp+6iEFDXKdS_mTgrrpCX2isMAT3XJifRV0FYxV+PFpVGV=2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> On 15/03/18 08:57, Vivek Gautam wrote: > Hi Robin, > > > On Wed, Mar 14, 2018 at 11:20 PM, Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org> wrote: >> On 13/03/18 08:55, Vivek Gautam wrote: >>> >>> From: Sricharan R <sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> >>> >>> Finally add the device link between the master device and >>> smmu, so that the smmu gets runtime enabled/disabled only when the >>> master needs it. This is done from add_device callback which gets >>> called once when the master is added to the smmu. >>> >>> Signed-off-by: Sricharan R <sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> >>> Signed-off-by: Vivek Gautam <vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> >>> Reviewed-by: Tomasz Figa <tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> >>> --- >>> drivers/iommu/arm-smmu.c | 29 +++++++++++++++++++++++++++++ >>> 1 file changed, 29 insertions(+) >>> >>> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c >>> index 56a04ae80bf3..64953ff2281f 100644 >>> --- a/drivers/iommu/arm-smmu.c >>> +++ b/drivers/iommu/arm-smmu.c >>> @@ -1460,10 +1460,31 @@ static int arm_smmu_add_device(struct device *dev) >>> iommu_device_link(&smmu->iommu, dev); >>> + if (pm_runtime_enabled(smmu->dev)) { >>> + struct device_link *link; >>> + >>> + /* >>> + * Establish the link between smmu and master, so that the >>> + * smmu gets runtime enabled/disabled as per the master's >>> + * needs. >>> + */ >>> + link = device_link_add(dev, smmu->dev, >>> DL_FLAG_PM_RUNTIME); >>> + if (!link) { >> >> >> FWIW, given that we don't really care about link itself, I'd be quite happy >> to simplify that lot down to: >> >> if (pm_runtime_enabled(smmu_dev) && >> !device_link_add(dev, smmu->dev, DL_FLAG_PM_RUNTIME)) { > > Sure, will update this. > >> >>> + dev_warn(smmu->dev, >>> + "Unable to add link to the consumer >>> %s\n", >>> + dev_name(dev)); >> >> >> (side note: since device_link_add() already prints a message on success, >> maybe it could print its own failure message too?) > > Should we make device_link that verbose - to print failure messages at > each step (there are atleast a couple where we return link as NULL), > or we can let the users handle printing the message? I didn't mean to imply anything more than the idea below (although the whole function could of course be refactored further to report explicit error values). It just seems a bit unbalanced for the core code to be noisy about success yet silent about failure, but ultimately that's an entirely separate issue which doesn't have to have any bearing on this series. Robin. ----->8----- diff --git a/drivers/base/core.c b/drivers/base/core.c index b2261f92f2f1..895da95f5cb9 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -275,6 +275,9 @@ struct device_link *device_link_add(struct device *consumer, out: device_pm_unlock(); device_links_write_unlock(); + if (!link) + dev_warn(consumer, "Failed to link to supplier %s\n", dev_name(supplier)); + return link; } EXPORT_SYMBOL_GPL(device_link_add);
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com> To: Vivek Gautam <vivek.gautam@codeaurora.org> Cc: "list@263.net:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>, Joerg Roedel <joro@8bytes.org>, joro@8bytes.org, robh+dt <robh+dt@kernel.org>, "list@263.net:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>, Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org, devicetree@vger.kernel.org, open list <linux-kernel@vger.kernel.org>, Mark Rutland <mark.rutland@arm.com>, Will Deacon <will.deacon@arm.com>, Rob Clark <robdclark@gmail.com>, Tomasz Figa <tfiga@chromium.org>, Sricharan R <sricharan@codeaurora.org>, Marek Szyprowski <m.szyprowski@samsung.com>, Archit Taneja <architt@codeaurora.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org> Subject: Re: [PATCH v9 4/5] iommu/arm-smmu: Add the device_link between masters and smmu Date: Thu, 15 Mar 2018 11:12:06 +0000 [thread overview] Message-ID: <63943de8-198d-32ff-36fe-c3f6c4c10f1d@arm.com> (raw) In-Reply-To: <CAFp+6iEFDXKdS_mTgrrpCX2isMAT3XJifRV0FYxV+PFpVGV=2w@mail.gmail.com> On 15/03/18 08:57, Vivek Gautam wrote: > Hi Robin, > > > On Wed, Mar 14, 2018 at 11:20 PM, Robin Murphy <robin.murphy@arm.com> wrote: >> On 13/03/18 08:55, Vivek Gautam wrote: >>> >>> From: Sricharan R <sricharan@codeaurora.org> >>> >>> Finally add the device link between the master device and >>> smmu, so that the smmu gets runtime enabled/disabled only when the >>> master needs it. This is done from add_device callback which gets >>> called once when the master is added to the smmu. >>> >>> Signed-off-by: Sricharan R <sricharan@codeaurora.org> >>> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> >>> Reviewed-by: Tomasz Figa <tfiga@chromium.org> >>> --- >>> drivers/iommu/arm-smmu.c | 29 +++++++++++++++++++++++++++++ >>> 1 file changed, 29 insertions(+) >>> >>> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c >>> index 56a04ae80bf3..64953ff2281f 100644 >>> --- a/drivers/iommu/arm-smmu.c >>> +++ b/drivers/iommu/arm-smmu.c >>> @@ -1460,10 +1460,31 @@ static int arm_smmu_add_device(struct device *dev) >>> iommu_device_link(&smmu->iommu, dev); >>> + if (pm_runtime_enabled(smmu->dev)) { >>> + struct device_link *link; >>> + >>> + /* >>> + * Establish the link between smmu and master, so that the >>> + * smmu gets runtime enabled/disabled as per the master's >>> + * needs. >>> + */ >>> + link = device_link_add(dev, smmu->dev, >>> DL_FLAG_PM_RUNTIME); >>> + if (!link) { >> >> >> FWIW, given that we don't really care about link itself, I'd be quite happy >> to simplify that lot down to: >> >> if (pm_runtime_enabled(smmu_dev) && >> !device_link_add(dev, smmu->dev, DL_FLAG_PM_RUNTIME)) { > > Sure, will update this. > >> >>> + dev_warn(smmu->dev, >>> + "Unable to add link to the consumer >>> %s\n", >>> + dev_name(dev)); >> >> >> (side note: since device_link_add() already prints a message on success, >> maybe it could print its own failure message too?) > > Should we make device_link that verbose - to print failure messages at > each step (there are atleast a couple where we return link as NULL), > or we can let the users handle printing the message? I didn't mean to imply anything more than the idea below (although the whole function could of course be refactored further to report explicit error values). It just seems a bit unbalanced for the core code to be noisy about success yet silent about failure, but ultimately that's an entirely separate issue which doesn't have to have any bearing on this series. Robin. ----->8----- diff --git a/drivers/base/core.c b/drivers/base/core.c index b2261f92f2f1..895da95f5cb9 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -275,6 +275,9 @@ struct device_link *device_link_add(struct device *consumer, out: device_pm_unlock(); device_links_write_unlock(); + if (!link) + dev_warn(consumer, "Failed to link to supplier %s\n", dev_name(supplier)); + return link; } EXPORT_SYMBOL_GPL(device_link_add);
next prev parent reply other threads:[~2018-03-15 11:12 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-13 8:55 [PATCH v9 0/5] iommu/arm-smmu: Add runtime pm/sleep support Vivek Gautam 2018-03-13 8:55 ` Vivek Gautam [not found] ` <20180313085534.11650-1-vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2018-03-13 8:55 ` [PATCH v9 1/5] driver core: Find an existing link between two devices Vivek Gautam 2018-03-13 8:55 ` Vivek Gautam 2018-03-13 9:40 ` Rafael J. Wysocki [not found] ` <8903307.QazHKW0JrR-yvgW3jdyMHm1GS7QM15AGw@public.gmane.org> 2018-03-13 9:55 ` Vivek Gautam 2018-03-13 9:55 ` Vivek Gautam [not found] ` <CAFp+6iE=0PD6fZZVd+bC1Z95Lkt=X-F4YOXz8EtdiXL=jsC1RA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-03-13 12:49 ` Robin Murphy 2018-03-13 12:49 ` Robin Murphy [not found] ` <4eaf2006-ea68-d9e9-a0db-89acec0ea299-5wv7dgnIgG8@public.gmane.org> 2018-03-13 14:39 ` Vivek Gautam 2018-03-13 14:39 ` Vivek Gautam [not found] ` <20180313085534.11650-2-vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2018-03-13 9:58 ` Vivek Gautam 2018-03-13 9:58 ` Vivek Gautam 2018-03-13 10:15 ` Tomasz Figa [not found] ` <CAAFQd5DXvnjaFw4Ct1Xn90nQZ4F4dLtov0ymG-tycQt5oLNpiQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-03-13 10:34 ` Vivek Gautam 2018-03-13 10:34 ` Vivek Gautam 2018-03-13 11:23 ` Tomasz Figa [not found] ` <CAAFQd5A5Rj1KAZjUc5ZUKuKnbkA5Q6aLw9z0H3_kfyBQOOF-gw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-03-14 11:12 ` Rafael J. Wysocki 2018-03-14 11:12 ` Rafael J. Wysocki [not found] ` <2217404.A2W3Iek6du-yvgW3jdyMHm1GS7QM15AGw@public.gmane.org> 2018-03-14 11:50 ` Tomasz Figa 2018-03-14 11:50 ` Tomasz Figa [not found] ` <CAAFQd5CQXY0Efv+2MC1kTVW5q4eZjJ=gwVaR-LA=3agnSSHzUw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-03-14 11:57 ` Rafael J. Wysocki 2018-03-14 11:57 ` Rafael J. Wysocki [not found] ` <2705105.V6KYPvoJqj-yvgW3jdyMHm1GS7QM15AGw@public.gmane.org> 2018-03-14 12:14 ` Robin Murphy 2018-03-14 12:14 ` Robin Murphy 2018-03-14 12:27 ` Lukas Wunner [not found] ` <20180314122759.GB19651-JFq808J9C/izQB+pC5nmwQ@public.gmane.org> 2018-03-20 7:56 ` Vivek Gautam 2018-03-20 7:56 ` Vivek Gautam 2018-03-14 12:23 ` Lukas Wunner 2018-03-13 8:55 ` [PATCH v9 2/5] iommu/arm-smmu: Add pm_runtime/sleep ops Vivek Gautam 2018-03-13 8:55 ` Vivek Gautam 2018-03-13 8:55 ` [PATCH v9 3/5] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device Vivek Gautam 2018-03-13 8:55 ` Vivek Gautam [not found] ` <20180313085534.11650-4-vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2018-03-14 17:46 ` Robin Murphy 2018-03-14 17:46 ` Robin Murphy [not found] ` <77ed3675-0af0-b36a-5f76-b920d7a4c8e0-5wv7dgnIgG8@public.gmane.org> 2018-03-15 7:17 ` Tomasz Figa 2018-03-15 7:17 ` Tomasz Figa 2018-03-20 9:49 ` Vivek Gautam 2018-03-20 9:49 ` Vivek Gautam 2018-03-13 8:55 ` [PATCH v9 4/5] iommu/arm-smmu: Add the device_link between masters and smmu Vivek Gautam 2018-03-13 8:55 ` Vivek Gautam [not found] ` <20180313085534.11650-5-vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2018-03-14 17:50 ` Robin Murphy 2018-03-14 17:50 ` Robin Murphy [not found] ` <8b427ea2-5c13-4712-13d1-e4c1aed0779e-5wv7dgnIgG8@public.gmane.org> 2018-03-15 6:18 ` Tomasz Figa 2018-03-15 6:18 ` Tomasz Figa [not found] ` <CAAFQd5AqERQMLsJNLAsVXox79kZ+ZtpCUuMSutn70FGK-3Q7vw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-03-15 10:44 ` Robin Murphy 2018-03-15 10:44 ` Robin Murphy 2018-03-15 8:57 ` Vivek Gautam 2018-03-15 8:57 ` Vivek Gautam [not found] ` <CAFp+6iEFDXKdS_mTgrrpCX2isMAT3XJifRV0FYxV+PFpVGV=2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-03-15 11:12 ` Robin Murphy [this message] 2018-03-15 11:12 ` Robin Murphy 2018-03-13 8:55 ` [PATCH v9 5/5] iommu/arm-smmu: Add support for qcom,smmu-v2 variant Vivek Gautam 2018-03-13 8:55 ` Vivek Gautam [not found] ` <61d30fff-1bf8-d2c1-bbe9-f93de836ae77@huawei.com> [not found] ` <7d5af071-ef98-8461-3ce9-e84fc0b3956a@codeaurora.org> [not found] ` <7d5af071-ef98-8461-3ce9-e84fc0b3956a-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2018-03-28 6:11 ` Yisheng Xie 2018-03-28 6:11 ` Yisheng Xie [not found] ` <d97872fe-5e8e-cc27-e385-64cea8ea2458-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> 2018-04-10 13:14 ` [PATCH v9 5/5] iommu/arm-smmu: Add support for qcom, smmu-v2 variant Tomasz Figa 2018-04-10 13:14 ` [PATCH v9 5/5] iommu/arm-smmu: Add support for qcom,smmu-v2 variant Tomasz Figa [not found] ` <CAAFQd5Cj3qaqt8ACabZwN4ZKaNbF9N9suGVaOKD8-kNxgfeeVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-04-11 1:22 ` Yisheng Xie 2018-04-11 1:22 ` Yisheng Xie [not found] ` <65a57964-805b-3a38-71a2-0c383af30539-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> 2018-04-11 5:15 ` Vivek Gautam 2018-04-11 5:15 ` Vivek Gautam [not found] ` <ff1c730f-0009-58e5-cf4a-45fe9ab93d1e-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2018-04-12 1:55 ` Yisheng Xie 2018-04-12 1:55 ` Yisheng Xie
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=63943de8-198d-32ff-36fe-c3f6c4c10f1d@arm.com \ --to=robin.murphy-5wv7dgnigg8@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \ --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.