From: Yisheng Xie <xieyisheng1-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Vivek Gautam <vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Gaojianbo <gaojianbo-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
Subject: Re: [PATCH v9 5/5] iommu/arm-smmu: Add support for qcom,smmu-v2 variant
Date: Wed, 28 Mar 2018 14:11:07 +0800 [thread overview]
Message-ID: <d97872fe-5e8e-cc27-e385-64cea8ea2458@huawei.com> (raw)
In-Reply-To: <7d5af071-ef98-8461-3ce9-e84fc0b3956a-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Hi Vivek,
On 2018/3/28 12:37, Vivek Gautam wrote:
> Hi Yisheng
>
>
> On 3/28/2018 6:54 AM, Yisheng Xie wrote:
>> Hi Vivek,
>>
>> On 2018/3/13 16:55, Vivek Gautam wrote:
>>> +- power-domains: Specifiers for power domains required to be powered on for
>>> + the SMMU to operate, as per generic power domain bindings.
>>> +
>> In this patchset, power-domains is not used right? And you just do the clock gating,
>> but not power gating, right?
>
> We are handling the power-domains too. Please see the example in this binding doc.
I see, but I do not find the point in code of these patchset, do you mean PMIC(e.g mmcc)
will gate the power domain of SMMU(e.g. MDSS_GDSC of mmcc) when PMIC suspend?
>
>>
>> Another question is if smmu do power gating, it will reset some of its registers, so
>> it need save at suspend and restore at resume, right?
>
> Qualcomm implementation of the arm-smmu has the retenetion enabled. So the smmu doesn't
> loose state when power is pulled out of it.
> And now we are just selectively enabling the runtime pm. So only the platforms that can really
> support runtime pm can enable it.
Get it, thanks for your explain.
Thanks
Yisheng
>
> Thanks
> Vivek
>>
>> Thanks
>> Yisheng
>>
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Yisheng Xie <xieyisheng1@huawei.com>
To: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: <joro@8bytes.org>, <robin.murphy@arm.com>,
<iommu@lists.linux-foundation.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <mark.rutland@arm.com>,
<linux-arm-msm@vger.kernel.org>,
Will Deacon <will.deacon@arm.com>,
Gaojianbo <gaojianbo@hisilicon.com>
Subject: Re: [PATCH v9 5/5] iommu/arm-smmu: Add support for qcom,smmu-v2 variant
Date: Wed, 28 Mar 2018 14:11:07 +0800 [thread overview]
Message-ID: <d97872fe-5e8e-cc27-e385-64cea8ea2458@huawei.com> (raw)
In-Reply-To: <7d5af071-ef98-8461-3ce9-e84fc0b3956a@codeaurora.org>
Hi Vivek,
On 2018/3/28 12:37, Vivek Gautam wrote:
> Hi Yisheng
>
>
> On 3/28/2018 6:54 AM, Yisheng Xie wrote:
>> Hi Vivek,
>>
>> On 2018/3/13 16:55, Vivek Gautam wrote:
>>> +- power-domains: Specifiers for power domains required to be powered on for
>>> + the SMMU to operate, as per generic power domain bindings.
>>> +
>> In this patchset, power-domains is not used right? And you just do the clock gating,
>> but not power gating, right?
>
> We are handling the power-domains too. Please see the example in this binding doc.
I see, but I do not find the point in code of these patchset, do you mean PMIC(e.g mmcc)
will gate the power domain of SMMU(e.g. MDSS_GDSC of mmcc) when PMIC suspend?
>
>>
>> Another question is if smmu do power gating, it will reset some of its registers, so
>> it need save at suspend and restore at resume, right?
>
> Qualcomm implementation of the arm-smmu has the retenetion enabled. So the smmu doesn't
> loose state when power is pulled out of it.
> And now we are just selectively enabling the runtime pm. So only the platforms that can really
> support runtime pm can enable it.
Get it, thanks for your explain.
Thanks
Yisheng
>
> Thanks
> Vivek
>>
>> Thanks
>> Yisheng
>>
>
>
>
next prev parent reply other threads:[~2018-03-28 6:11 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 8:55 [PATCH v9 0/5] iommu/arm-smmu: Add runtime pm/sleep support Vivek Gautam
2018-03-13 8:55 ` Vivek Gautam
[not found] ` <20180313085534.11650-1-vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-13 8:55 ` [PATCH v9 1/5] driver core: Find an existing link between two devices Vivek Gautam
2018-03-13 8:55 ` Vivek Gautam
2018-03-13 9:40 ` Rafael J. Wysocki
[not found] ` <8903307.QazHKW0JrR-yvgW3jdyMHm1GS7QM15AGw@public.gmane.org>
2018-03-13 9:55 ` Vivek Gautam
2018-03-13 9:55 ` Vivek Gautam
[not found] ` <CAFp+6iE=0PD6fZZVd+bC1Z95Lkt=X-F4YOXz8EtdiXL=jsC1RA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-03-13 12:49 ` Robin Murphy
2018-03-13 12:49 ` Robin Murphy
[not found] ` <4eaf2006-ea68-d9e9-a0db-89acec0ea299-5wv7dgnIgG8@public.gmane.org>
2018-03-13 14:39 ` Vivek Gautam
2018-03-13 14:39 ` Vivek Gautam
[not found] ` <20180313085534.11650-2-vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-13 9:58 ` Vivek Gautam
2018-03-13 9:58 ` Vivek Gautam
2018-03-13 10:15 ` Tomasz Figa
[not found] ` <CAAFQd5DXvnjaFw4Ct1Xn90nQZ4F4dLtov0ymG-tycQt5oLNpiQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-03-13 10:34 ` Vivek Gautam
2018-03-13 10:34 ` Vivek Gautam
2018-03-13 11:23 ` Tomasz Figa
[not found] ` <CAAFQd5A5Rj1KAZjUc5ZUKuKnbkA5Q6aLw9z0H3_kfyBQOOF-gw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-03-14 11:12 ` Rafael J. Wysocki
2018-03-14 11:12 ` Rafael J. Wysocki
[not found] ` <2217404.A2W3Iek6du-yvgW3jdyMHm1GS7QM15AGw@public.gmane.org>
2018-03-14 11:50 ` Tomasz Figa
2018-03-14 11:50 ` Tomasz Figa
[not found] ` <CAAFQd5CQXY0Efv+2MC1kTVW5q4eZjJ=gwVaR-LA=3agnSSHzUw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-03-14 11:57 ` Rafael J. Wysocki
2018-03-14 11:57 ` Rafael J. Wysocki
[not found] ` <2705105.V6KYPvoJqj-yvgW3jdyMHm1GS7QM15AGw@public.gmane.org>
2018-03-14 12:14 ` Robin Murphy
2018-03-14 12:14 ` Robin Murphy
2018-03-14 12:27 ` Lukas Wunner
[not found] ` <20180314122759.GB19651-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2018-03-20 7:56 ` Vivek Gautam
2018-03-20 7:56 ` Vivek Gautam
2018-03-14 12:23 ` Lukas Wunner
2018-03-13 8:55 ` [PATCH v9 2/5] iommu/arm-smmu: Add pm_runtime/sleep ops Vivek Gautam
2018-03-13 8:55 ` Vivek Gautam
2018-03-13 8:55 ` [PATCH v9 3/5] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device Vivek Gautam
2018-03-13 8:55 ` Vivek Gautam
[not found] ` <20180313085534.11650-4-vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-14 17:46 ` Robin Murphy
2018-03-14 17:46 ` Robin Murphy
[not found] ` <77ed3675-0af0-b36a-5f76-b920d7a4c8e0-5wv7dgnIgG8@public.gmane.org>
2018-03-15 7:17 ` Tomasz Figa
2018-03-15 7:17 ` Tomasz Figa
2018-03-20 9:49 ` Vivek Gautam
2018-03-20 9:49 ` Vivek Gautam
2018-03-13 8:55 ` [PATCH v9 4/5] iommu/arm-smmu: Add the device_link between masters and smmu Vivek Gautam
2018-03-13 8:55 ` Vivek Gautam
[not found] ` <20180313085534.11650-5-vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-14 17:50 ` Robin Murphy
2018-03-14 17:50 ` Robin Murphy
[not found] ` <8b427ea2-5c13-4712-13d1-e4c1aed0779e-5wv7dgnIgG8@public.gmane.org>
2018-03-15 6:18 ` Tomasz Figa
2018-03-15 6:18 ` Tomasz Figa
[not found] ` <CAAFQd5AqERQMLsJNLAsVXox79kZ+ZtpCUuMSutn70FGK-3Q7vw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-03-15 10:44 ` Robin Murphy
2018-03-15 10:44 ` Robin Murphy
2018-03-15 8:57 ` Vivek Gautam
2018-03-15 8:57 ` Vivek Gautam
[not found] ` <CAFp+6iEFDXKdS_mTgrrpCX2isMAT3XJifRV0FYxV+PFpVGV=2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-03-15 11:12 ` Robin Murphy
2018-03-15 11:12 ` Robin Murphy
2018-03-13 8:55 ` [PATCH v9 5/5] iommu/arm-smmu: Add support for qcom,smmu-v2 variant Vivek Gautam
2018-03-13 8:55 ` Vivek Gautam
[not found] ` <61d30fff-1bf8-d2c1-bbe9-f93de836ae77@huawei.com>
[not found] ` <7d5af071-ef98-8461-3ce9-e84fc0b3956a@codeaurora.org>
[not found] ` <7d5af071-ef98-8461-3ce9-e84fc0b3956a-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-28 6:11 ` Yisheng Xie [this message]
2018-03-28 6:11 ` Yisheng Xie
[not found] ` <d97872fe-5e8e-cc27-e385-64cea8ea2458-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2018-04-10 13:14 ` [PATCH v9 5/5] iommu/arm-smmu: Add support for qcom, smmu-v2 variant Tomasz Figa
2018-04-10 13:14 ` [PATCH v9 5/5] iommu/arm-smmu: Add support for qcom,smmu-v2 variant Tomasz Figa
[not found] ` <CAAFQd5Cj3qaqt8ACabZwN4ZKaNbF9N9suGVaOKD8-kNxgfeeVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-04-11 1:22 ` Yisheng Xie
2018-04-11 1:22 ` Yisheng Xie
[not found] ` <65a57964-805b-3a38-71a2-0c383af30539-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2018-04-11 5:15 ` Vivek Gautam
2018-04-11 5:15 ` Vivek Gautam
[not found] ` <ff1c730f-0009-58e5-cf4a-45fe9ab93d1e-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-04-12 1:55 ` Yisheng Xie
2018-04-12 1:55 ` Yisheng Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d97872fe-5e8e-cc27-e385-64cea8ea2458@huawei.com \
--to=xieyisheng1-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gaojianbo-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.