From: Heiner Kallweit <hkallweit1@gmail.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH v3] dt-bindings: pinctrl: Convert Amlogic Meson pinctrl binding
Date: Sun, 5 Feb 2023 01:05:18 +0100 [thread overview]
Message-ID: <6dcf6333-f75a-f7ec-8ce9-fbbfb81d1a60@gmail.com> (raw)
In-Reply-To: <CAFBinCDHtX2W=Sh4ffUbugn+XVH2UcXWKH2Q63W9G074x6o7zw@mail.gmail.com>
On 04.02.2023 23:56, Martin Blumenstingl wrote:
> Hi Heiner,
>
> On Wed, Feb 1, 2023 at 11:13 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
> [...]
>>>> + - items:
>>>> + - const: amlogic,meson8m2-aobus-pinctrl
>>>> + - const: amlogic,meson8-aobus-pinctrl
>>>> + - items:
>>>> + - const: amlogic,meson8m2-cbus-pinctrl
>>>> + - const: amlogic,meson8-cbus-pinctrl
>>>
>>> Again, can't have both with and without the fallback allowed.
>>>
>> Hi Martin,
>>
>> meson8m2 is the only chip version having a fallback for the
>> pinctrl compatible. Is this fallback really needed?
>> Looking at the driver it seems that both compatibles
>> are handled identically.
> Back in the day we decided to duplicate the Meson8 driver code just to
> add four new pin functions that are added by the Meson8m2 SoC
> generation:
> "eth_rxd2", "eth_rxd3", "eth_txd2", "eth_txd3"
>
> The compatible string was defined with a similar approach: since
> Meson8m2 just adds a few bits to the Meson8 pin controller it's
> backwards compatible.
>
> If the fallback has to be removed then I'm okay with that but I would
> like to understand it first.
> So far I thought that Rob basically asked to remove the following two
> compatible strings from the enum (as they're listed separately with
> their fallbacks):
> - amlogic,meson8m2-cbus-pinctrl
> - amlogic,meson8m2-aobus-pinctrl
>
Right, this should be sufficient. There's no place where the 8m2 pinctrl
compatibles are used w/o fallback.
Then the hopefully final version of the binding is almost ready.
I'm just still checking whether there's any way in yaml to specify
a reg-names list with mandatory and optional names. Doesn't seem so.
>
> Best regards,
> Martin
Heiner
WARNING: multiple messages have this Message-ID (diff)
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH v3] dt-bindings: pinctrl: Convert Amlogic Meson pinctrl binding
Date: Sun, 5 Feb 2023 01:05:18 +0100 [thread overview]
Message-ID: <6dcf6333-f75a-f7ec-8ce9-fbbfb81d1a60@gmail.com> (raw)
In-Reply-To: <CAFBinCDHtX2W=Sh4ffUbugn+XVH2UcXWKH2Q63W9G074x6o7zw@mail.gmail.com>
On 04.02.2023 23:56, Martin Blumenstingl wrote:
> Hi Heiner,
>
> On Wed, Feb 1, 2023 at 11:13 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
> [...]
>>>> + - items:
>>>> + - const: amlogic,meson8m2-aobus-pinctrl
>>>> + - const: amlogic,meson8-aobus-pinctrl
>>>> + - items:
>>>> + - const: amlogic,meson8m2-cbus-pinctrl
>>>> + - const: amlogic,meson8-cbus-pinctrl
>>>
>>> Again, can't have both with and without the fallback allowed.
>>>
>> Hi Martin,
>>
>> meson8m2 is the only chip version having a fallback for the
>> pinctrl compatible. Is this fallback really needed?
>> Looking at the driver it seems that both compatibles
>> are handled identically.
> Back in the day we decided to duplicate the Meson8 driver code just to
> add four new pin functions that are added by the Meson8m2 SoC
> generation:
> "eth_rxd2", "eth_rxd3", "eth_txd2", "eth_txd3"
>
> The compatible string was defined with a similar approach: since
> Meson8m2 just adds a few bits to the Meson8 pin controller it's
> backwards compatible.
>
> If the fallback has to be removed then I'm okay with that but I would
> like to understand it first.
> So far I thought that Rob basically asked to remove the following two
> compatible strings from the enum (as they're listed separately with
> their fallbacks):
> - amlogic,meson8m2-cbus-pinctrl
> - amlogic,meson8m2-aobus-pinctrl
>
Right, this should be sufficient. There's no place where the 8m2 pinctrl
compatibles are used w/o fallback.
Then the hopefully final version of the binding is almost ready.
I'm just still checking whether there's any way in yaml to specify
a reg-names list with mandatory and optional names. Doesn't seem so.
>
> Best regards,
> Martin
Heiner
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH v3] dt-bindings: pinctrl: Convert Amlogic Meson pinctrl binding
Date: Sun, 5 Feb 2023 01:05:18 +0100 [thread overview]
Message-ID: <6dcf6333-f75a-f7ec-8ce9-fbbfb81d1a60@gmail.com> (raw)
In-Reply-To: <CAFBinCDHtX2W=Sh4ffUbugn+XVH2UcXWKH2Q63W9G074x6o7zw@mail.gmail.com>
On 04.02.2023 23:56, Martin Blumenstingl wrote:
> Hi Heiner,
>
> On Wed, Feb 1, 2023 at 11:13 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
> [...]
>>>> + - items:
>>>> + - const: amlogic,meson8m2-aobus-pinctrl
>>>> + - const: amlogic,meson8-aobus-pinctrl
>>>> + - items:
>>>> + - const: amlogic,meson8m2-cbus-pinctrl
>>>> + - const: amlogic,meson8-cbus-pinctrl
>>>
>>> Again, can't have both with and without the fallback allowed.
>>>
>> Hi Martin,
>>
>> meson8m2 is the only chip version having a fallback for the
>> pinctrl compatible. Is this fallback really needed?
>> Looking at the driver it seems that both compatibles
>> are handled identically.
> Back in the day we decided to duplicate the Meson8 driver code just to
> add four new pin functions that are added by the Meson8m2 SoC
> generation:
> "eth_rxd2", "eth_rxd3", "eth_txd2", "eth_txd3"
>
> The compatible string was defined with a similar approach: since
> Meson8m2 just adds a few bits to the Meson8 pin controller it's
> backwards compatible.
>
> If the fallback has to be removed then I'm okay with that but I would
> like to understand it first.
> So far I thought that Rob basically asked to remove the following two
> compatible strings from the enum (as they're listed separately with
> their fallbacks):
> - amlogic,meson8m2-cbus-pinctrl
> - amlogic,meson8m2-aobus-pinctrl
>
Right, this should be sufficient. There's no place where the 8m2 pinctrl
compatibles are used w/o fallback.
Then the hopefully final version of the binding is almost ready.
I'm just still checking whether there's any way in yaml to specify
a reg-names list with mandatory and optional names. Doesn't seem so.
>
> Best regards,
> Martin
Heiner
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-02-05 0:05 UTC|newest]
Thread overview: 138+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 21:22 [PATCH 0/8] soc: amlogic: switch bindings to yaml and adjust some dtbs's Heiner Kallweit
2023-01-23 21:22 ` Heiner Kallweit
2023-01-23 21:22 ` Heiner Kallweit
2023-01-23 21:23 ` [PATCH 1/8] arm64: dts: meson-gx: Remove invalid pwm compatible Heiner Kallweit
2023-01-23 21:23 ` Heiner Kallweit
2023-01-23 21:23 ` Heiner Kallweit
2023-01-23 21:24 ` [PATCH 2/8] arm64: dts: amlogic: Fix non-compliant SD/SDIO node names Heiner Kallweit
2023-01-23 21:24 ` Heiner Kallweit
2023-01-23 21:24 ` Heiner Kallweit
2023-01-24 7:17 ` Neil Armstrong
2023-01-24 7:17 ` Neil Armstrong
2023-01-24 7:17 ` Neil Armstrong
2023-01-23 21:25 ` [PATCH 3/8] arm64: dts: meson-gx: Set only one compatible string for mmc Heiner Kallweit
2023-01-23 21:25 ` Heiner Kallweit
2023-01-23 21:25 ` Heiner Kallweit
2023-01-23 21:27 ` [PATCH 4/8] arm64: dts: amlogic: Remove invalid compatible string amlogic,meson-gpio-intc Heiner Kallweit
2023-01-23 21:27 ` Heiner Kallweit
2023-01-23 21:27 ` Heiner Kallweit
2023-01-23 21:28 ` [PATCH 5/8] dt-bindings: rtc: Add Amlogic Meson vrtc controller binding Heiner Kallweit
2023-01-23 21:28 ` Heiner Kallweit
2023-01-23 21:28 ` Heiner Kallweit
2023-01-25 19:19 ` Rob Herring
2023-01-25 19:19 ` Rob Herring
2023-01-25 19:19 ` Rob Herring
2023-01-23 21:29 ` [PATCH 6/8] dt-bindings: pwm: Add Amlogic Meson PWM binding Heiner Kallweit
2023-01-23 21:29 ` Heiner Kallweit
2023-01-23 21:29 ` Heiner Kallweit
2023-01-24 1:22 ` Rob Herring
2023-01-24 1:22 ` Rob Herring
2023-01-24 1:22 ` Rob Herring
2023-01-25 19:22 ` Rob Herring
2023-01-25 19:22 ` Rob Herring
2023-01-25 19:22 ` Rob Herring
2023-01-23 21:30 ` [PATCH 7/8] dt-bindings: interrupt-controller: Add Amlogic Meson GPIO interrupt controller binding Heiner Kallweit
2023-01-23 21:30 ` Heiner Kallweit
2023-01-23 21:30 ` Heiner Kallweit
2023-01-24 1:22 ` Rob Herring
2023-01-24 1:22 ` Rob Herring
2023-01-24 1:22 ` Rob Herring
2023-01-24 7:03 ` Heiner Kallweit
2023-01-24 7:03 ` Heiner Kallweit
2023-01-24 7:03 ` Heiner Kallweit
2023-01-25 16:46 ` Rob Herring
2023-01-25 16:46 ` Rob Herring
2023-01-25 16:46 ` Rob Herring
2023-01-23 21:30 ` [PATCH 8/8] dt-bindings: pinctrl: Add Amlogic Meson pinctrl binding Heiner Kallweit
2023-01-23 21:30 ` Heiner Kallweit
2023-01-23 21:30 ` Heiner Kallweit
2023-01-24 1:22 ` Rob Herring
2023-01-24 1:22 ` Rob Herring
2023-01-24 1:22 ` Rob Herring
2023-01-24 7:14 ` Heiner Kallweit
2023-01-24 7:14 ` Heiner Kallweit
2023-01-24 7:14 ` Heiner Kallweit
2023-01-24 7:16 ` [PATCH 0/8] soc: amlogic: switch bindings to yaml and adjust some dtbs's Neil Armstrong
2023-01-24 7:16 ` Neil Armstrong
2023-01-24 7:16 ` Neil Armstrong
2023-01-24 9:20 ` Heiner Kallweit
2023-01-24 9:20 ` Heiner Kallweit
2023-01-24 9:20 ` Heiner Kallweit
2023-01-26 7:40 ` Uwe Kleine-König
2023-01-26 7:40 ` Uwe Kleine-König
2023-01-26 7:40 ` Uwe Kleine-König
2023-01-24 8:22 ` (subset) " Neil Armstrong
2023-01-24 8:22 ` Neil Armstrong
2023-01-24 8:22 ` Neil Armstrong
2023-01-25 22:24 ` [PATCH v2] dt-bindings: rtc: Convert Amlogic Meson vrtc controller binding Heiner Kallweit
2023-01-25 22:24 ` Heiner Kallweit
2023-01-25 22:24 ` Heiner Kallweit
2023-01-30 17:09 ` Rob Herring
2023-01-30 17:09 ` Rob Herring
2023-01-30 17:09 ` Rob Herring
2023-02-09 22:16 ` (subset) " Alexandre Belloni
2023-02-09 22:16 ` Alexandre Belloni
2023-02-09 22:16 ` Alexandre Belloni
2023-01-25 22:28 ` [PATCH v2] dt-bindings: pwm: Convert Amlogic Meson PWM binding Heiner Kallweit
2023-01-25 22:28 ` Heiner Kallweit
2023-01-25 22:28 ` Heiner Kallweit
2023-01-30 17:16 ` Rob Herring
2023-01-30 17:16 ` Rob Herring
2023-01-30 17:16 ` Rob Herring
2023-01-27 21:14 ` [PATCH v2] dt-bindings: interrupt-controller: Convert Amlogic Meson GPIO interrupt controller binding Heiner Kallweit
2023-01-27 21:14 ` Heiner Kallweit
2023-01-27 21:14 ` Heiner Kallweit
2023-01-27 21:16 ` [PATCH v2] dt-bindings: pinctrl: Convert Amlogic Meson pinctrl binding Heiner Kallweit
2023-01-27 21:16 ` Heiner Kallweit
2023-01-27 21:16 ` Heiner Kallweit
2023-01-30 20:34 ` [PATCH v3] dt-bindings: pwm: Convert Amlogic Meson PWM binding Heiner Kallweit
2023-01-30 20:34 ` Heiner Kallweit
2023-01-30 20:34 ` Heiner Kallweit
2023-01-30 21:21 ` Rob Herring
2023-01-30 21:21 ` Rob Herring
2023-01-30 21:21 ` Rob Herring
2023-02-01 7:35 ` Krzysztof Kozlowski
2023-02-01 7:35 ` Krzysztof Kozlowski
2023-02-01 7:35 ` Krzysztof Kozlowski
2023-01-30 20:53 ` [PATCH v3] dt-bindings: interrupt-controller: Convert Amlogic Meson GPIO interrupt controller binding Heiner Kallweit
2023-01-30 20:53 ` Heiner Kallweit
2023-01-30 20:53 ` Heiner Kallweit
2023-02-01 2:03 ` Rob Herring
2023-02-01 2:03 ` Rob Herring
2023-02-01 2:03 ` Rob Herring
2023-02-01 6:47 ` Heiner Kallweit
2023-02-01 6:47 ` Heiner Kallweit
2023-02-01 6:47 ` Heiner Kallweit
2023-02-01 10:21 ` Neil Armstrong
2023-02-01 10:21 ` Neil Armstrong
2023-02-01 10:21 ` Neil Armstrong
2023-01-30 21:00 ` [PATCH v3] dt-bindings: pinctrl: Convert Amlogic Meson pinctrl binding Heiner Kallweit
2023-01-30 21:00 ` Heiner Kallweit
2023-01-30 21:00 ` Heiner Kallweit
2023-02-01 2:06 ` Rob Herring
2023-02-01 2:06 ` Rob Herring
2023-02-01 2:06 ` Rob Herring
2023-02-01 22:13 ` Heiner Kallweit
2023-02-01 22:13 ` Heiner Kallweit
2023-02-01 22:13 ` Heiner Kallweit
2023-02-04 22:56 ` Martin Blumenstingl
2023-02-04 22:56 ` Martin Blumenstingl
2023-02-04 22:56 ` Martin Blumenstingl
2023-02-05 0:05 ` Heiner Kallweit [this message]
2023-02-05 0:05 ` Heiner Kallweit
2023-02-05 0:05 ` Heiner Kallweit
2023-02-05 7:57 ` Neil Armstrong
2023-02-05 7:57 ` Neil Armstrong
2023-02-05 7:57 ` Neil Armstrong
2023-02-05 16:54 ` Heiner Kallweit
2023-02-05 16:54 ` Heiner Kallweit
2023-02-05 16:54 ` Heiner Kallweit
2023-02-06 9:30 ` Neil Armstrong
2023-02-06 9:30 ` Neil Armstrong
2023-02-06 9:30 ` Neil Armstrong
2023-02-01 10:56 ` Neil Armstrong
2023-02-01 10:56 ` Neil Armstrong
2023-02-01 10:56 ` Neil Armstrong
2023-06-22 7:57 ` [PATCH 0/8] soc: amlogic: switch bindings to yaml and adjust some dtbs's Neil Armstrong
2023-06-22 7:57 ` Neil Armstrong
2023-06-22 7:57 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dcf6333-f75a-f7ec-8ce9-fbbfb81d1a60@gmail.com \
--to=hkallweit1@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.