All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Johannes Berg <johannes@sipsolutions.net>,
	Kalle Valo <kvalo@qca.qualcomm.com>
Cc: "akolli\@codeaurora.org" <akolli@codeaurora.org>,
	"ath10k\@lists.infradead.org" <ath10k@lists.infradead.org>,
	"linux-wireless\@vger.kernel.org"
	<linux-wireless@vger.kernel.org>,
	Anilkumar Kolli <akolli@qti.qualcomm.com>,
	"linux-wireless-owner\@vger.kernel.org"
	<linux-wireless-owner@vger.kernel.org>
Subject: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4
Date: Sat, 02 Dec 2017 10:53:48 +0100	[thread overview]
Message-ID: <87374t3177.fsf@toke.dk> (raw)
In-Reply-To: <1512143881.25588.18.camel@sipsolutions.net>

Johannes Berg <johannes@sipsolutions.net> writes:

> On Fri, 2017-12-01 at 16:54 +0100, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>
>> But since we'll have to do that for ath9k anyway it
>> becomes more a question of whether it's something that should be
>> supported in mac80211 or if it should be implemented in each driver.
>> But since that logic will have to be written from scratch anyway, is
>> there any reason to not just do it in mac80211 from the beginning?
>
> I was thinking in the driver so that there's no overhead for the other
> drivers that don't want it that way.
>
> Dunno. It probably doesn't really matter.

I'll prototype something, then we can revisit this based on actual code :)

-Toke

WARNING: multiple messages have this Message-ID (diff)
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Johannes Berg <johannes@sipsolutions.net>,
	Kalle Valo <kvalo@qca.qualcomm.com>
Cc: "linux-wireless-owner@vger.kernel.org"
	<linux-wireless-owner@vger.kernel.org>,
	Anilkumar Kolli <akolli@qti.qualcomm.com>,
	"akolli@codeaurora.org" <akolli@codeaurora.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4
Date: Sat, 02 Dec 2017 10:53:48 +0100	[thread overview]
Message-ID: <87374t3177.fsf@toke.dk> (raw)
In-Reply-To: <1512143881.25588.18.camel@sipsolutions.net>

Johannes Berg <johannes@sipsolutions.net> writes:

> On Fri, 2017-12-01 at 16:54 +0100, Toke Høiland-Jørgensen wrote:
>
>> But since we'll have to do that for ath9k anyway it
>> becomes more a question of whether it's something that should be
>> supported in mac80211 or if it should be implemented in each driver.
>> But since that logic will have to be written from scratch anyway, is
>> there any reason to not just do it in mac80211 from the beginning?
>
> I was thinking in the driver so that there's no overhead for the other
> drivers that don't want it that way.
>
> Dunno. It probably doesn't really matter.

I'll prototype something, then we can revisit this based on actual code :)

-Toke

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2017-12-02  9:53 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30 12:58 [PATCH 0/2] ath10k: tx stats for 10.2.4 akolli
2017-11-30 12:58 ` akolli
2017-11-30 12:58 ` [PATCH 1/2] ath10k: move pktlog_filter out of ath10k_debug akolli
2017-11-30 12:58   ` akolli
2017-11-30 12:58 ` [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4 akolli
2017-11-30 12:58   ` akolli
2017-11-30 16:14   ` Kalle Valo
2017-11-30 16:14     ` Kalle Valo
2017-11-30 16:28     ` Toke Høiland-Jørgensen
2017-11-30 16:28       ` Toke Høiland-Jørgensen
2017-11-30 16:38       ` Kalle Valo
2017-11-30 16:38         ` Kalle Valo
2017-12-01  4:23         ` akolli
2017-12-01  4:23           ` akolli
2017-12-01 13:41           ` Toke Høiland-Jørgensen
2017-12-01 13:41             ` Toke Høiland-Jørgensen
2017-12-01 14:49             ` Kalle Valo
2017-12-01 14:49               ` Kalle Valo
2017-12-01 15:29               ` Toke Høiland-Jørgensen
2017-12-01 15:29                 ` Toke Høiland-Jørgensen
2017-12-01 15:45                 ` Johannes Berg
2017-12-01 15:45                   ` Johannes Berg
2017-12-01 15:54                   ` Toke Høiland-Jørgensen
2017-12-01 15:54                     ` Toke Høiland-Jørgensen
2017-12-01 15:58                     ` Johannes Berg
2017-12-01 15:58                       ` Johannes Berg
2017-12-02  9:53                       ` Toke Høiland-Jørgensen [this message]
2017-12-02  9:53                         ` Toke Høiland-Jørgensen
2017-12-01 10:45   ` Maxime Bizon
2017-12-01 10:45     ` Maxime Bizon
2017-12-01 13:48     ` akolli
2017-12-01 13:48       ` akolli
2017-12-01 15:05       ` Maxime Bizon
2017-12-01 15:05         ` Maxime Bizon
2017-12-01 15:53         ` Christian Lamparter
2017-12-01 15:53           ` Christian Lamparter
2017-12-01 16:09           ` Maxime Bizon
2017-12-01 16:09             ` Maxime Bizon
2017-12-04 13:24         ` akolli
2017-12-04 13:24           ` akolli
2017-12-04 14:23           ` Maxime Bizon
2017-12-04 14:23             ` Maxime Bizon
2017-12-05  5:26             ` akolli
2017-12-05  5:26               ` akolli
2017-12-01 15:44       ` Kalle Valo
2017-12-01 15:44         ` Kalle Valo
2017-12-04 11:20         ` akolli
2017-12-04 11:20           ` akolli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87374t3177.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=akolli@codeaurora.org \
    --cc=akolli@qti.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless-owner@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.